[{"id":5333,"web_url":"https://patchwork.libcamera.org/comment/5333/","msgid":"<20200622223508.GI5852@pendragon.ideasonboard.com>","date":"2020-06-22T22:35:08","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: add a sharpness\n\tstrength control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Jun 22, 2020 at 02:55:47PM +0100, David Plowman wrote:\n> The control is a single float value with minimum, default and maximum\n> values. Please read the description for more details.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids.yaml | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 77ebc3f..8c3e4c7 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -239,4 +239,16 @@ controls:\n> pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels\n> control can only be returned in metadata.\n> size: [4]\n> +\n> + - Sharpness:\n> + type: float\n> + description: |\n> + A value of 0.0 means no sharpening. The minimum value means\n> + minimal sharpening, and shall be 0.0 unless the camera can't\n> + disable sharpening completely. The default value shall give a\n> + \"reasonable\" level of sharpening, suitable for most use cases.\n> + The maximum value may apply extremely high levels of sharpening,\n> + higher than anyone could reasonably want. Negative values are\n> + not allowed. Note also that sharpening is not applied to raw\n> + streams.\n> ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5517603BE\n\tfor ;\n\tTue, 23 Jun 2020 00:35:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B652327;\n\tTue, 23 Jun 2020 00:35:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dEQCKaP8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592865333;\n\tbh=efKM4zQo1gPcqd2TxzEbhUXtt7GHRXbHKN2sSfJ847A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dEQCKaP8ZsDSXTkrfb5M5+LyAMpq7jZtM6omldPkoAzKx6iuMzCDZN1d8wCQD6A7A\n\tr/djxewRJDEWzybHgVr56//iivbkgOKnMIRQawcsBzR0FkMJZBLu58Vk7meuZvrHCv\n\t8XhEopuHP9tb9aS9vQ2g5t01rZZpvUpnrwu7czp4=","Date":"Tue, 23 Jun 2020 01:35:08 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200622223508.GI5852@pendragon.ideasonboard.com>","References":"<20200622135550.10788-1-david.plowman@raspberrypi.com>\n\t<20200622135550.10788-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200622135550.10788-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: add a sharpness\n\tstrength control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 22 Jun 2020 22:35:34 -0000"}}]