{"id":4107,"url":"https://patchwork.libcamera.org/api/patches/4107/?format=json","web_url":"https://patchwork.libcamera.org/patch/4107/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200622132948.1398048-1-niklas.soderlund@ragnatech.se>","date":"2020-06-22T13:29:48","name":"[libcamera-devel,v3] meson: options: Add an option to control compilation of qcam","commit_ref":"fc520719a92f0f5cb3f673f09816686f6aaae682","pull_url":null,"state":"accepted","archived":false,"hash":"a4d413b79f15dea33fb09d7907eed4f77f444bb0","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4107/mbox/","series":[{"id":1023,"url":"https://patchwork.libcamera.org/api/series/1023/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1023","date":"2020-06-22T13:29:48","name":"[libcamera-devel,v3] meson: options: Add an option to control compilation of qcam","version":3,"mbox":"https://patchwork.libcamera.org/series/1023/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4107/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4107/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 429F5603BD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jun 2020 15:29:54 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 62bd2bf9-b48c-11ea-86ee-0050569116f7;\n\tMon, 22 Jun 2020 15:29:26 +0200 (CEST)"],"X-Halon-ID":"62bd2bf9-b48c-11ea-86ee-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 22 Jun 2020 15:29:48 +0200","Message-Id":"<20200622132948.1398048-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3] meson: options: Add an option to\n\tcontrol compilation of qcam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 22 Jun 2020 13:29:54 -0000"},"content":"Add an option to control compilation of the qcam test application. The\ndefault behavior is to compile qcam, no change in behavior without user\nintervention.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n* Changes since v2\n- Default to auto instead of enabled.\n\n* Changes since v1\n- Sort options alphabetical in meson_options.txt\n- Use feature instead of boolean and attach it to the qt5_dep\n---\n meson_options.txt    | 5 +++++\n src/qcam/meson.build | 2 +-\n 2 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/meson_options.txt b/meson_options.txt\nindex badace151bb62bc9..e9e815fde366c89d 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -19,6 +19,11 @@ option('pipelines',\n         choices : ['ipu3', 'raspberrypi', 'rkisp1', 'simple', 'uvcvideo', 'vimc'],\n         description : 'Select which pipeline handlers to include')\n \n+option('qcam',\n+        type : 'feature',\n+        value : 'auto',\n+        description : 'Compile the qcam test application')\n+\n option('test',\n         type : 'boolean',\n         description: 'Compile and include the tests')\ndiff --git a/src/qcam/meson.build b/src/qcam/meson.build\nindex 045db52acf26d71b..6ea886a32236d40f 100644\n--- a/src/qcam/meson.build\n+++ b/src/qcam/meson.build\n@@ -22,7 +22,7 @@ qt5 = import('qt5')\n qt5_dep = dependency('qt5',\n                      method : 'pkg-config',\n                      modules : ['Core', 'Gui', 'Widgets'],\n-                     required : false)\n+                     required : get_option('qcam'))\n \n if qt5_dep.found()\n     qcam_deps = [\n","prefixes":["libcamera-devel","v3"]}