[{"id":46,"web_url":"https://patchwork.libcamera.org/comment/46/","msgid":"<3903489.Y5tdAiPAlI@avalon>","date":"2018-12-12T18:30:59","subject":"Re: [libcamera-devel] [PATCH v2] build: Add 'std=c++11' cpp\n\tcompiler flag","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wednesday, 12 December 2018 16:32:25 EET Jacopo Mondi wrote:\n> Building the current master branch fails with:\n> ./src/libcamera/include/log.h:25:34:\n> error: defaulted and deleted functions only available with -std=c++11 \\\n> or -std=gnu++11 [-Werror]\n> LogMessage(const LogMessage&) = delete;\n> \n> Fix this by adding the 'std=c++11' compiler argument for to the list of\n> cpp build flags.\n\nYou may want to add compiler information to the commit message.\n\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> v2 -> v1:\n> - As suggested by Kieran, add 'std=c++11' argument to the global\n> cpp_arguments variable\n\nDon't forget to remove this before pushing.\n\n> ---\n> meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 2fdb166..7b6e2fe 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -17,6 +17,7 @@ common_arguments = [\n> \n> c_arguments = common_arguments\n> cpp_arguments = common_arguments\n> +cpp_arguments += '-std=c++11'\n> \n> add_project_arguments(c_arguments, language: 'c')\n> add_project_arguments(cpp_arguments, language: 'cpp')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C77E60A71\n\tfor ;\n\tWed, 12 Dec 2018 19:30:14 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD58355A;\n\tWed, 12 Dec 2018 19:30:13 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544639413;\n\tbh=1s95f/I0N+nqtA/2cQUQSW2mYgz0c/jB3ifTvpmJiKY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n3FAGgfrnou/CapqjFmjWVZC9Sa+RioAEHqzq0h/K7AS9G2bpJTFHdTyHxT+UsNiT\n\tC1vkpM+z94WFiL7JJFBmQ8LAd3WvIx+NSP5TsoxZUExQrCAxluE30SS3tNrIn0Ap88\n\tl8ItubF+RnAGIiTzb1BoLBzQWv9ZHA26CdMRCRMY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 12 Dec 2018 20:30:59 +0200","Message-ID":"<3903489.Y5tdAiPAlI@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<1544625145-8021-1-git-send-email-jacopo@jmondi.org>","References":"<1544625145-8021-1-git-send-email-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH v2] build: Add 'std=c++11' cpp\n\tcompiler flag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 12 Dec 2018 18:30:14 -0000"}}]