[{"id":5310,"web_url":"https://patchwork.libcamera.org/comment/5310/","msgid":"<20200622020715.GE25355@pendragon.ideasonboard.com>","date":"2020-06-22T02:07:15","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: add a sharpness\n\tstrength control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Jun 19, 2020 at 10:27:23AM +0100, David Plowman wrote:\n> The control is a single float value with minimum, default and maximum\n> values. Please read the description for more details.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 77ebc3f..1bc1b10 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -239,4 +239,15 @@ controls:\n> pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels\n> control can only be returned in metadata.\n> size: [4]\n> +\n> + - Sharpness:\n> + type: float\n> + description: |\n> + The strength of the sharpening to be applied.\n\nShould we specify that sharpening is not applied to RAW streams ? Or do\nyou expect hardware that would be able to apply sharpening in the Bayer\ndomain ?\n\n> The minimum value\n> + means minimal (or preferably no) sharpening, the maximum should\n> + signify extremely high levels of sharpening (higher than anyone could\n> + reasonably want), and the default value should give a \"reasonable\"\n> + level, suitable for many use cases. We recommand that the amount\n> + of sharpening applied should be \"approximately\" proportional to this\n> + parameter.\n\nI propose detailing this a bit further, to explain that 0 means no\nsharpening. How about the following ?\n\n\tA value of 0.0 means no sharpening. The minimum value means\n\tminimal sharpening, and shall be 0.0 unless the camera can't\n\tdisable sharpening completely. The default value shall give a\n\t\"reasonable\" level or sharpening, suitable for most use cases.\n\tThe maximum value may apply extremely high levels of sharpening,\n\thigher than anyone could reasonably want. Negative values are\n\tnot allowed.\n\n> ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27223609A3\n\tfor ;\n\tMon, 22 Jun 2020 04:07:55 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BDA3BB8;\n\tMon, 22 Jun 2020 04:07:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FYRS97p9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592791674;\n\tbh=OQKnnCvHXZDso+KZpuW+PkXvWYpNkv+4ICngbty+yIY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FYRS97p9SARnm5LN60NSyK7aW5dxR14Nosf9fz9stvfrjAdQ7GJCjkHUscgATdtwB\n\tTlxWigKdA0jKSr1V3BEkNmfxPEvRg4UjdRIX5Ljv4POB9tcrEotw6Ur2wA7FZl/hul\n\tPBJSAyMkHRO1M7Eo5tcZGqaG8VTk7D58RxY/qoaA=","Date":"Mon, 22 Jun 2020 05:07:15 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200622020715.GE25355@pendragon.ideasonboard.com>","References":"<20200619092725.19109-1-david.plowman@raspberrypi.com>\n\t<20200619092725.19109-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200619092725.19109-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: add a sharpness\n\tstrength control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 22 Jun 2020 02:07:55 -0000"}},{"id":5326,"web_url":"https://patchwork.libcamera.org/comment/5326/","msgid":"","date":"2020-06-22T10:00:01","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: add a sharpness\n\tstrength control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for the feedback.\n\nOn Mon, 22 Jun 2020 at 03:07, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Fri, Jun 19, 2020 at 10:27:23AM +0100, David Plowman wrote:\n> > The control is a single float value with minimum, default and maximum\n> > values. Please read the description for more details.\n> >\n> > Signed-off-by: David Plowman \n> > ---\n> > src/libcamera/control_ids.yaml | 11 +++++++++++\n> > 1 file changed, 11 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 77ebc3f..1bc1b10 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -239,4 +239,15 @@ controls:\n> > pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels\n> > control can only be returned in metadata.\n> > size: [4]\n> > +\n> > + - Sharpness:\n> > + type: float\n> > + description: |\n> > + The strength of the sharpening to be applied.\n>\n> Should we specify that sharpening is not applied to RAW streams ? Or do\n> you expect hardware that would be able to apply sharpening in the Bayer\n> domain ?\n\nAgreed. Sharpening a raw stream would seem strange. You'd probably\nhave to have done all kinds of other stuff before sharpening would make\nmuch sense, at which point it's hardly raw any more.\n\n>\n> > The minimum value\n> > + means minimal (or preferably no) sharpening, the maximum should\n> > + signify extremely high levels of sharpening (higher than anyone could\n> > + reasonably want), and the default value should give a \"reasonable\"\n> > + level, suitable for many use cases. We recommand that the amount\n> > + of sharpening applied should be \"approximately\" proportional to this\n> > + parameter.\n>\n> I propose detailing this a bit further, to explain that 0 means no\n> sharpening. How about the following ?\n>\n> A value of 0.0 means no sharpening. The minimum value means\n> minimal sharpening, and shall be 0.0 unless the camera can't\n> disable sharpening completely. The default value shall give a\n> \"reasonable\" level or sharpening, suitable for most use cases.\n> The maximum value may apply extremely high levels of sharpening,\n> higher than anyone could reasonably want. Negative values are\n> not allowed.\n\nYes, I like that. I'll put this all in v2 of the patch.\n\nBest regards\nDavid\n\n>\n> > ...\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-oi1-x243.google.com (mail-oi1-x243.google.com\n\t[IPv6:2607:f8b0:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AADCE603BF\n\tfor ;\n\tMon, 22 Jun 2020 12:00:14 +0200 (CEST)","by mail-oi1-x243.google.com with SMTP id d67so15058560oig.6\n\tfor ;\n\tMon, 22 Jun 2020 03:00:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"HyILnbzy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=W2A+smu9/Of8CJMDavfxf9I4ewIKVxKj670Lspy76y0=;\n\tb=HyILnbzy4YSfwolHiJBM3FranfR9IzsHPRbQ24V+Qif+PepE/wKT+C27Npr7aKKB7I\n\trRfYR5k3V8Sqy75UmWbnwRTAAsqfL30aY30kKlLNuM1lOHdmiBOwGfYgK1C9BtVyK/If\n\tuxfn9bzsuU6LWBDfsSJZa8dcvE1tolePJjHzUroKc6xAwkRjXLSsRyXv1VfLOXYcYL01\n\tlXWSuYh60PLzCGFSwEN6unq1MPu31kFfIJBn8W0NC7LzijsCyDRywOfXGNCdtUehkdye\n\tXgsUGuCHi8TDRbfSMx8Bw+eyH0MObrYK1U6G/zcp5zYw7z/ahIIrFc/s9hnRQoF5PRam\n\tPa2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=W2A+smu9/Of8CJMDavfxf9I4ewIKVxKj670Lspy76y0=;\n\tb=FmHrBDvJgNDjkOL+loew3Wb4hyHbxYxdzwydReEfAa7iuSUg9OcLMpoJyUM8hAdE96\n\taP7/Ge3mYdBYUVDy1E0fhZSbCgdeWhrZqdL6SYfxLZ3DDo4obgcdtkHRsv0eVEOVmzu3\n\tYp2YAjieAsomWy2bmOgKhO3pm5v0kCg/xLAnX5ChANEFnNEV/7dccUbZWMjfO6FwkzfO\n\tvhu5bWlG2OTvjPwznY7mWYLozrxc9uom3H6dWUsNVfPp71LtSl6vuKD/3ueOcg10SExu\n\tq1yZDHy+rtWvrBSQUeYfPsxaWTvrGzj5za6YG7uwNsHlxMPRw5SnIkYs3/CwxcloJDY/\n\tFTsg==","X-Gm-Message-State":"AOAM5325z4yZpQ1qKSM/0B6SZf3G349ukGcbccGBT9bdZtf4Uc5n6QrZ\n\tDfJGeID7b4R6OR/zV4yoNX1eBEcEeBModAuy+2Ct0Seo","X-Google-Smtp-Source":"ABdhPJy4Z4ZZZsZa0UcBNDoQpA70Aqeer+IjyuY7CiQYah0ttOCdliTMm0yDpsFEErugGPyQY5kwAcWSjXGkqRYL5b4=","X-Received":"by 2002:a54:4504:: with SMTP id l4mr11308215oil.22.1592820013588;\n\tMon, 22 Jun 2020 03:00:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20200619092725.19109-1-david.plowman@raspberrypi.com>\n\t<20200619092725.19109-2-david.plowman@raspberrypi.com>\n\t<20200622020715.GE25355@pendragon.ideasonboard.com>","In-Reply-To":"<20200622020715.GE25355@pendragon.ideasonboard.com>","From":"David Plowman ","Date":"Mon, 22 Jun 2020 11:00:01 +0100","Message-ID":"","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: add a sharpness\n\tstrength control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 22 Jun 2020 10:00:14 -0000"}}]