{"id":4095,"url":"https://patchwork.libcamera.org/api/patches/4095/?format=json","web_url":"https://patchwork.libcamera.org/patch/4095/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200619054123.19052-16-paul.elder@ideasonboard.com>","date":"2020-06-19T05:41:21","name":"[libcamera-devel,v2,15/17] v4l2: v4l2_camera_proxy: Don't allow streamon if no buffers have been requested","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d6023ba7762547984a7292a9b0c20d48fd8479d9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4095/mbox/","series":[{"id":1017,"url":"https://patchwork.libcamera.org/api/series/1017/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1017","date":"2020-06-19T05:41:06","name":"Support v4l2-compliance","version":2,"mbox":"https://patchwork.libcamera.org/series/1017/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4095/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4095/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27EBF603BF\n\tfor ;\n\tFri, 19 Jun 2020 07:42:08 +0200 (CEST)","from jade.flets-east.jp (unknown\n\t[IPv6:2400:4051:61:600:e972:d773:e99a:4f79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8466560;\n\tFri, 19 Jun 2020 07:42:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EMwF9Ee9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592545327;\n\tbh=4rytgg7NfyKgZ0viLomnAy+wSknPB7xeLvYF6T6EvPI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EMwF9Ee9y569ZVZB4z044YGULKAsikyedcnUTCCHK5LLwf9F3wfFve5uW+dikmg0P\n\tvf1p/0lRsVtXwUPd7F1hqPytGdS9D0spgKkxFPY83PgapdkHwQOMjEv+Yyh/f9CVdH\n\tV4mXgfPZMCs3Ni0yCZnbvxk4SeTB6Dcxu+Ym7Hxw=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Jun 2020 14:41:21 +0900","Message-Id":"<20200619054123.19052-16-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200619054123.19052-1-paul.elder@ideasonboard.com>","References":"<20200619054123.19052-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 15/17] v4l2: v4l2_camera_proxy: Don't\n\tallow streamon if no buffers have been requested","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Jun 2020 05:42:08 -0000"},"content":"Make VIDIOC_STREAMON return -EINVAL if no buffers have been allocated\nwith reqbufs.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v2\n- split from \"Fix v4l2-compliance streaming tests\"\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 8396f58..a7f987a 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -637,6 +637,9 @@ int V4L2CameraProxy::vidioc_streamon(V4L2CameraFile *cf, int *arg)\n {\n \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_streamon fd = \" << cf->efd();\n \n+\tif (bufferCount_ == 0)\n+\t\treturn -EINVAL;\n+\n \tif (vcam_->isRunning())\n \t\treturn 0;\n \n","prefixes":["libcamera-devel","v2","15/17"]}