[{"id":5299,"web_url":"https://patchwork.libcamera.org/comment/5299/","msgid":"<20200620015449.GW5823@pendragon.ideasonboard.com>","date":"2020-06-20T01:54:49","subject":"Re: [libcamera-devel] [PATCH v2 10/17] v4l2: v4l2_camera_proxy:\n\tnoop if streamon when stream is already on","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 19, 2020 at 02:41:16PM +0900, Paul Elder wrote:\n> If VIDIOC_STREMAON is called when the stream is already on, do a noop.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v2: (split from \"v4l2: v4l2_camera: Add isRunning()\")\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 63c6a2c..4d37662 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -616,6 +616,9 @@ int V4L2CameraProxy::vidioc_streamon(V4L2CameraFile *cf, int *arg)\n> {\n> \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_streamon fd = \" << cf->efd();\n> \n> +\tif (vcam_->isRunning())\n> +\t\treturn 0;\n> +\n\nThis should also go after the lock.\n\nReviewed-by: Laurent Pinchart \n\n> \tint ret = lock(cf);\n> \tif (ret < 0)\n> \t\treturn ret;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 985BF60710\n\tfor ;\n\tSat, 20 Jun 2020 03:55:13 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 199F0552;\n\tSat, 20 Jun 2020 03:55:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LzedfWjp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592618113;\n\tbh=Hvsr3cwB9ZKB5qvnKlX7Ct/6hth1VKi6TeFFC9pUhdE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LzedfWjpHbQdH7GYBKd5Bym/XWOSVqHWUoiau+76V8d03cPZERfW7N7oyF2YNff1N\n\t/55QllfQ396ARBPG1SfyisqWknnRPdEVleMR4rLW4XdTHT/YPwaDGuG8NC2HmlNeDl\n\tgE5R+ae0ZnD67zpQjIJEGa+btgxnM12UAh9b/oNc=","Date":"Sat, 20 Jun 2020 04:54:49 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200620015449.GW5823@pendragon.ideasonboard.com>","References":"<20200619054123.19052-1-paul.elder@ideasonboard.com>\n\t<20200619054123.19052-11-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200619054123.19052-11-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 10/17] v4l2: v4l2_camera_proxy:\n\tnoop if streamon when stream is already on","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 20 Jun 2020 01:55:13 -0000"}}]