[{"id":633,"web_url":"https://patchwork.libcamera.org/comment/633/","msgid":"<20190127004214.GY4127@bigcity.dyn.berto.se>","date":"2019-01-27T00:42:14","subject":"Re: [libcamera-devel] [PATCH] libcamera: signal: Don't use\n\treinterpret_cast<>() to perform downcasts","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-26 18:32:57 +0200, Laurent Pinchart wrote:\n> Use static_cast<>() instead of reinterpret_cast<>() to perform\n> downcasts, as reinterpret_cast<>() isn't meant (and guaranteed to be\n> safe) for that purpose.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/signal.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index 0b437a486c08..c375b0a878af 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -37,7 +37,7 @@ public:\n> \tSlotMember(T *obj, void(T::*func)(Args...))\n> \t\t: SlotBase(obj), func_(func) { }\n> \n> -\tvoid invoke(Args... args) { (reinterpret_cast(this->obj_)->*func_)(args...); }\n> +\tvoid invoke(Args... args) { (static_cast(this->obj_)->*func_)(args...); }\n> \n> private:\n> \tfriend class Signal;\n> @@ -111,7 +111,7 @@ public:\n> \t\t\t * match, so we can safely cast to SlotMember.\n> \t\t\t */\n> \t\t\tif (slot->obj_ == object &&\n> -\t\t\t reinterpret_cast *>(slot)->func_ == func) {\n> +\t\t\t static_cast *>(slot)->func_ == func) {\n> \t\t\t\titer = slots_.erase(iter);\n> \t\t\t\tdelete slot;\n> \t\t\t} else {\n> @@ -125,7 +125,7 @@ public:\n> \t\tfor (auto iter = slots_.begin(); iter != slots_.end(); ) {\n> \t\t\tSlotBase *slot = *iter;\n> \t\t\tif (slot->obj_ == nullptr &&\n> -\t\t\t reinterpret_cast *>(slot)->func_ == func) {\n> +\t\t\t static_cast *>(slot)->func_ == func) {\n> \t\t\t\titer = slots_.erase(iter);\n> \t\t\t\tdelete slot;\n> \t\t\t} else {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70B2660B1B\n\tfor ;\n\tSun, 27 Jan 2019 01:42:16 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id g11-v6so11333019ljk.3\n\tfor ;\n\tSat, 26 Jan 2019 16:42:16 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tu11sm2266892lfb.85.2019.01.26.16.42.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 26 Jan 2019 16:42:15 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xo2EkF69WNuZNPo8cqfcjPZmqH5CmO+2vfwG2yrHRSY=;\n\tb=CJuPzGowh/CdruMoKUhYL/LWOD6YWnaiUbCmUh0yb1NBZOqeEORfweeOia2xSRhpzx\n\t4eAKazeRXnl1THun24932fNv+x2ZntJSnppCcdXV+WKhSG47MYkK+KZKHGECr0WTJKJx\n\tphoNvgu7yyOSls9Qt/OJApvZ1K4RWIF+LIxJ91XUy2sb4xSDqOinDMiQVNqQhZ/W33iJ\n\txYTnGTsG3hbaNypB3EltBEg+SDueNt1VtGBQN0mOwOJVAQRwlsDNtAqcCR9Aih7ooFkm\n\tpcux5+Ep+rnTLnXTZl0NUHt1Z5A7W8lCSq8VgfPKH5S0qWHHmxOrr+Qc0rI6t0+re+2h\n\tPbow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xo2EkF69WNuZNPo8cqfcjPZmqH5CmO+2vfwG2yrHRSY=;\n\tb=UOuU4o2chtoEdHO081oxEx133qBJodk7q3No8jJwW/SNYZOI0ZQahcwyQ4kkSqp58s\n\thIXw29rpvdqSdsRwGGSoasHIrP4xqndekMh07Icpsk4vNmyj5KtOuYHQuRmcfy9vJ+iW\n\tsVa/U7Klgwd1PS1gqKrKOI+WAm/6QVKJqLfXTo6tSwl2lsSriqJLgO4LqO0/KXnYmu8u\n\tHD+siCysXyq/LRgCiq4lNaVvrBI9HOSZPtzSuymYYq2qPnusPtb42T4MwE0xJFWcoBPH\n\t14A56kp7Qt0YlYChyrtN3Ft+juUPqn3JkznXAKE4jmJ0/k7mla9jEI6/t25MVNdjyxvB\n\t6JgQ==","X-Gm-Message-State":"AJcUukcc8X4OkLjoSA5s+QWO78HL67uoB4PSEs6BGMIA5+kH6uIwUdFK\n\t3djybx6xPZAKsF0g/31engPqrQ==","X-Google-Smtp-Source":"ALg8bN6VVlNK5X/zG2R4OKs6FTO9Q0jdStMv5MZ0YOywFG7lBbRfO1tjF5L8qGKg/jE6OCroWsNPaA==","X-Received":"by 2002:a2e:20f:: with SMTP id\n\t15-v6mr13316076ljc.172.1548549735689; \n\tSat, 26 Jan 2019 16:42:15 -0800 (PST)","Date":"Sun, 27 Jan 2019 01:42:14 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190127004214.GY4127@bigcity.dyn.berto.se>","References":"<20190126163257.10417-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190126163257.10417-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: signal: Don't use\n\treinterpret_cast<>() to perform downcasts","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Jan 2019 00:42:16 -0000"}}]