[{"id":5298,"web_url":"https://patchwork.libcamera.org/comment/5298/","msgid":"<20200620015028.GV5823@pendragon.ideasonboard.com>","date":"2020-06-20T01:50:28","subject":"Re: [libcamera-devel] [PATCH v2 09/17] v4l2: v4l2_camera_proxy:\n\tDisallow dqbuf when not streaming","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 19, 2020 at 02:41:15PM +0900, Paul Elder wrote:\n> Make VIDIOC_DQBUF return -EINVAL if the stream is not turned on.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v2 (split from \"v4l2: v4l2_camera: Add isRunning()\")\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index c3032f5..63c6a2c 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -578,6 +578,9 @@ int V4L2CameraProxy::vidioc_dqbuf(V4L2CameraFile *cf, struct v4l2_buffer *arg)\n> {\n> \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_dqbuf fd = \" << cf->efd();\n> \n> +\tif (!vcam_->isRunning())\n> +\t\treturn -EINVAL;\n> +\n\nTo mimic the behaviour of V4L2, I would move this after the lock().\n\nReviewed-by: Laurent Pinchart \n\n> \tint ret = lock(cf);\n> \tif (ret < 0)\n> \t\treturn ret;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE9C160710\n\tfor ;\n\tSat, 20 Jun 2020 03:50:52 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 277BC592;\n\tSat, 20 Jun 2020 03:50:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"C8ynl/Vf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592617852;\n\tbh=MLRwbh0q4hR3Va3mhL0CLQRTHzLL3x5qg6cQ4VK9vYA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C8ynl/VfyBzYo+QUpe+LXMZOSqxglZDTfUDjgXZA0UxWquCGzA6ICXsrQZ5NUZB3t\n\tsSt+FnM+VdNXwZ5VV8mo5F0HT4DXonGN+0VeovB9yVM6SRcqLaytfkdO1F5ICYzs2q\n\tghrEVZgo2r5CUuMpsh2JmSl0TKdrQb3WiLaxI48A=","Date":"Sat, 20 Jun 2020 04:50:28 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200620015028.GV5823@pendragon.ideasonboard.com>","References":"<20200619054123.19052-1-paul.elder@ideasonboard.com>\n\t<20200619054123.19052-10-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200619054123.19052-10-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 09/17] v4l2: v4l2_camera_proxy:\n\tDisallow dqbuf when not streaming","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 20 Jun 2020 01:50:52 -0000"}}]