{"id":4089,"url":"https://patchwork.libcamera.org/api/patches/4089/?format=json","web_url":"https://patchwork.libcamera.org/patch/4089/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200619054123.19052-10-paul.elder@ideasonboard.com>","date":"2020-06-19T05:41:15","name":"[libcamera-devel,v2,09/17] v4l2: v4l2_camera_proxy: Disallow dqbuf when not streaming","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e3b1280b19f4f5110e266db5de9724c99663067e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4089/mbox/","series":[{"id":1017,"url":"https://patchwork.libcamera.org/api/series/1017/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1017","date":"2020-06-19T05:41:06","name":"Support v4l2-compliance","version":2,"mbox":"https://patchwork.libcamera.org/series/1017/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4089/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4089/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F393603BF\n\tfor ;\n\tFri, 19 Jun 2020 07:41:55 +0200 (CEST)","from jade.flets-east.jp (unknown\n\t[IPv6:2400:4051:61:600:e972:d773:e99a:4f79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C09C7556;\n\tFri, 19 Jun 2020 07:41:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wFTJp/Zp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592545315;\n\tbh=yWM+IpS+mbq48Xu1ydHWgzLhFuqMRaz6VRkM/ncO3ts=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wFTJp/Zp0tDIeeK+yWZI2hgk0IeajalDY5shaUJvmJA+UOcp6wTnuW+jJ8n57Pl0y\n\tKbW0MmaEXtcE5QFZbYflzvNSfrAZ3g3qL5baDe7wCaX6IcErbAcPbFTvfhudaHKwne\n\t12lG4sMsRwjwfTPoLK+0uuZfMM5zYLDF8f0I6ziY=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Jun 2020 14:41:15 +0900","Message-Id":"<20200619054123.19052-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200619054123.19052-1-paul.elder@ideasonboard.com>","References":"<20200619054123.19052-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 09/17] v4l2: v4l2_camera_proxy:\n\tDisallow dqbuf when not streaming","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Jun 2020 05:41:55 -0000"},"content":"Make VIDIOC_DQBUF return -EINVAL if the stream is not turned on.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v2 (split from \"v4l2: v4l2_camera: Add isRunning()\")\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex c3032f5..63c6a2c 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -578,6 +578,9 @@ int V4L2CameraProxy::vidioc_dqbuf(V4L2CameraFile *cf, struct v4l2_buffer *arg)\n {\n \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_dqbuf fd = \" << cf->efd();\n \n+\tif (!vcam_->isRunning())\n+\t\treturn -EINVAL;\n+\n \tint ret = lock(cf);\n \tif (ret < 0)\n \t\treturn ret;\n","prefixes":["libcamera-devel","v2","09/17"]}