[{"id":5297,"web_url":"https://patchwork.libcamera.org/comment/5297/","msgid":"<20200620014642.GU5823@pendragon.ideasonboard.com>","date":"2020-06-20T01:46:42","subject":"Re: [libcamera-devel] [PATCH v2 08/17] v4l2: v4l2_camera: Add\n\tisRunning()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 19, 2020 at 02:41:14PM +0900, Paul Elder wrote:\n> Add a method isRunning() to V4L2Camera so that V4L2CameraProxy can use\n> it for checks.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v2:\n> - replace V4L2CameraProxy::streaming_ with\n> V4L2CameraProxy::isRunning()\n> - moved the checks to different patches\n> ---\n> src/v4l2/v4l2_camera.cpp | 5 +++++\n> src/v4l2/v4l2_camera.h | 2 ++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 2557320..177b1ea 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -227,3 +227,8 @@ int V4L2Camera::qbuf(unsigned int index)\n> \n> \treturn 0;\n> }\n> +\n> +bool V4L2Camera::isRunning()\n> +{\n> +\treturn isRunning_;\n> +}\n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index 30114ed..c157a80 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -59,6 +59,8 @@ public:\n> \n> \tSemaphore bufferSema_;\n> \n> +\tbool isRunning();\n> +\n\nWe tend to put member functions before member objects.\n\n> private:\n> \tvoid requestComplete(Request *request);\n> \n\nI'd squash this with 09/17, but if you want to keep it separate,\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66E9D60710\n\tfor ;\n\tSat, 20 Jun 2020 03:47:06 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3B00552;\n\tSat, 20 Jun 2020 03:47:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FDuGr0Dw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592617626;\n\tbh=Ivf34NwZN92UtM0lPHwjJr2cZeHSnDzZKX5k4c2mS9Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FDuGr0Dwt3kEe4VuaLCMsGZfCGViHbSQ5B+dzYvos3g73mjefuQ0g9Uvtf3ll9iT0\n\tiXM2gvje1CXiR38r/1CDywchIAeIJ3z+gLiX3brWbHHE8BUBsf/7TSKPkCCPqR5FWK\n\tfc4XIWJXWGqD3mKXQVdf4VoFromw1d3LrPu00H4k=","Date":"Sat, 20 Jun 2020 04:46:42 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200620014642.GU5823@pendragon.ideasonboard.com>","References":"<20200619054123.19052-1-paul.elder@ideasonboard.com>\n\t<20200619054123.19052-9-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200619054123.19052-9-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 08/17] v4l2: v4l2_camera: Add\n\tisRunning()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 20 Jun 2020 01:47:06 -0000"}}]