[{"id":5281,"web_url":"https://patchwork.libcamera.org/comment/5281/","msgid":"<20200619101952.GB5823@pendragon.ideasonboard.com>","date":"2020-06-19T10:19:52","subject":"Re: [libcamera-devel] [PATCH v2] meson: options: Add an option to\n\tcontrol compilation of qcam","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Jun 19, 2020 at 02:44:43AM +0200, Niklas Söderlund wrote:\n> Add an option to control compilation of the qcam test application. The\n> default behavior is to compile qcam, no change in behavior without user\n> intervention.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> * Changes since v1\n> - Sort options alphabetical in meson_options.txt\n> - Use feature instead of boolean and attach it to the qt5_dep\n> ---\n> meson_options.txt | 5 +++++\n> src/qcam/meson.build | 2 +-\n> 2 files changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index badace151bb62bc9..44c40c1d96f8ec69 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -19,6 +19,11 @@ option('pipelines',\n> choices : ['ipu3', 'raspberrypi', 'rkisp1', 'simple', 'uvcvideo', 'vimc'],\n> description : 'Select which pipeline handlers to include')\n> \n> +option('qcam',\n> + type : 'feature',\n> + value : 'enabled',\n\nShouldn't this be 'auto' ? According to the meson documentation,\n\n- enabled is the same as passing required : true.\n- auto is the same as passing required : false.\n- disabled do not look for the dependency and always return 'not-found'.\n\nApart from that,\n\nReviewed-by: Laurent Pinchart \n\n> + description : 'Compile the qcam test application')\n> +\n> option('test',\n> type : 'boolean',\n> description: 'Compile and include the tests')\n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 045db52acf26d71b..6ea886a32236d40f 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -22,7 +22,7 @@ qt5 = import('qt5')\n> qt5_dep = dependency('qt5',\n> method : 'pkg-config',\n> modules : ['Core', 'Gui', 'Widgets'],\n> - required : false)\n> + required : get_option('qcam'))\n> \n> if qt5_dep.found()\n> qcam_deps = [","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA6DD60103\n\tfor ;\n\tFri, 19 Jun 2020 12:20:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43ADB556;\n\tFri, 19 Jun 2020 12:20:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dp0Jq3yc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592562015;\n\tbh=+G7HAs/w/DZzNz5zCE/r3f+1u0bPlAC2cQjSeY/VC4w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Dp0Jq3ycNGdDkiNemHjd+9BcDF75pq+q0XUCE4h+1fC51VFF4sr6qC73m5R6OnH52\n\th5B/wyegJaA0+bl2Hz4UBiQ0fQCw4Cy6M9V0sRlyexKKTUViKUdy2ELsOiwxZIpt1W\n\tP4QfbLQHIMGQYhDVqLcCRMFEx1Uo7UTx58YTquu8=","Date":"Fri, 19 Jun 2020 13:19:52 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200619101952.GB5823@pendragon.ideasonboard.com>","References":"<20200619004443.3253953-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200619004443.3253953-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2] meson: options: Add an option to\n\tcontrol compilation of qcam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Jun 2020 10:20:16 -0000"}}]