{"id":4066,"url":"https://patchwork.libcamera.org/api/patches/4066/?format=json","web_url":"https://patchwork.libcamera.org/patch/4066/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200616194523.23268-3-email@uajain.com>","date":"2020-06-16T19:45:34","name":"[libcamera-devel,v5,2/6] libcamera: camera_manager: Refactor pipelines creation into separate function","commit_ref":"c6f8ec7d8afdf6352fdbf6363052d7fa8370d1da","pull_url":null,"state":"accepted","archived":false,"hash":"19bac88678bf66ea1906681e547ee7526748aafe","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4066/mbox/","series":[{"id":1009,"url":"https://patchwork.libcamera.org/api/series/1009/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1009","date":"2020-06-16T19:45:33","name":"Introduce UVC hotplugging support","version":5,"mbox":"https://patchwork.libcamera.org/series/1009/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4066/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4066/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F9DE603C4\n\tfor ;\n\tTue, 16 Jun 2020 21:45:36 +0200 (CEST)","by filter0088p3las1.sendgrid.net with SMTP id\n\tfilter0088p3las1-13542-5EE9215E-EB\n\t2020-06-16 19:45:34.897993716 +0000 UTC m=+696962.422127552","from mail.uajain.com (unknown)\n\tby ismtpd0007p1maa1.sendgrid.net (SG) with ESMTP\n\tid UUHnVglXTjO3BhjCr1MdVg Tue, 16 Jun 2020 19:45:34.523 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"GerWgxdu\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=FikAzZVC5wWvR5l9nNnuXN41hQ1xpsTkcWITVMaV9w8=;\n\tb=GerWgxduibsIj9F3tbfZDEIXqcl+BuRVysv8F1VBaHCtXCgxwwqpRIsO3MLhjCfdXH9n\n\tW7b0arLfGisO5g2/L3ez/hWRc4Cqhm2ZaExUiE0zL/pm0rvvoEUaUY9ghT33hSCCi/OsqR\n\tQpp5PtvBLC6DLbi7ThbApgD70NDtC6V7k=","From":"Umang Jain ","Date":"Tue, 16 Jun 2020 19:45:34 +0000 (UTC)","Message-Id":"<20200616194523.23268-3-email@uajain.com>","In-Reply-To":"<20200616194523.23268-1-email@uajain.com>","References":"<20200616194523.23268-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPclq38gSC/txiORZpK15NbTiNN4t34vkHbngDjoVHubyaJU1FuzYgc2u/UQviNeN62Dkfco7jq6QVug6u9j3fxs8okeTO/ce1eJ7rurDyE5Ai3aobw0oNnF61atrYFR6MAd4MRqqec6qNNBOZtbe4JSDW/ftj6oPfP7EmQZhX2x8q+sAmAyMiK+00DNu/VWf29","To":"laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com,\n\tlibcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v5 2/6] libcamera: camera_manager:\n\tRefactor pipelines creation into separate function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 19:45:37 -0000"},"content":"This commit introduces no functional changes.\nSplit pipelines creation code into a separate function,\nso that the function can be re-used for upcoming hotplug\nfunctionality in subsequent commits.\n\nAlso, fixup correct tag for \\todo.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/camera_manager.cpp | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex dbdc78e..de6d5d8 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -55,6 +55,7 @@ protected:\n \n private:\n \tint init();\n+\tvoid createPipelineHandlers();\n \tvoid cleanup();\n \n \tCameraManager *cm_;\n@@ -123,12 +124,20 @@ int CameraManager::Private::init()\n \tif (!enumerator_ || enumerator_->enumerate())\n \t\treturn -ENODEV;\n \n+\tcreatePipelineHandlers();\n+\n+\treturn 0;\n+}\n+\n+void CameraManager::Private::createPipelineHandlers()\n+{\n \t/*\n-\t * TODO: Try to read handlers and order from configuration\n+\t * \\todo Try to read handlers and order from configuration\n \t * file and only fallback on all handlers if there is no\n \t * configuration file.\n \t */\n-\tstd::vector &factories = PipelineHandlerFactory::factories();\n+\tstd::vector &factories =\n+\t\tPipelineHandlerFactory::factories();\n \n \tfor (PipelineHandlerFactory *factory : factories) {\n \t\t/*\n@@ -146,14 +155,12 @@ int CameraManager::Private::init()\n \t\t}\n \t}\n \n-\t/* TODO: register hot-plug callback here */\n-\n-\treturn 0;\n+\t/* \\todo Register hot-plug callback here */\n }\n \n void CameraManager::Private::cleanup()\n {\n-\t/* TODO: unregister hot-plug callback here */\n+\t/* \\todo Unregister hot-plug callback here */\n \n \t/*\n \t * Release all references to cameras to ensure they all get destroyed\n","prefixes":["libcamera-devel","v5","2/6"]}