[{"id":5219,"web_url":"https://patchwork.libcamera.org/comment/5219/","msgid":"<8d81d86aab11a617253635603b78cf23bb06f0f0.camel@ndufresne.ca>","date":"2020-06-16T18:03:15","subject":"Re: [libcamera-devel] [PATCH] meson: options: Add a option to\n\tcontrol compilation of qcam","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mardi 16 juin 2020 à 17:27 +0200, Niklas Söderlund a écrit :\n> Add a option to control compilation of the qcam test application. The\n> default behavior is to compile qcam, no change in behavior without user\n> intervention.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> meson_options.txt | 5 +++++\n> src/meson.build | 5 ++++-\n> 2 files changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index badace151bb62bc9..9a4edf2a5fde8bcb 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -27,3 +27,8 @@ option('v4l2',\n> type : 'boolean',\n> value : false,\n> description : 'Compile the V4L2 compatibility layer')\n> +\n> +option('qcam',\n> + type : 'boolean',\n> + value : true,\n> + description : 'Compile the qcam test application')\n> diff --git a/src/meson.build b/src/meson.build\n> index d69b4c1ea9788f83..3a816fb610a68905 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -19,7 +19,10 @@ endif\n> subdir('libcamera')\n> subdir('ipa')\n> subdir('cam')\n> -subdir('qcam')\n> +\n> +if get_option('qcam')\n> + subdir('qcam')\n> +endif\n\nIt's much cleaner if you check that option inside the subdir\nmeson.build and call subdir_done() instead.\n\n(ignore if your required meson version is too ancient)\n\n> \n> if get_option('v4l2')\n> subdir('v4l2')\n\nAnd then this could be cleaned up.","headers":{"Return-Path":"","Received":["from mail-qt1-x841.google.com (mail-qt1-x841.google.com\n\t[IPv6:2607:f8b0:4864:20::841])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62DE3603C4\n\tfor ;\n\tTue, 16 Jun 2020 20:03:18 +0200 (CEST)","by mail-qt1-x841.google.com with SMTP id w9so16238022qtv.3\n\tfor ;\n\tTue, 16 Jun 2020 11:03:18 -0700 (PDT)","from skullcanyon ([192.222.193.21])\n\tby smtp.gmail.com with ESMTPSA id\n\ts4sm14653174qkh.120.2020.06.16.11.03.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 16 Jun 2020 11:03:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ndufresne-ca.20150623.gappssmtp.com\n\theader.i=@ndufresne-ca.20150623.gappssmtp.com header.b=\"o8Z35Y6g\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=IDSDyvHw5r0ck+hyOT2wRMrYddonX0rHqsyyeQ7+uLM=;\n\tb=o8Z35Y6gcbj/6digDj5KiSM43RcWBrzd6acFbwQTHUOSpC7LSXIy45R+074b5BlY9y\n\tyTBbnIie+QzeZZBILodR1VTA8kSTFVfF0wrMIZW1wWd9BA4H+z6WP1LGhNQ9w6mMKp15\n\tcsI4gjl0ioZoCOAPXyIkXpJSe+aCva1oKXw2nK9CrWjqo/2nEGQybZik909g6bV6ZYak\n\t66C0aG9A98s9VfFZ5DubTOOdWkA8KTmWRmys0bv+hifSMokVJvkTv/ZgLsG6etv+EJ1c\n\tIQGOi4dmQ43yNrV0E/0XkvhzxfVhJHLwxujLchdZe0t6mVTKBGq7xN/ykQOvWBeBvvJb\n\tzD9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=IDSDyvHw5r0ck+hyOT2wRMrYddonX0rHqsyyeQ7+uLM=;\n\tb=IGfAJxpjiS1fupKKl3ZTAKce/B7T7qVEIt/y6++Q1LPE1vBquYZxc7HHJGsF0k5rBP\n\tV2B2uJfn4IGok5oeeeq/RegHPwtYQtBXEpEilvvdGCd0kY4tWlP/tayMmTTROEDvoxT8\n\tbpmOgtqcN5tbvYyFtWiNpoWFJ/toDc1/SQYun0/3MIaTMu5FiZdkx4CDYjcduG+bDnhj\n\tAkW1syffX2YsLyDoCdfEMKrFCQh2mdhZuLAPnYf4QUvTovVyNuyek0+yAMJPwHqrEi4/\n\tFmwZqMYQfs3xxBF16dYNckQrr23FhLJtlF+ldyIbqeY9DnlNYcR6KAaMTHIrNIIzH2ti\n\tzA6g==","X-Gm-Message-State":"AOAM532Ky1FBp/79r1xawJyCCdzpq9lPjNCcdNUXPVbOh1hLfGjkE5up\n\tcVlnfonFb3vZwfO2tKhuCPGXE3/g8q/nRw==","X-Google-Smtp-Source":"ABdhPJzOlEpu5at2ZGuhkYb2aD0NyeN0S/J9M9z3O37Rf9yIJfk3eDeh/Uocw+sK3vXvtB6Z4orklA==","X-Received":"by 2002:ac8:5301:: with SMTP id\n\tt1mr22190085qtn.310.1592330596897; \n\tTue, 16 Jun 2020 11:03:16 -0700 (PDT)","Message-ID":"<8d81d86aab11a617253635603b78cf23bb06f0f0.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 16 Jun 2020 14:03:15 -0400","In-Reply-To":"<20200616152724.1292857-1-niklas.soderlund@ragnatech.se>","References":"<20200616152724.1292857-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.36.3 (3.36.3-1.fc32) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: options: Add a option to\n\tcontrol compilation of qcam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 18:03:18 -0000"}},{"id":5220,"web_url":"https://patchwork.libcamera.org/comment/5220/","msgid":"<20200616180612.GD913@pendragon.ideasonboard.com>","date":"2020-06-16T18:06:12","subject":"Re: [libcamera-devel] [PATCH] meson: options: Add a option to\n\tcontrol compilation of qcam","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Jun 16, 2020 at 05:27:24PM +0200, Niklas Söderlund wrote:\n> Add a option to control compilation of the qcam test application. The\n\ns/a option/an option/\n\n> default behavior is to compile qcam, no change in behavior without user\n> intervention.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> meson_options.txt | 5 +++++\n> src/meson.build | 5 ++++-\n> 2 files changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index badace151bb62bc9..9a4edf2a5fde8bcb 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -27,3 +27,8 @@ option('v4l2',\n> type : 'boolean',\n> value : false,\n> description : 'Compile the V4L2 compatibility layer')\n> +\n> +option('qcam',\n> + type : 'boolean',\n> + value : true,\n> + description : 'Compile the qcam test application')\n\nCould we keep the options alphabetically sorted ?\n\nReviewed-by: Laurent Pinchart \n\n> diff --git a/src/meson.build b/src/meson.build\n> index d69b4c1ea9788f83..3a816fb610a68905 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -19,7 +19,10 @@ endif\n> subdir('libcamera')\n> subdir('ipa')\n> subdir('cam')\n> -subdir('qcam')\n> +\n> +if get_option('qcam')\n> + subdir('qcam')\n> +endif\n> \n> if get_option('v4l2')\n> subdir('v4l2')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0546E603C4\n\tfor ;\n\tTue, 16 Jun 2020 20:06:36 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72F76F9;\n\tTue, 16 Jun 2020 20:06:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eLE0Ai0h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592330795;\n\tbh=cEFsitba0vx0FaL5q3+ZeyVx7fAkDABlnjLRMBv/fww=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eLE0Ai0hfdirZVwI7ueZOq4WCF8cJ+6NjAouw6KinL4/sDCEUNIG8RPOF3v4/ppGm\n\tHMDtzKjDWquqj3NC40qrITO8I+T4p7bbwiqg51G87KuTVgEtLkk1FOkcFtrOMAik3C\n\t0hmF+qFvg3RujU4NUx7jfSY5S0LpfYt+F2O/NiuQ=","Date":"Tue, 16 Jun 2020 21:06:12 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200616180612.GD913@pendragon.ideasonboard.com>","References":"<20200616152724.1292857-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200616152724.1292857-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] meson: options: Add a option to\n\tcontrol compilation of qcam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 18:06:36 -0000"}},{"id":5221,"web_url":"https://patchwork.libcamera.org/comment/5221/","msgid":"<20200616181159.GE913@pendragon.ideasonboard.com>","date":"2020-06-16T18:11:59","subject":"Re: [libcamera-devel] [PATCH] meson: options: Add a option to\n\tcontrol compilation of qcam","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 16, 2020 at 02:03:15PM -0400, Nicolas Dufresne wrote:\n> Le mardi 16 juin 2020 à 17:27 +0200, Niklas Söderlund a écrit :\n> > Add a option to control compilation of the qcam test application. The\n> > default behavior is to compile qcam, no change in behavior without user\n> > intervention.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > meson_options.txt | 5 +++++\n> > src/meson.build | 5 ++++-\n> > 2 files changed, 9 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/meson_options.txt b/meson_options.txt\n> > index badace151bb62bc9..9a4edf2a5fde8bcb 100644\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -27,3 +27,8 @@ option('v4l2',\n> > type : 'boolean',\n> > value : false,\n> > description : 'Compile the V4L2 compatibility layer')\n> > +\n> > +option('qcam',\n> > + type : 'boolean',\n> > + value : true,\n> > + description : 'Compile the qcam test application')\n> > diff --git a/src/meson.build b/src/meson.build\n> > index d69b4c1ea9788f83..3a816fb610a68905 100644\n> > --- a/src/meson.build\n> > +++ b/src/meson.build\n> > @@ -19,7 +19,10 @@ endif\n> > subdir('libcamera')\n> > subdir('ipa')\n> > subdir('cam')\n> > -subdir('qcam')\n> > +\n> > +if get_option('qcam')\n> > + subdir('qcam')\n> > +endif\n> \n> It's much cleaner if you check that option inside the subdir\n> meson.build and call subdir_done() instead.\n> \n> (ignore if your required meson version is too ancient)\n\nActually, now that I've sent an Rb tag, I wonder if we should make the\noption a feature instead of a boolean, and use\n\nqt5_dep = dependency('qt5',\n method : 'pkg-config',\n modules : ['Core', 'Gui', 'Widgets'],\n required : get_option('qcam'))\n\nlike we do for gstreamer. We wouldn't need to use subdir_done().\n\n> > \n> > if get_option('v4l2')\n> > subdir('v4l2')\n> \n> And then this could be cleaned up.\n\nsubdir_done() was introduced in 0.46 and we require 0.47 or newer, so\nthis should indeed be cleaned up.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A774603C4\n\tfor ;\n\tTue, 16 Jun 2020 20:12:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D52A1F9;\n\tTue, 16 Jun 2020 20:12:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hw0uc1Ef\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592331142;\n\tbh=YBq+tcu37V6K/DS5IaKikvdIApKJmVyryNAW8Na4gIU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hw0uc1EfXMmTYRIkfMlKvKi1itN+vOnC5LMzUT5BYop5KB2Uu6EvPHthQOKGG7U3f\n\tp8d6QkYyrfRQNMTwt40uUtjw0JlLGaLB4QXel6/8yAM3OwY7IV6XzVY8rydBpK3Msh\n\tqm1YxRPcPEvebgMirhRkr2Nkv8ruFAWR/cn0VK0Q=","Date":"Tue, 16 Jun 2020 21:11:59 +0300","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200616181159.GE913@pendragon.ideasonboard.com>","References":"<20200616152724.1292857-1-niklas.soderlund@ragnatech.se>\n\t<8d81d86aab11a617253635603b78cf23bb06f0f0.camel@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<8d81d86aab11a617253635603b78cf23bb06f0f0.camel@ndufresne.ca>","Subject":"Re: [libcamera-devel] [PATCH] meson: options: Add a option to\n\tcontrol compilation of qcam","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 18:12:22 -0000"}}]