[{"id":630,"web_url":"https://patchwork.libcamera.org/comment/630/","msgid":"<20190127002623.GV4127@bigcity.dyn.berto.se>","date":"2019-01-27T00:26:23","subject":"Re: [libcamera-devel] [PATCH] cam: options: Indent multi-line help\n\tmessage correctly","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nNeat idea!\n\nOn 2019-01-26 17:16:59 +0200, Laurent Pinchart wrote:\n> Split multi-line help messages and indent all lines the same way.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/options.cpp | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 55c42540f924..83601270207b 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -153,7 +153,17 @@ void OptionsParser::usage()\n> \t\t}\n> \n> \t\tstd::cerr << std::setw(indent) << std::left << argument;\n> -\t\tstd::cerr << option.help << std::endl;\n> +\n> +\t\tfor (const char *help = option.help, *end = help; end; ) {\n> +\t\t\tend = strchr(help, '\\n');\n> +\t\t\tif (end) {\n> +\t\t\t\tstd::cerr << std::string(help, end - help + 1);\n> +\t\t\t\tstd::cerr << std::setw(indent) << \" \";\n> +\t\t\t\thelp = end + 1;\n> +\t\t\t} else {\n> +\t\t\t\tstd::cerr << help << std::endl;\n> +\t\t\t}\n> +\t\t}\n> \t}\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A1FC60B2D\n\tfor ;\n\tSun, 27 Jan 2019 01:26:26 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id e26so9428607lfc.2\n\tfor ;\n\tSat, 26 Jan 2019 16:26:26 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tk68-v6sm2339326ljb.35.2019.01.26.16.26.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 26 Jan 2019 16:26:24 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=f/3ahR5JONB+u0QxVmePO9fRTotajKq18srqA3rYAz8=;\n\tb=b5fLWD5/vLtI/bwVXIWiwRKNlBz0h5QQSWFk7yxT0p43OW7LrtBNOkqW+kFXD82J2M\n\t0u24wnzf3zb+qWBn/jUJv8kUuDjUvBSooQ0iOFClFZ/9cdC2QbjNXM9NlFUi30c7xU8I\n\tYXB8lJKl8UrP2AQTVvjI4qG/BVnh+xN2eG7s8beOTfHWdDzqARflFCb+aOlXFsqrGIUs\n\tN9PJRTi2iNrejOWmvvoA5Kw1G2VzLIsetJgJKxB8/nsJk5BdVwDPJgF8nOrrv6HGDYKC\n\tnYfdNy6X9rqegLfYRxBGycuspT3VBbfWdMWFswvz6nnaRXb3bglXwn7NKGJC11WmMeZd\n\tGtTA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=f/3ahR5JONB+u0QxVmePO9fRTotajKq18srqA3rYAz8=;\n\tb=tVvgEe3r5T1CVyoXEr/eBauO4bXnUsymVX3RK8v+N/zUWE00lesr43wb055TE1MKNW\n\t5O1HueK1nXe0sGAyjODOE7k8fVAQAZwHCE+yZPSTLosggvKeg+U5JGd7Mj/tValvihDD\n\tbAWTueaMRR5kAv0j1WL9EAnpCOw5yqCGarGV9DOkIeODl4iqA37/8eSKSdSPPhJAlDHd\n\t2ypX5VfzTWTlpJxPRw3gqy8irsljeukVk0f1dT/vtpRWd/qbF6iDN2AI4EsDTS1Hj9HH\n\t+63jPv0iNagLZT34R8FeSICmu8zuYE921uS/TzUPpFMDTf8KXDCFNqUcrtDthpJt5JZC\n\tAUBQ==","X-Gm-Message-State":"AJcUukepqsTxBYACPYPm+ZPqUdR2GOpbh30WS4FuJGvUTu3LOZ6Eu54j\n\t2n5jBaGCSXifPNwlLowJGQs0JSF2hz0=","X-Google-Smtp-Source":"ALg8bN5q3gOk+pjeppXmAIPsNof94leEs7J6rAgx4J2ZcWNWlQiumFn14+bOhmatO5r0roe/IymvRw==","X-Received":"by 2002:a19:645b:: with SMTP id\n\tb27mr12231850lfj.14.1548548785382; \n\tSat, 26 Jan 2019 16:26:25 -0800 (PST)","Date":"Sun, 27 Jan 2019 01:26:23 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190127002623.GV4127@bigcity.dyn.berto.se>","References":"<20190126151659.7438-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190126151659.7438-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] cam: options: Indent multi-line help\n\tmessage correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Jan 2019 00:26:26 -0000"}}]