{"id":4047,"url":"https://patchwork.libcamera.org/api/patches/4047/?format=json","web_url":"https://patchwork.libcamera.org/patch/4047/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200616131244.70308-4-paul.elder@ideasonboard.com>","date":"2020-06-16T13:12:32","name":"[libcamera-devel,03/15] v4l2: v4l2_camera_proxy: Fix v4l2-compliance support for extended formats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1cc725e8999dd6c366b49513dfa98037d082cebe","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4047/mbox/","series":[{"id":1006,"url":"https://patchwork.libcamera.org/api/series/1006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1006","date":"2020-06-16T13:12:29","name":"Support v4l2-compliance","version":1,"mbox":"https://patchwork.libcamera.org/series/1006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4047/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4047/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03549603C1\n\tfor ;\n\tTue, 16 Jun 2020 15:13:06 +0200 (CEST)","from jade.flets-east.jp (unknown\n\t[IPv6:2400:4051:61:600:2807:bdfa:f6a:8e53])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74F7BF9;\n\tTue, 16 Jun 2020 15:13:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TVUKLDtT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592313185;\n\tbh=8h2S8jtP297Dfd4jnIvA20at3UGgn8S1dwpKQAOs2us=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TVUKLDtTf9J4JcVlviDW3q/jZKe+Th2Rb6c6y9YuUDMKKdw3hll2+Pda4WENPswT8\n\t1wSoHpocQW1ZEDDPXH8fUdIF2CfeDc5C8b+fkyjkE/wQkdXPmDXsnFEWZD0NKCKXzO\n\t3LqmtdRlqMF/dfH9/ucClY73sOT8i5WQozfq1EhM=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Jun 2020 22:12:32 +0900","Message-Id":"<20200616131244.70308-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200616131244.70308-1-paul.elder@ideasonboard.com>","References":"<20200616131244.70308-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 03/15] v4l2: v4l2_camera_proxy: Fix\n\tv4l2-compliance support for extended formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 13:13:06 -0000"},"content":"Fix the following v4l2-compliance error:\n\nfail: v4l2-compliance.cpp(652): !(caps & V4L2_CAP_EXT_PIX_FORMAT)\n\nSimply add V4L2_CAP_EXT_PIX_FORMAT to capabilities in querycap.\n\nSigned-off-by: Paul Elder \n---\n src/v4l2/v4l2_camera_proxy.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 5b74b53..d899853 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -202,7 +202,9 @@ void V4L2CameraProxy::querycap(std::shared_ptr camera)\n \t\t sizeof(capabilities_.bus_info));\n \t/* \\todo Put this in a header/config somewhere. */\n \tcapabilities_.version = KERNEL_VERSION(5, 2, 0);\n-\tcapabilities_.device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;\n+\tcapabilities_.device_caps = V4L2_CAP_VIDEO_CAPTURE\n+\t\t\t\t | V4L2_CAP_STREAMING\n+\t\t\t\t | V4L2_CAP_EXT_PIX_FORMAT;\n \tcapabilities_.capabilities = capabilities_.device_caps\n \t\t\t\t | V4L2_CAP_DEVICE_CAPS;\n \tmemset(capabilities_.reserved, 0, sizeof(capabilities_.reserved));\n","prefixes":["libcamera-devel","03/15"]}