[{"id":5216,"web_url":"https://patchwork.libcamera.org/comment/5216/","msgid":"<8a296afa-470f-b92c-7b70-5332bc71bed5@uajain.com>","date":"2020-06-16T14:30:52","subject":"Re: [libcamera-devel] [PATCH] libcamera: StreamConfiguration: Fix\n\ttypo in documentation","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn 6/16/20 4:24 PM, Paul Elder wrote:\n> Fix a typo in the documentation in the StreamConfiguration constructor.\n>\n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index f34348f..8e78234 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -276,7 +276,7 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n> \n> /**\n> * \\todo This method is deprecated and should be removed once all pipeline\n> - * handlers provied StreamFormats.\n> + * handlers provide StreamFormats.\n> */\n> StreamConfiguration::StreamConfiguration()\n> \t: pixelFormat(0), stream_(nullptr)\n\nLooks good to me.\n\nReviewed-by: Umang Jain ","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A09C603C1\n\tfor ;\n\tTue, 16 Jun 2020 16:30:54 +0200 (CEST)","by filterdrecv-p3iad2-784dbb6bd8-z6chg with SMTP id\n\tfilterdrecv-p3iad2-784dbb6bd8-z6chg-19-5EE8D79C-B4\n\t2020-06-16 14:30:52.770601832 +0000 UTC m=+1103043.803850026","from mail.uajain.com (unknown)\n\tby ismtpd0003p1maa1.sendgrid.net (SG) with ESMTP\n\tid COhzkYeVT2y7XQRC9yOnCA Tue, 16 Jun 2020 14:30:52.072 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"PQPdXpxv\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=tUSpDrBj6PR/AEJMC0x6hvSkw2SckX2dRjU/SFVD17w=;\n\tb=PQPdXpxvZMf33eMnKJIuSJchJ5w1koxOoGwyBUWVBPU/aI7Map/a2oYBnVZttTm94P9a\n\tzaCcAzVEFJCL4JsmaVvczp72RywCRMQsxXTdMLQQHSg4IHb8s4rYyvPwF0Xs14w+eE7z2q\n\tVUUUa6Gc/DbXxQj1q5PqQv3YaeqyhGQKE=","References":"<20200616105400.57377-1-paul.elder@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<8a296afa-470f-b92c-7b70-5332bc71bed5@uajain.com>","Date":"Tue, 16 Jun 2020 14:30:52 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<20200616105400.57377-1-paul.elder@ideasonboard.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc6PesGYbv37LpAT9IAi6gffW4sU0EyIMglswqhyGj4NJfe4U4cKjs6M2K0Kfi2KlrkeEqibsIpd2LDl/6zAFaoKQFuqXiX8mDVP4rhB+FpyQOIhCuyeZjVOxDzcV3n6EQLYiz2frYs+lrOt1ho5tAuuTuRU3CEZh1d2URdsyt2/alnl9B3YSw1x1u4tGh3DMLSovLMK7Rs3zjm2GCGYQQqA==","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: StreamConfiguration: Fix\n\ttypo in documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 14:30:55 -0000"}},{"id":5227,"web_url":"https://patchwork.libcamera.org/comment/5227/","msgid":"<20200617003007.GO913@pendragon.ideasonboard.com>","date":"2020-06-17T00:30:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: StreamConfiguration: Fix\n\ttypo in documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jun 16, 2020 at 07:54:00PM +0900, Paul Elder wrote:\n> Fix a typo in the documentation in the StreamConfiguration constructor.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/stream.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index f34348f..8e78234 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -276,7 +276,7 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n> \n> /**\n> * \\todo This method is deprecated and should be removed once all pipeline\n> - * handlers provied StreamFormats.\n> + * handlers provide StreamFormats.\n> */\n> StreamConfiguration::StreamConfiguration()\n> \t: pixelFormat(0), stream_(nullptr)\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36C85603D8\n\tfor ;\n\tWed, 17 Jun 2020 02:30:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9493F9;\n\tWed, 17 Jun 2020 02:30:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AC5WF4FM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592353830;\n\tbh=P/ARs5Ft2Bf4zZtQtAPkA6Y+FJd6Vhb1o1an0KcQZXY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AC5WF4FMiuuI61+81WbRBc5K0G2QXYLyis4FADXQeoLkUfPLa1ZaJ9IydkMXBU3Q6\n\tSHfPRBzHIhYxqeXDh9YQulST/4cWz6OP26hpmbUhQ8V8leVx7cP74mQdwtRyV5rOhr\n\t+ag4kJZR9S/yrCYvEQ9i1j8D1nmgETSfZhC8egmg=","Date":"Wed, 17 Jun 2020 03:30:07 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200617003007.GO913@pendragon.ideasonboard.com>","References":"<20200616105400.57377-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200616105400.57377-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: StreamConfiguration: Fix\n\ttypo in documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 17 Jun 2020 00:30:30 -0000"}}]