[{"id":5208,"web_url":"https://patchwork.libcamera.org/comment/5208/","msgid":"<3862c674-1458-5fde-4d2b-f1efe836d587@uajain.com>","date":"2020-06-15T15:14:26","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Chris,\n\nOn 6/15/20 8:19 PM, chris@gregariousmammal.com wrote:\n> From: Chris Chinchilla \n>\n> ---\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index a0f6b0f..fca11cb 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> *\n> * Pipeline handlers are expected to extend this base class with platform\n> * specific implementation, associate instances of the derived classes\n> - * using the setCameraData() method, and access them at a later time\n> + * using the registerCamera() method, and access them at a later time\n> * with cameraData().\n> */\n> \n\nThe change looks good. :-)\n\nCouple of comments on the commit message.\n\n* Missing sign-off tag\n\n    - Patches need to signed off. You can use --signoff flag while \ncommitting (git commit --signoff ...)\n\n* Missing \"Fixes:\" tag\n    - This commit actually fixes commit: b581b9576abd (\"libcamera: \npipeline_handler: Make pipeline-specific data mandatory\"), so add this \ntag to the commit message:\n\n > Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make \npipeline-specific data mandatory\")\n\n\nOnce you have these two things in your commit message:\n\nReviewed-by: Umang Jain ","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CED6603D8\n\tfor ;\n\tMon, 15 Jun 2020 17:14:28 +0200 (CEST)","by filter0072p3las1.sendgrid.net with SMTP id\n\tfilter0072p3las1-4518-5EE79051-E2\n\t2020-06-15 15:14:26.140793268 +0000 UTC m=+594303.898913613","from mail.uajain.com (unknown)\n\tby ismtpd0006p1hnd1.sendgrid.net (SG) with ESMTP\n\tid MreYEMiCTf6y_EogI7ao0w Mon, 15 Jun 2020 15:14:25.671 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"nZb83cgb\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=/oOoXru2rq9N+fGorvdQStSFGYVbTOyb2cODOW4PIeY=;\n\tb=nZb83cgbQRCdiVLt2ZyZWeTZvSRmprAKlxBX0lVrlCQ0RwmnoBy6kn/r4Pepq48dVHwN\n\t4l+gsjn7nF77rEbcgWyFImZA+Ddf7Lf3UajsSTiIwdRbvpoCdtAi1YwCNj8ZBhgRZ5kXmT\n\tmWBqy7CA+tvu+K0l/OVT9YGvZqQOxcgcI=","References":"<20200615144919.42388-1-chris@gregariousmammal.com>","From":"Umang Jain ","Message-ID":"<3862c674-1458-5fde-4d2b-f1efe836d587@uajain.com>","Date":"Mon, 15 Jun 2020 15:14:26 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<20200615144919.42388-1-chris@gregariousmammal.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc+mYHlj5pFD2lBxsaGLVsOL3ndUVDa95FP3SfloM/AJ06BYycvZHj92SYOVmsQdTmvZzSCGjETC0jg3qp4ghPRPgkBm5dF6a701CyMN6+pqQbcEU2CTwep/t0T/2uR/UiD0mQb4d14ZZnUxio51divy1JJQXui4kONoOWh9Ye9uaKCiWkXoT9vYarcKXkR49e","To":"chris@gregariousmammal.com, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=iso-8859-1; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Jun 2020 15:14:28 -0000"}},{"id":5215,"web_url":"https://patchwork.libcamera.org/comment/5215/","msgid":"<20200616024943.GE29596@pendragon.ideasonboard.com>","date":"2020-06-16T02:49:43","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jun 15, 2020 at 03:14:26PM +0000, Umang Jain wrote:\n> On 6/15/20 8:19 PM, chris@gregariousmammal.com wrote:\n\nWe try to always include a commit message, even for simple changes. It's\nnot a hard requirements, but it's highly encouraged.\n\n> > From: Chris Chinchilla \n> >\n> > ---\n> > src/libcamera/pipeline_handler.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index a0f6b0f..fca11cb 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> > *\n> > * Pipeline handlers are expected to extend this base class with platform\n> > * specific implementation, associate instances of the derived classes\n> > - * using the setCameraData() method, and access them at a later time\n> > + * using the registerCamera() method, and access them at a later time\n> > * with cameraData().\n> > */\n> \n> The change looks good. :-)\n> \n> Couple of comments on the commit message.\n> \n> * Missing sign-off tag\n> \n>    - Patches need to signed off. You can use --signoff flag while \n> committing (git commit --signoff ...)\n\nOr -s, that's shorter. And we even document the Signed-off-by\nrequirement in http://libcamera.org/contributing.html#submitting-patches\n:-)\n\n> \n> * Missing \"Fixes:\" tag\n>    - This commit actually fixes commit: b581b9576abd (\"libcamera: \n> pipeline_handler: Make pipeline-specific data mandatory\"), so add this \n> tag to the commit message:\n> \n> Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make pipeline-specific data mandatory\")\n\nTo add a bit more information, 'git blame' can help checking which\ncommit last modified a given line. To generate the Fixes: line, I have\nadded the following in ~/.gitconfig:\n\n[pretty]\n\tfixes = Fixes: %h (\\\"%s\\\")\n\nand added the following function in my ~.bashrc:\n\ngpf() {\n\tgit show --pretty=fixes ${1:-HEAD} | head -1\n}\n\nRunning\n\ngpf b581b9576abd\n\nproduces\n\nFixes: b581b9576abd (\"libcamera: pipeline_handler: Make pipeline-specific data mandatory\")\n\n> Once you have these two things in your commit message:\n> \n> Reviewed-by: Umang Jain \n\nSame,\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CB0B61027\n\tfor ;\n\tTue, 16 Jun 2020 04:50:06 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D45CBF9;\n\tTue, 16 Jun 2020 04:50:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Jv8ZvExE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592275806;\n\tbh=2YJwLbSYIB9lePY1zAB3IqpIt0KGnWO/cIcSXZiO7Oc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Jv8ZvExE1UCmeW8Bq+Ne52Q2NgthhqvA3aYdJd7UmmJauAl6L0izgdog7s7xsOOfX\n\tRzr0Go9j+VwGkkBeFBpvsLYMgx7qwqkynJdj/AVdvYvSZgZ1MAvzHiIbjn1Z3Ublg8\n\tPbX80ye1hP3rmPK4eezStzgMbiox5KVgRV/hC6dY=","Date":"Tue, 16 Jun 2020 05:49:43 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"chris@gregariousmammal.com, libcamera-devel@lists.libcamera.org","Message-ID":"<20200616024943.GE29596@pendragon.ideasonboard.com>","References":"<20200615144919.42388-1-chris@gregariousmammal.com>\n\t<3862c674-1458-5fde-4d2b-f1efe836d587@uajain.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<3862c674-1458-5fde-4d2b-f1efe836d587@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jun 2020 02:50:06 -0000"}}]