[{"id":5195,"web_url":"https://patchwork.libcamera.org/comment/5195/","msgid":"<20200612110405.GK5957@pendragon.ideasonboard.com>","date":"2020-06-12T11:04:05","subject":"Re: [libcamera-devel] [PATCH v4 5/6] qcam: main_window: Introduce\n\tinitial hotplug support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Jun 11, 2020 at 05:16:07PM +0000, Umang Jain wrote:\n> Hook up various QCam UI bits with hotplug support introduced\n> in previous commits. This looks good-enough as first steps\n> to see how the hotplugging functionality is turning out to be\n> from application point-of-view.\n> \n> One can still think of few edge case nuances not yet covered\n> under this implementation hence, those are intentionally\n> kept out of scope for now. It might require some thinking\n> and/or additional time on hand.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/main_window.cpp | 76 ++++++++++++++++++++++++++++++++++++++++\n> src/qcam/main_window.h | 6 ++++\n> 2 files changed, 82 insertions(+)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 2960259..7bc1360 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -59,6 +59,36 @@ public:\n> \t}\n> };\n> \n> +/**\n> + * \\brief Custom QEvent to signal hotplug or unplug\n> + */\n> +class HotplugEvent : public QEvent\n> +{\n> +public:\n> +\tenum PlugEvent {\n> +\t\tHotPlug,\n> +\t\tHotUnplug\n> +\t};\n> +\n> +\tHotplugEvent(std::shared_ptr camera, PlugEvent event)\n> +\t\t: QEvent(type()), camera_(std::move(camera)), plugEvent_(event)\n> +\t{\n> +\t}\n> +\n> +\tstatic Type type()\n> +\t{\n> +\t\tstatic int type = QEvent::registerEventType();\n> +\t\treturn static_cast(type);\n> +\t}\n> +\n> +\tPlugEvent hotplugEvent() const { return plugEvent_; }\n> +\tCamera *camera() const { return camera_.get(); }\n> +\n> +private:\n> +\tstd::shared_ptr camera_;\n> +\tPlugEvent plugEvent_;\n> +};\n> +\n> MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \t: saveRaw_(nullptr), options_(options), cm_(cm), allocator_(nullptr),\n> \t isCapturing_(false), captureRaw_(false)\n> @@ -81,6 +111,10 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \tsetCentralWidget(viewfinder_);\n> \tadjustSize();\n> \n> +\t/* Hotplug/unplug support */\n> +\tcm_->cameraAdded.connect(this, &MainWindow::addCamera);\n> +\tcm_->cameraRemoved.connect(this, &MainWindow::removeCamera);\n> +\n> \t/* Open the camera and start capture. */\n> \tret = openCamera();\n> \tif (ret < 0) {\n> @@ -105,6 +139,9 @@ bool MainWindow::event(QEvent *e)\n> \tif (e->type() == CaptureEvent::type()) {\n> \t\tprocessCapture();\n> \t\treturn true;\n> +\t} else if (e->type() == HotplugEvent::type()) {\n> +\t\tprocessHotplug(static_cast(e));\n> +\t\treturn true;\n> \t}\n> \n> \treturn QMainWindow::event(e);\n> @@ -535,6 +572,45 @@ void MainWindow::stopCapture()\n> \tsetWindowTitle(title_);\n> }\n> \n> +/* -----------------------------------------------------------------------------\n> + * Camera hotplugging support\n> + */\n> +\n> +void MainWindow::processHotplug(HotplugEvent *e)\n> +{\n> +\tCamera *camera = e->camera();\n> +\tHotplugEvent::PlugEvent event = e->hotplugEvent();\n> +\n> +\tif (event == HotplugEvent::HotPlug) {\n> +\t\tcameraCombo_->addItem(QString::fromStdString(camera->name()));\n> +\t} else if (event == HotplugEvent::HotUnplug) {\n> +\t\t/* Check if the currently-streaming camera is removed. */\n> +\t\tif (camera == camera_.get()) {\n> +\t\t\ttoggleCapture(false);\n> +\t\t\tcameraCombo_->setCurrentIndex(0);\n> +\t\t}\n> +\n> +\t\tint camIndex = cameraCombo_->findText(QString::fromStdString(camera->name()));\n> +\t\tcameraCombo_->removeItem(camIndex);\n> +\t}\n> +}\n> +\n> +void MainWindow::addCamera(std::shared_ptr camera)\n> +{\n> +\tqInfo() << \"Adding new camera:\" << camera->name().c_str();\n> +\tQCoreApplication::postEvent(this,\n> +\t\t\t\t new HotplugEvent(std::move(camera),\n> +\t\t\t\t\t\t HotplugEvent::HotPlug));\n> +}\n> +\n> +void MainWindow::removeCamera(std::shared_ptr camera)\n> +{\n> +\tqInfo() << \"Removing camera:\" << camera->name().c_str();\n> +\tQCoreApplication::postEvent(this,\n> +\t\t\t\t new HotplugEvent(std::move(camera),\n> +\t\t\t\t\t\t HotplugEvent::HotUnplug));\n> +}\n> +\n> /* -----------------------------------------------------------------------------\n> * Image Save\n> */\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 59fa2d9..4606fe4 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -32,6 +32,8 @@ using namespace libcamera;\n> class QAction;\n> class QComboBox;\n> \n> +class HotplugEvent;\n> +\n> enum {\n> \tOptCamera = 'c',\n> \tOptHelp = 'h',\n> @@ -87,8 +89,12 @@ private:\n> \tint startCapture();\n> \tvoid stopCapture();\n> \n> +\tvoid addCamera(std::shared_ptr camera);\n> +\tvoid removeCamera(std::shared_ptr camera);\n> +\n> \tvoid requestComplete(Request *request);\n> \tvoid processCapture();\n> +\tvoid processHotplug(HotplugEvent *e);\n> \tvoid processViewfinder(FrameBuffer *buffer);\n> \n> \t/* UI elements */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAE9660C4E\n\tfor ;\n\tFri, 12 Jun 2020 13:04:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A4B524F;\n\tFri, 12 Jun 2020 13:04:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"baydPmlb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591959866;\n\tbh=KZN311Y9YHgu0VA6uGbOpcpxaHhYqj+6nM/rHmz+9t0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=baydPmlb3WXMgzgwCqPx/dLKIaW3SrAbnTUH+ARtCRi0Ab28SENTRM7Cr+94xpeBl\n\tZQpk38+VIRDcerYI7lJzy9NIYrCwu6FLTjpc8eOoc8Oz9+tegWNYsze5ls+dL17z0/\n\t37wyYkENUMx0wqjM6oS+irAyMr/ElnC9aSfVohYI=","Date":"Fri, 12 Jun 2020 14:04:05 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200612110405.GK5957@pendragon.ideasonboard.com>","References":"<20200611171528.9381-1-email@uajain.com>\n\t<20200611171528.9381-6-email@uajain.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200611171528.9381-6-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v4 5/6] qcam: main_window: Introduce\n\tinitial hotplug support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 12 Jun 2020 11:04:27 -0000"}},{"id":5200,"web_url":"https://patchwork.libcamera.org/comment/5200/","msgid":"<0d1d0bed-7931-8ba6-fe0e-74a9043fdff4@ideasonboard.com>","date":"2020-06-12T15:25:08","subject":"Re: [libcamera-devel] [PATCH v4 5/6] qcam: main_window: Introduce\n\tinitial hotplug support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 12/06/2020 12:04, Laurent Pinchart wrote:\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Thu, Jun 11, 2020 at 05:16:07PM +0000, Umang Jain wrote:\n>> Hook up various QCam UI bits with hotplug support introduced\n>> in previous commits. This looks good-enough as first steps\n>> to see how the hotplugging functionality is turning out to be\n>> from application point-of-view.\n>>\n>> One can still think of few edge case nuances not yet covered\n>> under this implementation hence, those are intentionally\n>> kept out of scope for now. It might require some thinking\n>> and/or additional time on hand.\n>>\n>> Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> src/qcam/main_window.cpp | 76 ++++++++++++++++++++++++++++++++++++++++\n>> src/qcam/main_window.h | 6 ++++\n>> 2 files changed, 82 insertions(+)\n>>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 2960259..7bc1360 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -59,6 +59,36 @@ public:\n>> \t}\n>> };\n>> \n>> +/**\n>> + * \\brief Custom QEvent to signal hotplug or unplug\n>> + */\n>> +class HotplugEvent : public QEvent\n>> +{\n>> +public:\n>> +\tenum PlugEvent {\n>> +\t\tHotPlug,\n>> +\t\tHotUnplug\n>> +\t};\n\n\nRe: Laurent's quizzing of if I would dislike the choices here ...\nI think this is the best choice of naming, but I can see how it can be a\nbit painful.\n\nReviewed-by: Kieran Bingham \n\n\n>> +\n>> +\tHotplugEvent(std::shared_ptr camera, PlugEvent event)\n>> +\t\t: QEvent(type()), camera_(std::move(camera)), plugEvent_(event)\n>> +\t{\n>> +\t}\n>> +\n>> +\tstatic Type type()\n>> +\t{\n>> +\t\tstatic int type = QEvent::registerEventType();\n>> +\t\treturn static_cast(type);\n>> +\t}\n>> +\n>> +\tPlugEvent hotplugEvent() const { return plugEvent_; }\n>> +\tCamera *camera() const { return camera_.get(); }\n>> +\n>> +private:\n>> +\tstd::shared_ptr camera_;\n>> +\tPlugEvent plugEvent_;\n>> +};\n>> +\n>> MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n>> \t: saveRaw_(nullptr), options_(options), cm_(cm), allocator_(nullptr),\n>> \t isCapturing_(false), captureRaw_(false)\n>> @@ -81,6 +111,10 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n>> \tsetCentralWidget(viewfinder_);\n>> \tadjustSize();\n>> \n>> +\t/* Hotplug/unplug support */\n>> +\tcm_->cameraAdded.connect(this, &MainWindow::addCamera);\n>> +\tcm_->cameraRemoved.connect(this, &MainWindow::removeCamera);\n>> +\n>> \t/* Open the camera and start capture. */\n>> \tret = openCamera();\n>> \tif (ret < 0) {\n>> @@ -105,6 +139,9 @@ bool MainWindow::event(QEvent *e)\n>> \tif (e->type() == CaptureEvent::type()) {\n>> \t\tprocessCapture();\n>> \t\treturn true;\n>> +\t} else if (e->type() == HotplugEvent::type()) {\n>> +\t\tprocessHotplug(static_cast(e));\n>> +\t\treturn true;\n>> \t}\n>> \n>> \treturn QMainWindow::event(e);\n>> @@ -535,6 +572,45 @@ void MainWindow::stopCapture()\n>> \tsetWindowTitle(title_);\n>> }\n>> \n>> +/* -----------------------------------------------------------------------------\n>> + * Camera hotplugging support\n>> + */\n>> +\n>> +void MainWindow::processHotplug(HotplugEvent *e)\n>> +{\n>> +\tCamera *camera = e->camera();\n>> +\tHotplugEvent::PlugEvent event = e->hotplugEvent();\n>> +\n>> +\tif (event == HotplugEvent::HotPlug) {\n>> +\t\tcameraCombo_->addItem(QString::fromStdString(camera->name()));\n>> +\t} else if (event == HotplugEvent::HotUnplug) {\n>> +\t\t/* Check if the currently-streaming camera is removed. */\n>> +\t\tif (camera == camera_.get()) {\n>> +\t\t\ttoggleCapture(false);\n>> +\t\t\tcameraCombo_->setCurrentIndex(0);\n>> +\t\t}\n>> +\n>> +\t\tint camIndex = cameraCombo_->findText(QString::fromStdString(camera->name()));\n>> +\t\tcameraCombo_->removeItem(camIndex);\n>> +\t}\n>> +}\n>> +\n>> +void MainWindow::addCamera(std::shared_ptr camera)\n>> +{\n>> +\tqInfo() << \"Adding new camera:\" << camera->name().c_str();\n>> +\tQCoreApplication::postEvent(this,\n>> +\t\t\t\t new HotplugEvent(std::move(camera),\n>> +\t\t\t\t\t\t HotplugEvent::HotPlug));\n>> +}\n>> +\n>> +void MainWindow::removeCamera(std::shared_ptr camera)\n>> +{\n>> +\tqInfo() << \"Removing camera:\" << camera->name().c_str();\n>> +\tQCoreApplication::postEvent(this,\n>> +\t\t\t\t new HotplugEvent(std::move(camera),\n>> +\t\t\t\t\t\t HotplugEvent::HotUnplug));\n>> +}\n>> +\n>> /* -----------------------------------------------------------------------------\n>> * Image Save\n>> */\n>> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n>> index 59fa2d9..4606fe4 100644\n>> --- a/src/qcam/main_window.h\n>> +++ b/src/qcam/main_window.h\n>> @@ -32,6 +32,8 @@ using namespace libcamera;\n>> class QAction;\n>> class QComboBox;\n>> \n>> +class HotplugEvent;\n>> +\n>> enum {\n>> \tOptCamera = 'c',\n>> \tOptHelp = 'h',\n>> @@ -87,8 +89,12 @@ private:\n>> \tint startCapture();\n>> \tvoid stopCapture();\n>> \n>> +\tvoid addCamera(std::shared_ptr camera);\n>> +\tvoid removeCamera(std::shared_ptr camera);\n>> +\n>> \tvoid requestComplete(Request *request);\n>> \tvoid processCapture();\n>> +\tvoid processHotplug(HotplugEvent *e);\n>> \tvoid processViewfinder(FrameBuffer *buffer);\n>> \n>> \t/* UI elements */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C52860C4E\n\tfor ;\n\tFri, 12 Jun 2020 17:25:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3E2324F;\n\tFri, 12 Jun 2020 17:25:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YnQMDV3l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591975511;\n\tbh=qgjUGo+QG6dyKH96mmSOlLLMqnhflnT60BYY0Hm9ti4=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=YnQMDV3lPf9LHzIJSjNxwf0/ZBSeeyVt5Nbl4gdjTKsOg8/0qpvVHgNFrEcaKc+rb\n\tSkts+Y+hBsBND7aoPx6UXtP272PoinlKLPfWCSHTSocd/+DDklN1pokGoALyPr05HL\n\tdV0n4AxqIcOtj0jGygJA8AO0Spr6YBw3Ienahe3o=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tUmang Jain ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200611171528.9381-1-email@uajain.com>\n\t<20200611171528.9381-6-email@uajain.com>\n\t<20200612110405.GK5957@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0d1d0bed-7931-8ba6-fe0e-74a9043fdff4@ideasonboard.com>","Date":"Fri, 12 Jun 2020 16:25:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200612110405.GK5957@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 5/6] qcam: main_window: Introduce\n\tinitial hotplug support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 12 Jun 2020 15:25:11 -0000"}}]