{"id":4026,"url":"https://patchwork.libcamera.org/api/patches/4026/?format=json","web_url":"https://patchwork.libcamera.org/patch/4026/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200611171528.9381-3-email@uajain.com>","date":"2020-06-11T17:16:04","name":"[libcamera-devel,v4,2/6] libcamera: camera_manager: Refactor pipelines creation into separate function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4c2c22e0c3f22511933df85391fc23ab92c18ed1","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4026/mbox/","series":[{"id":993,"url":"https://patchwork.libcamera.org/api/series/993/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=993","date":"2020-06-11T17:16:02","name":"Introduce UVC hotplugging support","version":4,"mbox":"https://patchwork.libcamera.org/series/993/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4026/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4026/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8612561DFC\n\tfor ;\n\tThu, 11 Jun 2020 19:16:05 +0200 (CEST)","by filterdrecv-p3iad2-784dbb6bd8-p7j56 with SMTP id\n\tfilterdrecv-p3iad2-784dbb6bd8-p7j56-17-5EE266D4-7\n\t2020-06-11 17:16:04.216290268 +0000 UTC m=+680945.016001562","from mail.uajain.com (unknown)\n\tby ismtpd0008p1hnd1.sendgrid.net (SG) with ESMTP\n\tid rpAEfMy_SMqsn1TiB_m4Dg Thu, 11 Jun 2020 17:16:03.800 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"gV02pM6i\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=dziieE3rjqgnky53UeH/783O3RqTH7OtjKspSaaGZvM=;\n\tb=gV02pM6iLLtRHyaazn3qkoCIlpLqiludPZ3jQsZIQO2k/d9f9ivFOod8UI1ERSiIiFOP\n\tWELeS5SbXcdjX1YfiVN4mxOLHcgiOn701sumFHkvdeNcWfvQEFc9mCP6sQ6y/m+qkR5+Qk\n\ts1cCZX32gW3xEnWg0x//oCU79juUPMJiM=","From":"Umang Jain ","Date":"Thu, 11 Jun 2020 17:16:04 +0000 (UTC)","Message-Id":"<20200611171528.9381-3-email@uajain.com>","In-Reply-To":"<20200611171528.9381-1-email@uajain.com>","References":"<20200611171528.9381-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcIgOyDPOiX995eQdp4XFd3BFl5pNeueaPJmHuUAql2udzi84Ctd4sLAv7MxzkKZ0Pkz4DRH5DBvV1uGTjK34SzpoM0WHHfx2TCp0BYAQ9yp3B4e9uxqk4HBrJFKrzBIoS1YsGQJtiHI0G3E5wLLfgDUxWVSbbQyR2h+vLyhjUnrLi7tcwiSUetHlnp0NQgHEmLiRkb1cB6tA07NV3Hh0Lsw==","To":"laurent.pinchart@ideasonboard.com, libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v4 2/6] libcamera: camera_manager:\n\tRefactor pipelines creation into separate function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 17:16:06 -0000"},"content":"This commit introduces no functional changes.\nSplit pipelines creation code into a separate function,\nso that the function can be re-used for upcoming hotplug\nfunctionality in subsequent commits.\n\nAlso, fixup correct tag for \\todo.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/camera_manager.cpp | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex b8128df..aba5a0c 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -56,6 +56,7 @@ protected:\n private:\n \tint init();\n \tvoid cleanup();\n+\tvoid createPipelineHandlers();\n \n \tCameraManager *cm_;\n \n@@ -123,12 +124,20 @@ int CameraManager::Private::init()\n \tif (!enumerator_ || enumerator_->enumerate())\n \t\treturn -ENODEV;\n \n+\tcreatePipelineHandlers();\n+\n+\treturn 0;\n+}\n+\n+void CameraManager::Private::createPipelineHandlers()\n+{\n \t/*\n-\t * TODO: Try to read handlers and order from configuration\n+\t * \\todo Try to read handlers and order from configuration\n \t * file and only fallback on all handlers if there is no\n \t * configuration file.\n \t */\n-\tstd::vector &factories = PipelineHandlerFactory::factories();\n+\tstd::vector &factories =\n+\t\tPipelineHandlerFactory::factories();\n \n \tfor (PipelineHandlerFactory *factory : factories) {\n \t\t/*\n@@ -146,14 +155,12 @@ int CameraManager::Private::init()\n \t\t}\n \t}\n \n-\t/* TODO: register hot-plug callback here */\n-\n-\treturn 0;\n+\t/* \\todo Register hot-plug callback here */\n }\n \n void CameraManager::Private::cleanup()\n {\n-\t/* TODO: unregister hot-plug callback here */\n+\t/* \\todo Unregister hot-plug callback here */\n \n \t/*\n \t * Release all references to cameras and pipeline handlers to ensure\n","prefixes":["libcamera-devel","v4","2/6"]}