[{"id":5188,"web_url":"https://patchwork.libcamera.org/comment/5188/","msgid":"<28acf1b6-2c54-e71d-7b51-17248785161d@ideasonboard.com>","date":"2020-06-12T08:27:45","subject":"Re: [libcamera-devel] [PATCH v5] meson: detect kernel version","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Stéphane\n\nOn 11/06/2020 11:26, Stéphane Cerveau wrote:\n> Add kernel version detection to warn user\n> that only >= 5.0.0 V4L API are supported in\n> libcamera.\n> \n> Signed-off-by: Stéphane Cerveau \n\nPlease carry tags you receive forwards on patches, unless they need to\nbe dropped perhaps due to drastic changes or re-architecture of the patch.\n\nIn this instance, you can carry my RB tag from v4 to this patch:\n\nReviewed-by: Kieran Bingham \n\n> ---\n> meson.build | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index e898782..69d2d63 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -105,6 +105,15 @@ if get_option('test')\n> subdir('test')\n> endif\n> \n> +if not meson.is_cross_build()\n> + kernel_version_req = '>= 5.0.0'\n> + kernel_version = run_command('uname', '-r').stdout()\n> + if not kernel_version.version_compare(kernel_version_req)\n> + warning('Consider upgrading your kernel, as only @0@ is supported by libcamera at runtime'\n> + .format(kernel_version_req))\n> + endif\n> +endif\n> +\n> # Create a symlink from the build root to the source root. This is used when\n> # running libcamera from the build directory to locate resources in the source\n> # directory (such as IPA configuration files).\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DF09603C7\n\tfor ;\n\tFri, 12 Jun 2020 10:27:49 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8B3624F;\n\tFri, 12 Jun 2020 10:27:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CkHztZwt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591950468;\n\tbh=Lw8eFOlzumo/dHwlnNhC29VrAk+4d1MRAUE3Sx9ilWM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CkHztZwtnpIL0Q7O9UIrJsj1HNZ8/2HtZcHmwpncfagPb6Y1hdyhbpwcTk6VkGfkv\n\tk09yhPWsB+7+qdsuf4gb1x2Rc3l/28BmZ6Bx1kVsHae2rPsE0XSCcgHcyzP79i4gDL\n\tPolaus7VW86Rut/P1YzeGS/z0jgn5WihTDevreos=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?St=C3=A9phane_Cerveau?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200611102614.14355-1-scerveau@collabora.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<28acf1b6-2c54-e71d-7b51-17248785161d@ideasonboard.com>","Date":"Fri, 12 Jun 2020 09:27:45 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200611102614.14355-1-scerveau@collabora.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v5] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 12 Jun 2020 08:27:49 -0000"}},{"id":5189,"web_url":"https://patchwork.libcamera.org/comment/5189/","msgid":"<20200612085020.GD5957@pendragon.ideasonboard.com>","date":"2020-06-12T08:50:20","subject":"Re: [libcamera-devel] [PATCH v5] meson: detect kernel version","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stéphane,\n\nThank you for the patch.\n\nOn Thu, Jun 11, 2020 at 12:26:14PM +0200, Stéphane Cerveau wrote:\n> Add kernel version detection to warn user\n> that only >= 5.0.0 V4L API are supported in\n> libcamera.\n> \n> Signed-off-by: Stéphane Cerveau \n> ---\n> meson.build | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index e898782..69d2d63 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -105,6 +105,15 @@ if get_option('test')\n> subdir('test')\n> endif\n> \n> +if not meson.is_cross_build()\n> + kernel_version_req = '>= 5.0.0'\n\nWe use 4 spaces indentation in meson.build files.\n\n> + kernel_version = run_command('uname', '-r').stdout()\n\nYou should add .strip() here to remove the trailing newline output by\nuname. version_compare() will cope, but printing kernel_version (see\nbelow) would output an extra newline in the middle.\n\n> + if not kernel_version.version_compare(kernel_version_req)\n> + warning('Consider upgrading your kernel, as only @0@ is supported by libcamera at runtime'\n> + .format(kernel_version_req))\n\nEven when not cross-building, it may be possible to build libcamera on a\ndifferent machine than the target machine. How about wording the message\nas follows ?\n\n warning('The current running kernel version @0@ is too old to run libcamera.'\n .format(kernel_version))\n warning('If you intend to use libcamera on this maching, please upgrade to kernel @0@.'\n .format(kernel_version_req))\n\nSplitting the warning in two lines doesn't just make it more readable in\nthe meson.build file, but also on the output of meson.\n\n> + endif\n> +endif\n> +\n> # Create a symlink from the build root to the source root. This is used when\n> # running libcamera from the build directory to locate resources in the source\n> # directory (such as IPA configuration files).","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B06E2603C7\n\tfor ;\n\tFri, 12 Jun 2020 10:50:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2530A24F;\n\tFri, 12 Jun 2020 10:50:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"heJ0qrwB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591951841;\n\tbh=hIiV4GsiRtiZwHaoYviS1+px+r21B0R7lWUBWJLrYGs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=heJ0qrwB1/lnQXJGCQsbyBaT97A8pHQVFN/DRElokoyMsrY+m1u9DFTFj68ikC+3y\n\tqjpZvsuCs23xLDvuXb9tWfxGJWE/M4MTqBCzh5vibW847ewvxk1Nnnl5+C0+TPsIQd\n\tHfmsKGxaWbwQpbsnYGGlw3HIwX7kQ5tsFf3hvFyY=","Date":"Fri, 12 Jun 2020 11:50:20 +0300","From":"Laurent Pinchart ","To":"=?utf-8?b?U3TDqXBoYW5l?= Cerveau ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200612085020.GD5957@pendragon.ideasonboard.com>","References":"<20200611102614.14355-1-scerveau@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200611102614.14355-1-scerveau@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH v5] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 12 Jun 2020 08:50:41 -0000"}}]