[{"id":5176,"web_url":"https://patchwork.libcamera.org/comment/5176/","msgid":"<0e9b3ccb-19c7-c567-949c-79031710e06d@ideasonboard.com>","date":"2020-06-11T09:09:05","subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Stéphane,\n\nOn 11/06/2020 09:43, Stéphane Cerveau wrote:\n> Add kernel version detection to warn user\n> that only >= 5.0.0 V4L API are supported in\n> libcamera.\n> \n> Signed-off-by: Stéphane Cerveau \n> ---\n> meson.build | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index e898782..a72fef6 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -105,6 +105,14 @@ if get_option('test')\n> subdir('test')\n> endif\n> \n> +if not meson.is_cross_build()\n> + kernel_version_req = '>= 5.0.0'\n> + kernel_version = run_command('uname', '-r').stdout()\n\n> meson.build:112: WARNING: V4L2 API version 5.4.0-33-generic\n> is too old, >= 5.8.0 is required, consider to upgrade your kernel version to use libcamera\n\nThis needs a .strip() at the end to remove the new lines:\n\n> + if not kernel_version.version_compare(kernel_version_req)\n> + warning('V4L2 API version @0@ is too old, @1@ is required, consider to upgrade your kernel version to use \nlibcamera'.format(kernel_version, kernel_version_req))\n\nThat line is really long, can it be reduced? At the very least, the\n.format() can move to a new line I believe.\n\n\nGrammatically I think this should be :\n \"consider upgrading your\"\nrather than\n \"consider to upgrade\"\n\nbut that's longer ;-(\n\n\n\"WARNING: V4L2 API version 5.4.0-33-generic\"\n\nThat's not really the V4L2 API version (I mean I guess it is) but it's\nthe Linux-kernel version...\n\nSo I wouldn't reference the V4L2 API there ...\n\n\n> + endif\n> +endif\n> +\n> # Create a symlink from the build root to the source root. This is used when\n> # running libcamera from the build directory to locate resources in the source\n> # directory (such as IPA configuration files).\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CAAB61027\n\tfor ;\n\tThu, 11 Jun 2020 11:09:08 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD4472C9;\n\tThu, 11 Jun 2020 11:09:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nWzKEsUB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591866547;\n\tbh=8U9ii41QfDcd7W2bjf8x1DxiNl3uDjoRb6stC34Iew8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=nWzKEsUB4K3CVYM9z9HX86L1N7Ssz7VuLB2bOm7oTSyhrwJuuV2A4xLwJr98dHVPZ\n\t792rD0x8ckfDQtYCVBFblLRbodCKmg4gnF2HrNvRDbwITCEmAsxOUxP0XuNuJTy/8I\n\tviH6XjappkKp+zfjgVBM1ZAkT8rthOZetZ3PiQh4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?St=C3=A9phane_Cerveau?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200611084329.4648-1-scerveau@collabora.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0e9b3ccb-19c7-c567-949c-79031710e06d@ideasonboard.com>","Date":"Thu, 11 Jun 2020 10:09:05 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200611084329.4648-1-scerveau@collabora.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 09:09:08 -0000"}},{"id":5177,"web_url":"https://patchwork.libcamera.org/comment/5177/","msgid":"<5cfb5975-8892-15e0-cca3-8307b56d5e31@collabora.com>","date":"2020-06-11T09:32:33","subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","submitter":{"id":54,"url":"https://patchwork.libcamera.org/api/people/54/","name":"Stéphane Cerveau","email":"scerveau@collabora.com"},"content":"Hi Kieran,\n\nThank you for your feedback.\nI updated the message to be shorter and more explicit (I hope).\n\nConcerning V4L2 message, yes that's the original issue I was facing :) \nNot understand what I neeed to do fix this error:\n\nV4L2 API v4.15.18 too old, v5.0.0 or later\n\nMaybe we should fix this message too :)\n\nStéphane.\n\nOn 11/6/20 11:09, Kieran Bingham wrote:\n> Hi Stéphane,\n> \n> On 11/06/2020 09:43, Stéphane Cerveau wrote:\n>> Add kernel version detection to warn user\n>> that only >= 5.0.0 V4L API are supported in\n>> libcamera.\n>>\n>> Signed-off-by: Stéphane Cerveau \n>> ---\n>> meson.build | 8 ++++++++\n>> 1 file changed, 8 insertions(+)\n>>\n>> diff --git a/meson.build b/meson.build\n>> index e898782..a72fef6 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -105,6 +105,14 @@ if get_option('test')\n>> subdir('test')\n>> endif\n>> \n>> +if not meson.is_cross_build()\n>> + kernel_version_req = '>= 5.0.0'\n>> + kernel_version = run_command('uname', '-r').stdout()\n> \n>> meson.build:112: WARNING: V4L2 API version 5.4.0-33-generic\n>> is too old, >= 5.8.0 is required, consider to upgrade your kernel version to use libcamera\n> \n> This needs a .strip() at the end to remove the new lines:\n> \n>> + if not kernel_version.version_compare(kernel_version_req)\n>> + warning('V4L2 API version @0@ is too old, @1@ is required, consider to upgrade your kernel version to use\n> libcamera'.format(kernel_version, kernel_version_req))\n> \n> That line is really long, can it be reduced? At the very least, the\n> .format() can move to a new line I believe.\n> \n> \n> Grammatically I think this should be :\n> \"consider upgrading your\"\n> rather than\n> \"consider to upgrade\"\n> \n> but that's longer ;-(\n> \n> \n> \"WARNING: V4L2 API version 5.4.0-33-generic\"\n> \n> That's not really the V4L2 API version (I mean I guess it is) but it's\n> the Linux-kernel version...\n> \n> So I wouldn't reference the V4L2 API there ...\n> \n> \n>> + endif\n>> +endif\n>> +\n>> # Create a symlink from the build root to the source root. This is used when\n>> # running libcamera from the build directory to locate resources in the source\n>> # directory (such as IPA configuration files).\n>>\n>","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B2EB60C4E\n\tfor ;\n\tThu, 11 Jun 2020 11:32:37 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: scerveau) with ESMTPSA id 726FE2A23E6"],"To":"libcamera-devel@lists.libcamera.org","References":"<20200611084329.4648-1-scerveau@collabora.com>\n\t<0e9b3ccb-19c7-c567-949c-79031710e06d@ideasonboard.com>","From":"scerveau ","Message-ID":"<5cfb5975-8892-15e0-cca3-8307b56d5e31@collabora.com>","Date":"Thu, 11 Jun 2020 11:32:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<0e9b3ccb-19c7-c567-949c-79031710e06d@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 09:32:37 -0000"}},{"id":5178,"web_url":"https://patchwork.libcamera.org/comment/5178/","msgid":"<120c83a8-4929-be89-3bb2-925fbda46908@ideasonboard.com>","date":"2020-06-11T09:53:25","subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Stéphane\n\nOn 11/06/2020 10:32, scerveau wrote:\n> Hi Kieran,\n> \n> Thank you for your feedback.\n> I updated the message to be shorter and more explicit (I hope).\n> \n> Concerning V4L2 message, yes that's the original issue I was facing :)\n> Not understand what I neeed to do fix this error:\n> \n> V4L2 API v4.15.18 too old, v5.0.0 or later\n> \n> Maybe we should fix this message too :)\n\nAha - so the V4L2VideoDevice already does the check. I see. And that\nwill indeed prevent pipelines from being created.\n\nBelow I think I was really just being pedantic about the message\nprinted, as it is the kernel version not a 'v4l2 api' version (though\nthose are the same thing ultimately).\n\n\n> \n> Stéphane.\n> \n> On 11/6/20 11:09, Kieran Bingham wrote:\n>> Hi Stéphane,\n>>\n>> On 11/06/2020 09:43, Stéphane Cerveau wrote:\n>>> Add kernel version detection to warn user\n>>> that only >= 5.0.0 V4L API are supported in\n>>> libcamera.\n>>>\n>>> Signed-off-by: Stéphane Cerveau \n>>> ---\n>>>   meson.build | 8 ++++++++\n>>>   1 file changed, 8 insertions(+)\n>>>\n>>> diff --git a/meson.build b/meson.build\n>>> index e898782..a72fef6 100644\n>>> --- a/meson.build\n>>> +++ b/meson.build\n>>> @@ -105,6 +105,14 @@ if get_option('test')\n>>>       subdir('test')\n>>>   endif\n>>>   +if not meson.is_cross_build()\n>>> +  kernel_version_req = '>= 5.0.0'\n>>> +  kernel_version = run_command('uname', '-r').stdout()\n>>\n>>> meson.build:112: WARNING: V4L2 API version 5.4.0-33-generic\n>>>   is too old, >= 5.8.0 is required, consider to upgrade your kernel\n>>> version to use libcamera\n>>\n>> This needs a .strip() at the end to remove the new lines:\n>>\n>>> +  if not kernel_version.version_compare(kernel_version_req)\n>>> +    warning('V4L2 API version @0@ is too old, @1@ is required,\n>>> consider to upgrade your kernel version to use\n>> libcamera'.format(kernel_version, kernel_version_req))\n>>\n>> That line is really long, can it be reduced? At the very least, the\n>> .format() can move to a new line I believe.\n>>\n>>\n>> Grammatically I think this should be :\n>>   \"consider upgrading your\"\n>> rather than\n>>   \"consider to upgrade\"\n>>\n>> but that's longer ;-(\n>>\n>>\n>> \"WARNING: V4L2 API version 5.4.0-33-generic\"\n>>\n>> That's not really the V4L2 API version (I mean I guess it is) but it's\n>> the Linux-kernel version...\n>>\n>> So I wouldn't reference the V4L2 API there ...\n>>\n>>\n>>> +  endif\n>>> +endif\n>>> +\n>>>   # Create a symlink from the build root to the source root. This is\n>>> used when\n>>>   # running libcamera from the build directory to locate resources in\n>>> the source\n>>>   # directory (such as IPA configuration files).\n>>>\n>>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADED260C4E\n\tfor ;\n\tThu, 11 Jun 2020 11:53:28 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22EDE2C9;\n\tThu, 11 Jun 2020 11:53:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bu+2hkfU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591869208;\n\tbh=r1bkvDkWHOYdj4pyGDHIDm5XilI8Cri0dQlc+llM9Dg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bu+2hkfUd+VRPtb7klrL/mZRdM9wQrS4jG8VfmiAxEaaIpdjg6CMWDdv4Qo/7qu9n\n\t+EbkhUV4kCb43urje9DO0LcuUBTazBG23Lo1uYzj1AB73VshqRR4SEDmNoclqcpElU\n\t75vgAOEIwDbN39iq2Xpm4KZx3OjioHYjoNwoFWTk=","Reply-To":"kieran.bingham@ideasonboard.com","To":"scerveau , libcamera-devel@lists.libcamera.org","References":"<20200611084329.4648-1-scerveau@collabora.com>\n\t<0e9b3ccb-19c7-c567-949c-79031710e06d@ideasonboard.com>\n\t<5cfb5975-8892-15e0-cca3-8307b56d5e31@collabora.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<120c83a8-4929-be89-3bb2-925fbda46908@ideasonboard.com>","Date":"Thu, 11 Jun 2020 10:53:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<5cfb5975-8892-15e0-cca3-8307b56d5e31@collabora.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 09:53:28 -0000"}},{"id":5179,"web_url":"https://patchwork.libcamera.org/comment/5179/","msgid":"","date":"2020-06-11T10:05:58","subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","submitter":{"id":54,"url":"https://patchwork.libcamera.org/api/people/54/","name":"Stéphane Cerveau","email":"scerveau@collabora.com"},"content":"Hi Kieran,\n\n\nOn 11/6/20 11:53, Kieran Bingham wrote:\n> Hi Stéphane\n> \n> On 11/06/2020 10:32, scerveau wrote:\n>> Hi Kieran,\n>>\n>> Thank you for your feedback.\n>> I updated the message to be shorter and more explicit (I hope).\n>>\n>> Concerning V4L2 message, yes that's the original issue I was facing :)\n>> Not understand what I neeed to do fix this error:\n>>\n>> V4L2 API v4.15.18 too old, v5.0.0 or later\n>>\n>> Maybe we should fix this message too :)\n> \nYes but the message is not very obvious as it can be confusing with v4L\nlibrary version, dont you think ?\n\n> Aha - so the V4L2VideoDevice already does the check. I see. And that\n> will indeed prevent pipelines from being created.\n> \n> Below I think I was really just being pedantic about the message\n> printed, as it is the kernel version not a 'v4l2 api' version (though\n> those are the same thing ultimately).\n> \n> \n>>\n>> Stéphane.\n>>\n>> On 11/6/20 11:09, Kieran Bingham wrote:\n>>> Hi Stéphane,\n>>>\n>>> On 11/06/2020 09:43, Stéphane Cerveau wrote:\n>>>> Add kernel version detection to warn user\n>>>> that only >= 5.0.0 V4L API are supported in\n>>>> libcamera.\n>>>>\n>>>> Signed-off-by: Stéphane Cerveau \n>>>> ---\n>>>>   meson.build | 8 ++++++++\n>>>>   1 file changed, 8 insertions(+)\n>>>>\n>>>> diff --git a/meson.build b/meson.build\n>>>> index e898782..a72fef6 100644\n>>>> --- a/meson.build\n>>>> +++ b/meson.build\n>>>> @@ -105,6 +105,14 @@ if get_option('test')\n>>>>       subdir('test')\n>>>>   endif\n>>>>   +if not meson.is_cross_build()\n>>>> +  kernel_version_req = '>= 5.0.0'\n>>>> +  kernel_version = run_command('uname', '-r').stdout()\n>>>\n>>>> meson.build:112: WARNING: V4L2 API version 5.4.0-33-generic\n>>>>   is too old, >= 5.8.0 is required, consider to upgrade your kernel\n>>>> version to use libcamera\n>>>\n>>> This needs a .strip() at the end to remove the new lines:\n>>>\n>>>> +  if not kernel_version.version_compare(kernel_version_req)\n>>>> +    warning('V4L2 API version @0@ is too old, @1@ is required,\n>>>> consider to upgrade your kernel version to use\n>>> libcamera'.format(kernel_version, kernel_version_req))\n>>>\n>>> That line is really long, can it be reduced? At the very least, the\n>>> .format() can move to a new line I believe.\n>>>\n>>>\n>>> Grammatically I think this should be :\n>>>   \"consider upgrading your\"\n>>> rather than\n>>>   \"consider to upgrade\"\n>>>\n>>> but that's longer ;-(\n>>>\n>>>\n>>> \"WARNING: V4L2 API version 5.4.0-33-generic\"\n>>>\n>>> That's not really the V4L2 API version (I mean I guess it is) but it's\n>>> the Linux-kernel version...\n>>>\n>>> So I wouldn't reference the V4L2 API there ...\n>>>\n>>>\n>>>> +  endif\n>>>> +endif\n>>>> +\n>>>>   # Create a symlink from the build root to the source root. This is\n>>>> used when\n>>>>   # running libcamera from the build directory to locate resources in\n>>>> the source\n>>>>   # directory (such as IPA configuration files).\n>>>>\n>>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9F36610A5\n\tfor ;\n\tThu, 11 Jun 2020 12:06:02 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: scerveau) with ESMTPSA id 18FC72A4B47"],"To":"kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org","References":"<20200611084329.4648-1-scerveau@collabora.com>\n\t<0e9b3ccb-19c7-c567-949c-79031710e06d@ideasonboard.com>\n\t<5cfb5975-8892-15e0-cca3-8307b56d5e31@collabora.com>\n\t<120c83a8-4929-be89-3bb2-925fbda46908@ideasonboard.com>","From":"scerveau ","Message-ID":"","Date":"Thu, 11 Jun 2020 12:05:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<120c83a8-4929-be89-3bb2-925fbda46908@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 10:06:03 -0000"}}]