[{"id":631,"web_url":"https://patchwork.libcamera.org/comment/631/","msgid":"<20190127002856.GW4127@bigcity.dyn.berto.se>","date":"2019-01-27T00:28:56","subject":"Re: [libcamera-devel] [RFC 1/3] libcamera: stream: Add setters for\n\timage sizes and format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-01-26 16:13:16 +0100, Jacopo Mondi wrote:\n> Add methods to set width, height and pixelformat of a\n> StreamConfiguration instance.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/stream.h | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 8750797..ef7b32a 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -33,6 +33,10 @@ public:\n> \tvoid setDimension(unsigned int width, unsigned int height);\n> \tvoid setPixelFormat(unsigned int pixelformat);\n> \n> +\tvoid setWidth(unsigned int width) { width_ = width; }\n> +\tvoid setHeight(unsigned int height) { height_ = height; }\n> +\tvoid setPixelformat(unsigned int pix) { pixelformat_ = pix; }\n\nThis looks odd, there is already a setPixelFormat() defined just above. \nIn any case when you rebase this RFC all parameters of \nStreamConfiguration are now public so no longer a need for setters and \ngetters :-)\n\n> +\n> private:\n> \tunsigned int id_;\n> \tunsigned int width_;\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FF7060B2D\n\tfor ;\n\tSun, 27 Jan 2019 01:28:58 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id n18so9414937lfh.6\n\tfor ;\n\tSat, 26 Jan 2019 16:28:58 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\te13-v6sm2320227ljk.53.2019.01.26.16.28.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 26 Jan 2019 16:28:56 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=aaFxDalUkLrd6Bi6btNp2WyssVOhekXF7pD1QqTkKiY=;\n\tb=FfgAwhwEdaJjCYRoJ1ajHcfKn09OjtLZ/z5fsjnuBA01ufeABf+njLQcWDxlAFtD+J\n\tyVOkaUTWOPhXnpcIVHb7p717zcgs6ME3B/r/2laAaElLPHQgpgitMdUBZDQdJ67vkTOM\n\tn/nrkr7r6shSktDQhBhni+y+Z8iriyuV/MUxEKyT59LX5ZNNLGVhULxGQN8OEAZ4pnWd\n\teJU12xJUHVgSnxh8gKd4sWWRJ5b6CBuvgrHKVYL05Wp60Lh+hGThYUsYQmuGpNZPr1z/\n\t7M+WZ+LFmhDu98tdtx9L77CsxTMY0WaNJ1dER6/WgzH6WWOKgcbljNyGqks91tZ77asc\n\tREjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=aaFxDalUkLrd6Bi6btNp2WyssVOhekXF7pD1QqTkKiY=;\n\tb=uMSKQKTEFknkDn8JtX1aXzJ4mkd2glKrYkD8FIemz1LoFPhWf8IgeE5TWMx4obPi11\n\tgyqBGoGzyz5fsdPtEA62FaHLEsE5YVGGOwWtLdxpitaSB1hDvtQyTo3TufiP8e8dtg7W\n\tuYx26vAWVqlICBKq80f7hyiHX5Jp6MGpnSbVDILrJP0TGUOkZJEUg3xBi+mSZxw6AClx\n\tvG59ob8tVQZS88VlTIHngV0w/ue/l8RbDhOsGz3M9tee7pi7D8BKaZwH7Ic4mPD+HjkX\n\tIHf1rFA9yTfUwLJRBq3EZy7bLf/7jDHu0NAfaoC5R10wfJyMX8EJ683Lh0PsnLOKF80p\n\tPpvg==","X-Gm-Message-State":"AJcUukc01C7JTfN9ysJvo9zv2Grf2ZAfzV2WFEhdaRw/GTtrhdPOJqb+\n\tNXucJsGGzYpAAx252KoYD4Y0qiSBaIU=","X-Google-Smtp-Source":"ALg8bN5NxyuP5DyE05FBu44pMNzgjd20ry0x/sqhOsCjUmBVkVWejt/nlJ2JXTwKyG1IkMZ//2l0OA==","X-Received":"by 2002:a19:1bd2:: with SMTP id\n\tb201mr12369987lfb.136.1548548937320; \n\tSat, 26 Jan 2019 16:28:57 -0800 (PST)","Date":"Sun, 27 Jan 2019 01:28:56 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190127002856.GW4127@bigcity.dyn.berto.se>","References":"<20190126151318.28087-1-jacopo@jmondi.org>\n\t<20190126151318.28087-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190126151318.28087-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 1/3] libcamera: stream: Add setters for\n\timage sizes and format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Jan 2019 00:28:58 -0000"}},{"id":635,"web_url":"https://patchwork.libcamera.org/comment/635/","msgid":"<20190127102207.tjmp6hiynm4xtxdf@uno.localdomain>","date":"2019-01-27T10:22:08","subject":"Re: [libcamera-devel] [RFC 1/3] libcamera: stream: Add setters for\n\timage sizes and format","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Sun, Jan 27, 2019 at 01:28:56AM +0100, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2019-01-26 16:13:16 +0100, Jacopo Mondi wrote:\n> > Add methods to set width, height and pixelformat of a\n> > StreamConfiguration instance.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/stream.h | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > index 8750797..ef7b32a 100644\n> > --- a/include/libcamera/stream.h\n> > +++ b/include/libcamera/stream.h\n> > @@ -33,6 +33,10 @@ public:\n> > \tvoid setDimension(unsigned int width, unsigned int height);\n> > \tvoid setPixelFormat(unsigned int pixelformat);\n> >\n> > +\tvoid setWidth(unsigned int width) { width_ = width; }\n> > +\tvoid setHeight(unsigned int height) { height_ = height; }\n> > +\tvoid setPixelformat(unsigned int pix) { pixelformat_ = pix; }\n>\n> This looks odd, there is already a setPixelFormat() defined just above.\n> In any case when you rebase this RFC all parameters of\n> StreamConfiguration are now public so no longer a need for setters and\n> getters :-)\n>\n\nYou are correct. Please ignore this patch.\n\nThanks\n j\n\n> > +\n> > private:\n> > \tunsigned int id_;\n> > \tunsigned int width_;\n> > --\n> > 2.20.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD66960C6A\n\tfor ;\n\tSun, 27 Jan 2019 11:21:53 +0100 (CET)","from uno.localdomain\n\t(host20-49-dynamic.18-79-r.retail.telecomitalia.it [79.18.49.20])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3304A40004;\n\tSun, 27 Jan 2019 10:21:52 +0000 (UTC)"],"X-Originating-IP":"79.18.49.20","Date":"Sun, 27 Jan 2019 11:22:08 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190127102207.tjmp6hiynm4xtxdf@uno.localdomain>","References":"<20190126151318.28087-1-jacopo@jmondi.org>\n\t<20190126151318.28087-2-jacopo@jmondi.org>\n\t<20190127002856.GW4127@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"qne7hsjvvmfgb2gj\"","Content-Disposition":"inline","In-Reply-To":"<20190127002856.GW4127@bigcity.dyn.berto.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [RFC 1/3] libcamera: stream: Add setters for\n\timage sizes and format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Jan 2019 10:21:53 -0000"}}]