[{"id":5171,"web_url":"https://patchwork.libcamera.org/comment/5171/","msgid":"<857d1ea7d10690af009209743f98412cad8c416d.camel@ndufresne.ca>","date":"2020-06-10T21:15:41","subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mercredi 10 juin 2020 à 17:39 +0200, Stéphane Cerveau a écrit :\n> Add kernel version detection to warn user\n> that only >= 5.0.0 V4L API are supported in\n> libcamera.\n> \n> Signed-off-by: Stéphane Cerveau \n> ---\n> meson.build | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index e898782..5063edb 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -105,6 +105,12 @@ if get_option('test')\n> subdir('test')\n> endif\n> \n> +kernel_version_req = '>= 5.0.0'\n> +kernel_version = run_command('uname', '-r').stdout()\n> +if not kernel_version.version_compare(kernel_version_req)\n> + warning('V4L2 API version @0@ is too old, @1@ is required, consider to upgrade your kernel version to use libcamera'.format(kernel_version, kernel_version_req))\n> +endif\n\nThis should not be checked for cross builds. Perhaps it could be made\nconditional to meson.is_cross_build() not be set ? It remains error\nprone as the host kernel may differ from the target kernel even without\ncross compilation.\n\n> +\n> # Create a symlink from the build root to the source root. This is used when\n> # running libcamera from the build directory to locate resources in the source\n> # directory (such as IPA configuration files).","headers":{"Return-Path":"","Received":["from mail-qt1-x843.google.com (mail-qt1-x843.google.com\n\t[IPv6:2607:f8b0:4864:20::843])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD7726002E\n\tfor ;\n\tWed, 10 Jun 2020 23:15:43 +0200 (CEST)","by mail-qt1-x843.google.com with SMTP id g62so3009942qtd.5\n\tfor ;\n\tWed, 10 Jun 2020 14:15:43 -0700 (PDT)","from skullcanyon ([192.222.193.21])\n\tby smtp.gmail.com with ESMTPSA id\n\tw13sm724206qkb.91.2020.06.10.14.15.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Jun 2020 14:15:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ndufresne-ca.20150623.gappssmtp.com\n\theader.i=@ndufresne-ca.20150623.gappssmtp.com header.b=\"oXVkTv3y\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=xrPZKRsEvMp+TE41Zhgfk64eBMaG1A8Aja3L/YqIo2Q=;\n\tb=oXVkTv3yyUc4O6vNYXTcAnVKKhKZvZFDfQNDtXN7CD89+fdCP+6QMKnPwgnQyGX3Jk\n\twFxWORCPi27j8w8JbVaWD8qiw+XSOTEkBXt/96Oi5pi4C9o6/7BBhR/BDTytLTSxleia\n\tUM0svAgNz75HVcKZbZI7JvF+8Rg4nA0+QMqjQoXf7EsrFxYk9TMRUq+kRz1TXlMMXUrS\n\tA5+pARzGsAo0gOud/eUV3v1F2PZLsjbt65Yz2lfudzVaYu7CgnhbjsMR2Nl5faJjVVRE\n\tXVN5eSeAtYPkBdRMAwjazouKeAYg7ZvgeMTefQFn1nmLyHhj3HYJiaVM3corQ4fOLQAb\n\tfNew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=xrPZKRsEvMp+TE41Zhgfk64eBMaG1A8Aja3L/YqIo2Q=;\n\tb=hRBXb3B8zcCjnYiz2r2QavRTBYGsAA7MuFMZ+OjfOHNlKLu4hhUZxjA6G+/vD3dqRy\n\t+ECtXuW0NPZsLjaBGfbr92FvAXAYDOZoTFoojRl+HBdaH9S7otMk7/HYMxVbBs6gzxgm\n\t5h58Nmp5zNQPBQl41tdV9UOtJ5x5jIkKCr76Vj01UASSrcQAyjGJILw2YFR7OWnRiWht\n\tj7/dNrv71yycsYcu9mHxJLYHWbl0pDdA8a1fva2hRHlGKHFRU1m/GF4e6YsQZYK0uGSP\n\tvTM2twVqLnLi3+xCz3biHIZ0i/OUBssVicNEVxZfvRiYhdZ/WiAx+CgyRoMOt1hK/vtN\n\tzALQ==","X-Gm-Message-State":"AOAM533Qo5PKN0vuOEHhB6hygATNScy/+pY7cxizSoSSNZVawG9eW42/\n\tZOW4TAPks8k+VyisDe0nstDFoA==","X-Google-Smtp-Source":"ABdhPJyQmX0nY3AxO1GJKJTWQBH+1kXPoy7BndHUE7Oy/vz2lH+n0TradBgtikd9Tg9Omzw441dbxw==","X-Received":"by 2002:ac8:5354:: with SMTP id\n\td20mr5536380qto.363.1591823742467; \n\tWed, 10 Jun 2020 14:15:42 -0700 (PDT)","Message-ID":"<857d1ea7d10690af009209743f98412cad8c416d.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"=?iso-8859-1?q?St=E9phane?= Cerveau ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 10 Jun 2020 17:15:41 -0400","In-Reply-To":"<20200610153936.3469-1-scerveau@collabora.com>","References":"<20200610153936.3469-1-scerveau@collabora.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.36.3 (3.36.3-1.fc32) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 10 Jun 2020 21:15:44 -0000"}},{"id":5174,"web_url":"https://patchwork.libcamera.org/comment/5174/","msgid":"","date":"2020-06-11T07:48:00","subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 10/06/2020 22:15, Nicolas Dufresne wrote:\n> Le mercredi 10 juin 2020 à 17:39 +0200, Stéphane Cerveau a écrit :\n>> Add kernel version detection to warn user\n>> that only >= 5.0.0 V4L API are supported in\n>> libcamera.\n>>\n>> Signed-off-by: Stéphane Cerveau \n>> ---\n>> meson.build | 6 ++++++\n>> 1 file changed, 6 insertions(+)\n>>\n>> diff --git a/meson.build b/meson.build\n>> index e898782..5063edb 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -105,6 +105,12 @@ if get_option('test')\n>> subdir('test')\n>> endif\n>> \n>> +kernel_version_req = '>= 5.0.0'\n>> +kernel_version = run_command('uname', '-r').stdout()\n>> +if not kernel_version.version_compare(kernel_version_req)\n>> + warning('V4L2 API version @0@ is too old, @1@ is required, consider to upgrade your kernel version to use libcamera'.format(kernel_version, kernel_version_req))\n>> +endif\n> \n> This should not be checked for cross builds. Perhaps it could be made\n> conditional to meson.is_cross_build() not be set ? It remains error\n> prone as the host kernel may differ from the target kernel even without\n> cross compilation.\n\n\nIndeed,\n\nPerhaps we should add some LOG(Media, Fatal) when enumerating the\ndevices at runtime which will print a more meaningful message based on\nthe kernel version given by the devices?\n\n--\nKieran\n\n\n> \n>> +\n>> # Create a symlink from the build root to the source root. This is used when\n>> # running libcamera from the build directory to locate resources in the source\n>> # directory (such as IPA configuration files).\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F415561027\n\tfor ;\n\tThu, 11 Jun 2020 09:48:03 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6E8E26A;\n\tThu, 11 Jun 2020 09:48:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uJhVs+u0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591861683;\n\tbh=yEjzJI3PeHgOY+GMqKUqL7PFpg0tRWTMdc69RETw5d8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=uJhVs+u0y+692EL1oi9ARp4t93kC3ht24Oilbh6FbRhhDKEE7gX438KHIdVFO5NjK\n\t7igSjn7pOLtZCazW2KZEoX4BE+2Z41nbikHHnadCgqJQ9bnDa4cmRkEM/sJcaGU1C2\n\tldQDC0ZHOcflsPLeNkv5JxsYgREvVnCErHJVEMUg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Nicolas Dufresne , =?utf-8?q?St=C3=A9phane_Cerve?=\n\t=?utf-8?q?au?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200610153936.3469-1-scerveau@collabora.com>\n\t<857d1ea7d10690af009209743f98412cad8c416d.camel@ndufresne.ca>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 11 Jun 2020 08:48:00 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<857d1ea7d10690af009209743f98412cad8c416d.camel@ndufresne.ca>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] meson: detect kernel version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 11 Jun 2020 07:48:04 -0000"}}]