[{"id":5166,"web_url":"https://patchwork.libcamera.org/comment/5166/","msgid":"<20200610144002.GG192296@oden.dyn.berto.se>","date":"2020-06-10T14:40:02","subject":"Re: [libcamera-devel] [PATCH v2 5/7] test: Replace explicit DRM\n\tFourCCs with libcamera formats","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-06-10 02:23:21 +0300, Laurent Pinchart wrote:\n> Use the new pixel format constants to replace usage of macros from\n> drm_fourcc.h.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/v4l2_videodevice/buffer_cache.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\n> index d730e7550377..b22de88e214c 100644\n> --- a/test/v4l2_videodevice/buffer_cache.cpp\n> +++ b/test/v4l2_videodevice/buffer_cache.cpp\n> @@ -9,6 +9,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> \n> #include \"buffer_source.h\"\n> @@ -142,7 +143,7 @@ public:\n> \t\tconst unsigned int numBuffers = 8;\n> \n> \t\tStreamConfiguration cfg;\n> -\t\tcfg.pixelFormat = PixelFormat(DRM_FORMAT_YUYV);\n> +\t\tcfg.pixelFormat = formats::YUYV;\n> \t\tcfg.size = Size(600, 800);\n> \t\tcfg.bufferCount = numBuffers;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3558600F7\n\tfor ;\n\tWed, 10 Jun 2020 16:40:03 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id n24so2759995lji.10\n\tfor ;\n\tWed, 10 Jun 2020 07:40:03 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tn20sm5896753lfe.60.2020.06.10.07.40.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Jun 2020 07:40:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"b0dK677p\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=JdK0JSWTqXfqnRkiVvr69XEoXJPTkpjz2DXiyRWEZUE=;\n\tb=b0dK677pAlTNged8Z0nv56NYaagI8QdOwXHR1pcDxJKy1UHzTIbccW+X37Ef3st+X0\n\t1Ot/vumSMXmPPVMX2WyfMvckuh/Bcuy6hfwZTctDCon9qYcfBOoCkEP3macBbkHzFpGj\n\tYIeMNmHk7Mo+OWFTAgbKDSJDIzy0FgZgytISqhuRb5HWqfsG9zoG2vRVGfwJQWxb7OQs\n\tPgQqtJkFYMEfVj7VXdUZObad9E4l1t+9Ivn843OHhQTPg+J13t2SOPhtDfXjhQ+UoxFf\n\tmP1sG1uVDKod9TD9EwcbNy8CA5PJU7LWtCXIhwyywOJpZXOnM4+uDKUYMdxdmKUNLzcj\n\t1kpQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=JdK0JSWTqXfqnRkiVvr69XEoXJPTkpjz2DXiyRWEZUE=;\n\tb=LaKRBBI4yj9l2DMPfVV5YSBr8YTAOpd2kv10h9gKiIcujX9iPI5/UoOG2D89gZp4ft\n\tQD9nraf3Z+RT8/0igp0wLR3fZR8nyUej8sANWJ8bC7uY3YDI1/2CzifHL8cIQTZ9497e\n\tyJ5c6w8tIRZaIexHmvXhyJOQX9nlsNWeve/MWSUnXguhyXharKKTqzqZ/B02NsEGOx86\n\txcbFFuzEIvV1tyc/TvoOtnfMGx2p/sqAzk8O+8tsv82W9gi5sjSoZIIEesPrdxRhIfjZ\n\t0uHkC0rNLW2qH/gG4DszKag/G7WdM7LbTkSPyc+/0eBx0ZWZ8NYeJtlEQYbWBET15K3I\n\tZzTg==","X-Gm-Message-State":"AOAM530IGjOl7jvqro/7nce2Y+VZHKMecgR8nzrLTyO5MBWDjB7VSDZc\n\tx0G2OQqj6JsD3ofFRmNLoRVsZg==","X-Google-Smtp-Source":"ABdhPJzgpl7GAeCTSPiqGCU7pacZz44jzgWhepcFcybxAbZS5kkD9DY2PUE3e5tz2lnxXKDws3dZBw==","X-Received":"by 2002:a2e:3111:: with SMTP id x17mr1255082ljx.33.1591800003286;\n\tWed, 10 Jun 2020 07:40:03 -0700 (PDT)","Date":"Wed, 10 Jun 2020 16:40:02 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200610144002.GG192296@oden.dyn.berto.se>","References":"<20200609232323.29628-1-laurent.pinchart@ideasonboard.com>\n\t<20200609232323.29628-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200609232323.29628-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/7] test: Replace explicit DRM\n\tFourCCs with libcamera formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 10 Jun 2020 14:40:04 -0000"}}]