[{"id":5155,"web_url":"https://patchwork.libcamera.org/comment/5155/","msgid":"<20200610121241.iq47eg2aa2j52nd6@uno.localdomain>","date":"2020-06-10T12:12:41","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Use\n\tstd::make_tuple()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Jun 10, 2020 at 12:11:10AM +0300, Laurent Pinchart wrote:\n> Until N4387 (https://wg21.link/N4387, applied as a defect report for\n> C++11), a function could not return a tuple using\n> copy-list-initialization. This affects gcc-5 that was released before\n> N4387 was integrated, and causes a compilation error:\n>\n> ../../src/android/camera_device.cpp: In member function ‘std::tuple CameraDevice::calculateStaticMetadataSize()’:\n> ../../src/android/camera_device.cpp:391:32: error: converting to ‘std::tuple’ from initializer list would use explicit constructor ‘constexpr std::tuple<_T1, _T2>::tuple(_U1&&, _U2&&) [with _U1 = unsigned int&; _U2 = unsigned int&; = void; _T1 = unsigned int; _T2 = unsigned int]’\n> return { numEntries, byteSize };\n>\n> Fix it by using std::make_tuple().\n>\n> Fixes: a80d38109f65 (\"android: camera_device: Calculate metadata size\")\n> Signed-off-by: Laurent Pinchart \n\nThanks for catching this\nAcked-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 7a0dc530e35b..c56e2355f778 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -388,7 +388,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t */\n> \tbyteSize += streamConfigurations_.size() * 52;\n>\n> -\treturn { numEntries, byteSize };\n> +\treturn std::make_tuple(numEntries, byteSize);\n> }\n>\n> /*\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AEC20600F6\n\tfor ;\n\tWed, 10 Jun 2020 14:09:19 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 2F1BA1BF213;\n\tWed, 10 Jun 2020 12:09:18 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 10 Jun 2020 14:12:41 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200610121241.iq47eg2aa2j52nd6@uno.localdomain>","References":"<20200609211110.13440-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200609211110.13440-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Use\n\tstd::make_tuple()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 10 Jun 2020 12:09:19 -0000"}},{"id":5160,"web_url":"https://patchwork.libcamera.org/comment/5160/","msgid":"<20200610134508.GB192296@oden.dyn.berto.se>","date":"2020-06-10T13:45:08","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Use\n\tstd::make_tuple()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-06-10 00:11:10 +0300, Laurent Pinchart wrote:\n> Until N4387 (https://wg21.link/N4387, applied as a defect report for\n> C++11), a function could not return a tuple using\n> copy-list-initialization. This affects gcc-5 that was released before\n> N4387 was integrated, and causes a compilation error:\n> \n> ../../src/android/camera_device.cpp: In member function ‘std::tuple CameraDevice::calculateStaticMetadataSize()’:\n> ../../src/android/camera_device.cpp:391:32: error: converting to ‘std::tuple’ from initializer list would use explicit constructor ‘constexpr std::tuple<_T1, _T2>::tuple(_U1&&, _U2&&) [with _U1 = unsigned int&; _U2 = unsigned int&; = void; _T1 = unsigned int; _T2 = unsigned int]’\n> return { numEntries, byteSize };\n> \n> Fix it by using std::make_tuple().\n> \n> Fixes: a80d38109f65 (\"android: camera_device: Calculate metadata size\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 7a0dc530e35b..c56e2355f778 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -388,7 +388,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t */\n> \tbyteSize += streamConfigurations_.size() * 52;\n> \n> -\treturn { numEntries, byteSize };\n> +\treturn std::make_tuple(numEntries, byteSize);\n> }\n> \n> /*\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40E4C60C4E\n\tfor ;\n\tWed, 10 Jun 2020 15:45:10 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id n24so2512559lji.10\n\tfor ;\n\tWed, 10 Jun 2020 06:45:10 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ti26sm5846253lfc.21.2020.06.10.06.45.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Jun 2020 06:45:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"l52A5z2A\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=rU446f86b7OXT0eFbK8ciQXvitcp8ofHqu7kU2hF5aA=;\n\tb=l52A5z2AginZJ/xUP/D1028gd7xjjS6k2theAWTYR+1JECneqc9dAWyx1ldtcYO+5i\n\tKsg8NI3vYU52hVP5OQtjQmII3CkVEGIVbLn0mp7iNAXNn2VSB7+tfvTUy4UbIWo6yCCJ\n\tO20ioRIu5z4FfMUYfroCyV5vkjoacMC/U13DzAtu/yHNbGeZMA3h7v4v7+KJo039BL/8\n\twwKXFMWkYAnqfP2yVNC38jxf9dMla2h8oOMF8ih3UcsnVmN74bQ5zeb3Dk208CsoJ94Z\n\tDXm0PuCLLwy46yPmzWa5IbZ2E0FnfYfSMl4oJRuypGZj6bbJygY/lg05zuMJyPDjhCYJ\n\t4MSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=rU446f86b7OXT0eFbK8ciQXvitcp8ofHqu7kU2hF5aA=;\n\tb=pKXvhJf80wvH91VhN4AOvIqs2e6Q6gnPCWWZxbxW4FqpBKUngrGPDyHrwgzBXsPfgZ\n\t28dqPj3M4qDLGXvR6HxAk7L31TdhWSDOxDJInv+yoHcnyJrXPj/sOwI6vUzXj/X0bwmK\n\tk9PBnZNVrx8QqGTOkcqxuuWilktquIlOptju9Trq8Ukf1Z/lWUYmIONTKIEoU3fLDncd\n\tZd4bd67CU07rZgyS8Jis9WillOZrNsAHQK3gY0ohUD3MRNozPNd9RtSxaNgNtT6xVyoF\n\tC2ouFnCqqVU1ge4uAENCQV3Lad0/o0CI3bM9Pvv6mo2eyfuIGGZgJjp2DwQu4gmIoHrc\n\tdb0A==","X-Gm-Message-State":"AOAM532EcVncGleSiRM7HoxE325tf+ZHOxptrTTDYZmHZ+Xa3IEzQCIw\n\tzx/y06sSYwkJ04PhxKNKNXe347eSsvI=","X-Google-Smtp-Source":"ABdhPJzc10rUtlryE93ZcapiEp8/x9e4uMulmtWE85JjS39zj0Okrf35tMT2cNnPLveSDrRXve5qWw==","X-Received":"by 2002:a2e:9f57:: with SMTP id\n\tv23mr1933915ljk.324.1591796709404; \n\tWed, 10 Jun 2020 06:45:09 -0700 (PDT)","Date":"Wed, 10 Jun 2020 15:45:08 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200610134508.GB192296@oden.dyn.berto.se>","References":"<20200609211110.13440-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200609211110.13440-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Use\n\tstd::make_tuple()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 10 Jun 2020 13:45:10 -0000"}}]