[{"id":10874,"web_url":"https://patchwork.libcamera.org/comment/10874/","msgid":"<20200626013841.GV5865@pendragon.ideasonboard.com>","date":"2020-06-26T01:38:41","subject":"Re: [libcamera-devel] [PATCH v2 5/6] libcamera: formats: Expose\n\tstd::map::value_type","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jun 09, 2020 at 01:28:43AM +0200, Jacopo Mondi wrote:\n> In order to prepare to replace usage of custom map in pipeline handlers,\n> expose the formats map value_type type definition, to allow pipeline\n> handlers to use STL functions to iterate the class.\n> \n> Signed-off-by: Jacopo Mondi \n\nSo we're already starting to extend the std::map API being exposed.\nDidn't take long :-) Let's discuss that as part of 3/6. I would squash\n3/6 and 5/6 together.\n\n> ---\n> include/libcamera/internal/formats.h | 2 ++\n> src/libcamera/formats.cpp | 5 +++++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> index 914fdde27d0c..1361b55d63d2 100644\n> --- a/include/libcamera/internal/formats.h\n> +++ b/include/libcamera/internal/formats.h\n> @@ -22,6 +22,8 @@ template\n> class ImageFormats\n> {\n> public:\n> +\tusing value_type = typename std::map>::value_type;\n> +\n> \tusing iterator = typename std::map>::iterator;\n> \tusing const_iterator = typename std::map>::const_iterator;\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 9f46f82c9059..5037c5928669 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -34,6 +34,11 @@ LOG_DEFINE_CATEGORY(Formats)\n> * Sizes are stored as a list of SizeRange.\n> */\n> \n> +/**\n> + * \\typedef ImageFormats::value_type\n> + * \\brief Value type of the entries in the formats map\n> + */\n> +\n> /**\n> * \\typedef ImageFormats::iterator\n> * \\brief Iterator for the formats map","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C573C0109\n\tfor ;\n\tFri, 26 Jun 2020 01:38:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C437609C8;\n\tFri, 26 Jun 2020 03:38:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13FA2603BA\n\tfor ;\n\tFri, 26 Jun 2020 03:38:44 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4629595;\n\tFri, 26 Jun 2020 03:38:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H0ZGS+iJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593135523;\n\tbh=JOhQ7RL+pPj2qO5mIIUct1pqJ/+L7qjOxCsnNV258b0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H0ZGS+iJEHVgBhcD9cKPDmhlICc55kN6eOeeSCx4tEoJjGH4IMpLTthmKRUbSuddl\n\tSs8cYXr5WIqchdAoNIYu84yXbTdfA/EWW5GMfGxDGjPgvNq1io0pf0CQtfNtRJ9Oke\n\t/aQtaDAcDhV8bDTCOyt6A607gUZuP+QekJbqqcSs=","Date":"Fri, 26 Jun 2020 04:38:41 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200626013841.GV5865@pendragon.ideasonboard.com>","References":"<20200608232844.10150-1-jacopo@jmondi.org>\n\t<20200608232844.10150-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200608232844.10150-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] libcamera: formats: Expose\n\tstd::map::value_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]