[{"id":10871,"web_url":"https://patchwork.libcamera.org/comment/10871/","msgid":"<20200626012820.GS5865@pendragon.ideasonboard.com>","date":"2020-06-26T01:28:20","subject":"Re: [libcamera-devel] [PATCH v2 3/6] libcamera: formats: Make\n\tImageFormats iterable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jun 09, 2020 at 01:28:41AM +0200, Jacopo Mondi wrote:\n> Make ImageFormats an iterable class by exposing the type definitions\n> for forward iterators and begin() and end() function from the internal\n> formats map.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/internal/formats.h | 8 +++++++\n> src/libcamera/formats.cpp | 36 ++++++++++++++++++++++++++++\n> 2 files changed, 44 insertions(+)\n> \n> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> index 5668f3744c5d..cb840014cbd7 100644\n> --- a/include/libcamera/internal/formats.h\n> +++ b/include/libcamera/internal/formats.h\n> @@ -22,6 +22,14 @@ template\n> class ImageFormats\n> {\n> public:\n> +\tusing iterator = typename std::map>::iterator;\n> +\tusing const_iterator = typename std::map>::const_iterator;\n> +\n> +\titerator begin() { return data_.begin(); }\n> +\tconst_iterator begin() const { return data_.begin(); }\n> +\titerator end() { return data_.end(); }\n> +\tconst_iterator end() const { return data_.end(); }\n\nThis exposes a subset of the std::map API, excluding for instance reverse\niterators. I wonder if we should really go in this direction, which\nwould lead to potentially exposing more of the std::map API in the\nfuture, when users could iterate over data().\n\n> +\n> \tint addFormat(T format, const std::vector &sizes);\n> \n> \tbool isEmpty() const;\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 62fd46686d7d..fe50b9aaa1f2 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -34,6 +34,42 @@ LOG_DEFINE_CATEGORY(Formats)\n> * Sizes are stored as a list of SizeRange.\n> */\n> \n> +/**\n> + * \\typedef ImageFormats::iterator\n> + * \\brief Iterator for the formats map\n> + */\n> +\n> +/**\n> + * \\typedef ImageFormats::const_iterator\n> + * \\brief Const iterator for the formats map\n> + */\n> +\n> +/**\n> + * \\fn iterator ImageFormats::begin()\n> + * \\brief Retrieve an iterator to the first element in the formats map\n> + * \\return An iterator to the first format map\n> + */\n> +\n> +/**\n> + * \\fn const_iterator ImageFormats::begin() const\n> + * \\brief Retrieve an const iterator to the first element in the formats map\n> + * \\return A const iterator to the first format map\n> + */\n> +\n> +/**\n> + * \\fn iterator ImageFormats::end()\n> + * \\brief Retrieve an iterator pointing to the past-the-end element in the\n> + * formats map\n> + * \\return An iterator to the element following the last format\n> + */\n> +\n> +/**\n> + * \\fn const_iterator ImageFormats::end() const\n> + * \\brief Retrieve a const iterator pointing to the past-the-end element in the\n> + * formats map\n> + * \\return A const iterator to the element following the last format\n> + */\n> +\n> /**\n> * \\brief Add a format and corresponding sizes to the description\n> * \\param[in] format Pixel format or media bus code to describe","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A1D2C0109\n\tfor ;\n\tFri, 26 Jun 2020 01:28:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8565609C5;\n\tFri, 26 Jun 2020 03:28:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C55D7603BA\n\tfor ;\n\tFri, 26 Jun 2020 03:28:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4454D595;\n\tFri, 26 Jun 2020 03:28:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b5h1l/Fr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593134902;\n\tbh=wPDx1zCgCtjfGswnu40tUfbz3SXWCjrL8poQn4gVS4I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b5h1l/FrEhysKP7flAGgEWjr+4VB8OZiW2S4d0P8FvJFQudmhRdBYDnLc0IwaJC7K\n\tQTQm3gHTIV8D8igiF4b8gu6g/kxR7coXyH2DppmqLCp+YisXCIrsZwv0KKpiSPfN+z\n\tgKuELpMeXlkLcJs+VzNGQbzpi5YACOHV6UEXuICo=","Date":"Fri, 26 Jun 2020 04:28:20 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200626012820.GS5865@pendragon.ideasonboard.com>","References":"<20200608232844.10150-1-jacopo@jmondi.org>\n\t<20200608232844.10150-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200608232844.10150-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] libcamera: formats: Make\n\tImageFormats iterable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]