[{"id":5153,"web_url":"https://patchwork.libcamera.org/comment/5153/","msgid":"<20200610001720.GC394579@oden.dyn.berto.se>","date":"2020-06-10T00:17:20","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_module: Fix valgrind\n\tassertion failure","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-06-08 03:54:42 +0300, Laurent Pinchart wrote:\n> As the ELF parsing code uses non-const pointers to the ELF mapping, we\n> have to map the module in private read-write mode. This causes issues\n> with valgrind, due to the IPA manager mapping the module in shared\n> read-only mode and valgrind having trouble loading debugging symbols\n> later at dlopen time due to conflicting mappings.\n> \n> This is likely a bug in valgrind (reported as [1]), but we can easily\n> work around it by using shared read-only mappings only. As such a\n> mapping shouldn't be less efficient than private read-write mappings,\n> switch the mapping type. This requires modifying the ELF parsing\n> functions to operate on const memory, which is a good idea anyway as\n> they're not supposed to modify the ELF file.\n> \n> [1] https://bugs.kde.org/show_bug.cgi?id=422601\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/ipa_module.cpp | 42 ++++++++++++++++++++----------------\n> 1 file changed, 23 insertions(+), 19 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 72e357ec97ca..de512a7f3a0d 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -45,26 +45,27 @@ LOG_DEFINE_CATEGORY(IPAModule)\n> namespace {\n> \n> template\n> -typename std::remove_extent_t *elfPointer(Span elf, off_t offset,\n> -\t\t\t\t\t size_t objSize)\n> +typename std::remove_extent_t *elfPointer(Span elf,\n> +\t\t\t\t\t off_t offset, size_t objSize)\n> {\n> \tsize_t size = offset + objSize;\n> \tif (size > elf.size() || size < objSize)\n> \t\treturn nullptr;\n> \n> \treturn reinterpret_cast *>\n> -\t\t(reinterpret_cast(elf.data()) + offset);\n> +\t\t(reinterpret_cast(elf.data()) + offset);\n> }\n> \n> template\n> -typename std::remove_extent_t *elfPointer(Span elf, off_t offset)\n> +typename std::remove_extent_t *elfPointer(Span elf,\n> +\t\t\t\t\t off_t offset)\n> {\n> \treturn elfPointer(elf, offset, sizeof(T));\n> }\n> \n> -int elfVerifyIdent(Span elf)\n> +int elfVerifyIdent(Span elf)\n> {\n> -\tchar *e_ident = elfPointer(elf, 0);\n> +\tconst char *e_ident = elfPointer(elf, 0);\n> \tif (!e_ident)\n> \t\treturn -ENOEXEC;\n> \n> @@ -88,14 +89,15 @@ int elfVerifyIdent(Span elf)\n> \treturn 0;\n> }\n> \n> -ElfW(Shdr) *elfSection(Span elf, ElfW(Ehdr) *eHdr, ElfW(Half) idx)\n> +const ElfW(Shdr) *elfSection(Span elf, const ElfW(Ehdr) *eHdr,\n> +\t\t\t ElfW(Half) idx)\n> {\n> \tif (idx >= eHdr->e_shnum)\n> \t\treturn nullptr;\n> \n> \toff_t offset = eHdr->e_shoff + idx *\n> \t\t\t\t static_cast(eHdr->e_shentsize);\n> -\treturn elfPointer(elf, offset);\n> +\treturn elfPointer(elf, offset);\n> }\n> \n> /**\n> @@ -106,26 +108,26 @@ ElfW(Shdr) *elfSection(Span elf, ElfW(Ehdr) *eHdr, ElfW(Half) idx)\n> * \\return The memory region storing the symbol on success, or an empty span\n> * otherwise\n> */\n> -Span elfLoadSymbol(Span elf, const char *symbol)\n> +Span elfLoadSymbol(Span elf, const char *symbol)\n> {\n> -\tElfW(Ehdr) *eHdr = elfPointer(elf, 0);\n> +\tconst ElfW(Ehdr) *eHdr = elfPointer(elf, 0);\n> \tif (!eHdr)\n> \t\treturn {};\n> \n> -\tElfW(Shdr) *sHdr = elfSection(elf, eHdr, eHdr->e_shstrndx);\n> +\tconst ElfW(Shdr) *sHdr = elfSection(elf, eHdr, eHdr->e_shstrndx);\n> \tif (!sHdr)\n> \t\treturn {};\n> \toff_t shnameoff = sHdr->sh_offset;\n> \n> \t/* Locate .dynsym section header. */\n> -\tElfW(Shdr) *dynsym = nullptr;\n> +\tconst ElfW(Shdr) *dynsym = nullptr;\n> \tfor (unsigned int i = 0; i < eHdr->e_shnum; i++) {\n> \t\tsHdr = elfSection(elf, eHdr, i);\n> \t\tif (!sHdr)\n> \t\t\treturn {};\n> \n> \t\toff_t offset = shnameoff + sHdr->sh_name;\n> -\t\tchar *name = elfPointer(elf, offset);\n> +\t\tconst char *name = elfPointer(elf, offset);\n> \t\tif (!name)\n> \t\t\treturn {};\n> \n> @@ -146,16 +148,17 @@ Span elfLoadSymbol(Span elf, const char *symbol)\n> \toff_t dynsym_nameoff = sHdr->sh_offset;\n> \n> \t/* Locate symbol in the .dynsym section. */\n> -\tElfW(Sym) *targetSymbol = nullptr;\n> +\tconst ElfW(Sym) *targetSymbol = nullptr;\n> \tunsigned int dynsym_num = dynsym->sh_size / dynsym->sh_entsize;\n> \tfor (unsigned int i = 0; i < dynsym_num; i++) {\n> \t\toff_t offset = dynsym->sh_offset + dynsym->sh_entsize * i;\n> -\t\tElfW(Sym) *sym = elfPointer(elf, offset);\n> +\t\tconst ElfW(Sym) *sym = elfPointer(elf, offset);\n> \t\tif (!sym)\n> \t\t\treturn {};\n> \n> \t\toffset = dynsym_nameoff + sym->st_name;\n> -\t\tchar *name = elfPointer(elf, offset, strlen(symbol) + 1);\n> +\t\tconst char *name = elfPointer(elf, offset,\n> +\t\t\t\t\t\t\t strlen(symbol) + 1);\n> \t\tif (!name)\n> \t\t\treturn {};\n> \n> @@ -176,7 +179,8 @@ Span elfLoadSymbol(Span elf, const char *symbol)\n> \tif (!sHdr)\n> \t\treturn {};\n> \toff_t offset = sHdr->sh_offset + (targetSymbol->st_value - sHdr->sh_addr);\n> -\tuint8_t *data = elfPointer(elf, offset, targetSymbol->st_size);\n> +\tconst uint8_t *data = elfPointer(elf, offset,\n> +\t\t\t\t\t\t\ttargetSymbol->st_size);\n> \tif (!data)\n> \t\treturn {};\n> \n> @@ -277,14 +281,14 @@ int IPAModule::loadIPAModuleInfo()\n> \t\treturn file.error();\n> \t}\n> \n> -\tSpan data = file.map(0, -1, File::MapPrivate);\n> +\tSpan data = file.map();\n> \tint ret = elfVerifyIdent(data);\n> \tif (ret) {\n> \t\tLOG(IPAModule, Error) << \"IPA module is not an ELF file\";\n> \t\treturn ret;\n> \t}\n> \n> -\tSpan info = elfLoadSymbol(data, \"ipaModuleInfo\");\n> +\tSpan info = elfLoadSymbol(data, \"ipaModuleInfo\");\n> \tif (info.size() != sizeof(info_)) {\n> \t\tLOG(IPAModule, Error) << \"IPA module has no valid info\";\n> \t\treturn -EINVAL;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 279816002B\n\tfor ;\n\tWed, 10 Jun 2020 02:17:22 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id s1so299411ljo.0\n\tfor ;\n\tTue, 09 Jun 2020 17:17:22 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu4sm4576776ljg.132.2020.06.09.17.17.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Jun 2020 17:17:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"XKJA/4OK\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=NwlHhFZjnETcvHM7t65LsBlGjaZK0v8TvnAKOux89aM=;\n\tb=XKJA/4OKOzfnams4q6dBO944RO7g2l2DrRagdyBXI+GNNVan/VHHQ74OdweBE5E7X6\n\taEXen8pf1BAmiXRs+6KCizGqqYhBgK+uWnnWRligds4kuPv3cdHDDof9GsWGjDXxB7Aa\n\tHe/bFifZVYXaLtNX4XfFHMj8Ii/V1LlnIhI9uTScR57W6nkOAYk3Gerue9F5fiLNEc5p\n\tWeCQPs8+3suc2RnaZhbwBur0AZAJ5Jh09caxmN3LAN4bLlDe8Yp8hwKc9XEMZD1IKBa1\n\t+QPl19xCVLsRRkWjRqfEb3sngnhiW0lZZziQJHlHSO1eSgC6K33lAT+lOdhv+J9Balt0\n\tHRHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=NwlHhFZjnETcvHM7t65LsBlGjaZK0v8TvnAKOux89aM=;\n\tb=FKoSGEiEBuzv/MnGie8wgKFmPl0pkkBYQquoTstlo6EyZlgPg0IsVha295ZMzEV504\n\tRjzKpwfNFA4yi3+QUSOCiupovobpzYohIuR/ZhAK6EicmuujB0P4lc2c0c1odWn1+1Gi\n\t/uGFaJZLNFaKRhelqj6W32bPkKF9jq0me/8Zga5SDnEA72/T26BfBuT+QvXA6B7Jz3vh\n\tMdniWc5TzQUlCJTkhj9CHCzTrbiByqdSJ5Fk3a44PDsQu/ruQnK6c392+S4CJou5wcnF\n\tCJY4KndhrbipRyVoD6/lflJfxav4uAaZOm3G6eEGwIrHindbpSDMl+XHZ4APBfS8QUvh\n\tu3hA==","X-Gm-Message-State":"AOAM530AlnFN3Tc+xr/KuqF91NjbYxxynC+7726pDfJsQENBmPmrdHcK\n\t2QCDpT22vAxPxUqLhzRaTCxKrl4NnZ8=","X-Google-Smtp-Source":"ABdhPJw89Yw76RiSG+m8X9on1bPIKGBrU/FdDWV7TNAevQsNsFjNn2I3hsjX68qtjlmsC0eCxCJmHQ==","X-Received":"by 2002:a2e:1453:: with SMTP id 19mr373932lju.155.1591748241366; \n\tTue, 09 Jun 2020 17:17:21 -0700 (PDT)","Date":"Wed, 10 Jun 2020 02:17:20 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200610001720.GC394579@oden.dyn.berto.se>","References":"<20200608005442.1771-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200608005442.1771-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_module: Fix valgrind\n\tassertion failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 10 Jun 2020 00:17:22 -0000"}},{"id":5161,"web_url":"https://patchwork.libcamera.org/comment/5161/","msgid":"<20200610140459.GB3440@emerald.amanokami.net>","date":"2020-06-10T14:04:59","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_module: Fix valgrind\n\tassertion failure","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, Jun 08, 2020 at 03:54:42AM +0300, Laurent Pinchart wrote:\n> As the ELF parsing code uses non-const pointers to the ELF mapping, we\n> have to map the module in private read-write mode. This causes issues\n> with valgrind, due to the IPA manager mapping the module in shared\n> read-only mode and valgrind having trouble loading debugging symbols\n> later at dlopen time due to conflicting mappings.\n> \n> This is likely a bug in valgrind (reported as [1]), but we can easily\n> work around it by using shared read-only mappings only. As such a\n> mapping shouldn't be less efficient than private read-write mappings,\n> switch the mapping type. This requires modifying the ELF parsing\n> functions to operate on const memory, which is a good idea anyway as\n> they're not supposed to modify the ELF file.\n> \n> [1] https://bugs.kde.org/show_bug.cgi?id=422601\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/ipa_module.cpp | 42 ++++++++++++++++++++----------------\n> 1 file changed, 23 insertions(+), 19 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 72e357ec97ca..de512a7f3a0d 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -45,26 +45,27 @@ LOG_DEFINE_CATEGORY(IPAModule)\n> namespace {\n> \n> template\n> -typename std::remove_extent_t *elfPointer(Span elf, off_t offset,\n> -\t\t\t\t\t size_t objSize)\n> +typename std::remove_extent_t *elfPointer(Span elf,\n> +\t\t\t\t\t off_t offset, size_t objSize)\n> {\n> \tsize_t size = offset + objSize;\n> \tif (size > elf.size() || size < objSize)\n> \t\treturn nullptr;\n> \n> \treturn reinterpret_cast *>\n> -\t\t(reinterpret_cast(elf.data()) + offset);\n> +\t\t(reinterpret_cast(elf.data()) + offset);\n> }\n> \n> template\n> -typename std::remove_extent_t *elfPointer(Span elf, off_t offset)\n> +typename std::remove_extent_t *elfPointer(Span elf,\n> +\t\t\t\t\t off_t offset)\n> {\n> \treturn elfPointer(elf, offset, sizeof(T));\n> }\n> \n> -int elfVerifyIdent(Span elf)\n> +int elfVerifyIdent(Span elf)\n> {\n> -\tchar *e_ident = elfPointer(elf, 0);\n> +\tconst char *e_ident = elfPointer(elf, 0);\n> \tif (!e_ident)\n> \t\treturn -ENOEXEC;\n> \n> @@ -88,14 +89,15 @@ int elfVerifyIdent(Span elf)\n> \treturn 0;\n> }\n> \n> -ElfW(Shdr) *elfSection(Span elf, ElfW(Ehdr) *eHdr, ElfW(Half) idx)\n> +const ElfW(Shdr) *elfSection(Span elf, const ElfW(Ehdr) *eHdr,\n> +\t\t\t ElfW(Half) idx)\n> {\n> \tif (idx >= eHdr->e_shnum)\n> \t\treturn nullptr;\n> \n> \toff_t offset = eHdr->e_shoff + idx *\n> \t\t\t\t static_cast(eHdr->e_shentsize);\n> -\treturn elfPointer(elf, offset);\n> +\treturn elfPointer(elf, offset);\n> }\n> \n> /**\n> @@ -106,26 +108,26 @@ ElfW(Shdr) *elfSection(Span elf, ElfW(Ehdr) *eHdr, ElfW(Half) idx)\n> * \\return The memory region storing the symbol on success, or an empty span\n> * otherwise\n> */\n> -Span elfLoadSymbol(Span elf, const char *symbol)\n> +Span elfLoadSymbol(Span elf, const char *symbol)\n> {\n> -\tElfW(Ehdr) *eHdr = elfPointer(elf, 0);\n> +\tconst ElfW(Ehdr) *eHdr = elfPointer(elf, 0);\n> \tif (!eHdr)\n> \t\treturn {};\n> \n> -\tElfW(Shdr) *sHdr = elfSection(elf, eHdr, eHdr->e_shstrndx);\n> +\tconst ElfW(Shdr) *sHdr = elfSection(elf, eHdr, eHdr->e_shstrndx);\n> \tif (!sHdr)\n> \t\treturn {};\n> \toff_t shnameoff = sHdr->sh_offset;\n> \n> \t/* Locate .dynsym section header. */\n> -\tElfW(Shdr) *dynsym = nullptr;\n> +\tconst ElfW(Shdr) *dynsym = nullptr;\n> \tfor (unsigned int i = 0; i < eHdr->e_shnum; i++) {\n> \t\tsHdr = elfSection(elf, eHdr, i);\n> \t\tif (!sHdr)\n> \t\t\treturn {};\n> \n> \t\toff_t offset = shnameoff + sHdr->sh_name;\n> -\t\tchar *name = elfPointer(elf, offset);\n> +\t\tconst char *name = elfPointer(elf, offset);\n> \t\tif (!name)\n> \t\t\treturn {};\n> \n> @@ -146,16 +148,17 @@ Span elfLoadSymbol(Span elf, const char *symbol)\n> \toff_t dynsym_nameoff = sHdr->sh_offset;\n> \n> \t/* Locate symbol in the .dynsym section. */\n> -\tElfW(Sym) *targetSymbol = nullptr;\n> +\tconst ElfW(Sym) *targetSymbol = nullptr;\n> \tunsigned int dynsym_num = dynsym->sh_size / dynsym->sh_entsize;\n> \tfor (unsigned int i = 0; i < dynsym_num; i++) {\n> \t\toff_t offset = dynsym->sh_offset + dynsym->sh_entsize * i;\n> -\t\tElfW(Sym) *sym = elfPointer(elf, offset);\n> +\t\tconst ElfW(Sym) *sym = elfPointer(elf, offset);\n> \t\tif (!sym)\n> \t\t\treturn {};\n> \n> \t\toffset = dynsym_nameoff + sym->st_name;\n> -\t\tchar *name = elfPointer(elf, offset, strlen(symbol) + 1);\n> +\t\tconst char *name = elfPointer(elf, offset,\n> +\t\t\t\t\t\t\t strlen(symbol) + 1);\n> \t\tif (!name)\n> \t\t\treturn {};\n> \n> @@ -176,7 +179,8 @@ Span elfLoadSymbol(Span elf, const char *symbol)\n> \tif (!sHdr)\n> \t\treturn {};\n> \toff_t offset = sHdr->sh_offset + (targetSymbol->st_value - sHdr->sh_addr);\n> -\tuint8_t *data = elfPointer(elf, offset, targetSymbol->st_size);\n> +\tconst uint8_t *data = elfPointer(elf, offset,\n> +\t\t\t\t\t\t\ttargetSymbol->st_size);\n> \tif (!data)\n> \t\treturn {};\n> \n> @@ -277,14 +281,14 @@ int IPAModule::loadIPAModuleInfo()\n> \t\treturn file.error();\n> \t}\n> \n> -\tSpan data = file.map(0, -1, File::MapPrivate);\n> +\tSpan data = file.map();\n> \tint ret = elfVerifyIdent(data);\n> \tif (ret) {\n> \t\tLOG(IPAModule, Error) << \"IPA module is not an ELF file\";\n> \t\treturn ret;\n> \t}\n> \n> -\tSpan info = elfLoadSymbol(data, \"ipaModuleInfo\");\n> +\tSpan info = elfLoadSymbol(data, \"ipaModuleInfo\");\n> \tif (info.size() != sizeof(info_)) {\n> \t\tLOG(IPAModule, Error) << \"IPA module has no valid info\";\n> \t\treturn -EINVAL;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33E9160C4E\n\tfor ;\n\tWed, 10 Jun 2020 16:05:06 +0200 (CEST)","from emerald.amanokami.net (fs76eef344.knge213.ap.nuro.jp\n\t[118.238.243.68])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CECE929E;\n\tWed, 10 Jun 2020 16:05:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZspdnsSl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591797905;\n\tbh=Xx67cM08sn7EgXIhaJCdgoHI8ftzbwy15kBspXXK2uY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZspdnsSlYDVXZjP8TYQ4qU7EmMO+8tl9Oaz5nGDH+pV6kms/X2iqVqfU8oImEjKak\n\tZI9cUxNr9q2+f47l/37/tsOf0BFDJ8PRFVmzXBpyo9WkckjM+7sdJpwyKl0PwCczTY\n\t9KvwTEXGbw54WRJyHWANoSNVAomvrbtHZpkFcjvg=","Date":"Wed, 10 Jun 2020 23:04:59 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200610140459.GB3440@emerald.amanokami.net>","References":"<20200608005442.1771-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20200608005442.1771-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_module: Fix valgrind\n\tassertion failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 10 Jun 2020 14:05:06 -0000"}}]