[{"id":5111,"web_url":"https://patchwork.libcamera.org/comment/5111/","msgid":"<20200607171729.GB5958@pendragon.ideasonboard.com>","date":"2020-06-07T17:17:29","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Peter,\n\nThank you for the patch.\n\nOn Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote:\n> Fixes:\n> \n> ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> | ^~~~~\n> Signed-off-by: Peter Seiderer \n> ---\n> src/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 7de0895..1f3bdc1 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> \t\t<< \"timestamp:\" << metadata.timestamp\n> -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n\nHasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\ncompatibility with all older Qt versions ?\n\nOne option I haven't tested would be to keep Qt::fixed here, and add, at\nthe top of this file, something along those lines.\n\n#if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n/*\n * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n * usage of Qt::fixed unconditionally.\n */\nnamespace Qt {\nusing fixed = ::fixed;\n} /* namespace Qt */\n#endif\n\nWould you be able to test this ?\n\n> \n> \t/* Render the frame on the viewfinder. */\n> \tviewfinder_->render(buffer, &mappedBuffers_[buffer]);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42F8A600F7\n\tfor ;\n\tSun, 7 Jun 2020 19:17:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1EA22C9;\n\tSun, 7 Jun 2020 19:17:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gcNQkbij\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591550268;\n\tbh=QzWq4wSfrb/nKI/43epC66PxktvVdmBDv+9ohNHCZdg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gcNQkbij4B301kwVVv4oVPS1dbCwzhEKRt2TOGG5CyMBuYgtKnE9cQKAAb18DFtWg\n\tZlzCVRGYi5qWo+bHShBn/emcx6b49A3ec34SRoD6ndBQ7lIggz87GdxkinvUqE3/mB\n\tQ8lBt6RDlc/DmFOZef9d0TccRO3t9xd2jnHvPTN4=","Date":"Sun, 7 Jun 2020 20:17:29 +0300","From":"Laurent Pinchart ","To":"Peter Seiderer ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200607171729.GB5958@pendragon.ideasonboard.com>","References":"<20200607165655.4844-1-ps.report@gmx.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200607165655.4844-1-ps.report@gmx.net>","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 07 Jun 2020 17:17:49 -0000"}},{"id":5113,"web_url":"https://patchwork.libcamera.org/comment/5113/","msgid":"<20200607235826.7723842d@gmx.net>","date":"2020-06-07T21:58:26","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":52,"url":"https://patchwork.libcamera.org/api/people/52/","name":"Peter Seiderer","email":"ps.report@gmx.net"},"content":"Hello Laurent,\n\nOn Sun, 7 Jun 2020 20:17:29 +0300, Laurent Pinchart wrote:\n\n> Hi Peter,\n> \n> Thank you for the patch.\n> \n> On Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote:\n> > Fixes:\n> > \n> > ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> > 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > | ^~~~~\n> > Signed-off-by: Peter Seiderer \n> > ---\n> > src/qcam/main_window.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index 7de0895..1f3bdc1 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> > \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> > \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> > \t\t<< \"timestamp:\" << metadata.timestamp\n> > -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps; \n> \n> Hasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\n> compatibility with all older Qt versions ?\n\nYes, you are right...\n\n> \n> One option I haven't tested would be to keep Qt::fixed here, and add, at\n> the top of this file, something along those lines.\n> \n> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> /*\n> * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> * usage of Qt::fixed unconditionally.\n> */\n> namespace Qt {\n> using fixed = ::fixed;\n> } /* namespace Qt */\n> #endif\n> \n> Would you be able to test this ?\n\nDid try with Qt5.10.1 (with a standalone test program), leads to:\n\n test-qt-fixed.cpp:10:17: error: ‘fixed’ in namespace ‘::’ does not name a type\n 10 | using fixed = ::fixed;\n | ^~~~~\n\n\nAlternative would be:\n\n[...]\n#if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n\t<< fixed\n#else\n\t<< Qt::fixed\n#endif\n[...]\n\nShould I re-spin the patch?\n\nRegards,\nPeter\n\n> \n> > \n> > \t/* Render the frame on the viewfinder. */\n> > \tviewfinder_->render(buffer, &mappedBuffers_[buffer]); \n>","headers":{"Return-Path":"","Received":["from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BCB1600F7\n\tfor ;\n\tSun, 7 Jun 2020 23:58:28 +0200 (CEST)","from localhost ([62.216.209.160]) by mail.gmx.com (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MbAh0-1j6nkZ1Gx6-00besx;\n\tSun, 07 Jun 2020 23:58:27 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"EjfQIW4a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1591567107;\n\tbh=8rpHv0KjpHSA0B7C0ol9ZkTSUTAkpOYch3V0Iw4cnRA=;\n\th=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References;\n\tb=EjfQIW4afTyPqDriUMrHVt+pT0KxGjHs8G4bgN/5RCkWvzEjM7fyAOHM6jiqaNNiU\n\t3Bp6VHncKrJDDfJkZcGpB/yiwB/qK2I2o1ktmkEeCxDvFZokVR8o8lZLpXFTPN4raz\n\tWxCbdayRif/UKvtgwbRLLeUF1jYjQj+HoYreVIZg=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Date":"Sun, 7 Jun 2020 23:58:26 +0200","From":"Peter Seiderer ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200607235826.7723842d@gmx.net>","In-Reply-To":"<20200607171729.GB5958@pendragon.ideasonboard.com>","References":"<20200607165655.4844-1-ps.report@gmx.net>\n\t<20200607171729.GB5958@pendragon.ideasonboard.com>","X-Mailer":"Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-suse-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:VlVt5AaVRITKwnpOgAJ+BGA+xnvvXmh+qsq4hwJuXbiuitvDpDe\n\t6JDjT8GT+cIbQsAJHsuGxy6I9SKoxA+cMnDTcOu6kjIYOUc8LT8plyNzltI/mOerIVFJj/V\n\tsddEOgUk4KFpe/El90BBa/U2DBE3tNbT2s88HPT+AacW8mWP+FbliOFmuf0OFyze43eTQdN\n\tM0mkeF5VnPggAQE9h+Vug==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:KyJOkQpp3nk=:l6Mm849SRL1A811jXFACgU\n\tNPqa8brWhEK2vIiUuQZmBdyfhc5awGv0juq/dJ7ddUS09ywcbTUT+H3zauEhs/77O0dtsAV7U\n\tdNLc8Vchty0vMBxdD/OrpYVzpyqGW2h5m/mUawhZgES8imVwK/LmL4/m7vVMRC1cA4g7j1Z79\n\tYYhRWXM8c2uoso2TNfdVA2xxi2LfBDGD4chOdCz/6s4ppCrU95aNtTYiMdTVcHaGHK44oIHhI\n\tUreBwJp4vyWJut/2K9uL3CHtjm8ZcnSR2OecW4C/+j9KP5UUNBnQlWrr6H4RPvtpB/e0ZAwpM\n\tIfDCv5N7b5dF+UTlZV95faEEVFHf7Ip2QcgwGEqFEwJF72wL09rftTz1XZ3UWXkVflkJdSHh8\n\tFxkw4K7GzLwxqozNkFCojf4dGX59GSGGckrRtC7tMOmQ7u6a6KnQxgg1B2oUobIATFdHcoVgY\n\tiujg26H8HEKFqiqmjgV+ketXngGOxbli/bwcD1sce4lJK48dwK1xW7zms/UrHnC6Y5BCKsgOY\n\tMzYkE1kkabTHnEZ/YIoQyoLVn6u8S2cJgofgddc/bIlLIR6OhBXQ2JzGMxqZ+5bC7rnObeGYR\n\tWmk8gSn5ezMBsggywP0Zvuop3O9SA2uaztJUYJF0QjFbPxKs0i1C7e/l2GrFPXRf7C56xCSpk\n\ts5hpInnV8EKZo6Di9JumhBsJGd4iJsn8vnr9DBzXkIlgRSp02FGRLZthESd3y/p8kV3WDZ6NG\n\t3ezBkBlMsmjdzRC0WzjcuI8zzF+DZi8YbSE5xd70u+LUSVm66NqQv/WnfC1BZo8XDhqWZbfAQ\n\tnG9kds59xVvUJ111JChIWqdoFdcegmEH69FXG32cMU/LcvM/YMyMVBOhH90HnigITynIZ3NMp\n\tMRuVBHPi2IDFpMbSt7InAAvzS94myeHqz6MhSyhl+7dGIK61eXBHP/Z8/Ngk5xZ5LdUe6Wcv9\n\tpsSD5RofctX0borpEVlfJXp6iQcbsh4sfGhE1xTe+bTZ0D4WupleLjQ5L7sTxiQWGw+72OGVu\n\teTujMSra0woLjKBlwALwcPmDLL+rBYiHEtJBzrErAKxrZiV+eQi16LkBDle1FhNaH4s1XBCEp\n\t7Pk5Mn5gZ80KZlFbi4uGxFzVZELc2LAOBcM1FZ9lo6Bo4/2XufXBgxDfTl+mDiB49TsePSCLG\n\tA99Q35VeRJDHMh7JBcMRXCNzm40fxEH6/nJczu7T9cBP3Themfypaz3hbHeQTPKflKTKJKuvA\n\tJtwhuSsYtTGoPDGw2","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 07 Jun 2020 21:58:28 -0000"}},{"id":5117,"web_url":"https://patchwork.libcamera.org/comment/5117/","msgid":"<20200608011856.GH22208@pendragon.ideasonboard.com>","date":"2020-06-08T01:18:56","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Peter,\n\nOn Sun, Jun 07, 2020 at 11:58:26PM +0200, Peter Seiderer wrote:\n> On Sun, 7 Jun 2020 20:17:29 +0300, Laurent Pinchart wrote:\n> > On Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote:\n> > > Fixes:\n> > > \n> > > ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> > > 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > > | ^~~~~\n> > > Signed-off-by: Peter Seiderer \n> > > ---\n> > > src/qcam/main_window.cpp | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > > index 7de0895..1f3bdc1 100644\n> > > --- a/src/qcam/main_window.cpp\n> > > +++ b/src/qcam/main_window.cpp\n> > > @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> > > \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> > > \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> > > \t\t<< \"timestamp:\" << metadata.timestamp\n> > > -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > > +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps; \n> > \n> > Hasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\n> > compatibility with all older Qt versions ?\n> \n> Yes, you are right...\n> \n> > One option I haven't tested would be to keep Qt::fixed here, and add, at\n> > the top of this file, something along those lines.\n> > \n> > #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> > /*\n> > * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> > * usage of Qt::fixed unconditionally.\n> > */\n> > namespace Qt {\n> > using fixed = ::fixed;\n> > } /* namespace Qt */\n> > #endif\n> > \n> > Would you be able to test this ?\n> \n> Did try with Qt5.10.1 (with a standalone test program), leads to:\n> \n> test-qt-fixed.cpp:10:17: error: ‘fixed’ in namespace ‘::’ does not name a type\n> 10 | using fixed = ::fixed;\n> | ^~~~~\n> \n> \n> Alternative would be:\n> \n> [...]\n> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> \t<< fixed\n> #else\n> \t<< Qt::fixed\n> #endif\n> [...]\n\nThat would require an #if for every usage of fixed, which isn't very\nnice (even if we use it in a single place only). I've tested the\nfollowing v5.14 but can't easily test on older Qt versions. Could you\ntest v5.10 ?\n\n#if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n/*\n * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n * usage of Qt::fixed unconditionally.\n */\nnamespace Qt {\nconstexpr auto fixed = ::fixed;\n} /* namespace Qt */\n#endif\n\n> Should I re-spin the patch?\n> \n> > > \n> > > \t/* Render the frame on the viewfinder. */\n> > > \tviewfinder_->render(buffer, &mappedBuffers_[buffer]);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0A086002E\n\tfor ;\n\tMon, 8 Jun 2020 03:19:16 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B45082C1;\n\tMon, 8 Jun 2020 03:19:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JjMXsCKn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591579155;\n\tbh=Q0r9r/y3B0RCb0viUrNZSbs+aQ5vQMl+iIGJdNfoSwU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JjMXsCKnnGwc+56neBo3LboYvzhZqNZg80HA0ZJ1nKE+PFCKVBhwpVlq75ST4oB7i\n\tuee2wTZzK0/1fFDuYC0UErhAorieNXASk71ei7FJGd91jx7cb4Vm5L+8bWnoYUTrwX\n\t5eygvu5N2oY/mmFfLghKgm7waGksaAoVCd3l0J+0=","Date":"Mon, 8 Jun 2020 04:18:56 +0300","From":"Laurent Pinchart ","To":"Peter Seiderer ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200608011856.GH22208@pendragon.ideasonboard.com>","References":"<20200607165655.4844-1-ps.report@gmx.net>\n\t<20200607171729.GB5958@pendragon.ideasonboard.com>\n\t<20200607235826.7723842d@gmx.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200607235826.7723842d@gmx.net>","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 08 Jun 2020 01:19:16 -0000"}},{"id":5144,"web_url":"https://patchwork.libcamera.org/comment/5144/","msgid":"<20200608231102.315d3848@gmx.net>","date":"2020-06-08T21:11:02","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":52,"url":"https://patchwork.libcamera.org/api/people/52/","name":"Peter Seiderer","email":"ps.report@gmx.net"},"content":"Hello Laurent,\n\nOn Mon, 8 Jun 2020 04:18:56 +0300, Laurent Pinchart wrote:\n\n> Hi Peter,\n> \n> On Sun, Jun 07, 2020 at 11:58:26PM +0200, Peter Seiderer wrote:\n> > On Sun, 7 Jun 2020 20:17:29 +0300, Laurent Pinchart wrote: \n> > > On Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote: \n> > > > Fixes:\n> > > > \n> > > > ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> > > > 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > > > | ^~~~~\n> > > > Signed-off-by: Peter Seiderer \n> > > > ---\n> > > > src/qcam/main_window.cpp | 2 +-\n> > > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > > \n> > > > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > > > index 7de0895..1f3bdc1 100644\n> > > > --- a/src/qcam/main_window.cpp\n> > > > +++ b/src/qcam/main_window.cpp\n> > > > @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> > > > \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> > > > \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> > > > \t\t<< \"timestamp:\" << metadata.timestamp\n> > > > -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > > > +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps; \n> > > \n> > > Hasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\n> > > compatibility with all older Qt versions ? \n> > \n> > Yes, you are right...\n> > \n> > > One option I haven't tested would be to keep Qt::fixed here, and add, at\n> > > the top of this file, something along those lines.\n> > > \n> > > #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> > > /*\n> > > * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> > > * usage of Qt::fixed unconditionally.\n> > > */\n> > > namespace Qt {\n> > > using fixed = ::fixed;\n> > > } /* namespace Qt */\n> > > #endif\n> > > \n> > > Would you be able to test this ? \n> > \n> > Did try with Qt5.10.1 (with a standalone test program), leads to:\n> > \n> > test-qt-fixed.cpp:10:17: error: ‘fixed’ in namespace ‘::’ does not name a type\n> > 10 | using fixed = ::fixed;\n> > | ^~~~~\n> > \n> > \n> > Alternative would be:\n> > \n> > [...]\n> > #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> > \t<< fixed\n> > #else\n> > \t<< Qt::fixed\n> > #endif\n> > [...] \n> \n> That would require an #if for every usage of fixed, which isn't very\n> nice (even if we use it in a single place only). I've tested the\n> following v5.14 but can't easily test on older Qt versions. Could you\n> test v5.10 ?\n\nYes, can do...\n\n> \n> #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n> /*\n> * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> * usage of Qt::fixed unconditionally.\n> */\n> namespace Qt {\n> constexpr auto fixed = ::fixed;\n> } /* namespace Qt */\n> #endif\n\nThis one works with Qt5.10.1...\n\nRegards,\nPeter\n\n> \n> > Should I re-spin the patch?\n> > \n> > > > \n> > > > \t/* Render the frame on the viewfinder. */\n> > > > \tviewfinder_->render(buffer, &mappedBuffers_[buffer]); \n>","headers":{"Return-Path":"","Received":["from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E494461027\n\tfor ;\n\tMon, 8 Jun 2020 23:11:04 +0200 (CEST)","from localhost ([62.216.209.102]) by mail.gmx.com (mrgmx004\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1N1Obh-1ixovl4Aix-012qok;\n\tMon, 08 Jun 2020 23:11:03 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"UjCqGLxi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1591650663;\n\tbh=XFmhasEASRvt7Iy/dH72HYbLhqcVQNi7i6ud0ZNLLns=;\n\th=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References;\n\tb=UjCqGLxi+9JVUwricC/f03cUPQNDoZRh771TBqY0bUNH+wjfZjzQPNnu5AJAv731/\n\tk/6EoCTcF6JIASv79xSTZqQJBSoE+BuwXwQ5oPA3ghz77wwnFdowKdUKLoP2XofRgK\n\tLPdYVv76u0tZKdHVFG3ed7Z9jOlpQ0HZmVZZC0nw=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Date":"Mon, 8 Jun 2020 23:11:02 +0200","From":"Peter Seiderer ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200608231102.315d3848@gmx.net>","In-Reply-To":"<20200608011856.GH22208@pendragon.ideasonboard.com>","References":"<20200607165655.4844-1-ps.report@gmx.net>\n\t<20200607171729.GB5958@pendragon.ideasonboard.com>\n\t<20200607235826.7723842d@gmx.net>\n\t<20200608011856.GH22208@pendragon.ideasonboard.com>","X-Mailer":"Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-suse-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:M6piSCp8CAg1PBegpB5HQnwqzuOYYM1CSHtq4y8KETgcqYNABMp\n\tJIC/ilenNCinmXUHVeqnNFnj5lqeSac/1Tvx3x7CTY/THhUTY6Y2aJs+hGfAMWeTNsgz0e/\n\tzrDkA98dXoOFU3PL29xrojdbsIU93fi0vzFomqc2NaONZtdV6bEYd8NFlmu4qhPDBhYr4Yw\n\tx/27aQg2cgEP5pUXeS4Rw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:4qqGHkKlsLE=:qSUvW7yRS38yoBgTj7OB1+\n\tO7PNwJG13qNPcgbY9Ps3euAoqVrpiH+8olGJeQolLOvxTAZYsjJNHPQoYsVqilBghyTt7Qj+T\n\tqpfkaAcP3JbtU0PmBtUocTS36TRBSojLFco+yb/LOOl6k+0NZuvI9CwFdWIUA0s2pFIfTOWEO\n\tmjlDAgm8Cu5xmO8pVgnN1ve3TwiOK/ECJI3TyBNfwe1prmUYQzBeR1NSLFcH2tKR1f/ys/Are\n\t9cxpUpxCGkiwRGuNeyMU4UuGWpbe1DPMGko4O5fUTt4tfNrHaafvwV7b83tRsDjjkkZyLhJDV\n\t0Ecv+RtzgoMuM6wPTdHU0oz/vKhO/cfM8K3Q41h0KkrNI1yPimQk4aKnqj5+3kCkGcKXTr2A4\n\tm9CiXlVsObbywnwBQxzR1obJOhnU2x/zmU2lEhgm/ULsMis2m3OUD66bFs89Schg7xvZ3Sgzr\n\tCuOrtfQ3WhXfhplZA5x+zWvnehxwxgn0chRHsTDC39DEjmGYWz/Vp9lpLt5VkwUoSIdVdoF/m\n\tD3RfQrhUkW+cly2K/FYOfDisGsqKKQT3QeOZK0h6fMVftBqRfs4T3ib214ZuTfqPgS0Z8tXPS\n\toAWpbBRp/mD0ONzCCAH5rnfRMrtTg7JICpqQldmQ/+BT06lGaYtGAcyC8sq3jKBYIi516Fs5B\n\t6Ztn/NXzE/bEwNjPV4PEYo78bm+jiJEODa/Z4lgf9TlJMCFDqinCGHMur378HS1z5njtffqUt\n\txNKlq5PZPm18M4sXLbDe0/H29oBZkKe/ziEo9s35HrlPtXuWOiU0haHXAUzwkDqlNt+MscaiS\n\t962GLbHkboJELbFehwMpjU+7pQyO7Q70aRKLqFLWfPQJkrTMHAFNmpSrg5Pf9H8sNp3y7hu5S\n\t4Hz44/gJL6o4AM0d6kHEhPH7omzD8fw05Rb/xZd+TKAhKcHKha/TDTd/aMzNYMvIm+CzXOUcp\n\tjabM5sJxBQXOaY+drnY7TLHNRZuhYFst8RCDYS8PlelkUQTidV49JotPi9A1zK4Ira/4EQyUE\n\tfv1veoEjtIojoAqEbVkRYz5PA7VT9qZAVkMkJe3Gdw0l5Bttc8e7y9jwxm8Z6V0obDcwZLH68\n\t6y8w7GNv4p5XlC7D1lxE+J0qRTMZe6S+JAlZ9FhoQF6c4uSRPT4Mmky0fmELY97CT4GKkz2Lo\n\tspLv33ZS1X9Us1fyGlAmzOqSvbb/i3fFwTifJne9Sp/fpG3W3NTRnUt9yDz6qqCqZv4hk=","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 08 Jun 2020 21:11:05 -0000"}},{"id":5147,"web_url":"https://patchwork.libcamera.org/comment/5147/","msgid":"<20200608213232.GQ5896@pendragon.ideasonboard.com>","date":"2020-06-08T21:32:32","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Peter,\n\nOn Mon, Jun 08, 2020 at 11:11:02PM +0200, Peter Seiderer wrote:\n> On Mon, 8 Jun 2020 04:18:56 +0300, Laurent Pinchart wrote:\n> > On Sun, Jun 07, 2020 at 11:58:26PM +0200, Peter Seiderer wrote:\n> >> On Sun, 7 Jun 2020 20:17:29 +0300, Laurent Pinchart wrote: \n> >>> On Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote: \n> >>>> Fixes:\n> >>>> \n> >>>> ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> >>>> 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> >>>> | ^~~~~\n> >>>> Signed-off-by: Peter Seiderer \n> >>>> ---\n> >>>> src/qcam/main_window.cpp | 2 +-\n> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>> \n> >>>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> >>>> index 7de0895..1f3bdc1 100644\n> >>>> --- a/src/qcam/main_window.cpp\n> >>>> +++ b/src/qcam/main_window.cpp\n> >>>> @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> >>>> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> >>>> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> >>>> \t\t<< \"timestamp:\" << metadata.timestamp\n> >>>> -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> >>>> +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps; \n> >>> \n> >>> Hasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\n> >>> compatibility with all older Qt versions ? \n> >> \n> >> Yes, you are right...\n> >> \n> >>> One option I haven't tested would be to keep Qt::fixed here, and add, at\n> >>> the top of this file, something along those lines.\n> >>> \n> >>> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> >>> /*\n> >>> * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> >>> * usage of Qt::fixed unconditionally.\n> >>> */\n> >>> namespace Qt {\n> >>> using fixed = ::fixed;\n> >>> } /* namespace Qt */\n> >>> #endif\n> >>> \n> >>> Would you be able to test this ? \n> >> \n> >> Did try with Qt5.10.1 (with a standalone test program), leads to:\n> >> \n> >> test-qt-fixed.cpp:10:17: error: ‘fixed’ in namespace ‘::’ does not name a type\n> >> 10 | using fixed = ::fixed;\n> >> | ^~~~~\n> >> \n> >> \n> >> Alternative would be:\n> >> \n> >> [...]\n> >> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> >> \t<< fixed\n> >> #else\n> >> \t<< Qt::fixed\n> >> #endif\n> >> [...] \n> > \n> > That would require an #if for every usage of fixed, which isn't very\n> > nice (even if we use it in a single place only). I've tested the\n> > following v5.14 but can't easily test on older Qt versions. Could you\n> > test v5.10 ?\n> \n> Yes, can do...\n> \n> > #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n> > /*\n> > * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> > * usage of Qt::fixed unconditionally.\n> > */\n> > namespace Qt {\n> > constexpr auto fixed = ::fixed;\n> > } /* namespace Qt */\n> > #endif\n> \n> This one works with Qt5.10.1...\n\nGreat ! Thank you for testing.\n\nAre you fine with the following patch ? If so there's no need to send a\nnew version.\n\ncommit 3dd6902e12c73cdcb5ef1a0ce0aceee5c9008306\nAuthor: Peter Seiderer \nDate: Sun Jun 7 18:56:55 2020 +0200\n\n qcam: Fix compilation with Qt v5.15.0\n \n Starting from Qt v5.15.0, the QTextStreamFunctions::fixed function\n used to configure formatting on QTextStream is deprecated in favour of\n Qt::fixed. This causes a compilation error:\n \n ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n | ^~~~~\n \n Fix it by using Qt::fixed, and provide backward compatibility with Qt\n versions older than v5.14.0 that didn't provide Qt::fixed.\n \n Signed-off-by: Peter Seiderer \n Reviewed-by: Laurent Pinchart \n Signed-off-by: Laurent Pinchart \n\ndiff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 7de089571234..2960259f4213 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -31,6 +31,16 @@\n \n using namespace libcamera;\n \n+#if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n+/*\n+ * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n+ * usage of Qt::fixed unconditionally.\n+ */\n+namespace Qt {\n+constexpr auto fixed = ::fixed;\n+} /* namespace Qt */\n+#endif\n+\n /**\n * \\brief Custom QEvent to signal capture completion\n */\n@@ -631,7 +641,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n \t\t<< \"timestamp:\" << metadata.timestamp\n-\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n+\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n \n \t/* Render the frame on the viewfinder. */\n \tviewfinder_->render(buffer, &mappedBuffers_[buffer]);\n\n\n> >> Should I re-spin the patch?\n> >> \n> >>>> \n> >>>> \t/* Render the frame on the viewfinder. */\n> >>>> \tviewfinder_->render(buffer, &mappedBuffers_[buffer]);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 248C961027\n\tfor ;\n\tMon, 8 Jun 2020 23:32:52 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85D14525;\n\tMon, 8 Jun 2020 23:32:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DDSMe9Op\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591651971;\n\tbh=RL7yxH4c5dwOr2dono/q++Nkt0WjLhTE2ncOxOiWJdE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DDSMe9Op/V8iaENAbmNeN2e3EKqlpsIVE0SBYitWf59X34aTF8tK8ejcXucW0+XXO\n\tLn64gNVLBWCuC5lqmbGzvV+Aq2MXZrhQ/YITSGVRV0E7gfAy2X28zslcO4HadqgMrG\n\t5KGvfsz8KpEsCyZnAbBDTDDNLSQwY0D4ZA7N5WPc=","Date":"Tue, 9 Jun 2020 00:32:32 +0300","From":"Laurent Pinchart ","To":"Peter Seiderer ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200608213232.GQ5896@pendragon.ideasonboard.com>","References":"<20200607165655.4844-1-ps.report@gmx.net>\n\t<20200607171729.GB5958@pendragon.ideasonboard.com>\n\t<20200607235826.7723842d@gmx.net>\n\t<20200608011856.GH22208@pendragon.ideasonboard.com>\n\t<20200608231102.315d3848@gmx.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200608231102.315d3848@gmx.net>","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 08 Jun 2020 21:32:52 -0000"}},{"id":5148,"web_url":"https://patchwork.libcamera.org/comment/5148/","msgid":"<20200608234028.70b9426a@gmx.net>","date":"2020-06-08T21:40:28","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":52,"url":"https://patchwork.libcamera.org/api/people/52/","name":"Peter Seiderer","email":"ps.report@gmx.net"},"content":"Hello Laurent,\n\nOn Tue, 9 Jun 2020 00:32:32 +0300, Laurent Pinchart wrote:\n\n> Hi Peter,\n> \n> On Mon, Jun 08, 2020 at 11:11:02PM +0200, Peter Seiderer wrote:\n> > On Mon, 8 Jun 2020 04:18:56 +0300, Laurent Pinchart wrote: \n> > > On Sun, Jun 07, 2020 at 11:58:26PM +0200, Peter Seiderer wrote: \n> > >> On Sun, 7 Jun 2020 20:17:29 +0300, Laurent Pinchart wrote: \n> > >>> On Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote: \n> > >>>> Fixes:\n> > >>>> \n> > >>>> ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> > >>>> 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > >>>> | ^~~~~\n> > >>>> Signed-off-by: Peter Seiderer \n> > >>>> ---\n> > >>>> src/qcam/main_window.cpp | 2 +-\n> > >>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >>>> \n> > >>>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > >>>> index 7de0895..1f3bdc1 100644\n> > >>>> --- a/src/qcam/main_window.cpp\n> > >>>> +++ b/src/qcam/main_window.cpp\n> > >>>> @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> > >>>> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> > >>>> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> > >>>> \t\t<< \"timestamp:\" << metadata.timestamp\n> > >>>> -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> > >>>> +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps; \n> > >>> \n> > >>> Hasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\n> > >>> compatibility with all older Qt versions ? \n> > >> \n> > >> Yes, you are right...\n> > >> \n> > >>> One option I haven't tested would be to keep Qt::fixed here, and add, at\n> > >>> the top of this file, something along those lines.\n> > >>> \n> > >>> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> > >>> /*\n> > >>> * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> > >>> * usage of Qt::fixed unconditionally.\n> > >>> */\n> > >>> namespace Qt {\n> > >>> using fixed = ::fixed;\n> > >>> } /* namespace Qt */\n> > >>> #endif\n> > >>> \n> > >>> Would you be able to test this ? \n> > >> \n> > >> Did try with Qt5.10.1 (with a standalone test program), leads to:\n> > >> \n> > >> test-qt-fixed.cpp:10:17: error: ‘fixed’ in namespace ‘::’ does not name a type\n> > >> 10 | using fixed = ::fixed;\n> > >> | ^~~~~\n> > >> \n> > >> \n> > >> Alternative would be:\n> > >> \n> > >> [...]\n> > >> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n> > >> \t<< fixed\n> > >> #else\n> > >> \t<< Qt::fixed\n> > >> #endif\n> > >> [...] \n> > > \n> > > That would require an #if for every usage of fixed, which isn't very\n> > > nice (even if we use it in a single place only). I've tested the\n> > > following v5.14 but can't easily test on older Qt versions. Could you\n> > > test v5.10 ? \n> > \n> > Yes, can do...\n> > \n> > > #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n> > > /*\n> > > * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> > > * usage of Qt::fixed unconditionally.\n> > > */\n> > > namespace Qt {\n> > > constexpr auto fixed = ::fixed;\n> > > } /* namespace Qt */\n> > > #endif \n> > \n> > This one works with Qt5.10.1... \n> \n> Great ! Thank you for testing.\n> \n> Are you fine with the following patch ? If so there's no need to send a\n> new version.\n\nYes, fine for me...\n\nRegards,\nPeter\n \n> \n> commit 3dd6902e12c73cdcb5ef1a0ce0aceee5c9008306\n> Author: Peter Seiderer \n> Date: Sun Jun 7 18:56:55 2020 +0200\n> \n> qcam: Fix compilation with Qt v5.15.0\n> \n> Starting from Qt v5.15.0, the QTextStreamFunctions::fixed function\n> used to configure formatting on QTextStream is deprecated in favour of\n> Qt::fixed. This causes a compilation error:\n> \n> ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> | ^~~~~\n> \n> Fix it by using Qt::fixed, and provide backward compatibility with Qt\n> versions older than v5.14.0 that didn't provide Qt::fixed.\n> \n> Signed-off-by: Peter Seiderer \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 7de089571234..2960259f4213 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -31,6 +31,16 @@\n> \n> using namespace libcamera;\n> \n> +#if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n> +/*\n> + * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> + * usage of Qt::fixed unconditionally.\n> + */\n> +namespace Qt {\n> +constexpr auto fixed = ::fixed;\n> +} /* namespace Qt */\n> +#endif\n> +\n> /**\n> * \\brief Custom QEvent to signal capture completion\n> */\n> @@ -631,7 +641,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> \t\t<< \"timestamp:\" << metadata.timestamp\n> -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n> \n> \t/* Render the frame on the viewfinder. */\n> \tviewfinder_->render(buffer, &mappedBuffers_[buffer]);\n> \n> \n> > >> Should I re-spin the patch?\n> > >> \n> > >>>> \n> > >>>> \t/* Render the frame on the viewfinder. */\n> > >>>> \tviewfinder_->render(buffer, &mappedBuffers_[buffer]); \n>","headers":{"Return-Path":"","Received":["from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5F8A61027\n\tfor ;\n\tMon, 8 Jun 2020 23:40:29 +0200 (CEST)","from localhost ([62.216.209.102]) by mail.gmx.com (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1Mq2nA-1jCsO71OxG-00nAS1;\n\tMon, 08 Jun 2020 23:40:29 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"eXKWXVRD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1591652429;\n\tbh=9acLGdsdjV0r4OLsurC/whciDnCjjTLFh/Yk611dxQs=;\n\th=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References;\n\tb=eXKWXVRD/HZxPRgxJzmVEZPFGVBR8OMi5OX+on0xmsXQlU1RIyITmnWl4aa1hYlVD\n\tJD9cmeQEGO+MCPanKVUBu0ZGb0zM92XTwaNsni2ii1V3HwxJaNMDYxq5T92jv6cH0O\n\twveMSajHCFfJqanX8ANbtXvVpbaizI8mJKh6cfZA=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Date":"Mon, 8 Jun 2020 23:40:28 +0200","From":"Peter Seiderer ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200608234028.70b9426a@gmx.net>","In-Reply-To":"<20200608213232.GQ5896@pendragon.ideasonboard.com>","References":"<20200607165655.4844-1-ps.report@gmx.net>\n\t<20200607171729.GB5958@pendragon.ideasonboard.com>\n\t<20200607235826.7723842d@gmx.net>\n\t<20200608011856.GH22208@pendragon.ideasonboard.com>\n\t<20200608231102.315d3848@gmx.net>\n\t<20200608213232.GQ5896@pendragon.ideasonboard.com>","X-Mailer":"Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-suse-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:B9wFxTVnamBuZUkS5pxXQt3P7S3GfB/K/Jfo+qKJV0Xcv0PM8Yr\n\tZaDo4ybqIWZn9dvAkSTPAMZL/X3td/OCsrmXd065TmCk9zsENldLS2pUfbsF/A7MX6/YXww\n\tYGrxh8OEkeFhLSzdprgYAv+l32jWv8E6fZQ5MiuCNDAXJXrrcLz2crSVyD4a1NJUKT+3BwO\n\tqyQdC92z9OOMe5WCfMymg==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:tSg8y+cdzuI=:9w1Mk8iQWNg1qth4aerQSS\n\tFHaoRdKLToITtDElLszcsvXl/5WsMIupVrpL28Y9E3VN2diB8R88Marup76qxu+yte2kf3Of4\n\t4po69EtDzsFY7jkf8m5GBYqwXhpjw09P0E7DYjlCX6bvlAv6KiidMTSGpmLiBPTAVIr6WU9C5\n\tJHqhal53nXRgHQRH5JaVwkZC7HlFDmbDQvhGavKCVNmns8Dv9EMOl8FcnrYHK9aWbTBCeO+0I\n\tXe840+yLzBhB9+dmB5CL+5HLbkmQMHX+Y/Oe7SERQwvbYrFTD0vKf1SptDTcVkHE+QTrXrlXH\n\tOCLcjdv+pmL7iMVRxXFdZAHwscOQo5970A/CCWyP/u0QRV+XrtUfgFLHslNnyDhTGTkhhbLUk\n\tg966p3P7NWVZTsZvDT8GDSb3ovclAGLfi3P1l61LRikjoK26+Re/ysvy5QS1JVUZ/vhZJwMVJ\n\tlQ/wBYfRki1IDSEq7MhBxCiDybkBxCtbblfSyAM8wHx8qbXYvuSXN7ioNwEshHPthDhi4LJfn\n\tMWx62eOgbju8OZM3/B4b03YsFu9LO0d/SZx5gAhAVUWJcfScB5bttNZByKxZoPNbBaaxeDZYa\n\tObGcDqOjFy6TC72DuMf4sBahqTFsUu80Aavw8j0tHd3qARYGi9JqgZthNIgGdOpqABaaMsLfs\n\tTqPnyDA75BIFemEdqp6p96dxGOrf19XpuR9xIOhP7MvqemJPaMefcysnrHDqvMrwgsjbLuhJW\n\tnFes3qEQRwAv9fhl4yRzEV+lR2k+FpSPDczPgdzl31OlmxSqmX5BQdcxCHnPaof+q6XR6G9XA\n\tfNBzo1r3HNXxEQ5TO8LKoZMRjuDrxwJ7J9mqiNn3/tYAoGPSrg0XDXxnf5yHJzHuOdVpfvze5\n\tHXf2rvyk4RrbsYCLI/hxd2JEGSbbnY0QtBjQTApcJZBHrZMiNct/Uurdib1OVES76pc7nAoWB\n\tZjHJKpanGdC0Z+OQewf+05lJOeFPsQBvFBXRHACxrr5BPn4W00tjswV1TW6EI+y2SCf+ohnYR\n\taCJqllM/x0GlqLLf/uAj7Gl5rbGww0EV2Fm+K3SP3NVuYPon5wouNJOm6uao4vrZseBV6MHig\n\tib8bq55dCgW5wljUFfroqJlaKrGpQOvODBTy9dNMPhd4QBK7VkJFSqO6JQnuVqBWwOTC9s2yr\n\t+7MDX3Zo0mfL3J3jlrZzziIeJoTKK/6AWGukCLG2UPtUBnX0Ade1hdKThE55na3TQKharVU6n\n\tVUs0pe/VA4keMZpd+","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 08 Jun 2020 21:40:30 -0000"}},{"id":5150,"web_url":"https://patchwork.libcamera.org/comment/5150/","msgid":"","date":"2020-06-09T10:20:56","subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Peter, Laurent,\n\nOn 08/06/2020 22:32, Laurent Pinchart wrote:\n> Hi Peter,\n> \n> On Mon, Jun 08, 2020 at 11:11:02PM +0200, Peter Seiderer wrote:\n>> On Mon, 8 Jun 2020 04:18:56 +0300, Laurent Pinchart wrote:\n>>> On Sun, Jun 07, 2020 at 11:58:26PM +0200, Peter Seiderer wrote:\n>>>> On Sun, 7 Jun 2020 20:17:29 +0300, Laurent Pinchart wrote: \n>>>>> On Sun, Jun 07, 2020 at 06:56:55PM +0200, Peter Seiderer wrote: \n>>>>>> Fixes:\n>>>>>>\n>>>>>> ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n>>>>>> 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n>>>>>> | ^~~~~\n>>>>>> Signed-off-by: Peter Seiderer \n>>>>>> ---\n>>>>>> src/qcam/main_window.cpp | 2 +-\n>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>>>\n>>>>>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>>>>>> index 7de0895..1f3bdc1 100644\n>>>>>> --- a/src/qcam/main_window.cpp\n>>>>>> +++ b/src/qcam/main_window.cpp\n>>>>>> @@ -631,7 +631,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n>>>>>> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n>>>>>> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n>>>>>> \t\t<< \"timestamp:\" << metadata.timestamp\n>>>>>> -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n>>>>>> +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps; \n>>>>>\n>>>>> Hasn't Qt::fixed been introduced in Qt v5.14, wouldn't this break\n>>>>> compatibility with all older Qt versions ? \n>>>>\n>>>> Yes, you are right...\n>>>> \n>>>>> One option I haven't tested would be to keep Qt::fixed here, and add, at\n>>>>> the top of this file, something along those lines.\n>>>>>\n>>>>> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n>>>>> /*\n>>>>> * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n>>>>> * usage of Qt::fixed unconditionally.\n>>>>> */\n>>>>> namespace Qt {\n>>>>> using fixed = ::fixed;\n>>>>> } /* namespace Qt */\n>>>>> #endif\n>>>>>\n>>>>> Would you be able to test this ? \n>>>>\n>>>> Did try with Qt5.10.1 (with a standalone test program), leads to:\n>>>>\n>>>> test-qt-fixed.cpp:10:17: error: ‘fixed’ in namespace ‘::’ does not name a type\n>>>> 10 | using fixed = ::fixed;\n>>>> | ^~~~~\n>>>>\n>>>>\n>>>> Alternative would be:\n>>>>\n>>>> [...]\n>>>> #if QT_VERSION <= QT_VERSION_CHECK(5, 14, 0)\n>>>> \t<< fixed\n>>>> #else\n>>>> \t<< Qt::fixed\n>>>> #endif\n>>>> [...] \n>>>\n>>> That would require an #if for every usage of fixed, which isn't very\n>>> nice (even if we use it in a single place only). I've tested the\n>>> following v5.14 but can't easily test on older Qt versions. Could you\n>>> test v5.10 ?\n>>\n>> Yes, can do...\n>>\n>>> #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n>>> /*\n>>> * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n>>> * usage of Qt::fixed unconditionally.\n>>> */\n>>> namespace Qt {\n>>> constexpr auto fixed = ::fixed;\n>>> } /* namespace Qt */\n>>> #endif\n>>\n>> This one works with Qt5.10.1...\n> \n> Great ! Thank you for testing.\n> \n> Are you fine with the following patch ? If so there's no need to send a\n> new version.\n> \n> commit 3dd6902e12c73cdcb5ef1a0ce0aceee5c9008306\n> Author: Peter Seiderer \n> Date: Sun Jun 7 18:56:55 2020 +0200\n> \n> qcam: Fix compilation with Qt v5.15.0\n> \n> Starting from Qt v5.15.0, the QTextStreamFunctions::fixed function\n> used to configure formatting on QTextStream is deprecated in favour of\n> Qt::fixed. This causes a compilation error:\n> \n> ../src/qcam/main_window.cpp:634:16: error: ‘QTextStream& QTextStreamFunctions::fixed(QTextStream&)’ is deprecated: Use Qt::fixed [-Werror=deprecated-declarations]\n> 634 | << \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> | ^~~~~\n> \n> Fix it by using Qt::fixed, and provide backward compatibility with Qt\n> versions older than v5.14.0 that didn't provide Qt::fixed.\n> \n> Signed-off-by: Peter Seiderer \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \nTested-by: Kieran Bingham # 5.12.8\n\n\nRun-time dependency qt5 (modules: Core, Gui, Widgets) found: YES 5.12.8\n(pkg-config)\nDetecting Qt5 tools\n moc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/moc, 5.12.8)\n uic: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/uic, 5.12.8)\n rcc: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/rcc, 5.12.8)\n lrelease: YES (/usr/lib/x86_64-linux-gnu/qt5/bin/lrelease, 5.12.8)\n\n--\nKieran\n\n\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 7de089571234..2960259f4213 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -31,6 +31,16 @@\n> \n> using namespace libcamera;\n> \n> +#if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)\n> +/*\n> + * Qt::fixed was introduced in v5.14, and ::fixed deprecated in v5.15. Allow\n> + * usage of Qt::fixed unconditionally.\n> + */\n> +namespace Qt {\n> +constexpr auto fixed = ::fixed;\n> +} /* namespace Qt */\n> +#endif\n> +\n> /**\n> * \\brief Custom QEvent to signal capture completion\n> */\n> @@ -631,7 +641,7 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> \t\t<< \"bytesused:\" << metadata.planes[0].bytesused\n> \t\t<< \"timestamp:\" << metadata.timestamp\n> -\t\t<< \"fps:\" << fixed << qSetRealNumberPrecision(2) << fps;\n> +\t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n> \n> \t/* Render the frame on the viewfinder. */\n> \tviewfinder_->render(buffer, &mappedBuffers_[buffer]);\n> \n> \n>>>> Should I re-spin the patch?\n>>>> \n>>>>>> \n>>>>>> \t/* Render the frame on the viewfinder. */\n>>>>>> \tviewfinder_->render(buffer, &mappedBuffers_[buffer]); \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55DCE61687\n\tfor ;\n\tTue, 9 Jun 2020 12:20:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C90A291;\n\tTue, 9 Jun 2020 12:20:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UCcJHgfw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591698058;\n\tbh=hworAMyKnlDj6p1TdoxJxo0MnU6YTqw1b81MT43PQVI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=UCcJHgfwZLQRDQwNmevAeK3LMRmXB6jxA+3YrlK74eIcigRegYcxzFB9SA6tBJ4BM\n\tDUpbICfA6vMoSI6FayQ/P3gSFV05Ye5Si/gM+bA0M9ifjTbgA9iOE+4JD9ZWT0llgI\n\tU2Ywl5xYrvtVlUMA2ceFtVnmvsleDqd/RCzLg7lg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tPeter Seiderer ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200607165655.4844-1-ps.report@gmx.net>\n\t<20200607171729.GB5958@pendragon.ideasonboard.com>\n\t<20200607235826.7723842d@gmx.net>\n\t<20200608011856.GH22208@pendragon.ideasonboard.com>\n\t<20200608231102.315d3848@gmx.net>\n\t<20200608213232.GQ5896@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 9 Jun 2020 11:20:56 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200608213232.GQ5896@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: fix Qt5.15.0 compile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 09 Jun 2020 10:20:59 -0000"}}]