[{"id":5055,"web_url":"https://patchwork.libcamera.org/comment/5055/","msgid":"<20200605181756.GF5864@oden.dyn.berto.se>","date":"2020-06-05T18:17:56","subject":"Re: [libcamera-devel] [PATCH v2 3/7] v4l2: v4l2_camera_proxy: Fix\n\tbounds check for VIDIOC_ENUM_FMT","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-06-05 18:01:02 +0900, Paul Elder wrote:\n> VIDIOC_ENUM_FMT is meant to return -EINVAL if the requested index is out\n> of bounds. This bounds is obtained from the libcamera Camera's list of\n> formats. The bounds check for this list was incorrect; fix it.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> No change in v2\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 3df4d42b..ec6d265d 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -224,7 +224,7 @@ int V4L2CameraProxy::vidioc_enum_fmt(struct v4l2_fmtdesc *arg)\n> \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_enum_fmt\";\n> \n> \tif (!validateBufferType(arg->type) ||\n> -\t arg->index > streamConfig_.formats().pixelformats().size())\n> +\t arg->index >= streamConfig_.formats().pixelformats().size())\n> \t\treturn -EINVAL;\n> \n> \t/* \\todo Add map from format to description. */\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1008603C6\n\tfor ;\n\tFri, 5 Jun 2020 20:17:57 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id b6so12929742ljj.1\n\tfor ;\n\tFri, 05 Jun 2020 11:17:57 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tz15sm1075556ljo.102.2020.06.05.11.17.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jun 2020 11:17:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"DoQvzGJz\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=VIgC5SAMloybAX9YMTzQyn1Pa8Ju4GiqkwL9eKpRq2U=;\n\tb=DoQvzGJzKK8cabvg8piW7OaOs6lQampo1N/gn5EBSlfppQVUVLUzYHpBlMHnjedBgq\n\tFzaiHKt4sdexj8jW+M5GodxEQ5xdSOd9ha/np2V+kNi7+ctiMHq4e2CPFLvqQNrueGjx\n\tCWy6ZW9u4rkFYemQmBPwqB9pNX4OzhTARWUS9CUErHrBiYbHk62uHE81+gvWnrcpQM+G\n\toNj+zyOf0oW5+0BSf/puUDbhDydU71sN542nqCG8Hs6NjkETmEoPQBWsPEKbvdsUF+Vy\n\tygFzi1X9CNaWV7Q+NaOXsv3NXg+15uWk5RKIYl3FhSR6UBBfUEu1y8G+b46jLQJUfwxr\n\trDvQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=VIgC5SAMloybAX9YMTzQyn1Pa8Ju4GiqkwL9eKpRq2U=;\n\tb=CozE2bkl2byNytIMM0+wccLhpDAxcgJPW+H/7ZDFxJf6OHuaXMn6lZFGVq8C96GXUW\n\tO0SbpdjWhzWd8Dl/DZm6cTZ176fcDatHd1aQO/RicMMr0J+P1/2BTBUfNp1yj+M53iDX\n\tMSuckCx5HfMCAEkROwWPOaWkT3PDxxMEBMj3Pba4BEwRdJj3BuS14BkVOniZAC4gLeNU\n\tTyBP3lITeHkgmwII3F/2Q9pzBsmVd89hIxocqSvrtOjE4x9u6ayqgPAzqqSu5+EoODwW\n\tVPUwsH6Ag1noI//rdmwAeQRZHpN+Ds9dvFpuSPqYckx42WTLBcsV0leWB+djQoLldh2o\n\typeQ==","X-Gm-Message-State":"AOAM531SJvx2tNHbRRZvF5kPz5+R2kWGJZtjBikRTVaM4cAqHLLvXOyj\n\tZ3WODp38ggtL6lGrpzFfUPkAhcFoEnH91w==","X-Google-Smtp-Source":"ABdhPJxImzqGAr0bRr418KYe0vrxN2YkhbtGyWFTJ+0ViWveoWW0E1RLE1Xv8gmX3uLGuJrjaV6kgQ==","X-Received":"by 2002:a2e:751a:: with SMTP id\n\tq26mr4897695ljc.258.1591381077319; \n\tFri, 05 Jun 2020 11:17:57 -0700 (PDT)","Date":"Fri, 5 Jun 2020 20:17:56 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200605181756.GF5864@oden.dyn.berto.se>","References":"<20200605090106.15424-1-paul.elder@ideasonboard.com>\n\t<20200605090106.15424-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200605090106.15424-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/7] v4l2: v4l2_camera_proxy: Fix\n\tbounds check for VIDIOC_ENUM_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Jun 2020 18:17:58 -0000"}}]