[{"id":5040,"web_url":"https://patchwork.libcamera.org/comment/5040/","msgid":"<20200605101531.GE5852@pendragon.ideasonboard.com>","date":"2020-06-05T10:15:31","subject":"Re: [libcamera-devel] [PATCH v2 2/7] IPAManager: remove instance()\n\tand make createIPA() static","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 05, 2020 at 06:01:01PM +0900, Paul Elder wrote:\n> As the only usage of IPAManager::instance() is by the pipeline handlers\n> to call IPAManager::createIPA(), remove the former and make the latter\n> static. Update the pipeline handlers and tests accordingly.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> \n> ---\n> New in v2\n> ---\n>  include/libcamera/internal/ipa_manager.h       |  8 +++-----\n>  src/libcamera/ipa_manager.cpp                  | 18 ++----------------\n>  .../pipeline/raspberrypi/raspberrypi.cpp       |  2 +-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp       |  2 +-\n>  src/libcamera/pipeline/vimc/vimc.cpp           |  2 +-\n>  test/ipa/ipa_interface_test.cpp                |  2 +-\n>  6 files changed, 9 insertions(+), 25 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> index 43f700d3..05643e5e 100644\n> --- a/include/libcamera/internal/ipa_manager.h\n> +++ b/include/libcamera/internal/ipa_manager.h\n> @@ -25,11 +25,9 @@ public:\n>  \tIPAManager();\n>  \t~IPAManager();\n>  \n> -\tstatic IPAManager *instance();\n> -\n> -\tstd::unique_ptr<IPAProxy> createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t    uint32_t maxVersion,\n> -\t\t\t\t\t    uint32_t minVersion);\n> +\tstatic std::unique_ptr<IPAProxy> createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t\t   uint32_t maxVersion,\n> +\t\t\t\t\t\t   uint32_t minVersion);\n>  \n>  private:\n>  \tstatic IPAManager *self_;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index abb681a3..9d0c2069 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -159,20 +159,6 @@ IPAManager::~IPAManager()\n>  \tself_ = nullptr;\n>  }\n>  \n> -/**\n> - * \\brief Retrieve the IPA manager instance\n> - *\n> - * The IPAManager is a singleton and can't be constructed manually. This\n> - * function shall instead be used to retrieve the single global instance of the\n> - * manager.\n> - *\n> - * \\return The IPA manager instance\n> - */\n> -IPAManager *IPAManager::instance()\n> -{\n> -\treturn self_;\n> -}\n> -\n>  /**\n>   * \\brief Identify shared library objects within a directory\n>   * \\param[in] libDir The directory to search for shared objects\n> @@ -274,7 +260,7 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,\n>  {\n>  \tIPAModule *m = nullptr;\n>  \n> -\tfor (IPAModule *module : modules_) {\n> +\tfor (IPAModule *module : self_->modules_) {\n>  \t\tif (module->match(pipe, minVersion, maxVersion)) {\n>  \t\t\tm = module;\n>  \t\t\tbreak;\n> @@ -290,7 +276,7 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,\n>  \t *\n>  \t * \\todo Implement a better proxy selection\n>  \t */\n> -\tconst char *proxyName = isSignatureValid(m)\n> +\tconst char *proxyName = self_->isSignatureValid(m)\n>  \t\t\t      ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n>  \tIPAProxyFactory *pf = nullptr;\n>  \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index e16a9c7f..b9b88506 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1118,7 +1118,7 @@ void RPiCameraData::frameStarted(uint32_t sequence)\n>  \n>  int RPiCameraData::loadIPA()\n>  {\n> -\tipa_ = IPAManager::instance()->createIPA(pipe_, 1, 1);\n> +\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n>  \tif (!ipa_)\n>  \t\treturn -ENOENT;\n>  \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index d807fc2c..900f873a 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -395,7 +395,7 @@ private:\n>  \n>  int RkISP1CameraData::loadIPA()\n>  {\n> -\tipa_ = IPAManager::instance()->createIPA(pipe_, 1, 1);\n> +\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n>  \tif (!ipa_)\n>  \t\treturn -ENOENT;\n>  \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index ba9fca50..3881545b 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -410,7 +410,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n>  \n>  \tstd::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this, media);\n>  \n> -\tdata->ipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n> +\tdata->ipa_ = IPAManager::createIPA(this, 0, 0);\n>  \tif (data->ipa_ != nullptr) {\n>  \t\tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n>  \t\tdata->ipa_->init(IPASettings{ conf });\n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 153493ba..1bc93a63 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -95,7 +95,7 @@ protected:\n>  \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n>  \t\tTimer timer;\n>  \n> -\t\tipa_ = IPAManager::instance()->createIPA(pipe_.get(), 0, 0);\n> +\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n>  \t\tif (!ipa_) {\n>  \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n>  \t\t\treturn TestFail;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E791D603C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jun 2020 12:15:50 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 513C227C;\n\tFri,  5 Jun 2020 12:15:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rCSjoTUN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591352150;\n\tbh=9vX+v2T+Zk8SsKiIC27hw/G7mqKgAOC6e9E5fa1EVgk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rCSjoTUN+pmItuwdf6kAEkkStF0Jjw0J7NTSSIOjtwWIhJbJ6mMQ8dMJUXmDN9T/n\n\tocLv+NXHy8Dv6bVY3RBgeTa+NX2UpbslmA2i3WIqsATX/V5xxPUJ+O+crZudr45o1/\n\tGsu7LnRUVvjcXgcZicpmA+dmKduk1DeAY/GXx0i4=","Date":"Fri, 5 Jun 2020 13:15:31 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200605101531.GE5852@pendragon.ideasonboard.com>","References":"<20200605090106.15424-1-paul.elder@ideasonboard.com>\n\t<20200605090106.15424-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200605090106.15424-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/7] IPAManager: remove instance()\n\tand make createIPA() static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 05 Jun 2020 10:15:51 -0000"}},{"id":5054,"web_url":"https://patchwork.libcamera.org/comment/5054/","msgid":"<20200605180939.GE5864@oden.dyn.berto.se>","date":"2020-06-05T18:09:39","subject":"Re: [libcamera-devel] [PATCH v2 2/7] IPAManager: remove instance()\n\tand make createIPA() static","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-06-05 18:01:01 +0900, Paul Elder wrote:\n> As the only usage of IPAManager::instance() is by the pipeline handlers\n> to call IPAManager::createIPA(), remove the former and make the latter\n> static. Update the pipeline handlers and tests accordingly.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> \n> ---\n> New in v2\n> ---\n>  include/libcamera/internal/ipa_manager.h       |  8 +++-----\n>  src/libcamera/ipa_manager.cpp                  | 18 ++----------------\n>  .../pipeline/raspberrypi/raspberrypi.cpp       |  2 +-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp       |  2 +-\n>  src/libcamera/pipeline/vimc/vimc.cpp           |  2 +-\n>  test/ipa/ipa_interface_test.cpp                |  2 +-\n>  6 files changed, 9 insertions(+), 25 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> index 43f700d3..05643e5e 100644\n> --- a/include/libcamera/internal/ipa_manager.h\n> +++ b/include/libcamera/internal/ipa_manager.h\n> @@ -25,11 +25,9 @@ public:\n>  \tIPAManager();\n>  \t~IPAManager();\n>  \n> -\tstatic IPAManager *instance();\n> -\n> -\tstd::unique_ptr<IPAProxy> createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t    uint32_t maxVersion,\n> -\t\t\t\t\t    uint32_t minVersion);\n> +\tstatic std::unique_ptr<IPAProxy> createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t\t   uint32_t maxVersion,\n> +\t\t\t\t\t\t   uint32_t minVersion);\n>  \n>  private:\n>  \tstatic IPAManager *self_;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index abb681a3..9d0c2069 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -159,20 +159,6 @@ IPAManager::~IPAManager()\n>  \tself_ = nullptr;\n>  }\n>  \n> -/**\n> - * \\brief Retrieve the IPA manager instance\n> - *\n> - * The IPAManager is a singleton and can't be constructed manually. This\n> - * function shall instead be used to retrieve the single global instance of the\n> - * manager.\n> - *\n> - * \\return The IPA manager instance\n> - */\n> -IPAManager *IPAManager::instance()\n> -{\n> -\treturn self_;\n> -}\n> -\n>  /**\n>   * \\brief Identify shared library objects within a directory\n>   * \\param[in] libDir The directory to search for shared objects\n> @@ -274,7 +260,7 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,\n>  {\n>  \tIPAModule *m = nullptr;\n>  \n> -\tfor (IPAModule *module : modules_) {\n> +\tfor (IPAModule *module : self_->modules_) {\n>  \t\tif (module->match(pipe, minVersion, maxVersion)) {\n>  \t\t\tm = module;\n>  \t\t\tbreak;\n> @@ -290,7 +276,7 @@ std::unique_ptr<IPAProxy> IPAManager::createIPA(PipelineHandler *pipe,\n>  \t *\n>  \t * \\todo Implement a better proxy selection\n>  \t */\n> -\tconst char *proxyName = isSignatureValid(m)\n> +\tconst char *proxyName = self_->isSignatureValid(m)\n>  \t\t\t      ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n>  \tIPAProxyFactory *pf = nullptr;\n>  \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index e16a9c7f..b9b88506 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1118,7 +1118,7 @@ void RPiCameraData::frameStarted(uint32_t sequence)\n>  \n>  int RPiCameraData::loadIPA()\n>  {\n> -\tipa_ = IPAManager::instance()->createIPA(pipe_, 1, 1);\n> +\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n>  \tif (!ipa_)\n>  \t\treturn -ENOENT;\n>  \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index d807fc2c..900f873a 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -395,7 +395,7 @@ private:\n>  \n>  int RkISP1CameraData::loadIPA()\n>  {\n> -\tipa_ = IPAManager::instance()->createIPA(pipe_, 1, 1);\n> +\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n>  \tif (!ipa_)\n>  \t\treturn -ENOENT;\n>  \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index ba9fca50..3881545b 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -410,7 +410,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n>  \n>  \tstd::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this, media);\n>  \n> -\tdata->ipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n> +\tdata->ipa_ = IPAManager::createIPA(this, 0, 0);\n>  \tif (data->ipa_ != nullptr) {\n>  \t\tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n>  \t\tdata->ipa_->init(IPASettings{ conf });\n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 153493ba..1bc93a63 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -95,7 +95,7 @@ protected:\n>  \t\tEventDispatcher *dispatcher = thread()->eventDispatcher();\n>  \t\tTimer timer;\n>  \n> -\t\tipa_ = IPAManager::instance()->createIPA(pipe_.get(), 0, 0);\n> +\t\tipa_ = IPAManager::createIPA(pipe_.get(), 0, 0);\n>  \t\tif (!ipa_) {\n>  \t\t\tcerr << \"Failed to create VIMC IPA interface\" << endl;\n>  \t\t\treturn TestFail;\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F0D3603C6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jun 2020 20:09:41 +0200 (CEST)","by mail-lj1-x234.google.com with SMTP id 9so12834977ljc.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 05 Jun 2020 11:09:41 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb144sm1254136lfg.82.2020.06.05.11.09.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jun 2020 11:09:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"FeAUvH+S\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=R86n8AXGkbxaBz7GxtqKh0Fa2Ma3IUWPRa46t2A0hSg=;\n\tb=FeAUvH+Svne3kIfRj4Ld7eu19ZdOHUVQL81NpERrjIg0KYj9cpZMh0iUC/kzeMHhCM\n\tJ8m81WA4Vzir0eBvsdkZBiu8FXcsQ9vIwIhzpILH1R1fDfLbdHc+1+e8+copysuxghf7\n\teLzANskuuQf66/ESOWc2pDvQ/PyLTLn5YdtPCoxYXONlydhpOAHD5NhNScROQK8TvCks\n\tCt6fT9DSfRFF4k0+gBEtBA0WOfWv/QfD6VCe33z6s3EKU+KBe1YtXg+EmfOZKnUAvBMO\n\tOuEcJNh6AMWbhxQk4T2K+4Wpb2x3cB6SrNQgbuvwz65/6kvANMi39NlWMULQueypKbUF\n\tR62g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=R86n8AXGkbxaBz7GxtqKh0Fa2Ma3IUWPRa46t2A0hSg=;\n\tb=ngls8vsLZujUIeMz95pJrbs6mlgdVJP6Zyjg4WmUUQL3uzIwn+kCgZuVCUrI0v2bBo\n\tizM3J/oJyaWa1ne+/1PhOAqdUjvT5sl0kttxKemM4+krPXyCNrI/BFUHmQVXivh2Htws\n\tBdtTJy9wqWJuklxu+DDnXmUDA0j07EUlEsSAbmd+FskqQy5FsR1aVRkrks8ZceIfQDD8\n\tTZVhgMrXFiXBRWRXYrJlNlfPoP4xpWixnFsFwU9F/j2jeFC4QALZvCDPqRZN+QplVzMS\n\tRT7vz3zgB/5FguXVNh+L7Rp/n/KjO7VsB8Kxkfg4lk8YyDVS6d1YZM4WN6EJDBP0t20f\n\tIn7w==","X-Gm-Message-State":"AOAM532BcPagIn4exLyFoXLCvu665cpu2gZtOHVCLIvDPD0UkXI4RsCQ\n\tKEkDCmEUbIZxM8uBBjxIg+Z87baU/78HMA==","X-Google-Smtp-Source":"ABdhPJyAwnXaJcIjwgSwhj/71cZr1UvWPlOHzxtgJEMbBpNNU3gz9oqe3+ZBZo9+9EljoTvjSOjw3g==","X-Received":"by 2002:a05:651c:3cc:: with SMTP id\n\tf12mr5314704ljp.244.1591380580924; \n\tFri, 05 Jun 2020 11:09:40 -0700 (PDT)","Date":"Fri, 5 Jun 2020 20:09:39 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200605180939.GE5864@oden.dyn.berto.se>","References":"<20200605090106.15424-1-paul.elder@ideasonboard.com>\n\t<20200605090106.15424-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200605090106.15424-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/7] IPAManager: remove instance()\n\tand make createIPA() static","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 05 Jun 2020 18:09:41 -0000"}}]