[{"id":5028,"web_url":"https://patchwork.libcamera.org/comment/5028/","msgid":"","date":"2020-06-04T13:54:37","subject":"Re: [libcamera-devel] [PATCH 6/6] libcamera: camera: Order\n\tparameter documentation correctly","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Marvin,\n\nThis checks out too!\n\nThank you for the fixups.\n\nReviewed-by: Kieran Bingham \n\nOn 04/06/2020 14:43, Marvin Schmidt wrote:\n> ---\n> src/libcamera/camera.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index dfc3d19..6033f47 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -449,8 +449,8 @@ void Camera::Private::setState(State state)\n> \n> /**\n> * \\brief Create a camera instance\n> - * \\param[in] name The name of the camera device\n> * \\param[in] pipe The pipeline handler responsible for the camera device\n> + * \\param[in] name The name of the camera device\n> * \\param[in] streams Array of streams the camera provides\n> *\n> * The caller is responsible for guaranteeing unicity of the camera name.\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C0F3603C6\n\tfor ;\n\tThu, 4 Jun 2020 15:54:40 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D67BB29B;\n\tThu, 4 Jun 2020 15:54:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hJvkhVVc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591278880;\n\tbh=4wavB92TtiGa8kORYraJOGYiBSp3dD67K4A4GdsDQPc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=hJvkhVVc42bdzFO3OtzPtqOJaMyz1O3rwUa42BbiMivk/TcZBSSbFBcZNAz6Y2gkk\n\t3Kt7qyKpX1yaWRWtZRKkAAmh4+N2nj+cvFf/njMeYCg2dZD5/7SQtIh5F2sYxfuuUU\n\t4i2b6Ojum5EqcHAd5kjitMlO7d+qA8Odf7MP0jps=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Marvin Schmidt ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200604134300.2986113-1-marvin.schmidt1987@gmail.com>\n\t<20200604134300.2986113-7-marvin.schmidt1987@gmail.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 4 Jun 2020 14:54:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200604134300.2986113-7-marvin.schmidt1987@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 6/6] libcamera: camera: Order\n\tparameter documentation correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 13:54:40 -0000"}},{"id":5031,"web_url":"https://patchwork.libcamera.org/comment/5031/","msgid":"","date":"2020-06-05T08:16:27","subject":"Re: [libcamera-devel] [PATCH 6/6] libcamera: camera: Order\n\tparameter documentation correctly","submitter":{"id":51,"url":"https://patchwork.libcamera.org/api/people/51/","name":"Marvin Schmidt","email":"marvin.schmidt1987@gmail.com"},"content":"Am Do., 4. Juni 2020 um 15:54 Uhr schrieb Kieran Bingham\n:\n>\n> Hi Marvin,\n>\n> This checks out too!\n>\n> Thank you for the fixups.\n>\n> Reviewed-by: Kieran Bingham \n>\n\nHey Kieran,\n\nthank you for you instant review! I'm glad to help :-)\n\nI'll add your R-b tags and send v2\n\n> On 04/06/2020 14:43, Marvin Schmidt wrote:\n> > ---\n> > src/libcamera/camera.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index dfc3d19..6033f47 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -449,8 +449,8 @@ void Camera::Private::setState(State state)\n> >\n> > /**\n> > * \\brief Create a camera instance\n> > - * \\param[in] name The name of the camera device\n> > * \\param[in] pipe The pipeline handler responsible for the camera device\n> > + * \\param[in] name The name of the camera device\n> > * \\param[in] streams Array of streams the camera provides\n> > *\n> > * The caller is responsible for guaranteeing unicity of the camera name.\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B96E4603C7\n\tfor ;\n\tFri, 5 Jun 2020 10:16:38 +0200 (CEST)","by mail-wr1-x441.google.com with SMTP id h5so8777238wrc.7\n\tfor ;\n\tFri, 05 Jun 2020 01:16:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IajtfY+8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=LpnLxlvX9u1i86mhvqE1d7rA/7+DP/t2PETP9F7ipXc=;\n\tb=IajtfY+828YbbSfGML5a7ElHunDy8mLZ/g/TJf7KDm9DL51NLberOXMjDp7xKUFlBF\n\t8zHe2fa96QNjFVPp1Sqxg79+pTO//CjxxzWLikGb+Y6YQw3mTaTxe53eVWuPJjcRdlba\n\tFzBZ5s+sUxXzg/25fthr0/vIQedj/F1QxKEiRYV20ByQW5+sPGsrbRf4b41yYcR9gSEi\n\tyggnei2OYK3HswbyCR/eUgqmbwit/QGIBAOd+81ciHiZpHeG86p8ew1t0x8DfXq48Eun\n\t6rwHYFjhi+AR0DCwCC5E/uFNLUbiMJQTqLWY6rHNss1NoUPvxEuBkefAxD4cVo1X3+VZ\n\tsjuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=LpnLxlvX9u1i86mhvqE1d7rA/7+DP/t2PETP9F7ipXc=;\n\tb=f+wU50jqwdV9j7QZfutMYQsv3Zv5oevR7HVbe/ik2VysyLrpQKVbXe0aE0J+IcXUWe\n\t5lA6Bs66sl8S+jFkfpsFVQIO71fzl6VO5u8dxeb/e2dcZXJ4uzP78VF9AHb6TXauRkoL\n\tWjqtBdzrrvcsdSL5pzT6grb5TRfUxHgv9BReg6AfsD2oerKre1WKYkZQCQHDcCBo+kb2\n\t4JwnxN1A3w1rwxW2o0MsIp9L76yaio2VX0sUfIAv986Xk2CzWbW5JS18zl6h02FPxvzb\n\tCtyakEIq/F22H6kazD6uz/nIt6nUB9J9K9Wls14wfYm33/Qpbi2pmDZMGAS1bzR/Vk20\n\tlwRw==","X-Gm-Message-State":"AOAM532wnwDGxLadBcT16xLwodvlw+lwsqxgjkSIY/9/7WoJ8PmKSkvo\n\tylXOGNxGG5hBmhfbuMZq5tnaAg1T3NGITiN05b0=","X-Google-Smtp-Source":"ABdhPJw8myLjFrai9nsQYlSXgGY2pdYz92tOoA1geKfrNlcOmovZDtEtpxkOwW3IqNDVnvKfns95Z0SayU7h0BYTjp4=","X-Received":"by 2002:adf:f988:: with SMTP id f8mr9032270wrr.81.1591344998312; \n\tFri, 05 Jun 2020 01:16:38 -0700 (PDT)","MIME-Version":"1.0","References":"<20200604134300.2986113-1-marvin.schmidt1987@gmail.com>\n\t<20200604134300.2986113-7-marvin.schmidt1987@gmail.com>\n\t","In-Reply-To":"","From":"Marvin Schmidt ","Date":"Fri, 5 Jun 2020 10:16:27 +0200","Message-ID":"","To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 6/6] libcamera: camera: Order\n\tparameter documentation correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Jun 2020 08:16:39 -0000"}}]