{"id":3913,"url":"https://patchwork.libcamera.org/api/patches/3913/?format=json","web_url":"https://patchwork.libcamera.org/patch/3913/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200604090503.3779724-1-kieran.bingham@ideasonboard.com>","date":"2020-06-04T09:05:03","name":"[libcamera-devel] libcamera: pipeline: vimc: Remove unsupportable format","commit_ref":"4bd25c6f51b951b8608c027f0706dc23f31fd773","pull_url":null,"state":"accepted","archived":false,"hash":"1bd5e6931817ddaf8dbcd907f975b531851ea065","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3913/mbox/","series":[{"id":950,"url":"https://patchwork.libcamera.org/api/series/950/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=950","date":"2020-06-04T09:05:03","name":"[libcamera-devel] libcamera: pipeline: vimc: Remove unsupportable format","version":1,"mbox":"https://patchwork.libcamera.org/series/950/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3913/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3913/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16A6C603C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 Jun 2020 11:05:08 +0200 (CEST)","from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7B6429B;\n\tThu,  4 Jun 2020 11:05:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gv6Evgm7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591261507;\n\tbh=8zcZvZW2A50S7S52cez8h3/EgPTpGvlCKwF/XMKx9YA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=gv6Evgm71kKBO5rpfksd58gvAikMwIcrg7AycBksI8NiZHGxwY5ULkFR1Qq+0DWg4\n\tA+2bgnpJeiXqFk46TXctxrp7OrCX/uryBhAenR8HaB2UkGQIQjPyQ/Bz+TCPavfDHw\n\ttwtZ4mv8IuznOrQgg0N7RBv0+hZmusVB4D+4f8CE=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Thu,  4 Jun 2020 10:05:03 +0100","Message-Id":"<20200604090503.3779724-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: vimc: Remove\n\tunsupportable format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 04 Jun 2020 09:05:08 -0000"},"content":"The DRM(BGRA8888)/V4L2(ARGB8888) format is not supported by the debayer\nunit at all in VIMC.\n\nRemove it from the list of supported configurations.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 914df3476eb9..9952e36b016d 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -110,7 +110,6 @@ namespace {\n static const std::map<PixelFormat, uint32_t> pixelformats{\n \t{ PixelFormat(DRM_FORMAT_RGB888), MEDIA_BUS_FMT_BGR888_1X24 },\n \t{ PixelFormat(DRM_FORMAT_BGR888), MEDIA_BUS_FMT_RGB888_1X24 },\n-\t{ PixelFormat(DRM_FORMAT_BGRA8888), MEDIA_BUS_FMT_ARGB8888_1X32 },\n };\n \n } /* namespace */\n","prefixes":["libcamera-devel"]}