[{"id":5009,"web_url":"https://patchwork.libcamera.org/comment/5009/","msgid":"<20200604090705.GA5829@pendragon.ideasonboard.com>","date":"2020-06-04T09:07:05","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n> It can be common to have multiple build directories with different\n> configurations. Ignore them all.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> .gitignore | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.gitignore b/.gitignore\n> index f989dee3bcb0..aecf971d30aa 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -1,5 +1,5 @@\n> __pycache__/\n> -build/\n> +*build*/\n\nThat's a bit of a too generic pattern, we could later have a directory\nwith build in its name.\n\nI personally have a single build/ directory directly at the root of the\nsource tree, and create subdirectories there for different builds. All\nit requires is 'meson setup ../..' instead of 'meson setup ..' (and it\nworks fine with the the run-from-build-dir support we have). Could that\nbe a solution you would consider instead of this patch ?\n\n> patches/\n> *.patch\n> *.pyc","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC2A3603C8\n\tfor ;\n\tThu, 4 Jun 2020 11:07:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CBD529B;\n\tThu, 4 Jun 2020 11:07:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"W2eWhgLN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591261642;\n\tbh=MCr1VNVx1RIlMlyPepozuCcMEZLw5h1Qy6CcAReq1Xw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W2eWhgLNy57cK0xtH0sLkoq9JAFeUxba2+ekSMk8nYx/SyJiHwNCZ+x5+scpSDttx\n\ttL3TOuU98iwZhG1heKlvMmWeUiA62KwyhZj6zv5/VEnmyKo2w2CWlddfu3zxAvUquw\n\tP8KIh6asIJq7Pk/vRtZd9O890TeEka3lI2yVAOYI=","Date":"Thu, 4 Jun 2020 12:07:05 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200604090705.GA5829@pendragon.ideasonboard.com>","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:07:23 -0000"}},{"id":5011,"web_url":"https://patchwork.libcamera.org/comment/5011/","msgid":"<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>","date":"2020-06-04T09:09:54","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 04/06/2020 10:07, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n>> It can be common to have multiple build directories with different\n>> configurations. Ignore them all.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> .gitignore | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/.gitignore b/.gitignore\n>> index f989dee3bcb0..aecf971d30aa 100644\n>> --- a/.gitignore\n>> +++ b/.gitignore\n>> @@ -1,5 +1,5 @@\n>> __pycache__/\n>> -build/\n>> +*build*/\n> \n> That's a bit of a too generic pattern, we could later have a directory\n> with build in its name.\n> \n> I personally have a single build/ directory directly at the root of the\n> source tree, and create subdirectories there for different builds. All\n> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n> works fine with the the run-from-build-dir support we have). Could that\n> be a solution you would consider instead of this patch ?\n\n\nhow about ./*build*/ to only match on the root then.\n\n\n>> patches/\n>> *.patch\n>> *.pyc\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B0EF603C8\n\tfor ;\n\tThu, 4 Jun 2020 11:09:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A113D27C;\n\tThu, 4 Jun 2020 11:09:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F/PQ6plO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591261798;\n\tbh=TJR9BAgSad299MhILTzVzkdkojD03/mG2LjkG/58Kss=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=F/PQ6plOhZNYTMhgozJ+KUoebVxXHUd/VFHsKuCPYA1eYrYzFHnY/WROjvko2jIvh\n\tqHmrxAJ9GF5kIU4zeH99i6aTRaw/9segrrMtTKmfX40+DJbXkwl7v145CEtbZjtAmX\n\tWjwAFTY8N9XAO6gCBUbaoSwEentrkDfKqugPfVpA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>","Date":"Thu, 4 Jun 2020 10:09:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200604090705.GA5829@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:09:59 -0000"}},{"id":5014,"web_url":"https://patchwork.libcamera.org/comment/5014/","msgid":"<20200604091557.GD5829@pendragon.ideasonboard.com>","date":"2020-06-04T09:15:57","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:\n> On 04/06/2020 10:07, Laurent Pinchart wrote:\n> > Hi Kieran,\n> > \n> > Thank you for the patch.\n> > \n> > On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n> >> It can be common to have multiple build directories with different\n> >> configurations. Ignore them all.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> .gitignore | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/.gitignore b/.gitignore\n> >> index f989dee3bcb0..aecf971d30aa 100644\n> >> --- a/.gitignore\n> >> +++ b/.gitignore\n> >> @@ -1,5 +1,5 @@\n> >> __pycache__/\n> >> -build/\n> >> +*build*/\n> > \n> > That's a bit of a too generic pattern, we could later have a directory\n> > with build in its name.\n> > \n> > I personally have a single build/ directory directly at the root of the\n> > source tree, and create subdirectories there for different builds. All\n> > it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n> > works fine with the the run-from-build-dir support we have). Could that\n> > be a solution you would consider instead of this patch ?\n> \n> how about ./*build*/ to only match on the root then.\n\nI'm still cautious about patterns that could have unexpected matches :-)\nAnd what if someone wants to name their build directories differently ?\nI think .gitignore should include minimal policy, if we can restrict\nignoring the builds to a single directory, I'd prefer that (I'm even\ntempted to say we shouldn't include build/ in .gitignore, but I agree\nit's useful).\n\n> >> patches/\n> >> *.patch\n> >> *.pyc","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E0C5603C8\n\tfor ;\n\tThu, 4 Jun 2020 11:16:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 920EC29B;\n\tThu, 4 Jun 2020 11:16:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VMA1Kfpy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591262174;\n\tbh=WK7axQpojk+Hh4Im8/0LkUaNgv6fSBbruu98byelBDw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VMA1Kfpy7ZZDnxrEj3w0IOeIc8r1p4lQIDZZEpsuA46gc8OW+ieHzL4FuIcGko3cv\n\ttvJNuczEoNiOK7xkaeVOqGmF5FdbuzVbKwo/Yz244R9jt3a6B/BnEOFWxn33ObsPXi\n\tzcgcJYM3TeC8uEiYnlB0osGN5FlLWuIBtlJ7MVQI=","Date":"Thu, 4 Jun 2020 12:15:57 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200604091557.GD5829@pendragon.ideasonboard.com>","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>\n\t<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:16:15 -0000"}},{"id":5015,"web_url":"https://patchwork.libcamera.org/comment/5015/","msgid":"","date":"2020-06-04T09:22:11","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 04/06/2020 10:15, Laurent Pinchart wrote:\n> On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:\n>> On 04/06/2020 10:07, Laurent Pinchart wrote:\n>>> Hi Kieran,\n>>>\n>>> Thank you for the patch.\n>>>\n>>> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n>>>> It can be common to have multiple build directories with different\n>>>> configurations. Ignore them all.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> .gitignore | 2 +-\n>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/.gitignore b/.gitignore\n>>>> index f989dee3bcb0..aecf971d30aa 100644\n>>>> --- a/.gitignore\n>>>> +++ b/.gitignore\n>>>> @@ -1,5 +1,5 @@\n>>>> __pycache__/\n>>>> -build/\n>>>> +*build*/\n>>>\n>>> That's a bit of a too generic pattern, we could later have a directory\n>>> with build in its name.\n>>>\n>>> I personally have a single build/ directory directly at the root of the\n>>> source tree, and create subdirectories there for different builds. All\n>>> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n>>> works fine with the the run-from-build-dir support we have). Could that\n>>> be a solution you would consider instead of this patch ?\n>>\n>> how about ./*build*/ to only match on the root then.\n> \n> I'm still cautious about patterns that could have unexpected matches :-)\n> And what if someone wants to name their build directories differently ?\n\nDoes anyone else have multiple builds at the root?\n\n> I think .gitignore should include minimal policy, if we can restrict\n> ignoring the builds to a single directory, I'd prefer that (I'm even\n> tempted to say we shouldn't include build/ in .gitignore, but I agree\n> it's useful).\n\nNever mind, I'll carry it locally.\n\n\n\n> \n>>>> patches/\n>>>> *.patch\n>>>> *.pyc\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B4F4603C8\n\tfor ;\n\tThu, 4 Jun 2020 11:22:14 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B3FE29B;\n\tThu, 4 Jun 2020 11:22:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"H/o87SJL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591262533;\n\tbh=Ac5ta9/DnoCvgauCjRiwuMRcNNoKlIcN+pEoxPGjcoU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=H/o87SJLYCkB0Q4wT6GyQGWh6V8nEe5HgGOBVNyZhrYBxh3SH63sJDVmFDjbnnMaW\n\tx+TXrh/HBFlKBC3kFwu94/nC858MA/fCihmyBWcRAMB7Sfp70hRtxtqhz1rAklCSp+\n\taG315ByNn6aZFxZQDOok3aAw5lLCpYJUnLc+WbXQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>\n\t<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>\n\t<20200604091557.GD5829@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 4 Jun 2020 10:22:11 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200604091557.GD5829@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:22:14 -0000"}},{"id":5016,"web_url":"https://patchwork.libcamera.org/comment/5016/","msgid":"","date":"2020-06-04T09:22:22","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"I think my mail client didn't sync up fully before me writing my last reply.\n\nOn 6/4/20 2:45 PM, Laurent Pinchart wrote:\n> On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:\n>> On 04/06/2020 10:07, Laurent Pinchart wrote:\n>>> Hi Kieran,\n>>>\n>>> Thank you for the patch.\n>>>\n>>> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n>>>> It can be common to have multiple build directories with different\n>>>> configurations. Ignore them all.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> .gitignore | 2 +-\n>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/.gitignore b/.gitignore\n>>>> index f989dee3bcb0..aecf971d30aa 100644\n>>>> --- a/.gitignore\n>>>> +++ b/.gitignore\n>>>> @@ -1,5 +1,5 @@\n>>>> __pycache__/\n>>>> -build/\n>>>> +*build*/\n>>> That's a bit of a too generic pattern, we could later have a directory\n>>> with build in its name.\n>>>\n>>> I personally have a single build/ directory directly at the root of the\n>>> source tree, and create subdirectories there for different builds. All\n>>> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n>>> works fine with the the run-from-build-dir support we have). Could that\n>>> be a solution you would consider instead of this patch ?\n>> how about ./*build*/ to only match on the root then.\n> I'm still cautious about patterns that could have unexpected matches :-)\n> And what if someone wants to name their build directories differently ?\n> I think .gitignore should include minimal policy, if we can restrict\n> ignoring the builds to a single directory, I'd prefer that (I'm even\n> tempted to say we shouldn't include build/ in .gitignore, but I agree\n\nAfter reading this reasoning, I remembered that I have seen directories\n\nlike 'build-aux/' at many places(which is part of the git repo) and \ngenerally contains various\n\npackaging specs for distros and their components. So maybe, we need to think\n\nlittle bit more..\n\n> it's useful).\n>\n>>>> patches/\n>>>> *.patch\n>>>> *.pyc","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71158603C8\n\tfor ;\n\tThu, 4 Jun 2020 11:22:24 +0200 (CEST)","by filterdrecv-p3mdw1-6f5df8956d-w9s4g with SMTP id\n\tfilterdrecv-p3mdw1-6f5df8956d-w9s4g-18-5ED8BD4E-2E\n\t2020-06-04 09:22:22.962013565 +0000 UTC m=+47313.975304752","from mail.uajain.com (unknown)\n\tby ismtpd0006p1hnd1.sendgrid.net (SG) with ESMTP\n\tid FoPg8-VMSVCMuWt_kebMqw Thu, 04 Jun 2020 09:22:22.525 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"vTAL4LZc\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:cc:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=JlxgXflWsB4YbtiXPYOpjegJezoWXmGxSbLyGtW+EZI=;\n\tb=vTAL4LZcUX4IqGD8o7VRFIoiYnqhKGm/PYB9dLdZc73mtJU+ni+t8b/Gsdzqy5xNIq1b\n\tpyZRbM0jnuRyT39qa2LoKy/HUDLh7/m9NVS35wWwz1ErzoGG/mC3ji9zhneH2qybpD/uOi\n\tfUM4w0sSp7CeMhC2G+BLgCsXdajVhDQME=","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>\n\t<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>\n\t<20200604091557.GD5829@pendragon.ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Thu, 04 Jun 2020 09:22:22 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<20200604091557.GD5829@pendragon.ideasonboard.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcQmPzxg2d8HRoKJI5HeDXckODWQrM4U2/3eC+mZ8YaPi2WYoOTi5iGx0hXQJ8503U+k4lCukr1IV9FsN3IIDj6bOEe6jxFQPyiKSTgk8yUSNT2gADsQ18h8YyOp6wsK1dQ1oEbgSKk6V/To0cd6ldNnSK9ZqiYb47Q5OBsyRDrpOsr06feEEYk6eYhOuOEYqZEdYq2EmqB+XsYK5iweK28g==","To":"Laurent Pinchart , Kieran Bingham\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:22:25 -0000"}},{"id":5017,"web_url":"https://patchwork.libcamera.org/comment/5017/","msgid":"<176dcfea-3241-5940-7d74-ff42b4ee2630@ideasonboard.com>","date":"2020-06-04T09:26:39","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 04/06/2020 10:22, Umang Jain wrote:\n> I think my mail client didn't sync up fully before me writing my last\n> reply.\n> \n> On 6/4/20 2:45 PM, Laurent Pinchart wrote:\n>> On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:\n>>> On 04/06/2020 10:07, Laurent Pinchart wrote:\n>>>> Hi Kieran,\n>>>>\n>>>> Thank you for the patch.\n>>>>\n>>>> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n>>>>> It can be common to have multiple build directories with different\n>>>>> configurations. Ignore them all.\n>>>>>\n>>>>> Signed-off-by: Kieran Bingham \n>>>>> ---\n>>>>>   .gitignore | 2 +-\n>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>>\n>>>>> diff --git a/.gitignore b/.gitignore\n>>>>> index f989dee3bcb0..aecf971d30aa 100644\n>>>>> --- a/.gitignore\n>>>>> +++ b/.gitignore\n>>>>> @@ -1,5 +1,5 @@\n>>>>>   __pycache__/\n>>>>> -build/\n>>>>> +*build*/\n>>>> That's a bit of a too generic pattern, we could later have a directory\n>>>> with build in its name.\n>>>>\n>>>> I personally have a single build/ directory directly at the root of the\n>>>> source tree, and create subdirectories there for different builds. All\n>>>> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n>>>> works fine with the the run-from-build-dir support we have). Could that\n>>>> be a solution you would consider instead of this patch ?\n>>> how about ./*build*/ to only match on the root then.\n>> I'm still cautious about patterns that could have unexpected matches :-)\n>> And what if someone wants to name their build directories differently ?\n>> I think .gitignore should include minimal policy, if we can restrict\n>> ignoring the builds to a single directory, I'd prefer that (I'm even\n>> tempted to say we shouldn't include build/ in .gitignore, but I agree\n> \n> After reading this reasoning, I remembered that I have seen directories\n> \n> like 'build-aux/' at many places(which is part of the git repo) and\n> generally contains various\n\nIsn't that an autotools generated directory ? (while we use meson)?\n\nAnyway, if this issue doesn't affect anyone else I'll just keep the\nchange locally.\n\n\n> packaging specs for distros and their components. So maybe, we need to\n> think\n> \n> little bit more..\n> \n>> it's useful).\n>>\n>>>>>   patches/\n>>>>>   *.patch\n>>>>>   *.pyc","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1E7861012\n\tfor ;\n\tThu, 4 Jun 2020 11:26:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3979029B;\n\tThu, 4 Jun 2020 11:26:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"urRiA9sC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591262802;\n\tbh=xlcn4mhWZ9dCtZpTO+iiHgOYPAdfIE2c5cKJZTCQHOs=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=urRiA9sCN27mAGuVmOtP4Z/9bMvvhxO3Up78C3T+x67390+t/aOadKisKTYuzot+M\n\tACzEhSVGxNkxurb688+E36e4fgn8cJP4xaC+OFhATh7yLl8vwyuleyzu33CHqmrhDE\n\t0OYNtxHwaXOzPDRLuOsDA5lRUpLT6ts9ThvqGaro=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Umang Jain ,\n\tLaurent Pinchart ","Cc":"libcamera devel ","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>\n\t<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>\n\t<20200604091557.GD5829@pendragon.ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<176dcfea-3241-5940-7d74-ff42b4ee2630@ideasonboard.com>","Date":"Thu, 4 Jun 2020 10:26:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:26:43 -0000"}},{"id":5018,"web_url":"https://patchwork.libcamera.org/comment/5018/","msgid":"","date":"2020-06-04T09:33:43","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Kieran,\n\nOn 6/4/20 2:56 PM, Kieran Bingham wrote:\n> Hi Umang,\n>\n> On 04/06/2020 10:22, Umang Jain wrote:\n>> I think my mail client didn't sync up fully before me writing my last\n>> reply.\n>>\n>> On 6/4/20 2:45 PM, Laurent Pinchart wrote:\n>>> On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:\n>>>> On 04/06/2020 10:07, Laurent Pinchart wrote:\n>>>>> Hi Kieran,\n>>>>>\n>>>>> Thank you for the patch.\n>>>>>\n>>>>> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n>>>>>> It can be common to have multiple build directories with different\n>>>>>> configurations. Ignore them all.\n>>>>>>\n>>>>>> Signed-off-by: Kieran Bingham \n>>>>>> ---\n>>>>>>   .gitignore | 2 +-\n>>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>>>\n>>>>>> diff --git a/.gitignore b/.gitignore\n>>>>>> index f989dee3bcb0..aecf971d30aa 100644\n>>>>>> --- a/.gitignore\n>>>>>> +++ b/.gitignore\n>>>>>> @@ -1,5 +1,5 @@\n>>>>>>   __pycache__/\n>>>>>> -build/\n>>>>>> +*build*/\n>>>>> That's a bit of a too generic pattern, we could later have a directory\n>>>>> with build in its name.\n>>>>>\n>>>>> I personally have a single build/ directory directly at the root of the\n>>>>> source tree, and create subdirectories there for different builds. All\n>>>>> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n>>>>> works fine with the the run-from-build-dir support we have). Could that\n>>>>> be a solution you would consider instead of this patch ?\n>>>> how about ./*build*/ to only match on the root then.\n>>> I'm still cautious about patterns that could have unexpected matches :-)\n>>> And what if someone wants to name their build directories differently ?\n>>> I think .gitignore should include minimal policy, if we can restrict\n>>> ignoring the builds to a single directory, I'd prefer that (I'm even\n>>> tempted to say we shouldn't include build/ in .gitignore, but I agree\n>> After reading this reasoning, I remembered that I have seen directories\n>>\n>> like 'build-aux/' at many places(which is part of the git repo) and\n>> generally contains various\n> Isn't that an autotools generated directory ? (while we use meson)?\n\nI have seen these directory structures for consolidating various\n\npackaging build formats under one directory - `build-aux/` : \nhttps://u15657259.ct.sendgrid.net/ls/click?upn=8H1KCc2bev8KdIveckpOEHWT1OrCdEOC9SiouJ35asUHkBzk4ylLE8WdFL-2Bscv2-2B620Dh4UC8H7psejRuWZa16XCh72Ct5Wbg9CRc8ChITw-3D-UAD_C3wFy2Q4UgRsRLDAYieRZ5Z3EhAWyy0-2FkOzyYc6FPc1dn6ROcAJqKXb9hjP566uP3uePquZjnTP33pt2nVf90BOSXVYWUKO1C2kiYnS9g0sA8hs0EtM0MAr-2FFcDqxncAiWaS6o3jhifJT9iVqRmA7LSkV87foigsz3qKIMQxf6dxqc14NA3thZavRTEaQe4ZQ-2FgYtFOIS1TqwX9p-2Blgaa8-2FhUO7KmjmAuPUcBuC3Z-2BYCH-2F3Le5Ul86QxZ8Fpoqof\n\nIt might have *also* been autotools generated dir, though I think I haven't\n\ncame across that.\n\n>\n> Anyway, if this issue doesn't affect anyone else I'll just keep the\n> change locally.\n>\n>\n>> packaging specs for distros and their components. So maybe, we need to\n>> think\n>>\n>> little bit more..\n>>\n>>> it's useful).\n>>>\n>>>>>>   patches/\n>>>>>>   *.patch\n>>>>>>   *.pyc","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41AEF61012\n\tfor ;\n\tThu, 4 Jun 2020 11:33:44 +0200 (CEST)","by filterdrecv-p3mdw1-6f5df8956d-7w4dp with SMTP id\n\tfilterdrecv-p3mdw1-6f5df8956d-7w4dp-20-5ED8BFF6-3B\n\t2020-06-04 09:33:43.086977983 +0000 UTC m=+47994.496572139","from mail.uajain.com (unknown)\n\tby ismtpd0006p1maa1.sendgrid.net (SG) with ESMTP\n\tid 3AmCT6SsS5aAfzaPrZIodw Thu, 04 Jun 2020 09:33:42.473 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"Jf5V34y4\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:cc:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=fiLMP2H4VyJaZYnSCwAqiUDv9zTdh8SilaIFgGeWWl4=;\n\tb=Jf5V34y45evBrt3LD5NxOQ3y26oDLc3w95wj+LgTvrsbCeI+Z/PRLx+2mfYJjcUMRDC+\n\tz9OUTXq8QrFXT34j9e+ou4iIevI5qEFveHt3k4mhq0QvrMj8CaMt6wKBLjjrkBmUyTsnTU\n\tyniHtjYKtIqBZ1yunkwOaQSKTgfq/Fvvk=","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>\n\t<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>\n\t<20200604091557.GD5829@pendragon.ideasonboard.com>\n\t\n\t<176dcfea-3241-5940-7d74-ff42b4ee2630@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Thu, 04 Jun 2020 09:33:43 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<176dcfea-3241-5940-7d74-ff42b4ee2630@ideasonboard.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcROc560Os82e1tQwAlD2FoK4WOeRPmc7J1j3wDZRAG2ouUTdGyopTIepnDIXFT1w4rrbEBMYgEUiGRX9ynrNnvJj9fiaiMK5bK3crRzqUuEBlWsc6VaiFU3VkpTunArIU64veOS9ZXdplSdWDCje/U+WSlitzCqXlX+JnD0eueQOVM/SmHmkQe/jIoqs9tzB+6qzNq9pT3/VN8g4QpXDDBQ==","To":"kieran.bingham@ideasonboard.com, Laurent Pinchart\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=iso-8859-1; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 09:33:44 -0000"}},{"id":5022,"web_url":"https://patchwork.libcamera.org/comment/5022/","msgid":"<20200604134358.h3l27jzwidgguqi4@uno.localdomain>","date":"2020-06-04T13:43:58","subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Thu, Jun 04, 2020 at 10:22:11AM +0100, Kieran Bingham wrote:\n>\n>\n> On 04/06/2020 10:15, Laurent Pinchart wrote:\n> > On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:\n> >> On 04/06/2020 10:07, Laurent Pinchart wrote:\n> >>> Hi Kieran,\n> >>>\n> >>> Thank you for the patch.\n> >>>\n> >>> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:\n> >>>> It can be common to have multiple build directories with different\n> >>>> configurations. Ignore them all.\n> >>>>\n> >>>> Signed-off-by: Kieran Bingham \n> >>>> ---\n> >>>> .gitignore | 2 +-\n> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>>\n> >>>> diff --git a/.gitignore b/.gitignore\n> >>>> index f989dee3bcb0..aecf971d30aa 100644\n> >>>> --- a/.gitignore\n> >>>> +++ b/.gitignore\n> >>>> @@ -1,5 +1,5 @@\n> >>>> __pycache__/\n> >>>> -build/\n> >>>> +*build*/\n> >>>\n> >>> That's a bit of a too generic pattern, we could later have a directory\n> >>> with build in its name.\n> >>>\n> >>> I personally have a single build/ directory directly at the root of the\n> >>> source tree, and create subdirectories there for different builds. All\n> >>> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it\n> >>> works fine with the the run-from-build-dir support we have). Could that\n> >>> be a solution you would consider instead of this patch ?\n> >>\n> >> how about ./*build*/ to only match on the root then.\n> >\n> > I'm still cautious about patterns that could have unexpected matches :-)\n> > And what if someone wants to name their build directories differently ?\n>\n> Does anyone else have multiple builds at the root?\n>\nCurrently 4\nI the past I had more...\n\nbuild-aarch64\nbuild-armv7\nbuild-clang\nbuild-gcc\n\n> > I think .gitignore should include minimal policy, if we can restrict\n> > ignoring the builds to a single directory, I'd prefer that (I'm even\n> > tempted to say we shouldn't include build/ in .gitignore, but I agree\n> > it's useful).\n>\n> Never mind, I'll carry it locally.\n>\n>\n>\n> >\n> >>>> patches/\n> >>>> *.patch\n> >>>> *.pyc\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09E79603C6\n\tfor ;\n\tThu, 4 Jun 2020 15:40:36 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 2313BFF80C;\n\tThu, 4 Jun 2020 13:40:34 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 4 Jun 2020 15:43:58 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"Laurent Pinchart ,\n\tlibcamera devel ","Message-ID":"<20200604134358.h3l27jzwidgguqi4@uno.localdomain>","References":"<20200604084908.3776979-1-kieran.bingham@ideasonboard.com>\n\t<20200604090705.GA5829@pendragon.ideasonboard.com>\n\t<36b7083f-954c-6cfd-ba6c-decf6b910671@ideasonboard.com>\n\t<20200604091557.GD5829@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] gitignore: Ignore all build\n\tdirectories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 13:40:36 -0000"}}]