[{"id":5006,"web_url":"https://patchwork.libcamera.org/comment/5006/","msgid":"<20200604074034.urvhny4vi47niock@uno.localdomain>","date":"2020-06-04T07:40:34","subject":"Re: [libcamera-devel] [PATCH] libcamera: Mark logPrefix()\n\timplementations with override","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Jun 04, 2020 at 03:41:06AM +0300, Laurent Pinchart wrote:\n> Virtual functions overriden in derived classes should be marked with the\n> override keyword. Do so for the logPrefix() implementations inheriting\n> from the Loggable class.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/camera_sensor.h | 2 +-\n> include/libcamera/internal/media_device.h | 2 +-\n> include/libcamera/internal/v4l2_subdevice.h | 2 +-\n> include/libcamera/internal/v4l2_videodevice.h | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index d79bd9ce9d58..eb464114cb3a 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -66,7 +66,7 @@ public:\n> \tint sensorInfo(CameraSensorInfo *info) const;\n>\n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n>\n> private:\n> \tconst MediaEntity *entity_;\n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index 19af059d9291..20e397ccac49 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -55,7 +55,7 @@ public:\n> \tSignal disconnected;\n>\n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n>\n> private:\n> \tint open();\n> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> index 1be454f0ddda..07dc93d98776 100644\n> --- a/include/libcamera/internal/v4l2_subdevice.h\n> +++ b/include/libcamera/internal/v4l2_subdevice.h\n> @@ -62,7 +62,7 @@ public:\n> \t\t\t\t\t const std::string &entity);\n>\n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n>\n> private:\n> \tstd::vector enumPadCodes(unsigned int pad);\n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index dc259523599c..cbaee6149f34 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -213,7 +213,7 @@ public:\n> \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat);\n>\n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n>\n> private:\n> \tint getFormatMeta(V4L2DeviceFormat *format);\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AF0C603C8\n\tfor ;\n\tThu, 4 Jun 2020 09:37:12 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 5945760002;\n\tThu, 4 Jun 2020 07:37:11 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 4 Jun 2020 09:40:34 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200604074034.urvhny4vi47niock@uno.localdomain>","References":"<20200604004106.7240-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200604004106.7240-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Mark logPrefix()\n\timplementations with override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 07:37:12 -0000"}},{"id":5051,"web_url":"https://patchwork.libcamera.org/comment/5051/","msgid":"<20200605174650.GB5864@oden.dyn.berto.se>","date":"2020-06-05T17:46:50","subject":"Re: [libcamera-devel] [PATCH] libcamera: Mark logPrefix()\n\timplementations with override","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-06-04 03:41:06 +0300, Laurent Pinchart wrote:\n> Virtual functions overriden in derived classes should be marked with the\n> override keyword. Do so for the logPrefix() implementations inheriting\n> from the Loggable class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/camera_sensor.h | 2 +-\n> include/libcamera/internal/media_device.h | 2 +-\n> include/libcamera/internal/v4l2_subdevice.h | 2 +-\n> include/libcamera/internal/v4l2_videodevice.h | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index d79bd9ce9d58..eb464114cb3a 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -66,7 +66,7 @@ public:\n> \tint sensorInfo(CameraSensorInfo *info) const;\n> \n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n> \n> private:\n> \tconst MediaEntity *entity_;\n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index 19af059d9291..20e397ccac49 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -55,7 +55,7 @@ public:\n> \tSignal disconnected;\n> \n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n> \n> private:\n> \tint open();\n> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> index 1be454f0ddda..07dc93d98776 100644\n> --- a/include/libcamera/internal/v4l2_subdevice.h\n> +++ b/include/libcamera/internal/v4l2_subdevice.h\n> @@ -62,7 +62,7 @@ public:\n> \t\t\t\t\t const std::string &entity);\n> \n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n> \n> private:\n> \tstd::vector enumPadCodes(unsigned int pad);\n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index dc259523599c..cbaee6149f34 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -213,7 +213,7 @@ public:\n> \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat);\n> \n> protected:\n> -\tstd::string logPrefix() const;\n> +\tstd::string logPrefix() const override;\n> \n> private:\n> \tint getFormatMeta(V4L2DeviceFormat *format);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 659B1603C6\n\tfor ;\n\tFri, 5 Jun 2020 19:46:52 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id d7so6302166lfi.12\n\tfor ;\n\tFri, 05 Jun 2020 10:46:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt5sm1229110lff.39.2020.06.05.10.46.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jun 2020 10:46:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"jBs10cmL\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Li0AJ0DRJJBtytzz0do5ubWdF2ig3X9FohPxA3KYxe0=;\n\tb=jBs10cmLN50VzF+rATYS16GEysdFm21+T6efSc9rD9XbL8U32ZhHxVx0taMvR3IWKo\n\tvrcOnkKAushWP+adOC3H9m25jKhVszcElXU8ZPj8v1og59ZF0VR0jcwkpByv2euzyJVO\n\tTVINSsfAYQKrI+TuSkWaW6tZoFbCYwc00ud7IQbSDUb7+WOuwkZoyc8lHNAJZnfxgQ23\n\tQlvgUfYqaOgn/0NmdG8s30Kg9AJUiHhFujA3Vgs5Ep4Ea1FwJUkpm/yQpRpgB9Tccfk8\n\tABW1J+Hog4WsIG/3DSEC4aM/KEh+PbGcV/8pD1sR5HEBhGtR6kY2yKEs1C6oIcX9ZXiF\n\t1dMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Li0AJ0DRJJBtytzz0do5ubWdF2ig3X9FohPxA3KYxe0=;\n\tb=QqqOFE0wcQO7P7opuxZB3XJYWake7kxkoR86wKKJrTs1J29H29v8hdsycb+wHhl1dg\n\tE4/mnVuHBu4EwGNuTD4dM146TgmVQLPngzbelSFH/kLiI+uCDoXCwLjz5sFszDif/nX4\n\tBZmXeVr75dyTGQsx1bPHg1QG9spyRCDT+LltT0xoC2y6wEdu/W62KHP6qOBE53TC7o+q\n\tc0UNHD8BanMtSZNnx6ZCUNRtgbUAif2q244+1qRxNpcwCjPsyoipBYjqpJIiNLUhJtcL\n\tjzz+ZrLqYYtFB8kTWAB70k7yUw6K5xuzb/J3VtFoRPhs6pMbxcjjhwO4f0Pa6iiZHBGs\n\tXGpQ==","X-Gm-Message-State":"AOAM530DcCydkRlvBwfI73uFWlre2z0X9gnneLJ86ikAQnHOLmxATYHV\n\tKhHsJXY1h82JRt/fB3X1aqr0tg==","X-Google-Smtp-Source":"ABdhPJzlmJ7AOYFu9yx4ybFxBDu4zS7cHQ0VSzgXhuIBONDXe60epiJo2KMDUmR/fVB4FaKPIbuwyg==","X-Received":"by 2002:ac2:43a5:: with SMTP id t5mr5646468lfl.197.1591379211588;\n\tFri, 05 Jun 2020 10:46:51 -0700 (PDT)","Date":"Fri, 5 Jun 2020 19:46:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200605174650.GB5864@oden.dyn.berto.se>","References":"<20200604004106.7240-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200604004106.7240-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Mark logPrefix()\n\timplementations with override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Jun 2020 17:46:52 -0000"}}]