{"id":391,"url":"https://patchwork.libcamera.org/api/patches/391/?format=json","web_url":"https://patchwork.libcamera.org/patch/391/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190125170400.24821-5-jacopo@jmondi.org>","date":"2019-01-25T17:03:59","name":"[libcamera-devel,4/5] libcamera: pipeline: Misc comments update","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1061ce0e1de817b25cbce60aa902cc347390b646","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/391/mbox/","series":[{"id":133,"url":"https://patchwork.libcamera.org/api/series/133/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=133","date":"2019-01-25T17:03:55","name":"libcamera: camera data: Address review comments","version":1,"mbox":"https://patchwork.libcamera.org/series/133/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/391/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/391/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C961960C7F\n\tfor ;\n\tFri, 25 Jan 2019 18:04:12 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 621B220000C;\n\tFri, 25 Jan 2019 17:04:12 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 25 Jan 2019 18:03:59 +0100","Message-Id":"<20190125170400.24821-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190125170400.24821-1-jacopo@jmondi.org>","References":"<20190125170400.24821-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/5] libcamera: pipeline: Misc comments\n\tupdate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 25 Jan 2019 17:04:13 -0000"},"content":"Apply some comments improvements pointed out during review.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline_handler.cpp | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex e75bf0f..dc55f8f 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -100,7 +100,7 @@ PipelineHandler::~PipelineHandler()\n * one pipeline instance, until all compatible media devices are exhausted.\n *\n * If this function returns true, a new instance of the pipeline handler will\n- * be created and its match() function called,\n+ * be created and its match() function called.\n *\n * \\return true if media devices have been acquired and camera instances\n * created, or false otherwise\n@@ -184,11 +184,12 @@ void PipelineHandler::mediaDeviceDisconnected(MediaDevice *media)\n \n /**\n * \\brief Retrieve the pipeline-specific data associated with a Camera\n- * \\param camera The camera data is associate with\n+ * \\param camera The camera whose data to retrieve\n *\n * \\return A pointer to the pipeline-specific data set with setCameraData().\n- * The returned pointer lifetime is associated with the one of the pipeline\n- * handler, and caller of this function shall never release it manually.\n+ * The returned pointer is a borrowed reference and is guaranteed to remain\n+ * valid until the pipeline handler is destroyed. It shall not be deleted\n+ * manually by the caller.\n */\n CameraData *PipelineHandler::cameraData(const Camera *camera)\n {\n@@ -203,13 +204,13 @@ CameraData *PipelineHandler::cameraData(const Camera *camera)\n }\n \n /**\n- * \\brief Set pipeline-specific data in the camera\n+ * \\brief Set pipeline-specific data for the camera\n * \\param camera The camera to associate data to\n * \\param data The pipeline-specific data\n *\n * This method allows pipeline handlers to associate pipeline-specific\n- * information with \\a camera. The \\a data lifetime gets associated with\n- * the pipeline handler one, and gets released at deletion time.\n+ * information with \\a camera. Ownership of \\a data is transferred to\n+ * the PipelineHandler.\n *\n * If pipeline-specific data has already been associated with the camera by a\n * previous call to this method, is it replaced by \\a data and the previous data\n","prefixes":["libcamera-devel","4/5"]}