[{"id":4988,"web_url":"https://patchwork.libcamera.org/comment/4988/","msgid":"<20200603205242.GG5959@pendragon.ideasonboard.com>","date":"2020-06-03T20:52:42","subject":"Re: [libcamera-devel] [PATCH 2/5] v4l2: v4l2_camera_proxy: Fix\n\tbounds check for VIDIOC_ENUM_FMT","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jun 03, 2020 at 11:16:06PM +0900, Paul Elder wrote:\n> VIDIOC_ENUM_FMT is meant to return -EINVAL if the requested index is out\n> of bounds. This bounds is obtained from the libcamera Camera's list of\n> formats. The bounds check for this list was incorrect; fix it.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 3df4d42b..ec6d265d 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -224,7 +224,7 @@ int V4L2CameraProxy::vidioc_enum_fmt(struct v4l2_fmtdesc *arg)\n> \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_enum_fmt\";\n> \n> \tif (!validateBufferType(arg->type) ||\n> -\t arg->index > streamConfig_.formats().pixelformats().size())\n> +\t arg->index >= streamConfig_.formats().pixelformats().size())\n> \t\treturn -EINVAL;\n> \n> \t/* \\todo Add map from format to description. */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B485E6110A\n\tfor ;\n\tWed, 3 Jun 2020 22:52:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4180D29B;\n\tWed, 3 Jun 2020 22:52:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QTS5NsWk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591217578;\n\tbh=/iimbEVkHaRjBUFeKnTkf71wYVXKQeRpNKF3a6wrVrQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QTS5NsWkoUqgU1marZ2LeI7U89/ppzZK388MXSr2jdINue7191Y3/k1XOCuhDcBSz\n\tdTmterw2dGsYjs1LQcuYJF81P/izFbrOfMMipitpxmz044gwueZ//YIxaSOPJf6+H0\n\t9YBtQGkopTK+PilKAOqBxtN5EK+yy1WG0xud7Mkc=","Date":"Wed, 3 Jun 2020 23:52:42 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200603205242.GG5959@pendragon.ideasonboard.com>","References":"<20200603141609.18584-1-paul.elder@ideasonboard.com>\n\t<20200603141609.18584-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200603141609.18584-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/5] v4l2: v4l2_camera_proxy: Fix\n\tbounds check for VIDIOC_ENUM_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Jun 2020 20:52:58 -0000"}}]