[{"id":615,"web_url":"https://patchwork.libcamera.org/comment/615/","msgid":"<20190125224228.GR4127@bigcity.dyn.berto.se>","date":"2019-01-25T22:42:28","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: pipeline: Rework class\n\tdestructor","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2019-01-25 18:03:58 +0100, Jacopo Mondi wrote:\n> Remove comment and do not delete a class member, as it will be destroyed\n> already with the instance that contains it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 7 -------\n> 1 file changed, 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index cca5576..e75bf0f 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -71,15 +71,8 @@ PipelineHandler::PipelineHandler(CameraManager *manager)\n> {\n> }\n> \n> -/**\n> - * \\brief Delete the pipeline handler\n> - *\n> - * Release the cameraData_ map, causing all data there referenced to be\n> - * deleted, as they are stored as unique_ptr\n> - */\n> PipelineHandler::~PipelineHandler()\n> {\n> -\tcameraData_.clear();\n> };\n> \n> /**\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D70860C65\n\tfor ;\n\tFri, 25 Jan 2019 23:42:30 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id v5so8047884lfe.7\n\tfor ;\n\tFri, 25 Jan 2019 14:42:30 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\to88sm1745191lfk.38.2019.01.25.14.42.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 25 Jan 2019 14:42:29 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Yr6tgwGn+T7zuoHqXWAZB/MkljTgBwhG88tc+QDhKbo=;\n\tb=eR7hm4UX9NNUkxJt5VbzgQxXQ6D6q3yffJ70xqpGj9jZRokoAkkIAESBZspRN4F8qW\n\tsEBOR63aWFydwbwifu7kBH9ANOjeMvxZdNsfce0JL8FPnfCg8BxR2X1NlJbmlwI8xFnv\n\txbjXvcklUwlYDu17J/H9MfAkYc0y8HZwVfg14HmiTofFLQgUQy1pd0ooElxdY5Rui8hA\n\tiIeiapdU1v7xNtk1s09o1zqWD2HOUH/2/KkIp1WmsMgDYx6TDeX8J2VanhjyjxnlsZVw\n\txnwQyDlJZssD8TralOCoYrZgYFUz2Sa47UFGbwhuaJGNSHeej3IjnwVD68SOw1S1HTIk\n\tClzA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Yr6tgwGn+T7zuoHqXWAZB/MkljTgBwhG88tc+QDhKbo=;\n\tb=HqLITvOA+noMFypCOXPAVNPP9V6HcAInf/Vwj+uaLotedux3VSf/rNs0vKkB4LrV1d\n\tmaYTRl3ySQl3c1MPM47x+MYKluZGnSyN5k8WwH11uHUtO16EY2/anTQUMnqhbr/mVE3a\n\tvSfCVCf8t9up04H4/ngQ8IwbldOLg07yZt+7XScybcMDtcHcuXekYPsRHSeYdIcBrUYd\n\tNVmbIt2f7jQpmnwMqNQCK2RKopXK4rDWo0py60DIOSrTsXZH+KlOFv745YePl85x/HmM\n\tmIYFiJeFAEJ6dlsBE1da5DYr9FyRf+HbHrKexN2pn5tTHBpJPeptltw896AkEBCBlC2C\n\t2bUA==","X-Gm-Message-State":"AJcUukfBwPejnr995D0VZy5EJE8QTfo22128SO41/Z6oA+H5unkGEiej\n\tp9Cjr/vdxHZsGmUPv76xAUBXWNpxmQM=","X-Google-Smtp-Source":"ALg8bN5dIrewh+54AUg8NWZbyC0TMHvNDVqCYP1Vr5R5m1FhWwITLAoegQlQI8uh10ixlTueT/uZTQ==","X-Received":"by 2002:a19:8f45:: with SMTP id r66mr10069303lfd.9.1548456149896;\n\tFri, 25 Jan 2019 14:42:29 -0800 (PST)","Date":"Fri, 25 Jan 2019 23:42:28 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190125224228.GR4127@bigcity.dyn.berto.se>","References":"<20190125170400.24821-1-jacopo@jmondi.org>\n\t<20190125170400.24821-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190125170400.24821-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: pipeline: Rework class\n\tdestructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 25 Jan 2019 22:42:30 -0000"}}]