{"id":390,"url":"https://patchwork.libcamera.org/api/patches/390/?format=json","web_url":"https://patchwork.libcamera.org/patch/390/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190125170400.24821-4-jacopo@jmondi.org>","date":"2019-01-25T17:03:58","name":"[libcamera-devel,3/5] libcamera: pipeline: Rework class destructor","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a836af5c915e48bcd9a5de539fe64979accbb439","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/390/mbox/","series":[{"id":133,"url":"https://patchwork.libcamera.org/api/series/133/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=133","date":"2019-01-25T17:03:55","name":"libcamera: camera data: Address review comments","version":1,"mbox":"https://patchwork.libcamera.org/series/133/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/390/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/390/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37D6E60C7F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jan 2019 18:04:12 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id C4537200004;\n\tFri, 25 Jan 2019 17:04:11 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 25 Jan 2019 18:03:58 +0100","Message-Id":"<20190125170400.24821-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190125170400.24821-1-jacopo@jmondi.org>","References":"<20190125170400.24821-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/5] libcamera: pipeline: Rework class\n\tdestructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 25 Jan 2019 17:04:12 -0000"},"content":"Remove comment and do not delete a class member, as it will be destroyed\nalready with the instance that contains it.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline_handler.cpp | 7 -------\n 1 file changed, 7 deletions(-)","diff":"diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex cca5576..e75bf0f 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -71,15 +71,8 @@ PipelineHandler::PipelineHandler(CameraManager *manager)\n {\n }\n \n-/**\n- * \\brief Delete the pipeline handler\n- *\n- * Release the cameraData_ map, causing all data there referenced to be\n- * deleted, as they are stored as unique_ptr<CameraData>\n- */\n PipelineHandler::~PipelineHandler()\n {\n-\tcameraData_.clear();\n };\n \n /**\n","prefixes":["libcamera-devel","3/5"]}