[{"id":4966,"web_url":"https://patchwork.libcamera.org/comment/4966/","msgid":"<20200602122439.rzjjiwjfn7nxfhrv@uno.localdomain>","date":"2020-06-02T12:24:39","subject":"Re: [libcamera-devel] [PATCH 08/10] libcamera: ipu3: cio2: Make the\n\tV4L2 devices private","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Jun 02, 2020 at 03:39:07AM +0200, Niklas Söderlund wrote:\n> In order to make the CIO2 easier to extend with new features make the\n> V4L2 deices (sensor, CIO2 and video device) private members. This\n> requires a few helper functions to be added to allow for the IPU3 driver\n> to still be able to interact with all parts of the CIO2. These helper\n> functions will later be extended to add new features to the IPU3\n> pipeline.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 18 ++++++++++++++++++\n> src/libcamera/pipeline/ipu3/cio2.h | 19 +++++++++++++++----\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +++++++---------\n> 3 files changed, 40 insertions(+), 13 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 2263d6530ec6b672..63a46959f3cac06a 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -98,6 +98,8 @@ int CIO2Device::init(const MediaDevice *media, unsigned int index)\n> \tif (ret)\n> \t\treturn ret;\n>\n> +\toutput_->bufferReady.connect(this, &CIO2Device::cio2BufferReady);\n> +\n> \treturn 0;\n> }\n>\n> @@ -218,6 +220,12 @@ int CIO2Device::allocateBuffers()\n> \treturn ret;\n> }\n>\n> +int CIO2Device::exportBuffers(unsigned int count,\n> +\t\t\t std::vector> *buffers)\n> +{\n> +\treturn output_->exportBuffers(count, buffers);\n> +}\n> +\n> void CIO2Device::freeBuffers()\n> {\n> \t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n> @@ -258,6 +266,11 @@ int CIO2Device::stop()\n> \treturn output_->streamOff();\n> }\n>\n> +int CIO2Device::queueBuffer(FrameBuffer *buffer)\n> +{\n> +\treturn output_->queueBuffer(buffer);\n> +}\n> +\n> V4L2PixelFormat CIO2Device::mediaBusToFormat(unsigned int code)\n> {\n> \tswitch (code) {\n> @@ -274,4 +287,9 @@ V4L2PixelFormat CIO2Device::mediaBusToFormat(unsigned int code)\n> \t}\n> }\n>\n> +void CIO2Device::cio2BufferReady(FrameBuffer *buffer)\n> +{\n> +\tbufferReady.emit(buffer);\n> +}\n> +\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> index 2e268a7154b2d241..465c0778f27e4066 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.h\n> +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> @@ -27,7 +27,7 @@ public:\n> \tstatic constexpr unsigned int CIO2_BUFFER_COUNT = 4;\n>\n> \tCIO2Device()\n> -\t\t: output_(nullptr), csi2_(nullptr), sensor_(nullptr)\n> +\t\t: sensor_(nullptr), csi2_(nullptr), output_(nullptr)\n\nI wonder if sensor_ should be part of CIO2 at all\nI see below a CIO2Device::resolution() which I'm not super happy\nabout...\n\nCould the sensor live in the CameraData and CameraData be passed to\nthe CIO2Device, if it needs it ?\n\n> \t{\n> \t}\n>\n> @@ -45,6 +45,8 @@ public:\n> \t\t\t\t\t\t const Size desiredSize = {}) const;\n>\n> \tint allocateBuffers();\n> +\tint exportBuffers(unsigned int count,\n> +\t\t\t std::vector> *buffers);\n> \tvoid freeBuffers();\n>\n> \tFrameBuffer *getBuffer();\n> @@ -53,13 +55,22 @@ public:\n> \tint start();\n> \tint stop();\n>\n> +\tconst std::string &name() const { return sensor_->entity()->name(); }\n> +\tSize resolution() const { return sensor_->resolution(); }\n> +\tControlList properties() const { return sensor_->properties(); }\n\nI really don't like these three :(\n\n> +\n> +\tint queueBuffer(FrameBuffer *buffer);\n> +\tSignal bufferReady;\n\nYou could inline their single-line implementations here\n\n> +\n> +private:\n> \tstatic V4L2PixelFormat mediaBusToFormat(unsigned int code);\n>\n> -\tV4L2VideoDevice *output_;\n> -\tV4L2Subdevice *csi2_;\n> +\tvoid cio2BufferReady(FrameBuffer *buffer);\n> +\n> \tCameraSensor *sensor_;\n> +\tV4L2Subdevice *csi2_;\n> +\tV4L2VideoDevice *output_;\n>\n> -private:\n> \tstd::vector> buffers_;\n> \tstd::queue availableBuffers_;\n> };\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 56cc3ca10414f0d2..2d636f0944587a17 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -454,7 +454,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\t\t * available sensor resolution and to the IPU3\n> \t\t\t * alignment constraints.\n> \t\t\t */\n> -\t\t\tconst Size &res = data->cio2_.sensor_->resolution();\n> +\t\t\tconst Size &res = data->cio2_.resolution();\n\nThis would really be better as data->sensor_.resolution() assuming\nthat's possible.\n\n> \t\t\tunsigned int width = std::min(1280U, res.width);\n> \t\t\tunsigned int height = std::min(720U, res.height);\n> \t\t\tcfg.size = { width & ~7, height & ~3 };\n> @@ -634,13 +634,11 @@ int PipelineHandlerIPU3::exportFrameBuffers(Camera *camera, Stream *stream,\n> \tIPU3CameraData *data = cameraData(camera);\n> \tIPU3Stream *ipu3stream = static_cast(stream);\n> \tunsigned int count = stream->configuration().bufferCount;\n> -\tV4L2VideoDevice *video;\n>\n> \tif (ipu3stream->raw_)\n> -\t\tvideo = data->cio2_.output_;\n> -\telse\n> -\t\tvideo = ipu3stream->device_->dev;\n> +\t\treturn data->cio2_.exportBuffers(count, buffers);\n>\n> +\tV4L2VideoDevice *video = ipu3stream->device_->dev;\n> \treturn video->exportBuffers(count, buffers);\n> }\n>\n> @@ -749,7 +747,7 @@ int PipelineHandlerIPU3::queueRequestDevice(Camera *camera, Request *request)\n> \t\treturn -EINVAL;\n>\n> \tbuffer->setRequest(request);\n> -\tdata->cio2_.output_->queueBuffer(buffer);\n> +\tdata->cio2_.queueBuffer(buffer);\n>\n> \tfor (auto it : request->buffers()) {\n> \t\tIPU3Stream *stream = static_cast(it.first);\n> @@ -862,7 +860,7 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\tcontinue;\n>\n> \t\t/* Initialize the camera properties. */\n> -\t\tdata->properties_ = cio2->sensor_->properties();\n> +\t\tdata->properties_ = cio2->properties();\n>\n> \t\t/**\n> \t\t * \\todo Dynamically assign ImgU and output devices to each\n> @@ -886,7 +884,7 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t * associated ImgU input where they get processed and\n> \t\t * returned through the ImgU main and secondary outputs.\n> \t\t */\n> -\t\tdata->cio2_.output_->bufferReady.connect(data.get(),\n> +\t\tdata->cio2_.bufferReady.connect(data.get(),\n> \t\t\t\t\t&IPU3CameraData::cio2BufferReady);\n> \t\tdata->imgu_->input_->bufferReady.connect(data.get(),\n> \t\t\t\t\t&IPU3CameraData::imguInputBufferReady);\n> @@ -896,7 +894,7 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n>\n> \t\t/* Create and register the Camera instance. */\n> -\t\tstd::string cameraName = cio2->sensor_->entity()->name();\n> +\t\tstd::string cameraName = cio2->name();\n\nSame here and above.\n\nThanks\n j\n\n> \t\tstd::shared_ptr camera = Camera::create(this,\n> \t\t\t\t\t\t\t\tcameraName,\n> \t\t\t\t\t\t\t\tstreams);\n> --\n> 2.26.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE94C61012\n\tfor ;\n\tTue, 2 Jun 2020 14:21:18 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 05D79200004;\n\tTue, 2 Jun 2020 12:21:17 +0000 (UTC)"],"Date":"Tue, 2 Jun 2020 14:24:39 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200602122439.rzjjiwjfn7nxfhrv@uno.localdomain>","References":"<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>\n\t<20200602013909.3170593-9-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200602013909.3170593-9-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 08/10] libcamera: ipu3: cio2: Make the\n\tV4L2 devices private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 12:21:19 -0000"}},{"id":5005,"web_url":"https://patchwork.libcamera.org/comment/5005/","msgid":"<20200604032601.GR27695@pendragon.ideasonboard.com>","date":"2020-06-04T03:26:01","subject":"Re: [libcamera-devel] [PATCH 08/10] libcamera: ipu3: cio2: Make the\n\tV4L2 devices private","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Tue, Jun 02, 2020 at 02:24:39PM +0200, Jacopo Mondi wrote:\n> On Tue, Jun 02, 2020 at 03:39:07AM +0200, Niklas Söderlund wrote:\n> > In order to make the CIO2 easier to extend with new features make the\n> > V4L2 deices (sensor, CIO2 and video device) private members. This\n> > requires a few helper functions to be added to allow for the IPU3 driver\n> > to still be able to interact with all parts of the CIO2. These helper\n> > functions will later be extended to add new features to the IPU3\n> > pipeline.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/ipu3/cio2.cpp | 18 ++++++++++++++++++\n> > src/libcamera/pipeline/ipu3/cio2.h | 19 +++++++++++++++----\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +++++++---------\n> > 3 files changed, 40 insertions(+), 13 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> > index 2263d6530ec6b672..63a46959f3cac06a 100644\n> > --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> > @@ -98,6 +98,8 @@ int CIO2Device::init(const MediaDevice *media, unsigned int index)\n> > \tif (ret)\n> > \t\treturn ret;\n> >\n> > +\toutput_->bufferReady.connect(this, &CIO2Device::cio2BufferReady);\n> > +\n> > \treturn 0;\n> > }\n> >\n> > @@ -218,6 +220,12 @@ int CIO2Device::allocateBuffers()\n> > \treturn ret;\n> > }\n> >\n> > +int CIO2Device::exportBuffers(unsigned int count,\n> > +\t\t\t std::vector> *buffers)\n> > +{\n> > +\treturn output_->exportBuffers(count, buffers);\n> > +}\n> > +\n> > void CIO2Device::freeBuffers()\n> > {\n> > \t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n> > @@ -258,6 +266,11 @@ int CIO2Device::stop()\n> > \treturn output_->streamOff();\n> > }\n> >\n> > +int CIO2Device::queueBuffer(FrameBuffer *buffer)\n> > +{\n> > +\treturn output_->queueBuffer(buffer);\n> > +}\n> > +\n> > V4L2PixelFormat CIO2Device::mediaBusToFormat(unsigned int code)\n> > {\n> > \tswitch (code) {\n> > @@ -274,4 +287,9 @@ V4L2PixelFormat CIO2Device::mediaBusToFormat(unsigned int code)\n> > \t}\n> > }\n> >\n> > +void CIO2Device::cio2BufferReady(FrameBuffer *buffer)\n> > +{\n> > +\tbufferReady.emit(buffer);\n> > +}\n> > +\n> > } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> > index 2e268a7154b2d241..465c0778f27e4066 100644\n> > --- a/src/libcamera/pipeline/ipu3/cio2.h\n> > +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> > @@ -27,7 +27,7 @@ public:\n> > \tstatic constexpr unsigned int CIO2_BUFFER_COUNT = 4;\n> >\n> > \tCIO2Device()\n> > -\t\t: output_(nullptr), csi2_(nullptr), sensor_(nullptr)\n> > +\t\t: sensor_(nullptr), csi2_(nullptr), output_(nullptr)\n> \n> I wonder if sensor_ should be part of CIO2 at all\n> I see below a CIO2Device::resolution() which I'm not super happy\n> about...\n> \n> Could the sensor live in the CameraData and CameraData be passed to\n> the CIO2Device, if it needs it ?\n\nI was going to write the same :-)\n\n> > \t{\n> > \t}\n> >\n> > @@ -45,6 +45,8 @@ public:\n> > \t\t\t\t\t\t const Size desiredSize = {}) const;\n> >\n> > \tint allocateBuffers();\n> > +\tint exportBuffers(unsigned int count,\n> > +\t\t\t std::vector> *buffers);\n> > \tvoid freeBuffers();\n> >\n> > \tFrameBuffer *getBuffer();\n> > @@ -53,13 +55,22 @@ public:\n> > \tint start();\n> > \tint stop();\n> >\n> > +\tconst std::string &name() const { return sensor_->entity()->name(); }\n> > +\tSize resolution() const { return sensor_->resolution(); }\n> > +\tControlList properties() const { return sensor_->properties(); }\n> \n> I really don't like these three :(\n\nAgreed.\n\n> > +\n> > +\tint queueBuffer(FrameBuffer *buffer);\n> > +\tSignal bufferReady;\n> \n> You could inline their single-line implementations here\n> \n> > +\n> > +private:\n> > \tstatic V4L2PixelFormat mediaBusToFormat(unsigned int code);\n> >\n> > -\tV4L2VideoDevice *output_;\n> > -\tV4L2Subdevice *csi2_;\n> > +\tvoid cio2BufferReady(FrameBuffer *buffer);\n> > +\n> > \tCameraSensor *sensor_;\n> > +\tV4L2Subdevice *csi2_;\n> > +\tV4L2VideoDevice *output_;\n> >\n> > -private:\n> > \tstd::vector> buffers_;\n> > \tstd::queue availableBuffers_;\n> > };\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 56cc3ca10414f0d2..2d636f0944587a17 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -454,7 +454,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> > \t\t\t * available sensor resolution and to the IPU3\n> > \t\t\t * alignment constraints.\n> > \t\t\t */\n> > -\t\t\tconst Size &res = data->cio2_.sensor_->resolution();\n> > +\t\t\tconst Size &res = data->cio2_.resolution();\n> \n> This would really be better as data->sensor_.resolution() assuming\n> that's possible.\n> \n> > \t\t\tunsigned int width = std::min(1280U, res.width);\n> > \t\t\tunsigned int height = std::min(720U, res.height);\n> > \t\t\tcfg.size = { width & ~7, height & ~3 };\n> > @@ -634,13 +634,11 @@ int PipelineHandlerIPU3::exportFrameBuffers(Camera *camera, Stream *stream,\n> > \tIPU3CameraData *data = cameraData(camera);\n> > \tIPU3Stream *ipu3stream = static_cast(stream);\n> > \tunsigned int count = stream->configuration().bufferCount;\n> > -\tV4L2VideoDevice *video;\n> >\n> > \tif (ipu3stream->raw_)\n> > -\t\tvideo = data->cio2_.output_;\n> > -\telse\n> > -\t\tvideo = ipu3stream->device_->dev;\n> > +\t\treturn data->cio2_.exportBuffers(count, buffers);\n> >\n> > +\tV4L2VideoDevice *video = ipu3stream->device_->dev;\n> > \treturn video->exportBuffers(count, buffers);\n> > }\n> >\n> > @@ -749,7 +747,7 @@ int PipelineHandlerIPU3::queueRequestDevice(Camera *camera, Request *request)\n> > \t\treturn -EINVAL;\n> >\n> > \tbuffer->setRequest(request);\n> > -\tdata->cio2_.output_->queueBuffer(buffer);\n> > +\tdata->cio2_.queueBuffer(buffer);\n> >\n> > \tfor (auto it : request->buffers()) {\n> > \t\tIPU3Stream *stream = static_cast(it.first);\n> > @@ -862,7 +860,7 @@ int PipelineHandlerIPU3::registerCameras()\n> > \t\t\tcontinue;\n> >\n> > \t\t/* Initialize the camera properties. */\n> > -\t\tdata->properties_ = cio2->sensor_->properties();\n> > +\t\tdata->properties_ = cio2->properties();\n> >\n> > \t\t/**\n> > \t\t * \\todo Dynamically assign ImgU and output devices to each\n> > @@ -886,7 +884,7 @@ int PipelineHandlerIPU3::registerCameras()\n> > \t\t * associated ImgU input where they get processed and\n> > \t\t * returned through the ImgU main and secondary outputs.\n> > \t\t */\n> > -\t\tdata->cio2_.output_->bufferReady.connect(data.get(),\n> > +\t\tdata->cio2_.bufferReady.connect(data.get(),\n> > \t\t\t\t\t&IPU3CameraData::cio2BufferReady);\n> > \t\tdata->imgu_->input_->bufferReady.connect(data.get(),\n> > \t\t\t\t\t&IPU3CameraData::imguInputBufferReady);\n> > @@ -896,7 +894,7 @@ int PipelineHandlerIPU3::registerCameras()\n> > \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n> >\n> > \t\t/* Create and register the Camera instance. */\n> > -\t\tstd::string cameraName = cio2->sensor_->entity()->name();\n> > +\t\tstd::string cameraName = cio2->name();\n> \n> Same here and above.\n> \n> > \t\tstd::shared_ptr camera = Camera::create(this,\n> > \t\t\t\t\t\t\t\tcameraName,\n> > \t\t\t\t\t\t\t\tstreams);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DD456115D\n\tfor ;\n\tThu, 4 Jun 2020 05:26:18 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7138329B;\n\tThu, 4 Jun 2020 05:26:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CjtYEVSQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591241177;\n\tbh=uDa+v14VPtUsU3JbfQvQ6fFZsQQeEGWKIO/p3fHSlck=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CjtYEVSQ3MocTe5ObnHKe3BUa3ukPddhx5CkAVfndBsfM8sgs35Biv7oQAJdDOuqU\n\tZ3FZ0VZeq2bBPeCvWLwb9Nc4KQAUSwhtumL2/+fLtoqqrkbT2TVXjHIzW5E4KxnUrr\n\t/BH4CJ4HHNkiScL0w9Q9HspCL2Bw91MIOXFcigR0=","Date":"Thu, 4 Jun 2020 06:26:01 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200604032601.GR27695@pendragon.ideasonboard.com>","References":"<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>\n\t<20200602013909.3170593-9-niklas.soderlund@ragnatech.se>\n\t<20200602122439.rzjjiwjfn7nxfhrv@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200602122439.rzjjiwjfn7nxfhrv@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 08/10] libcamera: ipu3: cio2: Make the\n\tV4L2 devices private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 03:26:18 -0000"}}]