[{"id":4951,"web_url":"https://patchwork.libcamera.org/comment/4951/","msgid":"<20200602083213.cuplui6wo7s3yz5m@uno.localdomain>","date":"2020-06-02T08:32:13","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Remove id from\n\tcamera names","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Jun 02, 2020 at 03:39:01AM +0200, Niklas Söderlund wrote:\n> The id in the camera name is confusing and is of little use for users.\n> Camera names are not (yet) required to be unique and appending which\n> numerical CIO2 unit the sensor is attached to is just as good as\n> depending on the i2c bus information already present in the entity name.\n>\n> Before this change,\n>\n> $ cam -l\n> Available cameras:\n> 1: ov13858 2-0010 0\n> 2: ov5670 4-0036 1\n>\n> After this change,\n>\n> $ cam -l\n> Available cameras:\n> 1: ov13858 2-0010\n> 2: ov5670 4-0036\n\nAs the i2c bus info been added later ? I recall we added the cio2\nindex to avoid name clashing, but I guess we're now safe.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index b805fea71c2d812d..6df1e29281941ebf 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -949,8 +949,7 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n>\n> \t\t/* Create and register the Camera instance. */\n> -\t\tstd::string cameraName = cio2->sensor_->entity()->name() + \" \"\n> -\t\t\t\t + std::to_string(id);\n> +\t\tstd::string cameraName = cio2->sensor_->entity()->name();\n> \t\tstd::shared_ptr camera = Camera::create(this,\n> \t\t\t\t\t\t\t\tcameraName,\n> \t\t\t\t\t\t\t\tstreams);\n> --\n> 2.26.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2888C603CA\n\tfor ;\n\tTue, 2 Jun 2020 10:28:53 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8FD8AFF807;\n\tTue, 2 Jun 2020 08:28:52 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 2 Jun 2020 10:32:13 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200602083213.cuplui6wo7s3yz5m@uno.localdomain>","References":"<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>\n\t<20200602013909.3170593-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200602013909.3170593-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Remove id from\n\tcamera names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 08:28:53 -0000"}},{"id":5001,"web_url":"https://patchwork.libcamera.org/comment/5001/","msgid":"<20200604030310.GN27695@pendragon.ideasonboard.com>","date":"2020-06-04T03:03:10","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Remove id from\n\tcamera names","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Jun 02, 2020 at 03:39:01AM +0200, Niklas Söderlund wrote:\n> The id in the camera name is confusing and is of little use for users.\n> Camera names are not (yet) required to be unique and appending which\n> numerical CIO2 unit the sensor is attached to is just as good as\n> depending on the i2c bus information already present in the entity name.\n> \n> Before this change,\n> \n> $ cam -l\n> Available cameras:\n> 1: ov13858 2-0010 0\n> 2: ov5670 4-0036 1\n> \n> After this change,\n> \n> $ cam -l\n> Available cameras:\n> 1: ov13858 2-0010\n> 2: ov5670 4-0036\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\nCan't wait to fix the camera naming issue though :-)\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index b805fea71c2d812d..6df1e29281941ebf 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -949,8 +949,7 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n> \n> \t\t/* Create and register the Camera instance. */\n> -\t\tstd::string cameraName = cio2->sensor_->entity()->name() + \" \"\n> -\t\t\t\t + std::to_string(id);\n> +\t\tstd::string cameraName = cio2->sensor_->entity()->name();\n> \t\tstd::shared_ptr camera = Camera::create(this,\n> \t\t\t\t\t\t\t\tcameraName,\n> \t\t\t\t\t\t\t\tstreams);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EB5461012\n\tfor ;\n\tThu, 4 Jun 2020 05:03:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF59F29B;\n\tThu, 4 Jun 2020 05:03:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CiQ8eWWx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591239806;\n\tbh=lwsrZetGkUlxioH0zv1N7PQP71Ce0vFPqk0oiJqBFMU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CiQ8eWWx/l5juRzl2Vyir1JsUR8KJS5IlC54Hu8TxA1QPpZaQk2W9lkcb2B9BTs0P\n\toxxEzPs/wT0oj5iADHsu1AfPxh/CyRCsVUoFr7Q/b5rwNf1M50MtkXJl/arGjZ7Tpo\n\te9X84yMLjZOuRsmDY9uxn4c77M/U5jswqwSA7u1o=","Date":"Thu, 4 Jun 2020 06:03:10 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200604030310.GN27695@pendragon.ideasonboard.com>","References":"<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>\n\t<20200602013909.3170593-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200602013909.3170593-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: ipu3: Remove id from\n\tcamera names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 03:03:27 -0000"}}]