[{"id":4950,"web_url":"https://patchwork.libcamera.org/comment/4950/","msgid":"<20200602083029.jtfggyyae5isuzqc@uno.localdomain>","date":"2020-06-02T08:30:29","subject":"Re: [libcamera-devel] [PATCH 01/10] libcamera: stream: Initialize\n\tstride and bufferCount","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Jun 02, 2020 at 03:39:00AM +0200, Niklas Söderlund wrote:\n> The two public unsigned integer fields of StreamConfiguration, stride\n> and bufferCount where not initialized, fix this to match other members\n> being initialized to their 'zero' state.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/stream.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index f34348f2aea022a0..3c4f64daf69d68a4 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -279,7 +279,7 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n> * handlers provied StreamFormats.\n> */\n> StreamConfiguration::StreamConfiguration()\n> -\t: pixelFormat(0), stream_(nullptr)\n> +\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr)\n> {\n> }\n>\n> @@ -287,7 +287,8 @@ StreamConfiguration::StreamConfiguration()\n> * \\brief Construct a configuration with stream formats\n> */\n> StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> -\t: pixelFormat(0), stream_(nullptr), formats_(formats)\n> +\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr),\n> +\t formats_(formats)\n\nNo need to initialize size as well ?\n\n(this could be a good occasion to re-order StreamConfiguration\ndeclaration in stream.h as fields are declared before functions\nthere).\n\nAnyway,\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> {\n> }\n>\n> --\n> 2.26.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B443603CA\n\tfor ;\n\tTue, 2 Jun 2020 10:27:09 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 950B41C0004;\n\tTue, 2 Jun 2020 08:27:08 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 2 Jun 2020 10:30:29 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200602083029.jtfggyyae5isuzqc@uno.localdomain>","References":"<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>\n\t<20200602013909.3170593-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200602013909.3170593-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 01/10] libcamera: stream: Initialize\n\tstride and bufferCount","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 08:27:09 -0000"}},{"id":5070,"web_url":"https://patchwork.libcamera.org/comment/5070/","msgid":"<20200605214252.GI26752@pendragon.ideasonboard.com>","date":"2020-06-05T21:42:52","subject":"Re: [libcamera-devel] [PATCH 01/10] libcamera: stream: Initialize\n\tstride and bufferCount","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 02, 2020 at 10:30:29AM +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Tue, Jun 02, 2020 at 03:39:00AM +0200, Niklas Söderlund wrote:\n> > The two public unsigned integer fields of StreamConfiguration, stride\n> > and bufferCount where not initialized, fix this to match other members\n> > being initialized to their 'zero' state.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/stream.cpp | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index f34348f2aea022a0..3c4f64daf69d68a4 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -279,7 +279,7 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n> > * handlers provied StreamFormats.\n> > */\n> > StreamConfiguration::StreamConfiguration()\n> > -\t: pixelFormat(0), stream_(nullptr)\n> > +\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr)\n> > {\n> > }\n> >\n> > @@ -287,7 +287,8 @@ StreamConfiguration::StreamConfiguration()\n> > * \\brief Construct a configuration with stream formats\n> > */\n> > StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> > -\t: pixelFormat(0), stream_(nullptr), formats_(formats)\n> > +\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr),\n> > +\t formats_(formats)\n> \n> No need to initialize size as well ?\n\nsize_ is of type Size, and the default constructor initializes the\nvalues.\n\n> (this could be a good occasion to re-order StreamConfiguration\n> declaration in stream.h as fields are declared before functions\n> there).\n> \n> Anyway,\n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> > {\n> > }\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54EA1603CA\n\tfor ;\n\tFri, 5 Jun 2020 23:43:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72A1227C;\n\tFri, 5 Jun 2020 23:43:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eXD8bPVp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591393391;\n\tbh=Acicg8tfH4mzLfpVJp59UZgiTCi7v43iWO6m9OLXmas=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eXD8bPVpSsB43TrmcvR0Xe4PPdPM5uoL/U4tIgnLBMYeM24+2HgNk7zYFGbez3j5/\n\tC9kipdAgZ9Uv0qQpMXBFVXp/wjqqrpeU/y7qtkaC8qStvk4WYhFigca08vdfbne4bN\n\t45EKrtzR8nC6zs3Z4564KA4cpO8shoHgb5GOWWRw=","Date":"Sat, 6 Jun 2020 00:42:52 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200605214252.GI26752@pendragon.ideasonboard.com>","References":"<20200602013909.3170593-1-niklas.soderlund@ragnatech.se>\n\t<20200602013909.3170593-2-niklas.soderlund@ragnatech.se>\n\t<20200602083029.jtfggyyae5isuzqc@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200602083029.jtfggyyae5isuzqc@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 01/10] libcamera: stream: Initialize\n\tstride and bufferCount","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Jun 2020 21:43:12 -0000"}}]