[{"id":4958,"web_url":"https://patchwork.libcamera.org/comment/4958/","msgid":"<3807edb3-318f-09a1-5e52-b6c6de3f6e4f@ideasonboard.com>","date":"2020-06-02T09:49:17","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kaaira,\n\nI have applied this to my next branch and will merge to master later\nafter tests if there are no further comments.\n\nThanks.\n\nKieran\n\n\nOn 01/06/2020 19:52, Kaaira Gupta wrote:\n> Modify toString() to print mbus format string instead of its hex code as\n> the string is easier to understand.\n> \n> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Acked-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n> \n> (sending again because I missed the tags in the previous patch)\n> \n> Changes since V2:\n>         Re-formatted the code.\n> \n> Changes since v1:\n>         Add check for unsupported format.\n>         Rename struct\n> \n> \n>  src/libcamera/v4l2_subdevice.cpp | 175 +++++++++++++++++--------------\n>  1 file changed, 96 insertions(+), 79 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 7aefc1b..f3cd04b 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -35,84 +35,93 @@ LOG_DECLARE_CATEGORY(V4L2)\n>  \n>  namespace {\n>  \n> +/*\n> + * \\struct mbusFormatInfo\n> + * \\brief Bits per pixel and mbus format\n> + */\n> +struct mbusFormatInfo {\n> +\tunsigned int bits;\n> +\tstd::string format;\n> +};\n> +\n>  /*\n>   * \\var formatInfoMap\n> - * \\brief A map that associates bits per pixel to V4L2 media bus codes\n> + * \\brief A map that associates mbusFormatInfo struct to V4L2 media bus codes\n>   */\n> -const std::map<uint32_t, unsigned int> formatInfoMap = {\n> -\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, 16 },\n> -\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, 16 },\n> -\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, 16 },\n> -\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, 16 },\n> -\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, 16 },\n> -\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, 16 },\n> -\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, 16 },\n> -\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, 16 },\n> -\t{ V4L2_MBUS_FMT_RGB666_1X18, 18 },\n> -\t{ V4L2_MBUS_FMT_RGB888_1X24, 24 },\n> -\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, 24 },\n> -\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, 24 },\n> -\t{ V4L2_MBUS_FMT_ARGB8888_1X32, 32 },\n> -\t{ V4L2_MBUS_FMT_Y8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_UV8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, 12 },\n> -\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, 12 },\n> -\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, 12 },\n> -\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, 12 },\n> -\t{ V4L2_MBUS_FMT_UYVY8_2X8, 16 },\n> -\t{ V4L2_MBUS_FMT_VYUY8_2X8, 16 },\n> -\t{ V4L2_MBUS_FMT_YUYV8_2X8, 16 },\n> -\t{ V4L2_MBUS_FMT_YVYU8_2X8, 16 },\n> -\t{ V4L2_MBUS_FMT_Y10_1X10, 10 },\n> -\t{ V4L2_MBUS_FMT_UYVY10_2X10, 20 },\n> -\t{ V4L2_MBUS_FMT_VYUY10_2X10, 20 },\n> -\t{ V4L2_MBUS_FMT_YUYV10_2X10, 20 },\n> -\t{ V4L2_MBUS_FMT_YVYU10_2X10, 20 },\n> -\t{ V4L2_MBUS_FMT_Y12_1X12, 12 },\n> -\t{ V4L2_MBUS_FMT_UYVY8_1X16, 16 },\n> -\t{ V4L2_MBUS_FMT_VYUY8_1X16, 16 },\n> -\t{ V4L2_MBUS_FMT_YUYV8_1X16, 16 },\n> -\t{ V4L2_MBUS_FMT_YVYU8_1X16, 16 },\n> -\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, 16 },\n> -\t{ V4L2_MBUS_FMT_UYVY10_1X20, 20 },\n> -\t{ V4L2_MBUS_FMT_VYUY10_1X20, 20 },\n> -\t{ V4L2_MBUS_FMT_YUYV10_1X20, 20 },\n> -\t{ V4L2_MBUS_FMT_YVYU10_1X20, 20 },\n> -\t{ V4L2_MBUS_FMT_YUV10_1X30, 30 },\n> -\t{ V4L2_MBUS_FMT_AYUV8_1X32, 32 },\n> -\t{ V4L2_MBUS_FMT_UYVY12_2X12, 24 },\n> -\t{ V4L2_MBUS_FMT_VYUY12_2X12, 24 },\n> -\t{ V4L2_MBUS_FMT_YUYV12_2X12, 24 },\n> -\t{ V4L2_MBUS_FMT_YVYU12_2X12, 24 },\n> -\t{ V4L2_MBUS_FMT_UYVY12_1X24, 24 },\n> -\t{ V4L2_MBUS_FMT_VYUY12_1X24, 24 },\n> -\t{ V4L2_MBUS_FMT_YUYV12_1X24, 24 },\n> -\t{ V4L2_MBUS_FMT_YVYU12_1X24, 24 },\n> -\t{ V4L2_MBUS_FMT_SBGGR8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SGBRG8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SGRBG8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SRGGB8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, 8 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, 16 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, 16 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, 16 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, 16 },\n> -\t{ V4L2_MBUS_FMT_SBGGR10_1X10, 10 },\n> -\t{ V4L2_MBUS_FMT_SGBRG10_1X10, 10 },\n> -\t{ V4L2_MBUS_FMT_SGRBG10_1X10, 10 },\n> -\t{ V4L2_MBUS_FMT_SRGGB10_1X10, 10 },\n> -\t{ V4L2_MBUS_FMT_SBGGR12_1X12, 12 },\n> -\t{ V4L2_MBUS_FMT_SGBRG12_1X12, 12 },\n> -\t{ V4L2_MBUS_FMT_SGRBG12_1X12, 12 },\n> -\t{ V4L2_MBUS_FMT_SRGGB12_1X12, 12 },\n> -\t{ V4L2_MBUS_FMT_AHSV8888_1X32, 32 },\n> +const std::map<uint32_t, mbusFormatInfo> formatInfoMap = {\n> +\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, { 16, \"RGB555_2X8_PADHI_LE\" } },\n> +\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, { 16, \"BGR565_2X8_BE\" } },\n> +\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, { 16, \"BGR565_2X8_LE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, { 16, \"RGB565_2X8_BE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\" } },\n> +\t{ V4L2_MBUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\" } },\n> +\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\" } },\n> +\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\" } },\n> +\t{ V4L2_MBUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\" } },\n> +\t{ V4L2_MBUS_FMT_Y8_1X8, { 8, \"Y8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_UV8_1X8, { 8, \"UV8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, { 12, \"UYVY8_1_5X8\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, { 12, \"VYUY8_1_5X8\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, { 12, \"YUYV8_1_5X8\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, { 12, \"YVYU8_1_5X8\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY8_2X8, { 16, \"UYVY8_2X8\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY8_2X8, { 16, \"VYUY8_2X8\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV8_2X8, { 16, \"YUYV8_2X8\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU8_2X8, { 16, \"YVYU8_2X8\" } },\n> +\t{ V4L2_MBUS_FMT_Y10_1X10, { 10, \"Y10_1X10\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY10_2X10, { 20, \"UYVY10_2X10\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY10_2X10, { 20, \"VYUY10_2X10\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\" } },\n> +\t{ V4L2_MBUS_FMT_Y12_1X12, { 12, \"Y12_1X12\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU8_1X16, { 16, \"YVYU8_1X16\" } },\n> +\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, { 16, \"YDYUYDYV8_1X16\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY10_1X20, { 20, \"UYVY10_1X20\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY10_1X20, { 20, \"VYUY10_1X20\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV10_1X20, { 20, \"YUYV10_1X20\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU10_1X20, { 20, \"YVYU10_1X20\" } },\n> +\t{ V4L2_MBUS_FMT_YUV10_1X30, { 30, \"YUV10_1X30\" } },\n> +\t{ V4L2_MBUS_FMT_AYUV8_1X32, { 32, \"AYUV8_1X32\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY12_2X12, { 24, \"UYVY12_2X12\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY12_2X12, { 24, \"VYUY12_2X12\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV12_2X12, { 24, \"YUYV12_2X12\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU12_2X12, { 24, \"YVYU12_2X12\" } },\n> +\t{ V4L2_MBUS_FMT_UYVY12_1X24, { 24, \"UYVY12_1X24\" } },\n> +\t{ V4L2_MBUS_FMT_VYUY12_1X24, { 24, \"VYUY12_1X24\" } },\n> +\t{ V4L2_MBUS_FMT_YUYV12_1X24, { 24, \"YUYV12_1X24\" } },\n> +\t{ V4L2_MBUS_FMT_YVYU12_1X24, { 24, \"YVYU12_1X24\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR8_1X8, { 8, \"SBGGR8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SGBRG8_1X8, { 8, \"SGBRG8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SGRBG8_1X8, { 8, \"SGRBG8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SRGGB8_1X8, { 8, \"SRGGB8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, { 8, \"SBGGR10_ALAW8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, { 8, \"SGBRG10_ALAW8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, { 8, \"SGRBG10_ALAW8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, { 8, \"SRGGB10_ALAW8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, { 8, \"SBGGR10_DPCM8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, { 8, \"SGBRG10_DPCM8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, { 8, \"SGRBG10_DPCM8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, { 8, \"SRGGB10_DPCM8_1X8\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, { 16, \"SBGGR10_2X8_PADHI_BE\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, { 16, \"SBGGR10_2X8_PADHI_LE\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, { 16, \"SBGGR10_2X8_PADLO_BE\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, { 16, \"SBGGR10_2X8_PADLO_LE\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR10_1X10, { 10, \"SBGGR10_1X10\" } },\n> +\t{ V4L2_MBUS_FMT_SGBRG10_1X10, { 10, \"SGBRG10_1X10\" } },\n> +\t{ V4L2_MBUS_FMT_SGRBG10_1X10, { 10, \"SGRBG10_1X10\" } },\n> +\t{ V4L2_MBUS_FMT_SRGGB10_1X10, { 10, \"SRGGB10_1X10\" } },\n> +\t{ V4L2_MBUS_FMT_SBGGR12_1X12, { 12, \"SBGGR12_1X12\" } },\n> +\t{ V4L2_MBUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\" } },\n> +\t{ V4L2_MBUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\" } },\n> +\t{ V4L2_MBUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\" } },\n> +\t{ V4L2_MBUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\" } },\n>  };\n>  \n>  } /* namespace */\n> @@ -161,9 +170,17 @@ const std::map<uint32_t, unsigned int> formatInfoMap = {\n>   */\n>  const std::string V4L2SubdeviceFormat::toString() const\n>  {\n> -\tstd::stringstream ss;\n> -\tss << size.toString() << \"-\" << utils::hex(mbus_code, 4);\n> -\treturn ss.str();\n> +\tstd::stringstream mbus;\n> +\tmbus << size.toString() << \"-\";\n> +\n> +\tconst auto it = formatInfoMap.find(mbus_code);\n> +\n> +\tif (it == formatInfoMap.end())\n> +\t\tmbus << utils::hex(mbus_code, 4);\n> +\telse\n> +\t\tmbus << it->second.format;\n> +\n> +\treturn mbus.str();\n>  }\n>  \n>  /**\n> @@ -180,7 +197,7 @@ uint8_t V4L2SubdeviceFormat::bitsPerPixel() const\n>  \t\treturn 0;\n>  \t}\n>  \n> -\treturn it->second;\n> +\treturn it->second.bits;\n>  }\n>  \n>  /**\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81203603CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Jun 2020 11:49:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9A502E5;\n\tTue,  2 Jun 2020 11:49:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Jiqln6JU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591091360;\n\tbh=IoWUc2uiXkdOf1kqHRpGcBcFciZNkE0MyLSgLjqaWTg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Jiqln6JUXpxSo+Ddc52J0pQP4OGNAfcAYixIAH+XyE98Z4oi+9rqfAfcmugHfo5VL\n\t55+LIHCf8aakpgBKlrGzFngn3vQuedZy+KAEFuaZE7E2xHHt8NTXJyZLKmb39AgWNE\n\t8u1DAGyaW/M7QaNO8m5XNErI7YZzat0+nQYr+Fis=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Kaaira Gupta <kgupta@es.iitr.ac.in>, libcamera-devel@lists.libcamera.org","References":"<20200601185233.GA26406@kaaira-HP-Pavilion-Notebook>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3807edb3-318f-09a1-5e52-b6c6de3f6e4f@ideasonboard.com>","Date":"Tue, 2 Jun 2020 10:49:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200601185233.GA26406@kaaira-HP-Pavilion-Notebook>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 02 Jun 2020 09:49:20 -0000"}},{"id":4977,"web_url":"https://patchwork.libcamera.org/comment/4977/","msgid":"<20200602205833.GF6547@pendragon.ideasonboard.com>","date":"2020-06-02T20:58:33","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Tue, Jun 02, 2020 at 10:49:17AM +0100, Kieran Bingham wrote:\n> Hi Kaaira,\n> \n> I have applied this to my next branch and will merge to master later\n> after tests if there are no further comments.\n\nA few additional comments I'm afraid :-)\n\n> On 01/06/2020 19:52, Kaaira Gupta wrote:\n> > Modify toString() to print mbus format string instead of its hex code as\n> > the string is easier to understand.\n> > \n> > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > Acked-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> > \n> > (sending again because I missed the tags in the previous patch)\n> > \n> > Changes since V2:\n> >         Re-formatted the code.\n> > \n> > Changes since v1:\n> >         Add check for unsupported format.\n> >         Rename struct\n> > \n> > \n> >  src/libcamera/v4l2_subdevice.cpp | 175 +++++++++++++++++--------------\n> >  1 file changed, 96 insertions(+), 79 deletions(-)\n> > \n> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > index 7aefc1b..f3cd04b 100644\n> > --- a/src/libcamera/v4l2_subdevice.cpp\n> > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > @@ -35,84 +35,93 @@ LOG_DECLARE_CATEGORY(V4L2)\n> >  \n> >  namespace {\n> >  \n> > +/*\n> > + * \\struct mbusFormatInfo\n\nThe structure name should start with an uppercase letter, like all type\nnames (MbusFormatInfo or MBusFormatInfo ? MediaBusFormatInfo and\nV4L2SubdeviceFormatInfo are alternatives, the latter because it\ndescribes a format carried in the V4L2SubdeviceFormat class.\n\n> > + * \\brief Bits per pixel and mbus format\n\nThis will need to be updated every time a field is added. How about\n\"Information about media bus formats\" ?\n\nThe fields should be documented too.\n\n> > + */\n> > +struct mbusFormatInfo {\n> > +\tunsigned int bits;\n\nShould this field be named \"bitsPerPixel\" ?\n\n> > +\tstd::string format;\n\nShould this be a const char * ? Should the field be named \"name\" ?\n\n> > +};\n> > +\n> >  /*\n> >   * \\var formatInfoMap\n> > - * \\brief A map that associates bits per pixel to V4L2 media bus codes\n> > + * \\brief A map that associates mbusFormatInfo struct to V4L2 media bus codes\n> >   */\n> > -const std::map<uint32_t, unsigned int> formatInfoMap = {\n> > -\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, 16 },\n> > -\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, 16 },\n> > -\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, 16 },\n> > -\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, 16 },\n> > -\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, 16 },\n> > -\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, 16 },\n> > -\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, 16 },\n> > -\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, 16 },\n> > -\t{ V4L2_MBUS_FMT_RGB666_1X18, 18 },\n> > -\t{ V4L2_MBUS_FMT_RGB888_1X24, 24 },\n> > -\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, 24 },\n> > -\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, 24 },\n> > -\t{ V4L2_MBUS_FMT_ARGB8888_1X32, 32 },\n> > -\t{ V4L2_MBUS_FMT_Y8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_UV8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, 12 },\n> > -\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, 12 },\n> > -\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, 12 },\n> > -\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, 12 },\n> > -\t{ V4L2_MBUS_FMT_UYVY8_2X8, 16 },\n> > -\t{ V4L2_MBUS_FMT_VYUY8_2X8, 16 },\n> > -\t{ V4L2_MBUS_FMT_YUYV8_2X8, 16 },\n> > -\t{ V4L2_MBUS_FMT_YVYU8_2X8, 16 },\n> > -\t{ V4L2_MBUS_FMT_Y10_1X10, 10 },\n> > -\t{ V4L2_MBUS_FMT_UYVY10_2X10, 20 },\n> > -\t{ V4L2_MBUS_FMT_VYUY10_2X10, 20 },\n> > -\t{ V4L2_MBUS_FMT_YUYV10_2X10, 20 },\n> > -\t{ V4L2_MBUS_FMT_YVYU10_2X10, 20 },\n> > -\t{ V4L2_MBUS_FMT_Y12_1X12, 12 },\n> > -\t{ V4L2_MBUS_FMT_UYVY8_1X16, 16 },\n> > -\t{ V4L2_MBUS_FMT_VYUY8_1X16, 16 },\n> > -\t{ V4L2_MBUS_FMT_YUYV8_1X16, 16 },\n> > -\t{ V4L2_MBUS_FMT_YVYU8_1X16, 16 },\n> > -\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, 16 },\n> > -\t{ V4L2_MBUS_FMT_UYVY10_1X20, 20 },\n> > -\t{ V4L2_MBUS_FMT_VYUY10_1X20, 20 },\n> > -\t{ V4L2_MBUS_FMT_YUYV10_1X20, 20 },\n> > -\t{ V4L2_MBUS_FMT_YVYU10_1X20, 20 },\n> > -\t{ V4L2_MBUS_FMT_YUV10_1X30, 30 },\n> > -\t{ V4L2_MBUS_FMT_AYUV8_1X32, 32 },\n> > -\t{ V4L2_MBUS_FMT_UYVY12_2X12, 24 },\n> > -\t{ V4L2_MBUS_FMT_VYUY12_2X12, 24 },\n> > -\t{ V4L2_MBUS_FMT_YUYV12_2X12, 24 },\n> > -\t{ V4L2_MBUS_FMT_YVYU12_2X12, 24 },\n> > -\t{ V4L2_MBUS_FMT_UYVY12_1X24, 24 },\n> > -\t{ V4L2_MBUS_FMT_VYUY12_1X24, 24 },\n> > -\t{ V4L2_MBUS_FMT_YUYV12_1X24, 24 },\n> > -\t{ V4L2_MBUS_FMT_YVYU12_1X24, 24 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SGBRG8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SGRBG8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SRGGB8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, 8 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, 16 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, 16 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, 16 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, 16 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR10_1X10, 10 },\n> > -\t{ V4L2_MBUS_FMT_SGBRG10_1X10, 10 },\n> > -\t{ V4L2_MBUS_FMT_SGRBG10_1X10, 10 },\n> > -\t{ V4L2_MBUS_FMT_SRGGB10_1X10, 10 },\n> > -\t{ V4L2_MBUS_FMT_SBGGR12_1X12, 12 },\n> > -\t{ V4L2_MBUS_FMT_SGBRG12_1X12, 12 },\n> > -\t{ V4L2_MBUS_FMT_SGRBG12_1X12, 12 },\n> > -\t{ V4L2_MBUS_FMT_SRGGB12_1X12, 12 },\n> > -\t{ V4L2_MBUS_FMT_AHSV8888_1X32, 32 },\n> > +const std::map<uint32_t, mbusFormatInfo> formatInfoMap = {\n> > +\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, { 16, \"RGB555_2X8_PADHI_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, { 16, \"BGR565_2X8_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, { 16, \"BGR565_2X8_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, { 16, \"RGB565_2X8_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\" } },\n> > +\t{ V4L2_MBUS_FMT_Y8_1X8, { 8, \"Y8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_UV8_1X8, { 8, \"UV8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, { 12, \"UYVY8_1_5X8\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, { 12, \"VYUY8_1_5X8\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, { 12, \"YUYV8_1_5X8\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, { 12, \"YVYU8_1_5X8\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY8_2X8, { 16, \"UYVY8_2X8\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY8_2X8, { 16, \"VYUY8_2X8\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV8_2X8, { 16, \"YUYV8_2X8\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU8_2X8, { 16, \"YVYU8_2X8\" } },\n> > +\t{ V4L2_MBUS_FMT_Y10_1X10, { 10, \"Y10_1X10\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY10_2X10, { 20, \"UYVY10_2X10\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY10_2X10, { 20, \"VYUY10_2X10\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\" } },\n> > +\t{ V4L2_MBUS_FMT_Y12_1X12, { 12, \"Y12_1X12\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU8_1X16, { 16, \"YVYU8_1X16\" } },\n> > +\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, { 16, \"YDYUYDYV8_1X16\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY10_1X20, { 20, \"UYVY10_1X20\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY10_1X20, { 20, \"VYUY10_1X20\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV10_1X20, { 20, \"YUYV10_1X20\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU10_1X20, { 20, \"YVYU10_1X20\" } },\n> > +\t{ V4L2_MBUS_FMT_YUV10_1X30, { 30, \"YUV10_1X30\" } },\n> > +\t{ V4L2_MBUS_FMT_AYUV8_1X32, { 32, \"AYUV8_1X32\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY12_2X12, { 24, \"UYVY12_2X12\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY12_2X12, { 24, \"VYUY12_2X12\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV12_2X12, { 24, \"YUYV12_2X12\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU12_2X12, { 24, \"YVYU12_2X12\" } },\n> > +\t{ V4L2_MBUS_FMT_UYVY12_1X24, { 24, \"UYVY12_1X24\" } },\n> > +\t{ V4L2_MBUS_FMT_VYUY12_1X24, { 24, \"VYUY12_1X24\" } },\n> > +\t{ V4L2_MBUS_FMT_YUYV12_1X24, { 24, \"YUYV12_1X24\" } },\n> > +\t{ V4L2_MBUS_FMT_YVYU12_1X24, { 24, \"YVYU12_1X24\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR8_1X8, { 8, \"SBGGR8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SGBRG8_1X8, { 8, \"SGBRG8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SGRBG8_1X8, { 8, \"SGRBG8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SRGGB8_1X8, { 8, \"SRGGB8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, { 8, \"SBGGR10_ALAW8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, { 8, \"SGBRG10_ALAW8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, { 8, \"SGRBG10_ALAW8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, { 8, \"SRGGB10_ALAW8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, { 8, \"SBGGR10_DPCM8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, { 8, \"SGBRG10_DPCM8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, { 8, \"SGRBG10_DPCM8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, { 8, \"SRGGB10_DPCM8_1X8\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, { 16, \"SBGGR10_2X8_PADHI_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, { 16, \"SBGGR10_2X8_PADHI_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, { 16, \"SBGGR10_2X8_PADLO_BE\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, { 16, \"SBGGR10_2X8_PADLO_LE\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR10_1X10, { 10, \"SBGGR10_1X10\" } },\n> > +\t{ V4L2_MBUS_FMT_SGBRG10_1X10, { 10, \"SGBRG10_1X10\" } },\n> > +\t{ V4L2_MBUS_FMT_SGRBG10_1X10, { 10, \"SGRBG10_1X10\" } },\n> > +\t{ V4L2_MBUS_FMT_SRGGB10_1X10, { 10, \"SRGGB10_1X10\" } },\n> > +\t{ V4L2_MBUS_FMT_SBGGR12_1X12, { 12, \"SBGGR12_1X12\" } },\n> > +\t{ V4L2_MBUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\" } },\n> > +\t{ V4L2_MBUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\" } },\n> > +\t{ V4L2_MBUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\" } },\n> > +\t{ V4L2_MBUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\" } },\n> >  };\n> >  \n> >  } /* namespace */\n> > @@ -161,9 +170,17 @@ const std::map<uint32_t, unsigned int> formatInfoMap = {\n> >   */\n> >  const std::string V4L2SubdeviceFormat::toString() const\n> >  {\n> > -\tstd::stringstream ss;\n> > -\tss << size.toString() << \"-\" << utils::hex(mbus_code, 4);\n> > -\treturn ss.str();\n> > +\tstd::stringstream mbus;\n> > +\tmbus << size.toString() << \"-\";\n> > +\n> > +\tconst auto it = formatInfoMap.find(mbus_code);\n> > +\n> > +\tif (it == formatInfoMap.end())\n> > +\t\tmbus << utils::hex(mbus_code, 4);\n> > +\telse\n> > +\t\tmbus << it->second.format;\n> > +\n> > +\treturn mbus.str();\n> >  }\n> >  \n> >  /**\n> > @@ -180,7 +197,7 @@ uint8_t V4L2SubdeviceFormat::bitsPerPixel() const\n> >  \t\treturn 0;\n> >  \t}\n> >  \n> > -\treturn it->second;\n> > +\treturn it->second.bits;\n> >  }\n> >  \n> >  /**","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDFFC603D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Jun 2020 22:58:48 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3963B2A4;\n\tTue,  2 Jun 2020 22:58:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YeBb7on/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591131528;\n\tbh=0EfvCBy1lDoe66yFnqFEY5YMtL0zfiueSG4RQiMNpaw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YeBb7on/DpYZ47B9lidDTmzu5v9VEUVyB4TbtLnfwvnLQ6UumarmeWVBKqGVFDP0k\n\tjqX6/qt31uj5cFbeGs5/3Yftjvc1a4kTe+4x1eVoQ8wYkpRlVc4hlyVQJFIMWM2UGu\n\tTM4P5nCn94pVlMvn4si+4YYdWegqWC90cF/Yk3co=","Date":"Tue, 2 Jun 2020 23:58:33 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Kaaira Gupta <kgupta@es.iitr.ac.in>, libcamera-devel@lists.libcamera.org","Message-ID":"<20200602205833.GF6547@pendragon.ideasonboard.com>","References":"<20200601185233.GA26406@kaaira-HP-Pavilion-Notebook>\n\t<3807edb3-318f-09a1-5e52-b6c6de3f6e4f@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<3807edb3-318f-09a1-5e52-b6c6de3f6e4f@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 02 Jun 2020 20:58:49 -0000"}},{"id":4983,"web_url":"https://patchwork.libcamera.org/comment/4983/","msgid":"<20200603125734.GB4967@kaaira-HP-Pavilion-Notebook>","date":"2020-06-03T12:57:34","subject":"[libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code","submitter":{"id":39,"url":"https://patchwork.libcamera.org/api/people/39/","name":"Kaaira Gupta","email":"kgupta@es.iitr.ac.in"},"content":"On Tue, Jun 02, 2020 at 11:58:33PM +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> On Tue, Jun 02, 2020 at 10:49:17AM +0100, Kieran Bingham wrote:\n> > Hi Kaaira,\n> > \n> > I have applied this to my next branch and will merge to master later\n> > after tests if there are no further comments.\n> \n> A few additional comments I'm afraid :-)\n> \n> > On 01/06/2020 19:52, Kaaira Gupta wrote:\n> > > Modify toString() to print mbus format string instead of its hex code as\n> > > the string is easier to understand.\n> > > \n> > > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n> > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > > Acked-by: Jacopo Mondi <jacopo@jmondi.org>\n> > > ---\n> > > \n> > > (sending again because I missed the tags in the previous patch)\n> > > \n> > > Changes since V2:\n> > >         Re-formatted the code.\n> > > \n> > > Changes since v1:\n> > >         Add check for unsupported format.\n> > >         Rename struct\n> > > \n> > > \n> > >  src/libcamera/v4l2_subdevice.cpp | 175 +++++++++++++++++--------------\n> > >  1 file changed, 96 insertions(+), 79 deletions(-)\n> > > \n> > > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > > index 7aefc1b..f3cd04b 100644\n> > > --- a/src/libcamera/v4l2_subdevice.cpp\n> > > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > > @@ -35,84 +35,93 @@ LOG_DECLARE_CATEGORY(V4L2)\n> > >  \n> > >  namespace {\n> > >  \n> > > +/*\n> > > + * \\struct mbusFormatInfo\n> \n> The structure name should start with an uppercase letter, like all type\n> names (MbusFormatInfo or MBusFormatInfo ? MediaBusFormatInfo and\n> V4L2SubdeviceFormatInfo are alternatives, the latter because it\n> describes a format carried in the V4L2SubdeviceFormat class.\n\nHm, V4L2SubdeviceFormatInfo is better.\n\n> \n> > > + * \\brief Bits per pixel and mbus format\n> \n> This will need to be updated every time a field is added. How about\n> \"Information about media bus formats\" ?\n> \n> The fields should be documented too.\n\nNoted\n\n> \n> > > + */\n> > > +struct mbusFormatInfo {\n> > > +\tunsigned int bits;\n> \n> Should this field be named \"bitsPerPixel\" ?\n> \n> > > +\tstd::string format;\n> \n> Should this be a const char * ? Should the field be named \"name\" ?\n\nI don't understand..why a const char* over string?\n\n> \n> > > +};\n> > > +\n> > >  /*\n> > >   * \\var formatInfoMap\n> > > - * \\brief A map that associates bits per pixel to V4L2 media bus codes\n> > > + * \\brief A map that associates mbusFormatInfo struct to V4L2 media bus codes\n> > >   */\n> > > -const std::map<uint32_t, unsigned int> formatInfoMap = {\n> > > -\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_RGB666_1X18, 18 },\n> > > -\t{ V4L2_MBUS_FMT_RGB888_1X24, 24 },\n> > > -\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, 24 },\n> > > -\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, 24 },\n> > > -\t{ V4L2_MBUS_FMT_ARGB8888_1X32, 32 },\n> > > -\t{ V4L2_MBUS_FMT_Y8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_UV8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, 12 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, 12 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, 12 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, 12 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY8_2X8, 16 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY8_2X8, 16 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV8_2X8, 16 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU8_2X8, 16 },\n> > > -\t{ V4L2_MBUS_FMT_Y10_1X10, 10 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY10_2X10, 20 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY10_2X10, 20 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV10_2X10, 20 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU10_2X10, 20 },\n> > > -\t{ V4L2_MBUS_FMT_Y12_1X12, 12 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY8_1X16, 16 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY8_1X16, 16 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV8_1X16, 16 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU8_1X16, 16 },\n> > > -\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, 16 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY10_1X20, 20 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY10_1X20, 20 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV10_1X20, 20 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU10_1X20, 20 },\n> > > -\t{ V4L2_MBUS_FMT_YUV10_1X30, 30 },\n> > > -\t{ V4L2_MBUS_FMT_AYUV8_1X32, 32 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY12_2X12, 24 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY12_2X12, 24 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV12_2X12, 24 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU12_2X12, 24 },\n> > > -\t{ V4L2_MBUS_FMT_UYVY12_1X24, 24 },\n> > > -\t{ V4L2_MBUS_FMT_VYUY12_1X24, 24 },\n> > > -\t{ V4L2_MBUS_FMT_YUYV12_1X24, 24 },\n> > > -\t{ V4L2_MBUS_FMT_YVYU12_1X24, 24 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SGBRG8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SGRBG8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SRGGB8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, 8 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, 16 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR10_1X10, 10 },\n> > > -\t{ V4L2_MBUS_FMT_SGBRG10_1X10, 10 },\n> > > -\t{ V4L2_MBUS_FMT_SGRBG10_1X10, 10 },\n> > > -\t{ V4L2_MBUS_FMT_SRGGB10_1X10, 10 },\n> > > -\t{ V4L2_MBUS_FMT_SBGGR12_1X12, 12 },\n> > > -\t{ V4L2_MBUS_FMT_SGBRG12_1X12, 12 },\n> > > -\t{ V4L2_MBUS_FMT_SGRBG12_1X12, 12 },\n> > > -\t{ V4L2_MBUS_FMT_SRGGB12_1X12, 12 },\n> > > -\t{ V4L2_MBUS_FMT_AHSV8888_1X32, 32 },\n> > > +const std::map<uint32_t, mbusFormatInfo> formatInfoMap = {\n> > > +\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE, { 16, \"RGB444_2X8_PADHI_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE, { 16, \"RGB444_2X8_PADHI_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE, { 16, \"RGB555_2X8_PADHI_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE, { 16, \"RGB555_2X8_PADHI_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_BGR565_2X8_BE, { 16, \"BGR565_2X8_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_BGR565_2X8_LE, { 16, \"BGR565_2X8_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB565_2X8_BE, { 16, \"RGB565_2X8_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB565_2X8_LE, { 16, \"RGB565_2X8_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB666_1X18, { 18, \"RGB666_1X18\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB888_1X24, { 24, \"RGB888_1X24\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB888_2X12_BE, { 24, \"RGB888_2X12_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_RGB888_2X12_LE, { 24, \"RGB888_2X12_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_ARGB8888_1X32, { 32, \"ARGB8888_1X32\" } },\n> > > +\t{ V4L2_MBUS_FMT_Y8_1X8, { 8, \"Y8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_UV8_1X8, { 8, \"UV8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY8_1_5X8, { 12, \"UYVY8_1_5X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY8_1_5X8, { 12, \"VYUY8_1_5X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV8_1_5X8, { 12, \"YUYV8_1_5X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU8_1_5X8, { 12, \"YVYU8_1_5X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY8_2X8, { 16, \"UYVY8_2X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY8_2X8, { 16, \"VYUY8_2X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV8_2X8, { 16, \"YUYV8_2X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU8_2X8, { 16, \"YVYU8_2X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_Y10_1X10, { 10, \"Y10_1X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY10_2X10, { 20, \"UYVY10_2X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY10_2X10, { 20, \"VYUY10_2X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV10_2X10, { 20, \"YUYV10_2X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU10_2X10, { 20, \"YVYU10_2X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_Y12_1X12, { 12, \"Y12_1X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY8_1X16, { 16, \"UYVY8_1X16\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY8_1X16, { 16, \"VYUY8_1X16\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV8_1X16, { 16, \"YUYV8_1X16\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU8_1X16, { 16, \"YVYU8_1X16\" } },\n> > > +\t{ V4L2_MBUS_FMT_YDYUYDYV8_1X16, { 16, \"YDYUYDYV8_1X16\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY10_1X20, { 20, \"UYVY10_1X20\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY10_1X20, { 20, \"VYUY10_1X20\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV10_1X20, { 20, \"YUYV10_1X20\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU10_1X20, { 20, \"YVYU10_1X20\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUV10_1X30, { 30, \"YUV10_1X30\" } },\n> > > +\t{ V4L2_MBUS_FMT_AYUV8_1X32, { 32, \"AYUV8_1X32\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY12_2X12, { 24, \"UYVY12_2X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY12_2X12, { 24, \"VYUY12_2X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV12_2X12, { 24, \"YUYV12_2X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU12_2X12, { 24, \"YVYU12_2X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_UYVY12_1X24, { 24, \"UYVY12_1X24\" } },\n> > > +\t{ V4L2_MBUS_FMT_VYUY12_1X24, { 24, \"VYUY12_1X24\" } },\n> > > +\t{ V4L2_MBUS_FMT_YUYV12_1X24, { 24, \"YUYV12_1X24\" } },\n> > > +\t{ V4L2_MBUS_FMT_YVYU12_1X24, { 24, \"YVYU12_1X24\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR8_1X8, { 8, \"SBGGR8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGBRG8_1X8, { 8, \"SGBRG8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGRBG8_1X8, { 8, \"SGRBG8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SRGGB8_1X8, { 8, \"SRGGB8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8, { 8, \"SBGGR10_ALAW8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGBRG10_ALAW8_1X8, { 8, \"SGBRG10_ALAW8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8, { 8, \"SGRBG10_ALAW8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SRGGB10_ALAW8_1X8, { 8, \"SRGGB10_ALAW8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, { 8, \"SBGGR10_DPCM8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, { 8, \"SGBRG10_DPCM8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, { 8, \"SGRBG10_DPCM8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, { 8, \"SRGGB10_DPCM8_1X8\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE, { 16, \"SBGGR10_2X8_PADHI_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE, { 16, \"SBGGR10_2X8_PADHI_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE, { 16, \"SBGGR10_2X8_PADLO_BE\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE, { 16, \"SBGGR10_2X8_PADLO_LE\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR10_1X10, { 10, \"SBGGR10_1X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGBRG10_1X10, { 10, \"SGBRG10_1X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGRBG10_1X10, { 10, \"SGRBG10_1X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_SRGGB10_1X10, { 10, \"SRGGB10_1X10\" } },\n> > > +\t{ V4L2_MBUS_FMT_SBGGR12_1X12, { 12, \"SBGGR12_1X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\" } },\n> > > +\t{ V4L2_MBUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\" } },\n> > >  };\n> > >  \n> > >  } /* namespace */\n> > > @@ -161,9 +170,17 @@ const std::map<uint32_t, unsigned int> formatInfoMap = {\n> > >   */\n> > >  const std::string V4L2SubdeviceFormat::toString() const\n> > >  {\n> > > -\tstd::stringstream ss;\n> > > -\tss << size.toString() << \"-\" << utils::hex(mbus_code, 4);\n> > > -\treturn ss.str();\n> > > +\tstd::stringstream mbus;\n> > > +\tmbus << size.toString() << \"-\";\n> > > +\n> > > +\tconst auto it = formatInfoMap.find(mbus_code);\n> > > +\n> > > +\tif (it == formatInfoMap.end())\n> > > +\t\tmbus << utils::hex(mbus_code, 4);\n> > > +\telse\n> > > +\t\tmbus << it->second.format;\n> > > +\n> > > +\treturn mbus.str();\n> > >  }\n> > >  \n> > >  /**\n> > > @@ -180,7 +197,7 @@ uint8_t V4L2SubdeviceFormat::bitsPerPixel() const\n> > >  \t\treturn 0;\n> > >  \t}\n> > >  \n> > > -\treturn it->second;\n> > > +\treturn it->second.bits;\n> > >  }\n> > >  \n> > >  /**\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<kgupta@es.iitr.ac.in>","Received":["from mail-pl1-x641.google.com (mail-pl1-x641.google.com\n\t[IPv6:2607:f8b0:4864:20::641])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71C6761027\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Jun 2020 14:57:43 +0200 (CEST)","by mail-pl1-x641.google.com with SMTP id y18so796534plr.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 03 Jun 2020 05:57:43 -0700 (PDT)","from kaaira-HP-Pavilion-Notebook ([103.113.213.174])\n\tby smtp.gmail.com with ESMTPSA id\n\tl187sm1911026pfl.218.2020.06.03.05.57.38\n\t(version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 03 Jun 2020 05:57:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=es-iitr-ac-in.20150623.gappssmtp.com\n\theader.i=@es-iitr-ac-in.20150623.gappssmtp.com header.b=\"cKc4KAzC\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:date:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=raBfGiq03NXOR6pSepExn2RLiyhchEQybtc93P8SSrM=;\n\tb=cKc4KAzC4mEQ463R1zTk6NQo5tEX+8lIQo4KbLvp1agjx81W0zgCoQKI9jnAin+CLU\n\txWj66lKDqmnlI99BgbEv2+lz0+b7JKgs1GtK4qK525Pdzi2bxN+UXWX6Y43crtQT0agF\n\t0eYFYOzzxfcRlG9LL9fALhPEwmXBxAmUwDefZrm6JuO7jHo5PTzza+PJzkuXACmT61/B\n\t7tqmYuxgYpT2NkLl/DOW5udXtyVSIIjLAYr1oNu6SV8WE1eYmE9FZtQjNmci4inQ5BUw\n\tqWEvuz+eUY6tLgAZ8tOzjaHrUmafI3JZkdE/I32H7isw3oH2AZXAQEceXwAulb1oBtpz\n\tKIoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:date:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=raBfGiq03NXOR6pSepExn2RLiyhchEQybtc93P8SSrM=;\n\tb=eU/wcyaCYYX0ezWL7cFAOQPz/FiRQs6DoZvN4S5K/CJhrdz9btOXmanfJ5csGdWNcs\n\tg+A1xyaT6n7cZnnYOW4m7XCJ7tKu85eTCUNhRtlil+oeEgToIufvibg2GOLwRON8SDtN\n\tS8yFM3gxmQuOxiEnlSAOY5utCcDqhoUb1JDwaTc8EUNG+1yM88z6AZN0GNTmiN71suF8\n\ttBU8Y5k3rLtlI96tv6Xu7axQuhhsssX5KVKjJrFQfjmlMrAN/MClCNiIODYF6kSDPYQY\n\tUljhVIpPyTohQ9THLHkcJahEX1wBXTsE1VmheiUrhb38dzis6zbWH7+thfCTPSvEPXZb\n\t54Gg==","X-Gm-Message-State":"AOAM531YB07EgyQd/Y4GaD2pE0P3aXAdMQc8UsM3R9LaQ0AOsyjLxx1l\n\tgdZMMAQUTOZAsgmBXiwqvdyShA==","X-Google-Smtp-Source":"ABdhPJwETDmuzcgkixUCzHSd1flPnpggLcZn3mwhdIf24+glCDhZzwwHLcH/9JrFMEliSf8bXv4kAA==","X-Received":"by 2002:a17:902:b097:: with SMTP id\n\tp23mr18588907plr.14.1591189061296; \n\tWed, 03 Jun 2020 05:57:41 -0700 (PDT)","From":"Kaaira Gupta <kgupta@es.iitr.ac.in>","X-Google-Original-From":"Kaaira Gupta <Kaairakgupta@es.iitr.ac.in>","Date":"Wed, 3 Jun 2020 18:27:34 +0530","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tKaaira Gupta <kgupta@es.iitr.ac.in>, libcamera-devel@lists.libcamera.org","Message-ID":"<20200603125734.GB4967@kaaira-HP-Pavilion-Notebook>","References":"<20200601185233.GA26406@kaaira-HP-Pavilion-Notebook>\n\t<3807edb3-318f-09a1-5e52-b6c6de3f6e4f@ideasonboard.com>\n\t<20200602205833.GF6547@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20200602205833.GF6547@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.9.4 (2018-02-28)","Subject":"[libcamera-devel] [PATCH v3] libcamera: v4l2subdev: Print mbus\n\tstring instead of code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 03 Jun 2020 12:57:45 -0000"}}]