[{"id":613,"web_url":"https://patchwork.libcamera.org/comment/613/","msgid":"<20190125224103.GP4127@bigcity.dyn.berto.se>","date":"2019-01-25T22:41:03","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: pipeline: Fix\n\toperator= declaration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-01-25 18:03:56 +0100, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/pipeline_handler.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 0db8421..ca77a40 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -29,7 +29,7 @@ protected:\n> \n> private:\n> \tCameraData(const CameraData &) = delete;\n> -\tvoid operator=(const CameraData &) = delete;\n> +\tCameraData &operator=(const CameraData &) = delete;\n> };\n> \n> class PipelineHandler : public std::enable_shared_from_this\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F66860C65\n\tfor ;\n\tFri, 25 Jan 2019 23:41:05 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id l10so8036423lfh.9\n\tfor ;\n\tFri, 25 Jan 2019 14:41:05 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tr26-v6sm1727756lji.25.2019.01.25.14.41.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 25 Jan 2019 14:41:03 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=5udtljHzT1hpLBh6KYXwGeAgCIL0A3oC/IWur9kd7ic=;\n\tb=fvwXmnTipH6bFKsMZAWtTkD1tvxAT75Qa5x63gNL9ciEzHBIrIlq0bFM6rOQKuJLAh\n\t4EH36A5g2iVv1BswqYC5lDW+aS7mdXH/lldxB51FwQHRKS91x6ToCEFSapyDMmQghGGc\n\tCAuyR6/aa21iggFUwFge8iYpNqC06iEdyRZbEaVg/SeQXwVDjDoBSJ+q/L2XPLn5PM2n\n\t8X7shrMvFaSu5bLu11ggPDzOm1JCFhZMLnWkcJNmPNnxgIbyxcUUEaX+c15NwUL5zV5u\n\tMvAh9OqWGWaQfyyyNH+Zw8SkGP7E+/r8mrH16nlrMraEgPOr3h9O0XrV2XtTknU/vsqF\n\tr07Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=5udtljHzT1hpLBh6KYXwGeAgCIL0A3oC/IWur9kd7ic=;\n\tb=tdenu/FCt/c+bZTW4rHOse2xjBD4SEbvPjKkTyGU+MMhcICylkegVXhQXR8akzLpxL\n\t8HkTf3hdbZ5C+2DYo339yl4Q+N0V8ZfiWccmOgMXixUFT/ONnFMI6lunMZi/rqLW53tI\n\trOQGXm7FJMpm1NgCuZxZ1CYmIVygforNY3Bv4lOwtdxw6kEJw5U1KVuAsNnN/jKIEB2V\n\twFbG7lTU8Be9fdIX8w6J9UHSu4h20alBluD4JmZn6RnQQ3wkaGZhUdkrl4DtJmboYotz\n\tiFdcQa+N3mrRgeARGcILRyaQWMzKUIUUFfUw5jN45ncZckw9Y7zDQXZGTu+D9AnIq5NP\n\t6uww==","X-Gm-Message-State":"AJcUukcnJGIAkPVqwnwRbKhq4o4ErQ+wxjzjgx3Cp+cLxI0tCm45/RrZ\n\tmi/rpLx1fkBFGWH3si00UHpr0cQKDlk=","X-Google-Smtp-Source":"ALg8bN6amuziu9EbvUwdO622ktmKhoqyseEtgmOmmap6a0rTEqA/+zaQ0/r6Sq0b1l6yGm8eKkkmFQ==","X-Received":"by 2002:a19:945b:: with SMTP id w88mr9854282lfd.15.1548456064432;\n\tFri, 25 Jan 2019 14:41:04 -0800 (PST)","Date":"Fri, 25 Jan 2019 23:41:03 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190125224103.GP4127@bigcity.dyn.berto.se>","References":"<20190125170400.24821-1-jacopo@jmondi.org>\n\t<20190125170400.24821-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190125170400.24821-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: pipeline: Fix\n\toperator= declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 25 Jan 2019 22:41:05 -0000"}}]