[{"id":4943,"web_url":"https://patchwork.libcamera.org/comment/4943/","msgid":"<20200601075432.rnvihi66annqmgh2@uno.localdomain>","date":"2020-06-01T07:54:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: test: Fixed the\n\tcompilation issue","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello Madhavan,\n\nOn Thu, May 28, 2020 at 02:30:05PM +0200, Madhavan Krishnan wrote:\n> In write() function, return value is not handled and stored.\n> So, we faced the compilation issue regarding this.\n\nWhich compilation error did you get ? Return value ignored ?\n\nOn which compiler ? I don't think we've seens this with latest GCC and\nclang.\n\n>\n> Handled to store the return value of write() function, and\n> modified the test execution based on the return values.\n\nSorry for being picky, but commit messages read better if they present\nthe problem and the solution (like your does) but in the present\ntense. Like\n\n\"The return value of write() function is ignored, causing the following\ncompiler error|warning with $compiler_version\n\nFix this by storing the return value of write() and return a test error in\ncase of failure.\"\n\n>\n> Signed-off-by: Madhavan Krishnan \n> ---\n> test/file.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n>\n> diff --git a/test/file.cpp b/test/file.cpp\n> index 6262a6f..85eacb5 100644\n> --- a/test/file.cpp\n> +++ b/test/file.cpp\n> @@ -27,10 +27,15 @@ protected:\n> \t{\n> \t\tfileName_ = \"/tmp/libcamera.test.XXXXXX\";\n> \t\tint fd = mkstemp(&fileName_.front());\n> +\t\tssize_t ret;\n> +\n> \t\tif (fd == -1)\n> \t\t\treturn TestFail;\n>\n> -\t\twrite(fd, \"libcamera\", 9);\n> +\t\tret = write(fd, \"libcamera\", 9);\n\nYou could delcare ret here\n ssize_t ret =\n\n> +\t\tif(ret == -1)\n> +\t\t\treturn TestFail;\n\nAnd you should close the fd before returning.\n\nAnwyay, I would be interested in knowing the exact error and the\ncompiler version which reported it first.\n\nThanks\n j\n\n> +\n> \t\tclose(fd);\n>\n> \t\treturn TestPass;\n> --\n> 2.7.4\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 087A8603CB\n\tfor ;\n\tMon, 1 Jun 2020 09:51:13 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 7D0CCFF80C;\n\tMon, 1 Jun 2020 07:51:13 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 1 Jun 2020 09:54:32 +0200","From":"Jacopo Mondi ","To":"Madhavan Krishnan ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200601075432.rnvihi66annqmgh2@uno.localdomain>","References":"<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: test: Fixed the\n\tcompilation issue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jun 2020 07:51:14 -0000"}},{"id":4960,"web_url":"https://patchwork.libcamera.org/comment/4960/","msgid":"","date":"2020-06-02T10:07:18","subject":"Re: [libcamera-devel] [PATCH] libcamera: test: Fixed the\n\tcompilation issue","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Madhavan,\n\nOn 28/05/2020 13:30, Madhavan Krishnan wrote:\n> In write() function, return value is not handled and stored.\n> So, we faced the compilation issue regarding this.\n\nAs mentioned by Jacopo, if you hit specific compilation problems, it\nwould be helpful to explain what here.\n\nBut this topic is also highlighted by our coverity scans, so I am happy\nto see this one resolved all the same.\n\n> Handled to store the return value of write() function, and\n> modified the test execution based on the return values.\n\nPlease add the following tag to this patch:\n\nReported-by: Coverity CID=284605\n\n> Signed-off-by: Madhavan Krishnan \n> ---\n> test/file.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/file.cpp b/test/file.cpp\n> index 6262a6f..85eacb5 100644\n> --- a/test/file.cpp\n> +++ b/test/file.cpp\n> @@ -27,10 +27,15 @@ protected:\n> \t{\n> \t\tfileName_ = \"/tmp/libcamera.test.XXXXXX\";\n> \t\tint fd = mkstemp(&fileName_.front());\n> +\t\tssize_t ret;\n> +\n> \t\tif (fd == -1)\n> \t\t\treturn TestFail;\n> \n> -\t\twrite(fd, \"libcamera\", 9);\n> +\t\tret = write(fd, \"libcamera\", 9);\n> +\t\tif(ret == -1)\n\nIndeed, as highlighted by Jacopo, this is missing a close(fd) on this\nerror path.\n\n> +\t\t\treturn TestFail;\n> +\n> \t\tclose(fd);\n> \n\nAlternatively, you could make the return value dependant upon ret?\n\n\t\treturn (ret == 9) ? TestPass : TestFail;\n\n> \t\treturn TestPass;\n> \n\n\nWith the necessary updates made,\n\nReviewed-by: Kieran Bingham ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F10CE603CB\n\tfor ;\n\tTue, 2 Jun 2020 12:07:21 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58B982E5;\n\tTue, 2 Jun 2020 12:07:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hkCl/dFn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591092441;\n\tbh=+Ie+HxU6h2kQv/DTKsW/svSzu0o7lXLCrr5MSVnOuMU=;\n\th=Reply-To:Subject:To:References:From:Cc:Date:In-Reply-To:From;\n\tb=hkCl/dFnvJdx0Gr/ZF06i68gneVLybWISxh8FODun7kWWd7vBQnSARcMmkCfUzneA\n\tr/MhCgzcxsXu5bV0b/Oc0ifSjhDI/kT1U5VoxYdj9matatSWz9JjbCKyeAPVDCRSCq\n\tO45+Ulv+0SefKLp0MiY8vaTS2+6Vd+mdU+ro8t4E=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Madhavan Krishnan ,\n\tlibcamera-devel@lists.libcamera.org","References":"\n\t<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 2 Jun 2020 11:07:18 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: test: Fixed the\n\tcompilation issue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 10:07:22 -0000"}},{"id":4972,"web_url":"https://patchwork.libcamera.org/comment/4972/","msgid":"<20200602183311.GA6547@pendragon.ideasonboard.com>","date":"2020-06-02T18:33:11","subject":"Re: [libcamera-devel] [PATCH] libcamera: test: Fixed the\n\tcompilation issue","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Tue, Jun 02, 2020 at 11:07:18AM +0100, Kieran Bingham wrote:\n> On 28/05/2020 13:30, Madhavan Krishnan wrote:\n> > In write() function, return value is not handled and stored.\n> > So, we faced the compilation issue regarding this.\n> \n> As mentioned by Jacopo, if you hit specific compilation problems, it\n> would be helpful to explain what here.\n> \n> But this topic is also highlighted by our coverity scans, so I am happy\n> to see this one resolved all the same.\n> \n> > Handled to store the return value of write() function, and\n> > modified the test execution based on the return values.\n> \n> Please add the following tag to this patch:\n> \n> Reported-by: Coverity CID=284605\n> \n> > Signed-off-by: Madhavan Krishnan \n> > ---\n> > test/file.cpp | 7 ++++++-\n> > 1 file changed, 6 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/test/file.cpp b/test/file.cpp\n> > index 6262a6f..85eacb5 100644\n> > --- a/test/file.cpp\n> > +++ b/test/file.cpp\n> > @@ -27,10 +27,15 @@ protected:\n> > \t{\n> > \t\tfileName_ = \"/tmp/libcamera.test.XXXXXX\";\n> > \t\tint fd = mkstemp(&fileName_.front());\n> > +\t\tssize_t ret;\n> > +\n> > \t\tif (fd == -1)\n> > \t\t\treturn TestFail;\n> > \n> > -\t\twrite(fd, \"libcamera\", 9);\n> > +\t\tret = write(fd, \"libcamera\", 9);\n> > +\t\tif(ret == -1)\n> \n> Indeed, as highlighted by Jacopo, this is missing a close(fd) on this\n> error path.\n> \n> > +\t\t\treturn TestFail;\n> > +\n> > \t\tclose(fd);\n> > \n> \n> Alternatively, you could make the return value dependant upon ret?\n> \n> \t\treturn (ret == 9) ? TestPass : TestFail;\n\nNo need for parentheses.\n\n> > \t\treturn TestPass;\n> > \n> \n> With the necessary updates made,\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4294F603D0\n\tfor ;\n\tTue, 2 Jun 2020 20:33:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BA9C2A4;\n\tTue, 2 Jun 2020 20:33:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r80MAhsW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591122806;\n\tbh=rr9Qa5ICfF99VcjENjwTtuZcZuc+Td2SoF/4Kp47AlQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r80MAhsWQtUJuj2LLvxtrZUwsxsP2h2Q0OzVpDJ469eSeChdaL81z0kqbqHQitMzg\n\tehdxkiGsqjMVSQvMxZB4v7kwST8WtRK5InkIWBEGc2O3K0anc4cd9+oX3r8KlAkb4g\n\tJLx5kN4UnQojqVxxlk8tS+wCABrGERqj+i23r55g=","Date":"Tue, 2 Jun 2020 21:33:11 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Madhavan Krishnan ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200602183311.GA6547@pendragon.ideasonboard.com>","References":"<1590669005-31453-1-git-send-email-madhavan.krishnan@linaro.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: test: Fixed the\n\tcompilation issue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 18:33:27 -0000"}}]