{"id":3868,"url":"https://patchwork.libcamera.org/api/patches/3868/?format=json","web_url":"https://patchwork.libcamera.org/patch/3868/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200526160644.154051-1-kieran.bingham@ideasonboard.com>","date":"2020-05-26T16:06:44","name":"[libcamera-devel] qcam: viewfinder: Use correct DRM/QImage mappings","commit_ref":"16c5f44c690a1d7d31b2e150d6e916cc6a999119","pull_url":null,"state":"accepted","archived":false,"hash":"369c5a1f5d855dfe1713c713c72e1f165195e883","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3868/mbox/","series":[{"id":931,"url":"https://patchwork.libcamera.org/api/series/931/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=931","date":"2020-05-26T16:06:44","name":"[libcamera-devel] qcam: viewfinder: Use correct DRM/QImage mappings","version":1,"mbox":"https://patchwork.libcamera.org/series/931/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3868/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3868/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AAAF60E08\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 May 2020 18:06:52 +0200 (CEST)","from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2FDD814;\n\tTue, 26 May 2020 18:06:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fvJ1cQ/B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590509211;\n\tbh=Mu16Lv1baSxwJSRdsEtbpgVGzmnJxHIttHnouvCxqNk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=fvJ1cQ/BjhSHmeQARw/bHKNcdHPccxkl3qrm6A6JZaLJL5y/EVXb3qyZaDk4QMq29\n\tcuJenVTFoY4Y3mX6IuSzoijkA6uAYaaACQ7xZJXvhJDB43aFskY8Yh9lVilrMyqFVR\n\tsMzgCOb81qqpVFcjA0SV5xPWRK/L1opxDw6sXDH0=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Cc":"Kaaira Gupta <kgupta@es.iitr.ac.in>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Date":"Tue, 26 May 2020 17:06:44 +0100","Message-Id":"<20200526160644.154051-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] qcam: viewfinder: Use correct DRM/QImage\n\tmappings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 26 May 2020 16:06:52 -0000"},"content":"When the native pixel formats supported by QT were introduced, the\nRGB/BGR formats were inverted.\n\nSwap the BGR888 and RGB888 mappings accordingly.\n\nFixes: f890a57b7a06 (\"qcam: viewfinder: Add support for more native formats\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/viewfinder.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex 0d68f62ee6d7..7a308f53f576 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -26,9 +26,9 @@ static const QMap<libcamera::PixelFormat, QImage::Format> nativeFormats\n #endif\n \t{ libcamera::PixelFormat{ DRM_FORMAT_ARGB8888 }, QImage::Format_RGB32 },\n #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n-\t{ libcamera::PixelFormat{ DRM_FORMAT_BGR888 }, QImage::Format_BGR888 },\n+\t{ libcamera::PixelFormat{ DRM_FORMAT_RGB888 }, QImage::Format_BGR888 },\n #endif\n-\t{ libcamera::PixelFormat{ DRM_FORMAT_RGB888 }, QImage::Format_RGB888 },\n+\t{ libcamera::PixelFormat{ DRM_FORMAT_BGR888 }, QImage::Format_RGB888 },\n };\n \n ViewFinder::ViewFinder(QWidget *parent)\n","prefixes":["libcamera-devel"]}