[{"id":4994,"web_url":"https://patchwork.libcamera.org/comment/4994/","msgid":"<20200604004215.GG27695@pendragon.ideasonboard.com>","date":"2020-06-04T00:42:15","subject":"Re: [libcamera-devel] [PATCH 2/8] android: hal_manager: Report\n\tsupported API version","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, May 26, 2020 at 04:22:31PM +0200, Jacopo Mondi wrote:\n> Report the supported API version in the camera_info structure provided\n> to the framework.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/android/camera_hal_manager.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 759e320dcd3b..b02d8d1a8362 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -110,7 +110,7 @@ int CameraHalManager::getCameraInfo(unsigned int id, struct camera_info *info)\n>  \t/* \\todo Get these info dynamically inspecting the camera module. */\n>  \tinfo->facing = id ? CAMERA_FACING_FRONT : CAMERA_FACING_BACK;\n>  \tinfo->orientation = 0;\n> -\tinfo->device_version = 0;\n> +\tinfo->device_version = CAMERA_DEVICE_API_VERSION_3_3;\n>  \tinfo->resource_cost = 0;\n>  \tinfo->static_camera_characteristics = camera->getStaticMetadata();\n>  \tinfo->conflicting_devices = nullptr;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C56AC61012\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 Jun 2020 02:42:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D52929B;\n\tThu,  4 Jun 2020 02:42:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vJNrQn0E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591231351;\n\tbh=UVp20+jlEElSmLMBB7Z8yvJog0ZW7RqQLzX833TjVFQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vJNrQn0EqJvbwfnn4lz/TASx8kWK+6wMKNCjFh6TICp0mMlOcSpb8K/UIKYDastPV\n\t2/CgNbqX1YPFxkrhkPX6ml/JHLuh/gbUgyydJ6B1bwnF1LBKFnKdFN/FYao9d3ZQh1\n\tOPq3/0scULHKItBA4UAF9CF0HMwkWL/UuzdtJdVs=","Date":"Thu, 4 Jun 2020 03:42:15 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200604004215.GG27695@pendragon.ideasonboard.com>","References":"<20200526142237.407557-1-jacopo@jmondi.org>\n\t<20200526142237.407557-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200526142237.407557-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/8] android: hal_manager: Report\n\tsupported API version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 04 Jun 2020 00:42:32 -0000"}}]