[{"id":4993,"web_url":"https://patchwork.libcamera.org/comment/4993/","msgid":"<20200604003923.GF27695@pendragon.ideasonboard.com>","date":"2020-06-04T00:39:23","subject":"Re: [libcamera-devel] [PATCH 1/8] android: camera_device: Provide\n\tlog prefix","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, May 26, 2020 at 04:22:30PM +0200, Jacopo Mondi wrote:\n> Make the CameraDevice a Loggable subclass and provide a logPrefix()\n> method to identify which camera the log outout refers to.\n\ns/outout/output/\n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 5 +++++\n> src/android/camera_device.h | 6 +++++-\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 4ec429fc3f8f..ad277cb059ca 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -863,6 +863,11 @@ void CameraDevice::requestComplete(Request *request)\n> \tdelete buffer;\n> }\n> \n> +std::string CameraDevice::logPrefix() const\n> +{\n> +\treturn \"'\" + camera_->name() + \"'\";\n> +}\n> +\n> void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)\n> {\n> \tcamera3_notify_msg_t notify = {};\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index bce1cfbc85a4..350408c1a3e4 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -16,11 +16,12 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/log.h\"\n> #include \"libcamera/internal/message.h\"\n> \n> class CameraMetadata;\n> \n> -class CameraDevice\n> +class CameraDevice : protected libcamera::Loggable\n> {\n> public:\n> \tCameraDevice(unsigned int id, const std::shared_ptr &camera);\n> @@ -39,6 +40,9 @@ public:\n> \tint processCaptureRequest(camera3_capture_request_t *request);\n> \tvoid requestComplete(libcamera::Request *request);\n> \n> +protected:\n> +\tstd::string logPrefix() const;\n\nMissing 'override' after const.\n\nWith this fixed,\n\nReviewed-by: Laurent Pinchart \n\n> +\n> private:\n> \tstruct Camera3RequestDescriptor {\n> \t\tCamera3RequestDescriptor(unsigned int frameNumber,","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 833A561012\n\tfor ;\n\tThu, 4 Jun 2020 02:39:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E48A229B;\n\tThu, 4 Jun 2020 02:39:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R3STCyJU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591231180;\n\tbh=iUqv1C8ObHfmaeR1538q7QIGD6CotNOt/uJYrlDtdlE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R3STCyJUAp7g9sxXciRG6gKxfubOX2NnN49SiNoSHSEUn6WC1UJm9a0FGTftLrZ8i\n\tCY4/FbqxPTP0BmFqFp74mW82d9yZimRgscLXy3St2WcIHCV25T993fPvLGDjRfGUFk\n\tD5I1somdTPCrgcgWjBdvwuhRH2g8/k0GYLtrWzaM=","Date":"Thu, 4 Jun 2020 03:39:23 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200604003923.GF27695@pendragon.ideasonboard.com>","References":"<20200526142237.407557-1-jacopo@jmondi.org>\n\t<20200526142237.407557-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200526142237.407557-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/8] android: camera_device: Provide\n\tlog prefix","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 04 Jun 2020 00:39:40 -0000"}}]