[{"id":4929,"web_url":"https://patchwork.libcamera.org/comment/4929/","msgid":"<37d704c8-c8f7-162d-94ca-ae33368d3b38@ideasonboard.com>","date":"2020-05-28T10:07:21","subject":"Re: [libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM\n\tFourCCs with libcamera formats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/05/2020 15:54, Laurent Pinchart wrote:\n> Use the new pixel format constants to replace usage of macros from\n> drm_fourcc.h.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/dng_writer.cpp | 17 +++++++++--------\n> src/qcam/format_converter.cpp | 36 ++++++++++++++++++-----------------\n> src/qcam/viewfinder.cpp | 10 ++++++----\n> 3 files changed, 34 insertions(+), 29 deletions(-)\n> \n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index cbd8bed3e6d0..1aa2eaa9a501 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> using namespace libcamera;\n> \n> @@ -83,49 +84,49 @@ void thumbScanlineSBGGRxxP(const FormatInfo &info, void *output,\n> }\n> \n> static const std::map formatInfo = {\n> -\t{ PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SBGGR10_CSI2P, {\n> \t\t.bitsPerSample = 10,\n> \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> \t\t.packScanline = packScanlineSBGGR10P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SGBRG10_CSI2P, {\n> \t\t.bitsPerSample = 10,\n> \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> \t\t.packScanline = packScanlineSBGGR10P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SGRBG10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SGRBG10_CSI2P, {\n> \t\t.bitsPerSample = 10,\n> \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> \t\t.packScanline = packScanlineSBGGR10P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SRGGB10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SRGGB10_CSI2P, {\n> \t\t.bitsPerSample = 10,\n> \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> \t\t.packScanline = packScanlineSBGGR10P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SBGGR12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SBGGR12_CSI2P, {\n> \t\t.bitsPerSample = 12,\n> \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> \t\t.packScanline = packScanlineSBGGR12P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SGBRG12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SGBRG12_CSI2P, {\n> \t\t.bitsPerSample = 12,\n> \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> \t\t.packScanline = packScanlineSBGGR12P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SGRBG12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SGRBG12_CSI2P, {\n> \t\t.bitsPerSample = 12,\n> \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> \t\t.packScanline = packScanlineSBGGR12P,\n> \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> \t} },\n> -\t{ PixelFormat(DRM_FORMAT_SRGGB12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> +\t{ formats::SRGGB12_CSI2P, {\n> \t\t.bitsPerSample = 12,\n> \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> \t\t.packScanline = packScanlineSBGGR12P,\n> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> index bf887ad446eb..4b9722d4ecf7 100644\n> --- a/src/qcam/format_converter.cpp\n> +++ b/src/qcam/format_converter.cpp\n> @@ -11,6 +11,8 @@\n> \n> #include \n> \n> +#include \n> +\n> #define RGBSHIFT\t\t8\n> #ifndef MAX\n> #define MAX(a,b)\t\t((a)>(b)?(a):(b))\n> @@ -29,79 +31,79 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\t\t const QSize &size)\n> {\n> \tswitch (format) {\n> -\tcase DRM_FORMAT_NV12:\n> +\tcase libcamera::formats::NV12:\n> \t\tformatFamily_ = NV;\n> \t\thorzSubSample_ = 2;\n> \t\tvertSubSample_ = 2;\n> \t\tnvSwap_ = false;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_NV21:\n> +\tcase libcamera::formats::NV21:\n> \t\tformatFamily_ = NV;\n> \t\thorzSubSample_ = 2;\n> \t\tvertSubSample_ = 2;\n> \t\tnvSwap_ = true;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_NV16:\n> +\tcase libcamera::formats::NV16:\n> \t\tformatFamily_ = NV;\n> \t\thorzSubSample_ = 2;\n> \t\tvertSubSample_ = 1;\n> \t\tnvSwap_ = false;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_NV61:\n> +\tcase libcamera::formats::NV61:\n> \t\tformatFamily_ = NV;\n> \t\thorzSubSample_ = 2;\n> \t\tvertSubSample_ = 1;\n> \t\tnvSwap_ = true;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_NV24:\n> +\tcase libcamera::formats::NV24:\n> \t\tformatFamily_ = NV;\n> \t\thorzSubSample_ = 1;\n> \t\tvertSubSample_ = 1;\n> \t\tnvSwap_ = false;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_NV42:\n> +\tcase libcamera::formats::NV42:\n> \t\tformatFamily_ = NV;\n> \t\thorzSubSample_ = 1;\n> \t\tvertSubSample_ = 1;\n> \t\tnvSwap_ = true;\n> \t\tbreak;\n> \n> -\tcase DRM_FORMAT_RGB888:\n> +\tcase libcamera::formats::RGB888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 2;\n> \t\tg_pos_ = 1;\n> \t\tb_pos_ = 0;\n> \t\tbpp_ = 3;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_BGR888:\n> +\tcase libcamera::formats::BGR888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 0;\n> \t\tg_pos_ = 1;\n> \t\tb_pos_ = 2;\n> \t\tbpp_ = 3;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_ARGB8888:\n> +\tcase libcamera::formats::ARGB8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 2;\n> \t\tg_pos_ = 1;\n> \t\tb_pos_ = 0;\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_RGBA8888:\n> +\tcase libcamera::formats::RGBA8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 3;\n> \t\tg_pos_ = 2;\n> \t\tb_pos_ = 1;\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_ABGR8888:\n> +\tcase libcamera::formats::ABGR8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 0;\n> \t\tg_pos_ = 1;\n> \t\tb_pos_ = 2;\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_BGRA8888:\n> +\tcase libcamera::formats::BGRA8888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 1;\n> \t\tg_pos_ = 2;\n> @@ -109,28 +111,28 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tbpp_ = 4;\n> \t\tbreak;\n> \n> -\tcase DRM_FORMAT_VYUY:\n> +\tcase libcamera::formats::VYUY:\n> \t\tformatFamily_ = YUV;\n> \t\ty_pos_ = 1;\n> \t\tcb_pos_ = 2;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_YVYU:\n> +\tcase libcamera::formats::YVYU:\n> \t\tformatFamily_ = YUV;\n> \t\ty_pos_ = 0;\n> \t\tcb_pos_ = 3;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_UYVY:\n> +\tcase libcamera::formats::UYVY:\n> \t\tformatFamily_ = YUV;\n> \t\ty_pos_ = 1;\n> \t\tcb_pos_ = 0;\n> \t\tbreak;\n> -\tcase DRM_FORMAT_YUYV:\n> +\tcase libcamera::formats::YUYV:\n> \t\tformatFamily_ = YUV;\n> \t\ty_pos_ = 0;\n> \t\tcb_pos_ = 1;\n> \t\tbreak;\n> \n> -\tcase DRM_FORMAT_MJPEG:\n> +\tcase libcamera::formats::MJPEG:\n> \t\tformatFamily_ = MJPEG;\n> \t\tbreak;\n> \n> diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> index 0d68f62ee6d7..ac83d7e6c397 100644\n> --- a/src/qcam/viewfinder.cpp\n> +++ b/src/qcam/viewfinder.cpp\n> @@ -17,18 +17,20 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"format_converter.h\"\n> \n> static const QMap nativeFormats\n> {\n> #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n> -\t{ libcamera::PixelFormat{ DRM_FORMAT_ABGR8888 }, QImage::Format_RGBA8888 },\n> +\t{ libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n> #endif\n> -\t{ libcamera::PixelFormat{ DRM_FORMAT_ARGB8888 }, QImage::Format_RGB32 },\n> +\t{ libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n> #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n> -\t{ libcamera::PixelFormat{ DRM_FORMAT_BGR888 }, QImage::Format_BGR888 },\n> +\t{ libcamera::formats::BGR888, QImage::Format_BGR888 },\n> #endif\n> -\t{ libcamera::PixelFormat{ DRM_FORMAT_RGB888 }, QImage::Format_RGB888 },\n> +\t{ libcamera::formats::RGB888, QImage::Format_RGB888 },\n\nExcepting the format swap necessary on BGR888/RGB888 in regards to the\nQImage formats, which has been identified after you created this patch:\n\nReviewed-by: Kieran Bingham \n\n> };\n> \n> ViewFinder::ViewFinder(QWidget *parent)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B3E2603D0\n\tfor ;\n\tThu, 28 May 2020 12:07:25 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACA352A3;\n\tThu, 28 May 2020 12:07:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Jqw1H9Cb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590660444;\n\tbh=rUrd0vJcZEf5OZKl6PaNwSo0QCcU3UMFIRVeYOiA4wQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Jqw1H9CbAOtWt3jRojC2+bO4675Nv5UJxPfsxsVf4HNfLzEBWxVs7AHqUp+FdflYk\n\tILow+Ja+mVrGT7TgHW0L4RKnDSSwUByiMZJgECI0bOKJ1jYXVV2rcmyvKXjcPnxfhc\n\tOPLPJIdnSpu2Zb63a8mS++mv/Wgk699yN1CgipSw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>\n\t<20200522145459.16836-9-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<37d704c8-c8f7-162d-94ca-ae33368d3b38@ideasonboard.com>","Date":"Thu, 28 May 2020 11:07:21 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200522145459.16836-9-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM\n\tFourCCs with libcamera formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 May 2020 10:07:25 -0000"}},{"id":4935,"web_url":"https://patchwork.libcamera.org/comment/4935/","msgid":"<20200528111137.GB6009@pendragon.ideasonboard.com>","date":"2020-05-28T11:11:37","subject":"Re: [libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM\n\tFourCCs with libcamera formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, May 28, 2020 at 11:07:21AM +0100, Kieran Bingham wrote:\n> On 22/05/2020 15:54, Laurent Pinchart wrote:\n> > Use the new pixel format constants to replace usage of macros from\n> > drm_fourcc.h.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/qcam/dng_writer.cpp | 17 +++++++++--------\n> > src/qcam/format_converter.cpp | 36 ++++++++++++++++++-----------------\n> > src/qcam/viewfinder.cpp | 10 ++++++----\n> > 3 files changed, 34 insertions(+), 29 deletions(-)\n> > \n> > diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> > index cbd8bed3e6d0..1aa2eaa9a501 100644\n> > --- a/src/qcam/dng_writer.cpp\n> > +++ b/src/qcam/dng_writer.cpp\n> > @@ -14,6 +14,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > \n> > using namespace libcamera;\n> > \n> > @@ -83,49 +84,49 @@ void thumbScanlineSBGGRxxP(const FormatInfo &info, void *output,\n> > }\n> > \n> > static const std::map formatInfo = {\n> > -\t{ PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SBGGR10_CSI2P, {\n> > \t\t.bitsPerSample = 10,\n> > \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > \t\t.packScanline = packScanlineSBGGR10P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SGBRG10_CSI2P, {\n> > \t\t.bitsPerSample = 10,\n> > \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> > \t\t.packScanline = packScanlineSBGGR10P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SGRBG10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SGRBG10_CSI2P, {\n> > \t\t.bitsPerSample = 10,\n> > \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> > \t\t.packScanline = packScanlineSBGGR10P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SRGGB10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SRGGB10_CSI2P, {\n> > \t\t.bitsPerSample = 10,\n> > \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > \t\t.packScanline = packScanlineSBGGR10P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SBGGR12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SBGGR12_CSI2P, {\n> > \t\t.bitsPerSample = 12,\n> > \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n> > \t\t.packScanline = packScanlineSBGGR12P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SGBRG12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SGBRG12_CSI2P, {\n> > \t\t.bitsPerSample = 12,\n> > \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> > \t\t.packScanline = packScanlineSBGGR12P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SGRBG12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SGRBG12_CSI2P, {\n> > \t\t.bitsPerSample = 12,\n> > \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n> > \t\t.packScanline = packScanlineSBGGR12P,\n> > \t\t.thumbScanline = thumbScanlineSBGGRxxP,\n> > \t} },\n> > -\t{ PixelFormat(DRM_FORMAT_SRGGB12, MIPI_FORMAT_MOD_CSI2_PACKED), {\n> > +\t{ formats::SRGGB12_CSI2P, {\n> > \t\t.bitsPerSample = 12,\n> > \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n> > \t\t.packScanline = packScanlineSBGGR12P,\n> > diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> > index bf887ad446eb..4b9722d4ecf7 100644\n> > --- a/src/qcam/format_converter.cpp\n> > +++ b/src/qcam/format_converter.cpp\n> > @@ -11,6 +11,8 @@\n> > \n> > #include \n> > \n> > +#include \n> > +\n> > #define RGBSHIFT\t\t8\n> > #ifndef MAX\n> > #define MAX(a,b)\t\t((a)>(b)?(a):(b))\n> > @@ -29,79 +31,79 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> > \t\t\t const QSize &size)\n> > {\n> > \tswitch (format) {\n> > -\tcase DRM_FORMAT_NV12:\n> > +\tcase libcamera::formats::NV12:\n> > \t\tformatFamily_ = NV;\n> > \t\thorzSubSample_ = 2;\n> > \t\tvertSubSample_ = 2;\n> > \t\tnvSwap_ = false;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_NV21:\n> > +\tcase libcamera::formats::NV21:\n> > \t\tformatFamily_ = NV;\n> > \t\thorzSubSample_ = 2;\n> > \t\tvertSubSample_ = 2;\n> > \t\tnvSwap_ = true;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_NV16:\n> > +\tcase libcamera::formats::NV16:\n> > \t\tformatFamily_ = NV;\n> > \t\thorzSubSample_ = 2;\n> > \t\tvertSubSample_ = 1;\n> > \t\tnvSwap_ = false;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_NV61:\n> > +\tcase libcamera::formats::NV61:\n> > \t\tformatFamily_ = NV;\n> > \t\thorzSubSample_ = 2;\n> > \t\tvertSubSample_ = 1;\n> > \t\tnvSwap_ = true;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_NV24:\n> > +\tcase libcamera::formats::NV24:\n> > \t\tformatFamily_ = NV;\n> > \t\thorzSubSample_ = 1;\n> > \t\tvertSubSample_ = 1;\n> > \t\tnvSwap_ = false;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_NV42:\n> > +\tcase libcamera::formats::NV42:\n> > \t\tformatFamily_ = NV;\n> > \t\thorzSubSample_ = 1;\n> > \t\tvertSubSample_ = 1;\n> > \t\tnvSwap_ = true;\n> > \t\tbreak;\n> > \n> > -\tcase DRM_FORMAT_RGB888:\n> > +\tcase libcamera::formats::RGB888:\n> > \t\tformatFamily_ = RGB;\n> > \t\tr_pos_ = 2;\n> > \t\tg_pos_ = 1;\n> > \t\tb_pos_ = 0;\n> > \t\tbpp_ = 3;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_BGR888:\n> > +\tcase libcamera::formats::BGR888:\n> > \t\tformatFamily_ = RGB;\n> > \t\tr_pos_ = 0;\n> > \t\tg_pos_ = 1;\n> > \t\tb_pos_ = 2;\n> > \t\tbpp_ = 3;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_ARGB8888:\n> > +\tcase libcamera::formats::ARGB8888:\n> > \t\tformatFamily_ = RGB;\n> > \t\tr_pos_ = 2;\n> > \t\tg_pos_ = 1;\n> > \t\tb_pos_ = 0;\n> > \t\tbpp_ = 4;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_RGBA8888:\n> > +\tcase libcamera::formats::RGBA8888:\n> > \t\tformatFamily_ = RGB;\n> > \t\tr_pos_ = 3;\n> > \t\tg_pos_ = 2;\n> > \t\tb_pos_ = 1;\n> > \t\tbpp_ = 4;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_ABGR8888:\n> > +\tcase libcamera::formats::ABGR8888:\n> > \t\tformatFamily_ = RGB;\n> > \t\tr_pos_ = 0;\n> > \t\tg_pos_ = 1;\n> > \t\tb_pos_ = 2;\n> > \t\tbpp_ = 4;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_BGRA8888:\n> > +\tcase libcamera::formats::BGRA8888:\n> > \t\tformatFamily_ = RGB;\n> > \t\tr_pos_ = 1;\n> > \t\tg_pos_ = 2;\n> > @@ -109,28 +111,28 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> > \t\tbpp_ = 4;\n> > \t\tbreak;\n> > \n> > -\tcase DRM_FORMAT_VYUY:\n> > +\tcase libcamera::formats::VYUY:\n> > \t\tformatFamily_ = YUV;\n> > \t\ty_pos_ = 1;\n> > \t\tcb_pos_ = 2;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_YVYU:\n> > +\tcase libcamera::formats::YVYU:\n> > \t\tformatFamily_ = YUV;\n> > \t\ty_pos_ = 0;\n> > \t\tcb_pos_ = 3;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_UYVY:\n> > +\tcase libcamera::formats::UYVY:\n> > \t\tformatFamily_ = YUV;\n> > \t\ty_pos_ = 1;\n> > \t\tcb_pos_ = 0;\n> > \t\tbreak;\n> > -\tcase DRM_FORMAT_YUYV:\n> > +\tcase libcamera::formats::YUYV:\n> > \t\tformatFamily_ = YUV;\n> > \t\ty_pos_ = 0;\n> > \t\tcb_pos_ = 1;\n> > \t\tbreak;\n> > \n> > -\tcase DRM_FORMAT_MJPEG:\n> > +\tcase libcamera::formats::MJPEG:\n> > \t\tformatFamily_ = MJPEG;\n> > \t\tbreak;\n> > \n> > diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> > index 0d68f62ee6d7..ac83d7e6c397 100644\n> > --- a/src/qcam/viewfinder.cpp\n> > +++ b/src/qcam/viewfinder.cpp\n> > @@ -17,18 +17,20 @@\n> > #include \n> > #include \n> > \n> > +#include \n> > +\n> > #include \"format_converter.h\"\n> > \n> > static const QMap nativeFormats\n> > {\n> > #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n> > -\t{ libcamera::PixelFormat{ DRM_FORMAT_ABGR8888 }, QImage::Format_RGBA8888 },\n> > +\t{ libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n> > #endif\n> > -\t{ libcamera::PixelFormat{ DRM_FORMAT_ARGB8888 }, QImage::Format_RGB32 },\n> > +\t{ libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n> > #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n> > -\t{ libcamera::PixelFormat{ DRM_FORMAT_BGR888 }, QImage::Format_BGR888 },\n> > +\t{ libcamera::formats::BGR888, QImage::Format_BGR888 },\n> > #endif\n> > -\t{ libcamera::PixelFormat{ DRM_FORMAT_RGB888 }, QImage::Format_RGB888 },\n> > +\t{ libcamera::formats::RGB888, QImage::Format_RGB888 },\n> \n> Excepting the format swap necessary on BGR888/RGB888 in regards to the\n> QImage formats, which has been identified after you created this patch:\n\nI'll rebase this on top of the fix you've submitted, once you merge it.\n\n> Reviewed-by: Kieran Bingham \n> \n> > };\n> > \n> > ViewFinder::ViewFinder(QWidget *parent)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A00BE603D0\n\tfor ;\n\tThu, 28 May 2020 13:11:51 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 366802A8;\n\tThu, 28 May 2020 13:11:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cookkTPo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590664311;\n\tbh=jo5FRg2jaEp9CU7kPsvaVNjxBAP70oGvvnklPE9z8Vo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cookkTPoInSCYhqASqKnLGChYPFCO1AeYTtI/4i57EkUu8A0qsLW5VSdS08SKdFOy\n\tWV415Ebv7xuuoPoFng6OsDBlUbruvc+zfs/PUUyKiwFOciZj/2y5Z9jUxS3/8pOxOl\n\tHbn/TK29y+GqPVupk+RzraekpAj7qGmYQXabteXA=","Date":"Thu, 28 May 2020 14:11:37 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200528111137.GB6009@pendragon.ideasonboard.com>","References":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>\n\t<20200522145459.16836-9-laurent.pinchart@ideasonboard.com>\n\t<37d704c8-c8f7-162d-94ca-ae33368d3b38@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<37d704c8-c8f7-162d-94ca-ae33368d3b38@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM\n\tFourCCs with libcamera formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 May 2020 11:11:51 -0000"}},{"id":4936,"web_url":"https://patchwork.libcamera.org/comment/4936/","msgid":"","date":"2020-05-28T11:15:22","subject":"Re: [libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM\n\tFourCCs with libcamera formats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\n\n\n\nOn 28/05/2020 12:11, Laurent Pinchart wrote:\n> Hi Kieran,\n>>> static const QMap nativeFormats\n>>> {\n>>> #if QT_VERSION >= QT_VERSION_CHECK(5, 2, 0)\n>>> -\t{ libcamera::PixelFormat{ DRM_FORMAT_ABGR8888 }, QImage::Format_RGBA8888 },\n>>> +\t{ libcamera::formats::ABGR8888, QImage::Format_RGBA8888 },\n>>> #endif\n>>> -\t{ libcamera::PixelFormat{ DRM_FORMAT_ARGB8888 }, QImage::Format_RGB32 },\n>>> +\t{ libcamera::formats::ARGB8888, QImage::Format_RGB32 },\n>>> #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)\n>>> -\t{ libcamera::PixelFormat{ DRM_FORMAT_BGR888 }, QImage::Format_BGR888 },\n>>> +\t{ libcamera::formats::BGR888, QImage::Format_BGR888 },\n>>> #endif\n>>> -\t{ libcamera::PixelFormat{ DRM_FORMAT_RGB888 }, QImage::Format_RGB888 },\n>>> +\t{ libcamera::formats::RGB888, QImage::Format_RGB888 },\n>>\n>> Excepting the format swap necessary on BGR888/RGB888 in regards to the\n>> QImage formats, which has been identified after you created this patch:\n> \n> I'll rebase this on top of the fix you've submitted, once you merge it.\n\nWell in that case, try a git fetch now ;-)\n\n> \n>> Reviewed-by: Kieran Bingham \n>>\n>>> };\n>>> \n>>> ViewFinder::ViewFinder(QWidget *parent)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AB52603D3\n\tfor ;\n\tThu, 28 May 2020 13:15:27 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E7A22A8;\n\tThu, 28 May 2020 13:15:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Kdy44iwX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590664526;\n\tbh=2NiGVlJRvz8zONFtQTYQ59+7j/vMzDTAq14fXXs52wc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Kdy44iwX1x+6Ex5f1+ys0FauXMUUVtf9VP3w1jpgfVlAEaCBBuLdFol+z2MWR79DX\n\tEW23DJSbsHpA0w/OvXPDCz7rSJGuSi/jnrfybhpjXkmId/VDMf8RMpzIoTw16/4enh\n\tnBdMwQo/9FWR7A1Y3/hbyxofWXslg9GgU/ee9JKA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>\n\t<20200522145459.16836-9-laurent.pinchart@ideasonboard.com>\n\t<37d704c8-c8f7-162d-94ca-ae33368d3b38@ideasonboard.com>\n\t<20200528111137.GB6009@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 28 May 2020 12:15:22 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200528111137.GB6009@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH/RFC 07/11] qcam: Replace explicit DRM\n\tFourCCs with libcamera formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 May 2020 11:15:27 -0000"}}]