[{"id":4926,"web_url":"https://patchwork.libcamera.org/comment/4926/","msgid":"","date":"2020-05-28T09:56:33","subject":"Re: [libcamera-devel] [PATCH/RFC 05/11] libcamera: Define constants\n\tfor pixel formats in the public API","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/05/2020 15:54, Laurent Pinchart wrote:\n> libcamera uses pixel format FourCC and modifier values from DRM. This\n> requires inclusion of drm_fourcc.h, creating a dependency on a header\n> that is packaged differently between distributions, and causing possible\n> issues with third-party applications.\n> \n> Define constants for the supported pixel formats in the public API, in\n> order to remove the dependency on drm_fourcc.h. The numerical values are\n> still identical to the DRM pixel formats, keeping the direct\n> interoperability.\n> > Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/formats.h | 94 ++++++++++++++++++++++++++++++++++\n> include/libcamera/meson.build | 1 +\n> src/libcamera/formats.cpp | 2 +-\n> src/libcamera/pixel_format.cpp | 1 +\n> 4 files changed, 97 insertions(+), 1 deletion(-)\n> create mode 100644 include/libcamera/formats.h\n> \n> diff --git a/include/libcamera/formats.h b/include/libcamera/formats.h\n> new file mode 100644\n> index 000000000000..bd164226d712\n> --- /dev/null\n> +++ b/include/libcamera/formats.h\n> @@ -0,0 +1,94 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * formats.h - Formats\n> + */\n> +#ifndef __LIBCAMERA_FORMATS_H__\n> +#define __LIBCAMERA_FORMATS_H__\n> +\n> +#include \n> +\n> +#include \n> +\n> +namespace libcamera {\n> +\n> +namespace formats {\n> +\n> +namespace {\n> +\n> +constexpr uint32_t __fourcc(char a, char b, char c, char d)\n> +{\n> +\treturn (static_cast(a) << 0) |\n> +\t (static_cast(b) << 8) |\n> +\t (static_cast(c) << 16) |\n> +\t (static_cast(d) << 24);\n> +}\n> +\n> +constexpr uint64_t __mod(unsigned int vendor, unsigned int mod)\n> +{\n> +\treturn (static_cast(vendor) << 56) |\n> +\t (static_cast(mod) << 0);\n> +}\n> +\n> +} /* namespace */\n> +\n> +constexpr PixelFormat R8{ __fourcc('R', '8', ' ', ' ') };\n> +\n> +constexpr PixelFormat RGB888{ __fourcc('R', 'G', '2', '4') };\n> +constexpr PixelFormat BGR888{ __fourcc('B', 'G', '2', '4') };\n> +\n> +constexpr PixelFormat XRGB8888{ __fourcc('X', 'R', '2', '4') };\n> +constexpr PixelFormat XBGR8888{ __fourcc('X', 'B', '2', '4') };\n> +constexpr PixelFormat RGBX8888{ __fourcc('R', 'X', '2', '4') };\n> +constexpr PixelFormat BGRX8888{ __fourcc('B', 'X', '2', '4') };\n> +\n> +constexpr PixelFormat ARGB8888{ __fourcc('A', 'R', '2', '4') };\n> +constexpr PixelFormat ABGR8888{ __fourcc('A', 'B', '2', '4') };\n> +constexpr PixelFormat RGBA8888{ __fourcc('R', 'A', '2', '4') };\n> +constexpr PixelFormat BGRA8888{ __fourcc('B', 'A', '2', '4') };\n> +\n> +constexpr PixelFormat YUYV{ __fourcc('Y', 'U', 'Y', 'V') };\n> +constexpr PixelFormat YVYU{ __fourcc('Y', 'V', 'Y', 'U') };\n> +constexpr PixelFormat UYVY{ __fourcc('U', 'Y', 'V', 'Y') };\n> +constexpr PixelFormat VYUY{ __fourcc('V', 'Y', 'U', 'Y') };\n> +\n> +constexpr PixelFormat NV12{ __fourcc('N', 'V', '1', '2') };\n> +constexpr PixelFormat NV21{ __fourcc('N', 'V', '2', '1') };\n> +constexpr PixelFormat NV16{ __fourcc('N', 'V', '1', '6') };\n> +constexpr PixelFormat NV61{ __fourcc('N', 'V', '6', '1') };\n> +constexpr PixelFormat NV24{ __fourcc('N', 'V', '2', '4') };\n> +constexpr PixelFormat NV42{ __fourcc('N', 'V', '4', '2') };\n> +\n> +constexpr PixelFormat MJPEG{ __fourcc('M', 'J', 'P', 'G') };\n> +\n> +constexpr PixelFormat SRGGB8{ __fourcc('R', 'G', 'G', 'B') };\n> +constexpr PixelFormat SGRBG8{ __fourcc('G', 'R', 'B', 'G') };\n> +constexpr PixelFormat SGBRG8{ __fourcc('G', 'B', 'R', 'G') };\n> +constexpr PixelFormat SBGGR8{ __fourcc('B', 'A', '8', '1') };\n> +\n> +constexpr PixelFormat SRGGB10{ __fourcc('R', 'G', '1', '0') };\n> +constexpr PixelFormat SGRBG10{ __fourcc('B', 'A', '1', '0') };\n> +constexpr PixelFormat SGBRG10{ __fourcc('G', 'B', '1', '0') };\n> +constexpr PixelFormat SBGGR10{ __fourcc('B', 'G', '1', '0') };\n> +\n> +constexpr PixelFormat SRGGB12{ __fourcc('R', 'G', '1', '2') };\n> +constexpr PixelFormat SGRBG12{ __fourcc('B', 'A', '1', '2') };\n> +constexpr PixelFormat SGBRG12{ __fourcc('G', 'B', '1', '2') };\n> +constexpr PixelFormat SBGGR12{ __fourcc('B', 'G', '1', '2') };\n> +\n> +constexpr PixelFormat SRGGB10_CSI2P{ __fourcc('R', 'G', '1', '0'), __mod(10, 1) };\n> +constexpr PixelFormat SGRBG10_CSI2P{ __fourcc('B', 'A', '1', '0'), __mod(10, 1) };\n> +constexpr PixelFormat SGBRG10_CSI2P{ __fourcc('G', 'B', '1', '0'), __mod(10, 1) };\n> +constexpr PixelFormat SBGGR10_CSI2P{ __fourcc('B', 'G', '1', '0'), __mod(10, 1) };\n> +\n> +constexpr PixelFormat SRGGB12_CSI2P{ __fourcc('R', 'G', '1', '2'), __mod(10, 1) };\n> +constexpr PixelFormat SGRBG12_CSI2P{ __fourcc('B', 'A', '1', '2'), __mod(10, 1) };\n> +constexpr PixelFormat SGBRG12_CSI2P{ __fourcc('G', 'B', '1', '2'), __mod(10, 1) };\n> +constexpr PixelFormat SBGGR12_CSI2P{ __fourcc('B', 'G', '1', '2'), __mod(10, 1) };\n\nAre these modifiers upstream yet?\n\nAutomating the generation of this file would indeed be benefical I think\n(as discussed offline) - but overall - as much as I fear it becoming\n'yet another pixelformat standard' I think this is a good idea.\n\nAt least if we generate from the DRM formats, then really it's just a\nnamespace/simplification - and I like that a lot.\n\nIn particular I like that libcamera applications who have no care for\nDRM at all don't have to use DRM prefixes (or include an 'arbitrary'\nsystem header).\n\n> +\n> +} /* namespace formats */\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif /* __LIBCAMERA_FORMATS_H__ */\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 73c5b999acf4..170744d0fbbc 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -9,6 +9,7 @@ libcamera_public_headers = files([\n> 'event_dispatcher.h',\n> 'event_notifier.h',\n> 'file_descriptor.h',\n> + 'formats.h',\n> 'framebuffer_allocator.h',\n> 'geometry.h',\n> 'logging.h',\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 2ac3b412ecdb..74c239a5e710 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -12,7 +12,7 @@\n> #include \"libcamera/internal/log.h\"\n> \n> /**\n> - * \\file formats.h\n> + * \\file internal/formats.h\n\nIt might be useful to explain in the commit message that you are fixing\nthe src/libcamera/formats.cpp doxygen tag for the header to the internal\nlocation. At first I thought this was an erroneous hunk in this patch.\n\n\nOtherwise,\n\n\nReviewed-by: Kieran Bingham \n\nBut maybe that's a moot tag if you're going to automate this file\ngeneration instead. But that could also be done on top - and this could\njust be manual to progress the fix.\n\n\n\n\n> * \\brief Types and helper methods to handle libcamera image formats\n> */\n> \n> diff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\n> index d501c5f09c6b..0709d1526b82 100644\n> --- a/src/libcamera/pixel_format.cpp\n> +++ b/src/libcamera/pixel_format.cpp\n> @@ -5,6 +5,7 @@\n> * pixel_format.cpp - libcamera Pixel Format\n> */\n> \n> +#include \n> #include \n> \n> /**\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8CAA603CF\n\tfor ;\n\tThu, 28 May 2020 11:56:36 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34DAF2A3;\n\tThu, 28 May 2020 11:56:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l/P3zy0d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590659796;\n\tbh=lAhbjuK1YLLUHG+JTmrxWQ/L/l6GT3EeRuTmN5LsspQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=l/P3zy0dGKAlarR4qPCXep+HEYRQFghe8OjO0+xtvLyE2WUftVwhg1GRZa6Uln/Fu\n\t8lfDGqRkHi7SF9VYSRCXMui7KTp5mPxymxSo/3lvxuoQbOiU5PbQ2Snc9TQFO9GZ7K\n\tDcSuMY65dOQiC1aboh6SlAYhmQ+yjr29vo31kCd8=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>\n\t<20200522145459.16836-7-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 28 May 2020 10:56:33 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200522145459.16836-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH/RFC 05/11] libcamera: Define constants\n\tfor pixel formats in the public API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 May 2020 09:56:37 -0000"}},{"id":4938,"web_url":"https://patchwork.libcamera.org/comment/4938/","msgid":"<20200528113524.GD6009@pendragon.ideasonboard.com>","date":"2020-05-28T11:35:24","subject":"Re: [libcamera-devel] [PATCH/RFC 05/11] libcamera: Define constants\n\tfor pixel formats in the public API","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, May 28, 2020 at 10:56:33AM +0100, Kieran Bingham wrote:\n> On 22/05/2020 15:54, Laurent Pinchart wrote:\n> > libcamera uses pixel format FourCC and modifier values from DRM. This\n> > requires inclusion of drm_fourcc.h, creating a dependency on a header\n> > that is packaged differently between distributions, and causing possible\n> > issues with third-party applications.\n> > \n> > Define constants for the supported pixel formats in the public API, in\n> > order to remove the dependency on drm_fourcc.h. The numerical values are\n> > still identical to the DRM pixel formats, keeping the direct\n> > interoperability.\n> > > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/formats.h | 94 ++++++++++++++++++++++++++++++++++\n> > include/libcamera/meson.build | 1 +\n> > src/libcamera/formats.cpp | 2 +-\n> > src/libcamera/pixel_format.cpp | 1 +\n> > 4 files changed, 97 insertions(+), 1 deletion(-)\n> > create mode 100644 include/libcamera/formats.h\n> > \n> > diff --git a/include/libcamera/formats.h b/include/libcamera/formats.h\n> > new file mode 100644\n> > index 000000000000..bd164226d712\n> > --- /dev/null\n> > +++ b/include/libcamera/formats.h\n> > @@ -0,0 +1,94 @@\n> > +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> > +/*\n> > + * Copyright (C) 2020, Google Inc.\n> > + *\n> > + * formats.h - Formats\n> > + */\n> > +#ifndef __LIBCAMERA_FORMATS_H__\n> > +#define __LIBCAMERA_FORMATS_H__\n> > +\n> > +#include \n> > +\n> > +#include \n> > +\n> > +namespace libcamera {\n> > +\n> > +namespace formats {\n> > +\n> > +namespace {\n> > +\n> > +constexpr uint32_t __fourcc(char a, char b, char c, char d)\n> > +{\n> > +\treturn (static_cast(a) << 0) |\n> > +\t (static_cast(b) << 8) |\n> > +\t (static_cast(c) << 16) |\n> > +\t (static_cast(d) << 24);\n> > +}\n> > +\n> > +constexpr uint64_t __mod(unsigned int vendor, unsigned int mod)\n> > +{\n> > +\treturn (static_cast(vendor) << 56) |\n> > +\t (static_cast(mod) << 0);\n> > +}\n> > +\n> > +} /* namespace */\n> > +\n> > +constexpr PixelFormat R8{ __fourcc('R', '8', ' ', ' ') };\n> > +\n> > +constexpr PixelFormat RGB888{ __fourcc('R', 'G', '2', '4') };\n> > +constexpr PixelFormat BGR888{ __fourcc('B', 'G', '2', '4') };\n> > +\n> > +constexpr PixelFormat XRGB8888{ __fourcc('X', 'R', '2', '4') };\n> > +constexpr PixelFormat XBGR8888{ __fourcc('X', 'B', '2', '4') };\n> > +constexpr PixelFormat RGBX8888{ __fourcc('R', 'X', '2', '4') };\n> > +constexpr PixelFormat BGRX8888{ __fourcc('B', 'X', '2', '4') };\n> > +\n> > +constexpr PixelFormat ARGB8888{ __fourcc('A', 'R', '2', '4') };\n> > +constexpr PixelFormat ABGR8888{ __fourcc('A', 'B', '2', '4') };\n> > +constexpr PixelFormat RGBA8888{ __fourcc('R', 'A', '2', '4') };\n> > +constexpr PixelFormat BGRA8888{ __fourcc('B', 'A', '2', '4') };\n> > +\n> > +constexpr PixelFormat YUYV{ __fourcc('Y', 'U', 'Y', 'V') };\n> > +constexpr PixelFormat YVYU{ __fourcc('Y', 'V', 'Y', 'U') };\n> > +constexpr PixelFormat UYVY{ __fourcc('U', 'Y', 'V', 'Y') };\n> > +constexpr PixelFormat VYUY{ __fourcc('V', 'Y', 'U', 'Y') };\n> > +\n> > +constexpr PixelFormat NV12{ __fourcc('N', 'V', '1', '2') };\n> > +constexpr PixelFormat NV21{ __fourcc('N', 'V', '2', '1') };\n> > +constexpr PixelFormat NV16{ __fourcc('N', 'V', '1', '6') };\n> > +constexpr PixelFormat NV61{ __fourcc('N', 'V', '6', '1') };\n> > +constexpr PixelFormat NV24{ __fourcc('N', 'V', '2', '4') };\n> > +constexpr PixelFormat NV42{ __fourcc('N', 'V', '4', '2') };\n> > +\n> > +constexpr PixelFormat MJPEG{ __fourcc('M', 'J', 'P', 'G') };\n> > +\n> > +constexpr PixelFormat SRGGB8{ __fourcc('R', 'G', 'G', 'B') };\n> > +constexpr PixelFormat SGRBG8{ __fourcc('G', 'R', 'B', 'G') };\n> > +constexpr PixelFormat SGBRG8{ __fourcc('G', 'B', 'R', 'G') };\n> > +constexpr PixelFormat SBGGR8{ __fourcc('B', 'A', '8', '1') };\n> > +\n> > +constexpr PixelFormat SRGGB10{ __fourcc('R', 'G', '1', '0') };\n> > +constexpr PixelFormat SGRBG10{ __fourcc('B', 'A', '1', '0') };\n> > +constexpr PixelFormat SGBRG10{ __fourcc('G', 'B', '1', '0') };\n> > +constexpr PixelFormat SBGGR10{ __fourcc('B', 'G', '1', '0') };\n> > +\n> > +constexpr PixelFormat SRGGB12{ __fourcc('R', 'G', '1', '2') };\n> > +constexpr PixelFormat SGRBG12{ __fourcc('B', 'A', '1', '2') };\n> > +constexpr PixelFormat SGBRG12{ __fourcc('G', 'B', '1', '2') };\n> > +constexpr PixelFormat SBGGR12{ __fourcc('B', 'G', '1', '2') };\n> > +\n> > +constexpr PixelFormat SRGGB10_CSI2P{ __fourcc('R', 'G', '1', '0'), __mod(10, 1) };\n> > +constexpr PixelFormat SGRBG10_CSI2P{ __fourcc('B', 'A', '1', '0'), __mod(10, 1) };\n> > +constexpr PixelFormat SGBRG10_CSI2P{ __fourcc('G', 'B', '1', '0'), __mod(10, 1) };\n> > +constexpr PixelFormat SBGGR10_CSI2P{ __fourcc('B', 'G', '1', '0'), __mod(10, 1) };\n> > +\n> > +constexpr PixelFormat SRGGB12_CSI2P{ __fourcc('R', 'G', '1', '2'), __mod(10, 1) };\n> > +constexpr PixelFormat SGRBG12_CSI2P{ __fourcc('B', 'A', '1', '2'), __mod(10, 1) };\n> > +constexpr PixelFormat SGBRG12_CSI2P{ __fourcc('G', 'B', '1', '2'), __mod(10, 1) };\n> > +constexpr PixelFormat SBGGR12_CSI2P{ __fourcc('B', 'G', '1', '2'), __mod(10, 1) };\n> \n> Are these modifiers upstream yet?\n\nNot yet, no.\n\n> Automating the generation of this file would indeed be benefical I think\n> (as discussed offline) - but overall - as much as I fear it becoming\n> 'yet another pixelformat standard' I think this is a good idea.\n\nI'm more and more convinced this header should be generated (at least\nuntil we decide to create our own formats standard :-)). I'll give it a\ntry.\n\n> At least if we generate from the DRM formats, then really it's just a\n> namespace/simplification - and I like that a lot.\n> \n> In particular I like that libcamera applications who have no care for\n> DRM at all don't have to use DRM prefixes (or include an 'arbitrary'\n> system header).\n> \n> > +\n> > +} /* namespace formats */\n> > +\n> > +} /* namespace libcamera */\n> > +\n> > +#endif /* __LIBCAMERA_FORMATS_H__ */\n> > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > index 73c5b999acf4..170744d0fbbc 100644\n> > --- a/include/libcamera/meson.build\n> > +++ b/include/libcamera/meson.build\n> > @@ -9,6 +9,7 @@ libcamera_public_headers = files([\n> > 'event_dispatcher.h',\n> > 'event_notifier.h',\n> > 'file_descriptor.h',\n> > + 'formats.h',\n> > 'framebuffer_allocator.h',\n> > 'geometry.h',\n> > 'logging.h',\n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index 2ac3b412ecdb..74c239a5e710 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -12,7 +12,7 @@\n> > #include \"libcamera/internal/log.h\"\n> > \n> > /**\n> > - * \\file formats.h\n> > + * \\file internal/formats.h\n> \n> It might be useful to explain in the commit message that you are fixing\n> the src/libcamera/formats.cpp doxygen tag for the header to the internal\n> location. At first I thought this was an erroneous hunk in this patch.\n\nIt's actually not really a fix (I would have split it in a separate\npatch otherwise), Doxygen doesn't need full paths, but now that we have\na formats.h header in include/libcamera/ and another one in\ninclude/libcamera/internal/, Doxygen needs more information. I'll\nmention this in the commit message.\n\n> Otherwise,\n> \n> Reviewed-by: Kieran Bingham \n> \n> But maybe that's a moot tag if you're going to automate this file\n> generation instead. But that could also be done on top - and this could\n> just be manual to progress the fix.\n\nLet's see if auto-generation will get implemented quickly or if the\nseries will be deemed ready for merge before that.\n\n> > * \\brief Types and helper methods to handle libcamera image formats\n> > */\n> > \n> > diff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\n> > index d501c5f09c6b..0709d1526b82 100644\n> > --- a/src/libcamera/pixel_format.cpp\n> > +++ b/src/libcamera/pixel_format.cpp\n> > @@ -5,6 +5,7 @@\n> > * pixel_format.cpp - libcamera Pixel Format\n> > */\n> > \n> > +#include \n> > #include \n> > \n> > /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A500F603D3\n\tfor ;\n\tThu, 28 May 2020 13:35:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20B932A8;\n\tThu, 28 May 2020 13:35:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"H9BYvIBM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1590665738;\n\tbh=fEsUK+pybeX/8lYKAUqOho4BIJ9k6CJp6gjDEr9QS7Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H9BYvIBMFPbJEQyloaLlIVFK7Pq4iaa559qzh0KvQqWF9ozGymmtnTY12MLmy8dxb\n\tl6M81nxOvMKWPtQqFs6qLcodGclnrHu1NPn8nDrCb6V+PbU3zr0JiQt1TNdWQUWRjS\n\tBGBj1pK+HA4remQ6+byERKtf+PQhWHj9VG5Egr/g=","Date":"Thu, 28 May 2020 14:35:24 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200528113524.GD6009@pendragon.ideasonboard.com>","References":"<20200522145459.16836-1-laurent.pinchart@ideasonboard.com>\n\t<20200522145459.16836-7-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH/RFC 05/11] libcamera: Define constants\n\tfor pixel formats in the public API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 28 May 2020 11:35:38 -0000"}}]